arcanis/queued
1
0
Fork 0
mirror of https://github.com/arcan1s/queued.git synced 2025-04-24 15:37:19 +00:00
Code Issues Projects Releases Wiki Activity

some improvements

Browse Source
This commit is contained in:
Evgenii Alekseev 2017-04-07 00:28:49 +03:00
parent e0833f22a5
commit baa20af363
30 changed files with 712 additions and 215 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
sources/queued-server/src/QueuedServer.cpp
View File

@ -50,12 +50,22 @@ void QueuedServer::init()
{
deinit();
m_server = new QueuedTcpServer(this);
m_server->listen(
QHostAddress(QueuedCoreAdaptor::getOption("ServerAddress").toString()),
QueuedCoreAdaptor::getOption("ServerPort").toUInt());
m_server
= new QueuedTcpServer(QueuedCoreAdaptor::getOption(
QueuedConfig::QueuedSettings::ServerTimeout)
.toInt(),
this);
QString address = QueuedCoreAdaptor::getOption(
QueuedConfig::QueuedSettings::ServerAddress)
.toString();
ushort port
= QueuedCoreAdaptor::getOption(QueuedConfig::QueuedSettings::ServerPort)
.toUInt();
m_server->listen(QHostAddress(address), port);
m_server->setMaxPendingConnections(
QueuedCoreAdaptor::getOption("ServerMaxConnections").toInt());
QueuedCoreAdaptor::getOption(
QueuedConfig::QueuedSettings::ServerMaxConnections)
.toInt());
qCInfo(LOG_SERV) << "Server listen on" << m_server->serverAddress()
<< m_server->serverPort();

5
sources/queued-server/src/QueuedTcpServer.cpp
View File

@ -21,8 +21,9 @@
#include "QueuedTcpServerThread.h"
QueuedTcpServer::QueuedTcpServer(QObject *parent)
QueuedTcpServer::QueuedTcpServer(const int timeout, QObject *parent)
: QTcpServer(parent)
, m_timeout(timeout)
{
qCDebug(LOG_SERV) << __PRETTY_FUNCTION__;
}
@ -50,7 +51,7 @@ void QueuedTcpServer::init()
void QueuedTcpServer::incomingConnection(qintptr socketDescriptor)
{
QueuedTcpServerThread *thread
= new QueuedTcpServerThread(socketDescriptor, this);
= new QueuedTcpServerThread(socketDescriptor, m_timeout, this);
connect(thread, SIGNAL(finished()), thread, SLOT(deleteLater()));
thread->start();
}

3
sources/queued-server/src/QueuedTcpServer.h
View File

@ -25,7 +25,7 @@ class QueuedTcpServer : public QTcpServer
Q_OBJECT
public:
explicit QueuedTcpServer(QObject *parent);
explicit QueuedTcpServer(const int timeout, QObject *parent);
virtual ~QueuedTcpServer();
void deinit();
void init();
@ -34,6 +34,7 @@ protected:
void incomingConnection(qintptr socketDescriptor) override;
private:
int m_timeout = -1;
};

6
sources/queued-server/src/QueuedTcpServerResponseHelper.cpp
View File

@ -88,10 +88,16 @@ QueuedTcpServerResponseHelper::pathToEnum(const QString &_path)
return RequestPath::Plugins;
else if (_path == "reports")
return RequestPath::Reports;
else if (_path == "status")
return RequestPath::Status;
else if (_path == "task")
return RequestPath::Task;
else if (_path == "tasks")
return RequestPath::Tasks;
else if (_path == "user")
return RequestPath::User;
else if (_path == "users")
return RequestPath::Users;
return RequestPath::Unknown;
}

5
sources/queued-server/src/QueuedTcpServerResponseHelper.h
View File

@ -29,8 +29,11 @@ enum class RequestPath {
Permissions,
Plugins,
Reports,
Status,
Task,
User
Tasks,
User,
Users
};
typedef struct {
int apiVersion;

71
sources/queued-server/src/QueuedTcpServerResponseHelperApi1.cpp
View File

@ -22,6 +22,8 @@
#include "QueuedTcpServerResponseHelperOption.h"
#include "QueuedTcpServerResponseHelperPermissions.h"
#include "QueuedTcpServerResponseHelperPlugins.h"
#include "QueuedTcpServerResponseHelperTask.h"
#include "QueuedTcpServerResponseHelperUser.h"
QVariantHash QueuedTcpServerResponseHelperApi1::getData(
@ -77,6 +79,75 @@ QVariantHash QueuedTcpServerResponseHelperApi1::getData(
else
output = {{"code", 405}};
break;
case QueuedTcpServerResponseHelper::RequestPath::Reports:
if (_type == "GET")
output
= QueuedTcpServerResponseHelperUser::getReport(_data, _token);
else
output = {{"code", 405}};
break;
case QueuedTcpServerResponseHelper::RequestPath::Status:
if (_type == "GET")
output = getStatus();
else
output = {{"code", 405}};
break;
case QueuedTcpServerResponseHelper::RequestPath::Task:
if (_type == "GET")
output = QueuedTcpServerResponseHelperTask::getTask(
_arg.toLongLong(), _data);
else if (_type == "POST")
output = QueuedTcpServerResponseHelperTask::addOrEditTask(
_arg.toLongLong(), _data, _token);
else
output = {{"code", 405}};
break;
case QueuedTcpServerResponseHelper::RequestPath::Tasks:
if (_type == "GET")
output = QueuedTcpServerResponseHelperTask::getTasks(_data, _token);
else
output = {{"code", 405}};
break;
break;
case QueuedTcpServerResponseHelper::RequestPath::User:
if (_type == "GET")
output = QueuedTcpServerResponseHelperUser::getUser(_arg, _data);
else if (_type == "POST")
output = QueuedTcpServerResponseHelperUser::addOrEditUser(
_arg, _data, _token);
else
output = {{"code", 405}};
break;
case QueuedTcpServerResponseHelper::RequestPath::Users:
if (_type == "GET")
output = QueuedTcpServerResponseHelperUser::getUsers(_data, _token);
else
output = {{"code", 405}};
break;
case QueuedTcpServerResponseHelper::RequestPath::Unknown:
output = {{"code", 404}};
break;
}
return output;
}
QVariantHash QueuedTcpServerResponseHelperApi1::getStatus()
{
QVariantHash output = {{"code", 200}};
auto data = QueuedCoreAdaptor::getStatus();
auto sections = data.keys();
sections.sort();
for (auto &section : sections) {
QVariantHash sectionData;
auto keys = data[section].keys();
keys.sort();
for (auto &key : keys)
sectionData[key] = data[section][key];
// append output
output[section] = sectionData;
}
return output;

1
sources/queued-server/src/QueuedTcpServerResponseHelperApi1.h
View File

@ -27,6 +27,7 @@ namespace QueuedTcpServerResponseHelperApi1
QVariantHash getData(const QueuedTcpServerResponseHelper::RequestPath _request,
const QString &_arg, const QString &_type,
const QVariantHash &_data, const QString &_token);
QVariantHash getStatus();
};

5
sources/queued-server/src/QueuedTcpServerResponseHelperPlugins.cpp
View File

@ -33,9 +33,8 @@ QueuedTcpServerResponseHelperPlugins::addPlugin(const QString &_name,
QVariantHash QueuedTcpServerResponseHelperPlugins::listPlugins()
{
return {{"code", 200},
{"plugins",
QueuedCoreAdaptor::getOption(QueuedAdvancedSettings::internalId(
QueuedConfig::QueuedSettings::Plugins))}};
{"plugins", QueuedCoreAdaptor::getOption(
QueuedConfig::QueuedSettings::Plugins)}};
}

113
sources/queued-server/src/QueuedTcpServerResponseHelperTask.cpp Normal file
View File

@ -0,0 +1,113 @@
/*
* Copyright (c) 2017 Evgeniy Alekseev
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
*
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*/
#include "QueuedTcpServerResponseHelperTask.h"
#include <queued/Queued.h>
QVariantHash QueuedTcpServerResponseHelperTask::addOrEditTask(
const long long _id, const QVariantHash &_data, const QString &_token)
{
qCDebug(LOG_SERV) << "Add or edit task" << _id << "with data" << _data;
auto defs = getDefinitions(_data);
if (_id > 0) {
// edit existing task
bool status = QueuedCoreAdaptor::sendTaskEdit(_id, defs, _token);
return {{"code", status ? 200 : 400}};
} else {
// add new task
auto id = QueuedCoreAdaptor::sendTaskAdd(defs, _token);
return {{"code", id > 0 ? 200 : 400}, {"id", id}};
}
}
QueuedProcess::QueuedProcessDefinitions
QueuedTcpServerResponseHelperTask::getDefinitions(const QVariantHash &_data)
{
qCDebug(LOG_SERV) << "Get definitions from" << _data;
QueuedProcess::QueuedProcessDefinitions defs;
auto args = _data["arguments"].toList();
for (auto &arg : args)
defs.arguments.append(arg.toString());
defs.command = _data["command"].toString();
defs.endTime
= QDateTime::fromString(_data["end"].toString(), Qt::ISODateWithMs);
defs.gid = _data["gid"].toUInt();
defs.nice = _data["nice"].toUInt();
defs.startTime
= QDateTime::fromString(_data["start"].toString(), Qt::ISODateWithMs);
defs.uid = _data["uid"].toUInt();
defs.user = _data["user"].toLongLong();
defs.workingDirectory = _data["workingDirectory"].toString();
// limits
QueuedLimits::Limits limits;
limits.cpu = _data["limitCpu"].toLongLong();
limits.gpu = _data["limitGpu"].toLongLong();
limits.memory = _data["limitMemory"].toLongLong();
limits.gpumemory = _data["limitGpumemory"].toLongLong();
limits.storage = _data["limitStorage"].toLongLong();
defs.limits = limits.toString();
return defs;
}
QVariantHash
QueuedTcpServerResponseHelperTask::getTask(const long long _id,
const QVariantHash &_data)
{
qCDebug(LOG_SERV) << "Get task" << _id << _data;
auto property = _data["property"].toString();
QVariantHash output = {{"code", 200}};
// some conversion magic
auto value = QueuedCoreAdaptor::getTask(_id, property);
if (property.isEmpty())
output["properties"] = qdbus_cast<QVariantHash>(value);
else
output["properties"] = QVariantHash({{property, value}});
return output;
}
QVariantHash
QueuedTcpServerResponseHelperTask::getTasks(const QVariantHash &_data,
const QString &_token)
{
qCDebug(LOG_SERV) << "Get tasks" << _data;
long long user = _data.value("userId").toLongLong();
QDateTime start
= QDateTime::fromString(_data["start"].toString(), Qt::ISODateWithMs);
QDateTime stop
= QDateTime::fromString(_data["stop"].toString(), Qt::ISODateWithMs);
QVariantHash output = {{"code", 200}};
// some conversion magic
QVariantList outputReport;
auto report = QueuedCoreAdaptor::getTasks(user, start, stop, _token);
for (auto &user : report)
outputReport.append(user);
output["report"] = outputReport;
return output;
}

36
sources/queued-server/src/QueuedTcpServerResponseHelperTask.h Normal file
View File

@ -0,0 +1,36 @@
/*
* Copyright (c) 2017 Evgeniy Alekseev
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
*
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*/
#ifndef QUEUEDTCPSERVERRESPONSEHELTASK_H
#define QUEUEDTCPSERVERRESPONSEHELTASK_H
#include <QVariant>
#include <queued/QueuedProcess.h>
namespace QueuedTcpServerResponseHelperTask
{
QVariantHash addOrEditTask(const long long _id, const QVariantHash &_data,
const QString &_token);
QueuedProcess::QueuedProcessDefinitions
getDefinitions(const QVariantHash &_data);
QVariantHash getTask(const long long _id, const QVariantHash &_data);
QVariantHash getTasks(const QVariantHash &_data, const QString &_token);
};
#endif /* QUEUEDTCPSERVERRESPONSEHELTASK_H */

130
sources/queued-server/src/QueuedTcpServerResponseHelperUser.cpp Normal file
View File

@ -0,0 +1,130 @@
/*
* Copyright (c) 2017 Evgeniy Alekseev
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
*
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*/
#include "QueuedTcpServerResponseHelperUser.h"
#include <queued/Queued.h>
QVariantHash QueuedTcpServerResponseHelperUser::addOrEditUser(
const QString &_user, const QVariantHash &_data, const QString &_token)
{
qCDebug(LOG_SERV) << "Add user" << _user << "with data" << _data;
// try define if user exists first
auto userId = QueuedCoreAdaptor::getUserId(_user);
auto defs = getDefinitions(_data);
defs.name = _user;
if (userId > 0) {
// edit existing user
bool status = QueuedCoreAdaptor::sendUserEdit(userId, defs, _token);
return {{"code", status ? 200 : 400}};
} else {
// add new user
auto id = QueuedCoreAdaptor::sendUserAdd(defs, _token);
return {{"code", id > 0 ? 200 : 400}, {"id", id}};
}
}
QueuedUser::QueuedUserDefinitions
QueuedTcpServerResponseHelperUser::getDefinitions(const QVariantHash &_data)
{
qCDebug(LOG_SERV) << "Generate definitions from" << _data;
QueuedUser::QueuedUserDefinitions defs;
defs.email = _data["email"].toString();
defs.password = QueuedUser::hashFromPassword(_data["password"].toString());
defs.permissions = _data["permissions"].toUInt();
// limits
QueuedLimits::Limits limits;
limits.cpu = _data["limitCpu"].toLongLong();
limits.gpu = _data["limitGpu"].toLongLong();
limits.memory = _data["limitMemory"].toLongLong();
limits.gpumemory = _data["limitGpumemory"].toLongLong();
limits.storage = _data["limitStorage"].toLongLong();
defs.limits = limits.toString();
return defs;
}
QVariantHash
QueuedTcpServerResponseHelperUser::getReport(const QVariantHash &_data,
const QString &_token)
{
qCDebug(LOG_SERV) << "Get report using payload" << _data;
QDateTime stop
= QDateTime::fromString(_data["stop"].toString(), Qt::ISODateWithMs);
QDateTime start
= QDateTime::fromString(_data["start"].toString(), Qt::ISODateWithMs);
QVariantHash output = {{"code", 200}};
// some conversion magic
QVariantList outputReport;
auto report = QueuedCoreAdaptor::getPerformance(start, stop, _token);
for (auto &user : report)
outputReport.append(user);
output["report"] = outputReport;
return output;
}
QVariantHash
QueuedTcpServerResponseHelperUser::getUser(const QString &_user,
const QVariantHash &_data)
{
qCDebug(LOG_SERV) << "Get user data for" << _user << _data;
auto userId = QueuedCoreAdaptor::getUserId(_user);
auto property = _data["property"].toString();
QVariantHash output = {{"code", 200}};
// some conversion magic
auto value = QueuedCoreAdaptor::getUser(userId, property);
if (property.isEmpty())
output["properties"] = qdbus_cast<QVariantHash>(value);
else
output["properties"] = QVariantHash({{property, value}});
return output;
}
QVariantHash
QueuedTcpServerResponseHelperUser::getUsers(const QVariantHash &_data,
const QString &_token)
{
qCDebug(LOG_SERV) << "Get users" << _data;
QDateTime lastLogin = QDateTime::fromString(_data["lastLogged"].toString(),
Qt::ISODateWithMs);
auto permission
= QueuedEnums::stringToPermission(_data["permission"].toString());
QVariantHash output = {{"code", 200}};
// some conversion magic
QVariantList outputReport;
auto report = QueuedCoreAdaptor::getUsers(lastLogin, permission, _token);
for (auto &user : report)
outputReport.append(user);
output["report"] = outputReport;
return output;
}

36
sources/queued-server/src/QueuedTcpServerResponseHelperUser.h Normal file
View File

@ -0,0 +1,36 @@
/*
* Copyright (c) 2017 Evgeniy Alekseev
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
*
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*/
#ifndef QUEUEDTCPSERVERRESPONSEHELUSER_H
#define QUEUEDTCPSERVERRESPONSEHELUSER_H
#include <QVariant>
#include <queued/QueuedUser.h>
namespace QueuedTcpServerResponseHelperUser
{
QVariantHash addOrEditUser(const QString &_user, const QVariantHash &_data,
const QString &_token);
QueuedUser::QueuedUserDefinitions getDefinitions(const QVariantHash &_data);
QVariantHash getReport(const QVariantHash &_data, const QString &_token);
QVariantHash getUser(const QString &_user, const QVariantHash &_data);
QVariantHash getUsers(const QVariantHash &_data, const QString &_token);
};
#endif /* QUEUEDTCPSERVERRESPONSEHELUSER_H */

25
sources/queued-server/src/QueuedTcpServerThread.cpp
View File

@ -28,9 +28,10 @@
QueuedTcpServerThread::QueuedTcpServerThread(int socketDescriptor,
QObject *parent)
const int timeout, QObject *parent)
: QThread(parent)
, m_socketDescriptor(socketDescriptor)
, m_timeout(timeout)
{
qCDebug(LOG_SERV) << __PRETTY_FUNCTION__;
}
@ -39,6 +40,9 @@ QueuedTcpServerThread::QueuedTcpServerThread(int socketDescriptor,
QueuedTcpServerThread::~QueuedTcpServerThread()
{
qCDebug(LOG_SERV) << __PRETTY_FUNCTION__;
if (m_socket)
m_socket->deleteLater();
}
@ -133,7 +137,7 @@ QueuedTcpServerThread::QueuedTcpServerRequest QueuedTcpServerThread::getRequest(
values = QVariantList({request.data[key]});
break;
}
values.append(key);
values.append(value);
request.data[key] = values.count() == 1 ? values.first() : values;
}
@ -182,7 +186,7 @@ QueuedTcpServerThread::response(const QueuedTcpServerRequest &request) const
void QueuedTcpServerThread::run()
{
m_socket = new QTcpSocket(this);
m_socket = new QTcpSocket(nullptr);
if (!m_socket->setSocketDescriptor(m_socketDescriptor)) {
qCWarning(LOG_SERV) << "Socket error" << m_socket->error();
return;
@ -190,20 +194,11 @@ void QueuedTcpServerThread::run()
connect(m_socket, SIGNAL(readyRead()), this, SLOT(readyRead()),
Qt::DirectConnection);
connect(m_socket, SIGNAL(disconnected()), this, SLOT(disconnected()),
Qt::DirectConnection);
exec();
}
void QueuedTcpServerThread::disconnected()
{
m_socket->deleteLater();
exit(0);
}
void QueuedTcpServerThread::readyRead()
{
QStringList headers;
@ -222,8 +217,12 @@ void QueuedTcpServerThread::readyRead()
m_socket->write(resp);
m_socket->flush();
m_socket->waitForBytesWritten(3000);
// TODO use timeouts?
if (m_socket->state() != QAbstractSocket::UnconnectedState)
m_socket->waitForBytesWritten(m_timeout);
m_socket->disconnectFromHost();
if (m_socket->state() != QAbstractSocket::UnconnectedState)
m_socket->waitForDisconnected();
exit(0);
}

5
sources/queued-server/src/QueuedTcpServerThread.h
View File

@ -44,7 +44,8 @@ public:
QVariantHash data;
} QueuedTcpServerResponse;
explicit QueuedTcpServerThread(int socketDescriptor, QObject *parent);
explicit QueuedTcpServerThread(int socketDescriptor, const int timeout,
QObject *parent);
virtual ~QueuedTcpServerThread();
static QByteArrayList defaultResponse(const int code,
const QVariantHash &json);
@ -56,12 +57,12 @@ public:
void run() override;
private slots:
void disconnected();
void readyRead();
private:
QTcpSocket *m_socket = nullptr;
int m_socketDescriptor;
int m_timeout = -1;
};

28
sources/queued/include/queued/QueuedCoreAdaptor.h
View File

@ -28,6 +28,7 @@
#include <QVariant>
#include "QueuedProcess.h"
#include "QueuedStaticConfig.h"
#include "QueuedUser.h"
@ -183,6 +184,13 @@ bool sendUserPermissionRemove(const long long _id,
* @return option value
*/
QVariant getOption(const QString &_property);
/**
* @brief get option
* @param _property
* option name
* @return option value
*/
QVariant getOption(const QueuedConfig::QueuedSettings _property);
/**
* @brief performance report
* @param _from
@ -195,6 +203,11 @@ QVariant getOption(const QString &_property);
*/
QList<QVariantHash> getPerformance(const QDateTime &_from, const QDateTime &_to,
const QString &_token);
/**
* @brief server status
* @return server status inforamtion
*/
QHash<QString, QHash<QString, QString>> getStatus();
/**
* @brief get task property
* @param _id
@ -227,6 +240,14 @@ QList<QVariantHash> getTasks(const long long _user, const QDateTime &_from,
* @return user property value
*/
QVariant getUser(const long long _id, const QString &_property);
/**
* @brief get user ID
* @param _name
* user name
* @return user ID or {0, -1} if no user found. If _name is numeric value it
* returns converted one
*/
long long getUserId(const QString &_name);
/**
* @brief get users list
* @param _lastLogged
@ -240,13 +261,6 @@ QVariant getUser(const long long _id, const QString &_property);
QList<QVariantHash> getUsers(const QDateTime &_lastLogged,
const QueuedEnums::Permission _permission,
const QString &_token);
/**
* @brief get user ID
* @param _name
* user name
* @return user ID or {0, -1} if no user found
*/
long long getUserId(const QString &_name);
// common methods
/**
* @brief common DBus request

5
sources/queued/include/queued/QueuedDebug.h
View File

@ -24,6 +24,7 @@
#ifndef QUEUEDDEBUG_H
#define QUEUEDDEBUG_H
#include <QHash>
#include <QLoggingCategory>
@ -78,6 +79,10 @@ void enableDebug();
* @brief additional method to get build details declared in version.h
*/
QStringList getBuildData();
/**
* @brief additional method to get build details declared in version.h
*/
QHash<QString, QHash<QString, QString>> getBuildMetaData();
}

5
sources/queued/include/queued/QueuedReportInterface.h
View File

@ -65,6 +65,11 @@ public slots:
*/
QDBusVariant Performance(const QString &from, const QString &to,
const QString &token);
/**
* @brief server status
* @return server status
*/
QDBusVariant Status();
/**
* @brief tasks list
* @param user

47
sources/queued/include/queued/QueuedStaticConfig.h
View File

@ -98,10 +98,12 @@ typedef struct {
* plugin list
* @var QueuedSettings::ServerAddress
* queued server bind address
* @var QueuedSettings::ServerPort
* queued server bind port
* @var QueuedSettings::ServerMaxConnections
* queued server max connections
* @var QueuedSettings::ServerPort
* queued server bind port
* @var QueuedSettings::ServerTimeout
* server thread timeout
*/
enum class QueuedSettings {
Invalid,
@ -115,8 +117,9 @@ enum class QueuedSettings {
ProcessCommandLine,
Plugins,
ServerAddress,
ServerMaxConnections,
ServerPort,
ServerMaxConnections
ServerTimeout
};
/**
* @struct QueuedSettingsField
@ -138,24 +141,26 @@ typedef QHash<QString, QueuedSettingsField> QueuedSettingsDefaultMap;
/**
* @brief default settings map
*/
const QueuedSettingsDefaultMap QueuedSettingsDefaults
= {{"", {QueuedSettings::Invalid, QVariant()}},
{"DatabaseInterval", {QueuedSettings::DatabaseInterval, 86400000}},
{"DefaultLimits", {QueuedSettings::DefaultLimits, "0\n0\n0\n0\n0"}},
{"KeepTasks", {QueuedSettings::KeepTasks, 0}},
{"KeepUsers", {QueuedSettings::KeepUsers, 0}},
{"OnExitAction", {QueuedSettings::OnExitAction, 2}},
{"TokenExpiration", {QueuedSettings::TokenExpiration, 30}},
{"DatabaseVersion",
{QueuedSettings::DatabaseVersion, QueuedConfig::DATABASE_VERSION}},
{"ProcessCommandLine",
{QueuedSettings::ProcessCommandLine,
"systemd-run\n--scope\n--unit={name}\n--uid={uid}\n--gid={gid}"
"\n-p\nCPUQuota={cpu}%\n-p\nMemoryHigh={memory}\n{application}"}},
{"Plugins", {QueuedSettings::Plugins, ""}},
{"ServerAddress", {QueuedSettings::ServerAddress, ""}},
{"ServerPort", {QueuedSettings::ServerPort, 8080}},
{"ServerMaxConnections", {QueuedSettings::ServerMaxConnections, 30}}};
const QueuedSettingsDefaultMap QueuedSettingsDefaults = {
{"", {QueuedSettings::Invalid, QVariant()}},
{"DatabaseInterval", {QueuedSettings::DatabaseInterval, 86400000}},
{"DefaultLimits", {QueuedSettings::DefaultLimits, "0\n0\n0\n0\n0"}},
{"KeepTasks", {QueuedSettings::KeepTasks, 0}},
{"KeepUsers", {QueuedSettings::KeepUsers, 0}},
{"OnExitAction", {QueuedSettings::OnExitAction, 2}},
{"TokenExpiration", {QueuedSettings::TokenExpiration, 30}},
{"DatabaseVersion",
{QueuedSettings::DatabaseVersion, QueuedConfig::DATABASE_VERSION}},
{"ProcessCommandLine",
{QueuedSettings::ProcessCommandLine,
"systemd-run\n--scope\n--unit={name}\n--uid={uid}\n--gid={gid}"
"\n-p\nCPUQuota={cpu}%\n-p\nMemoryHigh={memory}\n{application}"}},
{"Plugins", {QueuedSettings::Plugins, ""}},
{"ServerAddress", {QueuedSettings::ServerAddress, ""}},
{"ServerMaxConnections", {QueuedSettings::ServerMaxConnections, 30}},
{"ServerPort", {QueuedSettings::ServerPort, 8080}},
{"ServerTimeout", {QueuedSettings::ServerTimeout, -1}},
};
};
#endif /* QUEUEDCONFIGURATION_H */

14
sources/queued/src/QueuedCore.cpp
View File

@ -667,8 +667,9 @@ void QueuedCore::updateSettings(const QueuedConfig::QueuedSettings _id,
m_processes->setProcessLine(_value.toString());
break;
case QueuedConfig::QueuedSettings::ServerAddress:
case QueuedConfig::QueuedSettings::ServerPort:
case QueuedConfig::QueuedSettings::ServerMaxConnections:
case QueuedConfig::QueuedSettings::ServerPort:
case QueuedConfig::QueuedSettings::ServerTimeout:
// do nothing here
break;
case QueuedConfig::QueuedSettings::TokenExpiration:
@ -958,12 +959,11 @@ long long QueuedCore::addUserPrivate(const QString &_name,
qCDebug(LOG_LIB) << "Add user" << _name << "with email" << _email
<< "and permissions" << _permissions;
// add to database
QVariantHash properties
= {{"name", _name},
{"password", QueuedUser::hashFromPassword(_password)},
{"email", _email},
{"permissions", _permissions},
{"limits", _limits.toString()}};
QVariantHash properties = {{"name", _name},
{"password", _password},
{"email", _email},
{"permissions", _permissions},
{"limits", _limits.toString()}};
auto id = m_database->add(QueuedDB::USERS_TABLE, properties);
if (id == -1) {
qCWarning(LOG_LIB) << "Could not add user" << _name;

92
sources/queued/src/QueuedCoreAdaptor.cpp
View File

@ -313,6 +313,18 @@ QVariant QueuedCoreAdaptor::getOption(const QString &_property)
}
/**
* @fn getOption
*/
QVariant
QueuedCoreAdaptor::getOption(const QueuedConfig::QueuedSettings _property)
{
qCDebug(LOG_DBUS) << "Get option" << static_cast<int>(_property);
return getOption(QueuedAdvancedSettings::internalId(_property));
}
/**
* @fn getPerformance
*/
@ -324,13 +336,22 @@ QList<QVariantHash> QueuedCoreAdaptor::getPerformance(const QDateTime &_from,
QVariantList args = {_from.toString(Qt::ISODateWithMs),
_to.toString(Qt::ISODateWithMs), _token};
return qdbus_cast<QList<QVariantHash>>(
toNativeType(sendRequest(QueuedConfig::DBUS_SERVICE,
QueuedConfig::DBUS_REPORTS_PATH,
QueuedConfig::DBUS_SERVICE, "Performance",
args)
.first())
.value<QDBusArgument>());
return qdbus_cast<QList<QVariantHash>>(toNativeType(
sendRequest(QueuedConfig::DBUS_SERVICE, QueuedConfig::DBUS_REPORTS_PATH,
QueuedConfig::DBUS_SERVICE, "Performance", args)
.first()));
}
/**
* @fn getStatus
*/
QHash<QString, QHash<QString, QString>> QueuedCoreAdaptor::getStatus()
{
return qdbus_cast<QHash<QString, QHash<QString, QString>>>(toNativeType(
sendRequest(QueuedConfig::DBUS_SERVICE, QueuedConfig::DBUS_REPORTS_PATH,
QueuedConfig::DBUS_SERVICE, "Status", {})
.first()));
}
@ -362,12 +383,10 @@ QList<QVariantHash> QueuedCoreAdaptor::getTasks(const long long _user,
QVariantList args = {_user, _from.toString(Qt::ISODateWithMs),
_to.toString(Qt::ISODateWithMs), _token};
return qdbus_cast<QList<QVariantHash>>(
toNativeType(sendRequest(QueuedConfig::DBUS_SERVICE,
QueuedConfig::DBUS_REPORTS_PATH,
QueuedConfig::DBUS_SERVICE, "Tasks", args)
.first())
.value<QDBusArgument>());
return qdbus_cast<QList<QVariantHash>>(toNativeType(
sendRequest(QueuedConfig::DBUS_SERVICE, QueuedConfig::DBUS_REPORTS_PATH,
QueuedConfig::DBUS_SERVICE, "Tasks", args)
.first()));
}
@ -387,6 +406,27 @@ QVariant QueuedCoreAdaptor::getUser(const long long _id,
}
/**
* @fn getUserId
*/
long long QueuedCoreAdaptor::getUserId(const QString &_name)
{
qCDebug(LOG_DBUS) << "Get user ID for" << _name;
bool status = false;
long long stringToLong = _name.toLongLong(&status);
if (status)
return stringToLong;
QVariantList args = {_name};
return sendRequest(QueuedConfig::DBUS_SERVICE,
QueuedConfig::DBUS_PROPERTY_PATH,
QueuedConfig::DBUS_SERVICE, "UserIdByName", args)
.first()
.toLongLong();
}
/**
* @fn getUsers
*/
@ -400,28 +440,10 @@ QueuedCoreAdaptor::getUsers(const QDateTime &_lastLogged,
QVariantList args = {_lastLogged.toString(Qt::ISODateWithMs),
static_cast<uint>(_permission), _token};
return qdbus_cast<QList<QVariantHash>>(
toNativeType(sendRequest(QueuedConfig::DBUS_SERVICE,
QueuedConfig::DBUS_REPORTS_PATH,
QueuedConfig::DBUS_SERVICE, "Users", args)
.first())
.value<QDBusArgument>());
}
/**
* @fn getUserId
*/
long long QueuedCoreAdaptor::getUserId(const QString &_name)
{
qCDebug(LOG_DBUS) << "Get user ID for" << _name;
QVariantList args = {_name};
return sendRequest(QueuedConfig::DBUS_SERVICE,
QueuedConfig::DBUS_PROPERTY_PATH,
QueuedConfig::DBUS_SERVICE, "UserIdByName", args)
.first()
.toLongLong();
return qdbus_cast<QList<QVariantHash>>(toNativeType(
sendRequest(QueuedConfig::DBUS_SERVICE, QueuedConfig::DBUS_REPORTS_PATH,
QueuedConfig::DBUS_SERVICE, "Users", args)
.first()));
}

171
sources/queued/src/QueuedDebug.cpp
View File

@ -59,81 +59,102 @@ QStringList QueuedDebug::getBuildData()
{
QStringList metadata;
// general information
metadata += "Build details";
metadata += QString("\tVERSION: %1").arg(VERSION);
metadata += QString("\tCOMMIT_SHA: %1").arg(COMMIT_SHA);
metadata += QString("\tBUILD_DATE: %1").arg(BUILD_DATE);
// api
metadata += "API";
metadata += QString("\tDATABASE_VERSION: %1")
.arg(QueuedConfig::DATABASE_VERSION);
metadata += QString("\tPLUGIN_INTERFACE: %1")
.arg(QueuedConfig::PLUGIN_INTERFACE);
// paths
metadata += "Paths";
metadata
+= QString("\tBIN_INSTALL_DIR: %1").arg(QueuedConfig::BIN_INSTALL_DIR);
metadata += QString("\tDATA_INSTALL_DIR: %1")
.arg(QueuedConfig::DATA_INSTALL_DIR);
metadata += QString("\tINCLUDE_INSTALL_DIR: %1")
.arg(QueuedConfig::INCLUDE_INSTALL_DIR);
metadata
+= QString("\tLIB_INSTALL_DIR: %1").arg(QueuedConfig::LIB_INSTALL_DIR);
metadata += QString("\tROOT_INSTALL_DIR: %1")
.arg(QueuedConfig::ROOT_INSTALL_DIR);
metadata += QString("\tHOME_PATH: %1").arg(QueuedConfig::HOME_PATH);
metadata += QString("\tPLUGIN_PATH: %1").arg(QueuedConfig::PLUGIN_PATH);
// dbus
metadata += "DBus";
metadata += QString("\tDBUS_SERVICE: %1").arg(QueuedConfig::DBUS_SERVICE);
metadata += QString("\tDBUS_APPLICATION_PATH: %1")
.arg(QueuedConfig::DBUS_APPLICATION_PATH);
metadata += QString("\tDBUS_OBJECT_PATH: %1")
.arg(QueuedConfig::DBUS_OBJECT_PATH);
metadata += QString("\tDBUS_PROPERTY_PATH: %1")
.arg(QueuedConfig::DBUS_PROPERTY_PATH);
// cmake build information
metadata += "Cmake properties";
metadata += QString("\tCMAKE_BUILD_TYPE: %1").arg(CMAKE_BUILD_TYPE);
metadata += QString("\tCMAKE_CXX_COMPILER: %1").arg(CMAKE_CXX_COMPILER);
metadata += QString("\tCMAKE_CXX_FLAGS: %1").arg(CMAKE_CXX_FLAGS);
metadata
+= QString("\tCMAKE_CXX_FLAGS_DEBUG: %1").arg(CMAKE_CXX_FLAGS_DEBUG);
metadata += QString("\tCMAKE_CXX_FLAGS_RELEASE: %1")
.arg(CMAKE_CXX_FLAGS_RELEASE);
metadata += QString("\tCMAKE_CXX_FLAGS_OPTIMIZATION: %1")
.arg(CMAKE_CXX_FLAGS_OPTIMIZATION);
metadata += QString("\tCMAKE_DEFINITIONS: %1").arg(CMAKE_DEFINITIONS);
metadata += QString("\tCMAKE_INSTALL_PREFIX: %1").arg(CMAKE_INSTALL_PREFIX);
metadata += QString("\tCMAKE_MODULE_LINKER_FLAGS: %1")
.arg(CMAKE_MODULE_LINKER_FLAGS);
metadata += QString("\tCMAKE_SHARED_LINKER_FLAGS: %1")
.arg(CMAKE_SHARED_LINKER_FLAGS);
// components
metadata += "Components";
metadata += QString("\tBUILD_DEB_PACKAGE: %1").arg(BUILD_DEB_PACKAGE);
metadata += QString("\tBUILD_RPM_PACKAGE: %1").arg(BUILD_RPM_PACKAGE);
metadata
+= QString("\tCLANGFORMAT_EXECUTABLE: %1").arg(CLANGFORMAT_EXECUTABLE);
metadata += QString("\tCOVERITY_COMMENT: %1").arg(COVERITY_COMMENT);
metadata += QString("\tCOVERITY_DIRECTORY: %1").arg(COVERITY_DIRECTORY);
metadata += QString("\tCOVERITY_EMAIL: %1").arg(COVERITY_EMAIL);
metadata += QString("\tCOVERITY_EXECUTABLE: %1").arg(COVERITY_EXECUTABLE);
metadata += QString("\tCOVERITY_URL: %1").arg(COVERITY_URL);
metadata += QString("\tCPPCHECK_EXECUTABLE: %1").arg(CPPCHECK_EXECUTABLE);
// additional properties
metadata += "Additional properties";
metadata += QString("\tPROP_DOCS: %1").arg(PROP_DOCS);
metadata += QString("\tPROP_FUTURE: %1").arg(PROP_FUTURE);
metadata += QString("\tPROP_LOAD: %1").arg(PROP_LOAD);
metadata += QString("\tPROP_TEST: %1").arg(PROP_TEST);
auto data = getBuildMetaData();
auto sections = data.keys();
sections.sort();
for (auto &section : sections) {
metadata += section;
auto keys = data[section].keys();
keys.sort();
for (auto &key : keys)
metadata += QString("\t%1: %2").arg(key).arg(data[section][key]);
}
return metadata;
}
/**
* @fn getBuildMetaData
*/
QHash<QString, QHash<QString, QString>> QueuedDebug::getBuildMetaData()
{
return {// general information
{"Build details",
{
{"VERSION", VERSION},
{"COMMIT_SHA", COMMIT_SHA},
{"BUILD_DATE", BUILD_DATE},
{"QT_VERSION", qVersion()},
}},
// api
{"API",
{
{"DATABASE_VERSION",
QString::number(QueuedConfig::DATABASE_VERSION)},
{"PLUGIN_INTERFACE", QueuedConfig::PLUGIN_INTERFACE},
{"WEBAPI_TOKEN_HEADER", QueuedConfig::WEBAPI_TOKEN_HEADER},
{"WEBAPI_VERSIONS",
std::accumulate(
std::next(std::begin(QueuedConfig::WEBAPI_VERSIONS)),
std::end(QueuedConfig::WEBAPI_VERSIONS),
QString::number(QueuedConfig::WEBAPI_VERSIONS[0]),
[](const QString str, const int version) {
return QString("%1,%2").arg(str).arg(version);
})},
}},
// paths
{"Paths",
{
{"BIN_INSTALL_DIR", QueuedConfig::BIN_INSTALL_DIR},
{"DATA_INSTALL_DIR", QueuedConfig::DATA_INSTALL_DIR},
{"INCLUDE_INSTALL_DIR", QueuedConfig::INCLUDE_INSTALL_DIR},
{"LIB_INSTALL_DIR", QueuedConfig::LIB_INSTALL_DIR},
{"ROOT_INSTALL_DIR", QueuedConfig::ROOT_INSTALL_DIR},
{"HOME_PATH", QueuedConfig::HOME_PATH},
{"PLUGIN_PATH", QueuedConfig::PLUGIN_PATH},
}},
// dbus
{"DBus",
{
{"DBUS_SERVICE", QueuedConfig::DBUS_SERVICE},
{"DBUS_APPLICATION_PATH", QueuedConfig::DBUS_APPLICATION_PATH},
{"DBUS_OBJECT_PATH", QueuedConfig::DBUS_OBJECT_PATH},
{"DBUS_PROPERTY_PATH", QueuedConfig::DBUS_PROPERTY_PATH},
}},
// cmake build information
{"Cmake properties",
{
{"CMAKE_BUILD_TYPE", CMAKE_BUILD_TYPE},
{"CMAKE_CXX_COMPILER", CMAKE_CXX_COMPILER},
{"CMAKE_CXX_FLAGS", CMAKE_CXX_FLAGS},
{"CMAKE_CXX_FLAGS_DEBUG", CMAKE_CXX_FLAGS_DEBUG},
{"CMAKE_CXX_FLAGS_RELEASE", CMAKE_CXX_FLAGS_RELEASE},
{"CMAKE_CXX_FLAGS_OPTIMIZATION", CMAKE_CXX_FLAGS_OPTIMIZATION},
{"CMAKE_DEFINITIONS", CMAKE_DEFINITIONS},
{"CMAKE_INSTALL_PREFIX", CMAKE_INSTALL_PREFIX},
{"CMAKE_MODULE_LINKER_FLAGS", CMAKE_MODULE_LINKER_FLAGS},
{"CMAKE_SHARED_LINKER_FLAGS", CMAKE_SHARED_LINKER_FLAGS},
}},
// components
{"Components",
{
{"BUILD_DEB_PACKAGE", BUILD_DEB_PACKAGE},
{"BUILD_RPM_PACKAGE", BUILD_RPM_PACKAGE},
{"CLANGFORMAT_EXECUTABLE", CLANGFORMAT_EXECUTABLE},
{"COVERITY_COMMENT", COVERITY_COMMENT},
{"COVERITY_DIRECTORY", COVERITY_DIRECTORY},
{"COVERITY_EMAIL", COVERITY_EMAIL},
{"COVERITY_EXECUTABLE", COVERITY_EXECUTABLE},
{"COVERITY_URL", COVERITY_URL},
{"CPPCHECK_EXECUTABLE", CPPCHECK_EXECUTABLE},
}},
// additional properties
{"Additional properties",
{
{"PROP_DOCS", PROP_DOCS},
{"PROP_FUTURE", PROP_FUTURE},
{"PROP_LOAD", PROP_LOAD},
{"PROP_TEST", PROP_TEST},
}}};
}

11
sources/queued/src/QueuedProcess.cpp
View File

@ -24,6 +24,9 @@
#include <queued/Queued.h>
#include <QMetaProperty>
#include <QStandardPaths>
#include <queued/QueuedProcess.h>
/**
@ -385,10 +388,14 @@ void QueuedProcess::setWorkDirectory(const QString &_workDirectory)
{
qCDebug(LOG_LIB) << "Set working directory to" << _workDirectory;
m_definitions.workingDirectory = _workDirectory;
m_definitions.workingDirectory
= _workDirectory.isEmpty()
? QStandardPaths::writableLocation(
QStandardPaths::StandardLocation::TempLocation)
: _workDirectory;
setLogError("");
setLogOutput("");
setWorkingDirectory(_workDirectory);
setWorkingDirectory(m_definitions.workingDirectory);
}

31
sources/queued/src/QueuedPropertyInterface.cpp
View File

@ -56,7 +56,8 @@ QDBusVariant QueuedPropertyInterface::Option(const QString &property)
{
qCDebug(LOG_DBUS) << "Get property" << property;
return QDBusVariant(m_core->option(property));
auto response = m_core->option(property);
return QDBusVariant(response.isValid() ? response : "");
}
@ -71,14 +72,16 @@ QDBusVariant QueuedPropertyInterface::Task(const long long id,
auto task = m_core->task(id);
if (!task) {
qCWarning(LOG_DBUS) << "Could not find task" << id;
return QDBusVariant();
return QDBusVariant("");
}
if (property.isEmpty())
return QDBusVariant(
QVariant::fromValue<QVariantHash>(getProperties(task)));
else
return QDBusVariant(task->property(qPrintable(property)));
if (property.isEmpty()) {
auto response = QVariant::fromValue<QVariantHash>(getProperties(task));
return QDBusVariant(response);
} else {
auto response = task->property(qPrintable(property));
return QDBusVariant(response.isValid() ? response : "");
}
}
@ -93,14 +96,16 @@ QDBusVariant QueuedPropertyInterface::User(const long long id,
auto user = m_core->user(id);
if (!user) {
qCWarning(LOG_DBUS) << "Could not find user" << id;
return QDBusVariant();
return QDBusVariant("");
}
if (property.isEmpty())
return QDBusVariant(
QVariant::fromValue<QVariantHash>(getProperties(user)));
else
return QDBusVariant(user->property(qPrintable(property)));
if (property.isEmpty()) {
auto response = QVariant::fromValue<QVariantHash>(getProperties(user));
return QDBusVariant(response);
} else {
auto response = user->property(qPrintable(property));
return QDBusVariant(response.isValid() ? response : "");
}
}

21
sources/queued/src/QueuedReportInterface.cpp
View File

@ -38,8 +38,16 @@ QueuedReportInterface::QueuedReportInterface(QueuedCore *parent)
{
qCDebug(LOG_DBUS) << __PRETTY_FUNCTION__;
// QList<QVariantHash>
qRegisterMetaType<QList<QVariantHash>>("QList<QVariantHash>");
qDBusRegisterMetaType<QList<QVariantHash>>();
// QHash<QString, QString>
qRegisterMetaType<QHash<QString, QString>>("QHash<QString, QString>");
qDBusRegisterMetaType<QHash<QString, QString>>();
// QHash<QString, QHash<QString, QString>>
qRegisterMetaType<QHash<QString, QHash<QString, QString>>>(
"QHash<QString, QHash<QString, QString>>");
qDBusRegisterMetaType<QHash<QString, QHash<QString, QString>>>();
}
@ -68,6 +76,19 @@ QDBusVariant QueuedReportInterface::Performance(const QString &from,
}
/**
* @fn Status
*/
QDBusVariant QueuedReportInterface::Status()
{
auto metadata = QueuedDebug::getBuildMetaData();
// append metadata here
return QDBusVariant(
QVariant::fromValue<QHash<QString, QHash<QString, QString>>>(metadata));
}
/**
* @fn Tasks
*/

2
sources/queued/src/QueuedReportManager.cpp
View File

@ -143,7 +143,7 @@ QList<QVariantHash> QueuedReportManager::tasks(const long long _user,
qCDebug(LOG_LIB) << "Search for tasks in" << _user << _from << _to;
QStringList conditions;
if (_user != -1)
if (_user > 0)
conditions += QString("(user = %1)").arg(_user);
if (_from.isValid())
conditions += QString("((datetime(startTime) > datetime('%1')) OR "

8
sources/queuedctl/src/QueuedctlCommon.cpp
View File

@ -223,7 +223,7 @@ QueuedctlCommon::process(QCommandLineParser &_parser, const QString &_cache,
break;
}
case QueuedctlArgument::PermissionAdd: {
auto userId = QueuedctlUser::getUserId(args.at(1));
auto userId = QueuedCoreAdaptor::getUserId(args.at(1));
QString token = QueuedctlAuth::getToken(_cache, _user);
result.status
= QueuedctlPermissions::addPermission(userId, args.at(2), token);
@ -238,7 +238,7 @@ QueuedctlCommon::process(QCommandLineParser &_parser, const QString &_cache,
break;
}
case QueuedctlArgument::PermissionRemove: {
auto userId = QueuedctlUser::getUserId(args.at(1));
auto userId = QueuedCoreAdaptor::getUserId(args.at(1));
QString token = QueuedctlAuth::getToken(_cache, _user);
result.status
= QueuedctlPermissions::removePermission(userId, args.at(2), token);
@ -340,7 +340,7 @@ QueuedctlCommon::process(QCommandLineParser &_parser, const QString &_cache,
break;
}
case QueuedctlArgument::UserGet: {
auto userId = QueuedctlUser::getUserId(args.at(1));
auto userId = QueuedCoreAdaptor::getUserId(args.at(1));
QVariant value = QueuedctlUser::getUser(userId, args.at(2));
result.status = value.isValid();
result.output = args.at(2).isEmpty() ? hashToString(value.toHash())
@ -355,7 +355,7 @@ QueuedctlCommon::process(QCommandLineParser &_parser, const QString &_cache,
break;
}
case QueuedctlArgument::UserSet: {
auto userId = QueuedctlUser::getUserId(args.at(1));
auto userId = QueuedCoreAdaptor::getUserId(args.at(1));
QString token = QueuedctlAuth::getToken(_cache, _user);
auto definitions = QueuedctlUser::getDefinitions(_parser, true);
result.status = QueuedctlUser::setUser(userId, definitions, token);

4
sources/queuedctl/src/QueuedctlPlugins.cpp
View File

@ -29,9 +29,7 @@ bool QueuedctlPlugins::addPlugin(const QString &_plugin, const QString &_token)
QStringList QueuedctlPlugins::listPlugins()
{
return QueuedCoreAdaptor::getOption(
QueuedAdvancedSettings::internalId(
QueuedConfig::QueuedSettings::Plugins))
return QueuedCoreAdaptor::getOption(QueuedConfig::QueuedSettings::Plugins)
.toString()
.split('\n');
}

11
sources/queuedctl/src/QueuedctlTask.cpp
View File

@ -57,7 +57,7 @@ QueuedctlTask::getDefinitions(const QCommandLineParser &_parser,
definitions.user
= _parser.value("task-user").isEmpty()
? 0
: QueuedctlUser::getUserId(_parser.value("task-user"));
: QueuedCoreAdaptor::getUserId(_parser.value("task-user"));
definitions.workingDirectory
= QFileInfo(_parser.value("directory")).absoluteFilePath();
// limits now
@ -95,7 +95,7 @@ QVariant QueuedctlTask::getTask(const long long _id, const QString &_property)
auto value = QueuedCoreAdaptor::getTask(_id, _property);
if (_property.isEmpty())
return qdbus_cast<QVariantHash>(value.value<QDBusArgument>());
return qdbus_cast<QVariantHash>(value);
else
return value;
}
@ -104,9 +104,10 @@ QVariant QueuedctlTask::getTask(const long long _id, const QString &_property)
QList<QVariantHash> QueuedctlTask::getTasks(const QCommandLineParser &_parser,
const QString &_token)
{
long long user = _parser.value("task-user").isEmpty()
? -1
: QueuedctlUser::getUserId(_parser.value("task-user"));
long long user
= _parser.value("task-user").isEmpty()
? -1
: QueuedCoreAdaptor::getUserId(_parser.value("task-user"));
QDateTime stop
= QDateTime::fromString(_parser.value("stop"), Qt::ISODateWithMs);
QDateTime start

15
sources/queuedctl/src/QueuedctlUser.cpp
View File

@ -113,7 +113,7 @@ QVariant QueuedctlUser::getUser(const long long _id, const QString &_property)
auto value = QueuedCoreAdaptor::getUser(_id, _property);
if (_property.isEmpty())
return qdbus_cast<QVariantHash>(value.value<QDBusArgument>());
return qdbus_cast<QVariantHash>(value);
else
return value;
}
@ -133,19 +133,6 @@ QList<QVariantHash> QueuedctlUser::getUsers(const QCommandLineParser &_parser,
}
long long QueuedctlUser::getUserId(const QString &_name)
{
qCDebug(LOG_APP) << "Get user ID for" << _name;
bool status = false;
long long stringToLong = _name.toLongLong(&status);
if (status)
return stringToLong;
else
return QueuedCoreAdaptor::getUserId(_name);
}
void QueuedctlUser::parserAdd(QCommandLineParser &_parser)
{
_parser.addPositionalArgument("name", "User name.", "<name>");

1
sources/queuedctl/src/QueuedctlUser.h
View File

@ -34,7 +34,6 @@ QString getPassword();
QVariant getUser(const long long _id, const QString &_property);
QList<QVariantHash> getUsers(const QCommandLineParser &_parser,
const QString &_token);
long long getUserId(const QString &_name);
void parserAdd(QCommandLineParser &_parser);
void parserGet(QCommandLineParser &_parser);
void parserList(QCommandLineParser &_parser);