nodiscard attribute for formatter methods

This commit is contained in:
Evgenii Alekseev 2024-04-30 17:08:52 +03:00
parent 238e70e711
commit 985737564e
24 changed files with 60 additions and 35 deletions

View File

@ -29,7 +29,8 @@ class AWPluginFormaterInterface
{
public:
virtual ~AWPluginFormaterInterface() = default;
virtual QString format(const QVariant &_value, const QString &_key, const AWPluginFormatSettings &_settings) const
[[nodiscard]] virtual QString format(const QVariant &_value, const QString &_key,
const AWPluginFormatSettings &_settings) const
= 0;
virtual void load(){};
};
@ -46,19 +47,21 @@ public:
AWPluginFormatter(AWPluginFormatter &) = delete;
void operator=(const AWPluginFormatter &) = delete;
static Formatter *instance()
[[nodiscard]] static Formatter *instance()
{
static auto instance = loadInstance();
return instance.get();
};
static QLocale locale(const AWPluginFormatSettings &_settings)
[[nodiscard]] static QLocale locale(const AWPluginFormatSettings &_settings)
{
return _settings.translate ? QLocale::system() : QLocale::c();
};
protected:
AWPluginFormatter() = default;
static std::unique_ptr<Formatter> loadInstance()
[[nodiscard]] static std::unique_ptr<Formatter> loadInstance()
{
auto instance = std::make_unique<Formatter>();
instance->load();

View File

@ -24,5 +24,6 @@ class AWPluginFormatterAC : public AWPluginFormatter<AWPluginFormatterAC>
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &_settings) const override;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterCustom : public AWPluginFormatter<AWPluginFormatterCustom
{
public:
QString format(const QVariant &_value, const QString &_key, const AWPluginFormatSettings &_settings) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &_key,
const AWPluginFormatSettings &_settings) const override;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterDouble : public AWPluginFormatter<AWPluginFormatterDouble
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterFloat : public AWPluginFormatter<AWPluginFormatterFloat>
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterFloatPrecise : public AWPluginFormatter<AWPluginFormatter
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterInteger : public AWPluginFormatter<AWPluginFormatterInteg
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterIntegerShort : public AWPluginFormatter<AWPluginFormatter
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterIntegerWide : public AWPluginFormatter<AWPluginFormatterI
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterList : public AWPluginFormatter<AWPluginFormatterList>
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterMemory : public AWPluginFormatter<AWPluginFormatterMemory
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterMemoryGB : public AWPluginFormatter<AWPluginFormatterMemo
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterMemoryMB : public AWPluginFormatter<AWPluginFormatterMemo
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
};

View File

@ -24,9 +24,10 @@ class AWPluginFormatterNet : public AWPluginFormatter<AWPluginFormatterNet>
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
private:
static QString formatKB(const double &_value);
static QString formatMB(const double &_value);
[[nodiscard]] static QString formatKB(const double &_value);
[[nodiscard]] static QString formatMB(const double &_value);
};

View File

@ -24,9 +24,10 @@ class AWPluginFormatterNetUnits : public AWPluginFormatter<AWPluginFormatterNetU
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &_settings) const override;
private:
static QString formatKB(const AWPluginFormatSettings &_settings);
static QString formatMB(const AWPluginFormatSettings &_settings);
[[nodiscard]] static QString formatKB(const AWPluginFormatSettings &_settings);
[[nodiscard]] static QString formatMB(const AWPluginFormatSettings &_settings);
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterNoFormat : public AWPluginFormatter<AWPluginFormatterNoFo
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
};

View File

@ -24,8 +24,9 @@ class AWPluginFormatterTemperature : public AWPluginFormatter<AWPluginFormatterT
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &_settings) const override;
private:
static double convert(const double &_value, const QString &_units);
[[nodiscard]] static double convert(const double &_value, const QString &_units);
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterTime : public AWPluginFormatter<AWPluginFormatterTime>
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
};

View File

@ -26,10 +26,11 @@ class AWPluginFormatterTimeCustom : public AWPluginFormatter<AWPluginFormatterTi
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &_settings) const override;
void load() override;
private:
QString format(const QDateTime &_value, QString _formatString, const QLocale &_locale) const;
[[nodiscard]] QString format(const QDateTime &_value, QString _formatString, const QLocale &_locale) const;
QStringList m_timeKeys;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterTimeISO : public AWPluginFormatter<AWPluginFormatterTimeI
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &) const override;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterTimeLong : public AWPluginFormatter<AWPluginFormatterTime
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &_settings) const override;
};

View File

@ -24,5 +24,6 @@ class AWPluginFormatterTimeShort : public AWPluginFormatter<AWPluginFormatterTim
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &_settings) const override;
};

View File

@ -24,8 +24,9 @@ class AWPluginFormatterUptime : public AWPluginFormatter<AWPluginFormatterUptime
{
public:
QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
[[nodiscard]] QString format(const QVariant &_value, const QString &,
const AWPluginFormatSettings &_settings) const override;
private:
static QString format(const long &_value, QString _formatString);
[[nodiscard]] static QString format(const long &_value, QString _formatString);
};

View File

@ -45,13 +45,13 @@ public:
AWPluginMatcher(AWPluginMatcher &) = delete;
void operator=(const AWPluginMatcher &) = delete;
static Matcher *instance()
[[nodiscard]] static Matcher *instance()
{
static auto instance = std::make_unique<Matcher>();
return instance.get();
};
static QString device(const QString &_source) { return _source.split('/')[1]; };
[[nodiscard]] static QString device(const QString &_source) { return _source.split('/')[1]; };
protected:
AWPluginMatcher() = default;