From 985737564e6d2d558500d7b3626213c7c6bbe7e3 Mon Sep 17 00:00:00 2001
From: Evgenii Alekseev <i@arcanis.me>
Date: Tue, 30 Apr 2024 17:08:52 +0300
Subject: [PATCH] nodiscard attribute for formatter methods

---
 .../plugin/formatters/awpluginformatter.h             | 11 +++++++----
 .../plugin/formatters/awpluginformatterac.h           |  3 ++-
 .../plugin/formatters/awpluginformattercustom.h       |  3 ++-
 .../plugin/formatters/awpluginformatterdouble.h       |  3 ++-
 .../plugin/formatters/awpluginformatterfloat.h        |  3 ++-
 .../plugin/formatters/awpluginformatterfloatprecise.h |  3 ++-
 .../plugin/formatters/awpluginformatterinteger.h      |  3 ++-
 .../plugin/formatters/awpluginformatterintegershort.h |  3 ++-
 .../plugin/formatters/awpluginformatterintegerwide.h  |  3 ++-
 .../plugin/formatters/awpluginformatterlist.h         |  3 ++-
 .../plugin/formatters/awpluginformattermemory.h       |  3 ++-
 .../plugin/formatters/awpluginformattermemorygb.h     |  3 ++-
 .../plugin/formatters/awpluginformattermemorymb.h     |  3 ++-
 .../plugin/formatters/awpluginformatternet.h          |  7 ++++---
 .../plugin/formatters/awpluginformatternetunits.h     |  7 ++++---
 .../plugin/formatters/awpluginformatternoformat.h     |  3 ++-
 .../plugin/formatters/awpluginformattertemperature.h  |  5 +++--
 .../plugin/formatters/awpluginformattertime.h         |  3 ++-
 .../plugin/formatters/awpluginformattertimecustom.h   |  5 +++--
 .../plugin/formatters/awpluginformattertimeiso.h      |  3 ++-
 .../plugin/formatters/awpluginformattertimelong.h     |  3 ++-
 .../plugin/formatters/awpluginformattertimeshort.h    |  3 ++-
 .../plugin/formatters/awpluginformatteruptime.h       |  5 +++--
 .../awesome-widget/plugin/matchers/awpluginmatcher.h  |  4 ++--
 24 files changed, 60 insertions(+), 35 deletions(-)

diff --git a/sources/awesome-widget/plugin/formatters/awpluginformatter.h b/sources/awesome-widget/plugin/formatters/awpluginformatter.h
index 02f7a3b..12b27a1 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformatter.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformatter.h
@@ -29,7 +29,8 @@ class AWPluginFormaterInterface
 {
 public:
     virtual ~AWPluginFormaterInterface() = default;
-    virtual QString format(const QVariant &_value, const QString &_key, const AWPluginFormatSettings &_settings) const
+    [[nodiscard]] virtual QString format(const QVariant &_value, const QString &_key,
+                                         const AWPluginFormatSettings &_settings) const
         = 0;
     virtual void load(){};
 };
@@ -46,19 +47,21 @@ public:
     AWPluginFormatter(AWPluginFormatter &) = delete;
     void operator=(const AWPluginFormatter &) = delete;
 
-    static Formatter *instance()
+    [[nodiscard]] static Formatter *instance()
     {
         static auto instance = loadInstance();
         return instance.get();
     };
-    static QLocale locale(const AWPluginFormatSettings &_settings)
+
+    [[nodiscard]] static QLocale locale(const AWPluginFormatSettings &_settings)
     {
         return _settings.translate ? QLocale::system() : QLocale::c();
     };
 
 protected:
     AWPluginFormatter() = default;
-    static std::unique_ptr<Formatter> loadInstance()
+
+    [[nodiscard]] static std::unique_ptr<Formatter> loadInstance()
     {
         auto instance = std::make_unique<Formatter>();
         instance->load();
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformatterac.h b/sources/awesome-widget/plugin/formatters/awpluginformatterac.h
index 221a4df..bff2c5f 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformatterac.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformatterac.h
@@ -24,5 +24,6 @@ class AWPluginFormatterAC : public AWPluginFormatter<AWPluginFormatterAC>
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &_settings) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformattercustom.h b/sources/awesome-widget/plugin/formatters/awpluginformattercustom.h
index c815fa1..5793343 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformattercustom.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformattercustom.h
@@ -24,5 +24,6 @@ class AWPluginFormatterCustom : public AWPluginFormatter<AWPluginFormatterCustom
 {
 
 public:
-    QString format(const QVariant &_value, const QString &_key, const AWPluginFormatSettings &_settings) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &_key,
+                                 const AWPluginFormatSettings &_settings) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformatterdouble.h b/sources/awesome-widget/plugin/formatters/awpluginformatterdouble.h
index 4dc3f96..8b1980d 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformatterdouble.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformatterdouble.h
@@ -24,5 +24,6 @@ class AWPluginFormatterDouble : public AWPluginFormatter<AWPluginFormatterDouble
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformatterfloat.h b/sources/awesome-widget/plugin/formatters/awpluginformatterfloat.h
index 09e99fd..bc42b90 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformatterfloat.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformatterfloat.h
@@ -24,5 +24,6 @@ class AWPluginFormatterFloat : public AWPluginFormatter<AWPluginFormatterFloat>
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformatterfloatprecise.h b/sources/awesome-widget/plugin/formatters/awpluginformatterfloatprecise.h
index 666cff0..4f24626 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformatterfloatprecise.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformatterfloatprecise.h
@@ -24,5 +24,6 @@ class AWPluginFormatterFloatPrecise : public AWPluginFormatter<AWPluginFormatter
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformatterinteger.h b/sources/awesome-widget/plugin/formatters/awpluginformatterinteger.h
index 315605b..f765e88 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformatterinteger.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformatterinteger.h
@@ -24,5 +24,6 @@ class AWPluginFormatterInteger : public AWPluginFormatter<AWPluginFormatterInteg
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformatterintegershort.h b/sources/awesome-widget/plugin/formatters/awpluginformatterintegershort.h
index 5b4e12b..b306f82 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformatterintegershort.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformatterintegershort.h
@@ -24,5 +24,6 @@ class AWPluginFormatterIntegerShort : public AWPluginFormatter<AWPluginFormatter
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformatterintegerwide.h b/sources/awesome-widget/plugin/formatters/awpluginformatterintegerwide.h
index 8d5c4ef..edaff68 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformatterintegerwide.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformatterintegerwide.h
@@ -24,5 +24,6 @@ class AWPluginFormatterIntegerWide : public AWPluginFormatter<AWPluginFormatterI
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformatterlist.h b/sources/awesome-widget/plugin/formatters/awpluginformatterlist.h
index 69dc46a..65b948c 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformatterlist.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformatterlist.h
@@ -24,5 +24,6 @@ class AWPluginFormatterList : public AWPluginFormatter<AWPluginFormatterList>
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformattermemory.h b/sources/awesome-widget/plugin/formatters/awpluginformattermemory.h
index fcc4041..1fb2ba4 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformattermemory.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformattermemory.h
@@ -24,5 +24,6 @@ class AWPluginFormatterMemory : public AWPluginFormatter<AWPluginFormatterMemory
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformattermemorygb.h b/sources/awesome-widget/plugin/formatters/awpluginformattermemorygb.h
index a780632..6a78d27 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformattermemorygb.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformattermemorygb.h
@@ -24,5 +24,6 @@ class AWPluginFormatterMemoryGB : public AWPluginFormatter<AWPluginFormatterMemo
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformattermemorymb.h b/sources/awesome-widget/plugin/formatters/awpluginformattermemorymb.h
index 2973db6..8734408 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformattermemorymb.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformattermemorymb.h
@@ -24,5 +24,6 @@ class AWPluginFormatterMemoryMB : public AWPluginFormatter<AWPluginFormatterMemo
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformatternet.h b/sources/awesome-widget/plugin/formatters/awpluginformatternet.h
index 1084732..d0464d7 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformatternet.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformatternet.h
@@ -24,9 +24,10 @@ class AWPluginFormatterNet : public AWPluginFormatter<AWPluginFormatterNet>
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 
 private:
-    static QString formatKB(const double &_value);
-    static QString formatMB(const double &_value);
+    [[nodiscard]] static QString formatKB(const double &_value);
+    [[nodiscard]] static QString formatMB(const double &_value);
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformatternetunits.h b/sources/awesome-widget/plugin/formatters/awpluginformatternetunits.h
index 568e0c2..ba17855 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformatternetunits.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformatternetunits.h
@@ -24,9 +24,10 @@ class AWPluginFormatterNetUnits : public AWPluginFormatter<AWPluginFormatterNetU
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &_settings) const override;
 
 private:
-    static QString formatKB(const AWPluginFormatSettings &_settings);
-    static QString formatMB(const AWPluginFormatSettings &_settings);
+    [[nodiscard]] static QString formatKB(const AWPluginFormatSettings &_settings);
+    [[nodiscard]] static QString formatMB(const AWPluginFormatSettings &_settings);
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformatternoformat.h b/sources/awesome-widget/plugin/formatters/awpluginformatternoformat.h
index 983be3a..db1fb09 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformatternoformat.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformatternoformat.h
@@ -24,5 +24,6 @@ class AWPluginFormatterNoFormat : public AWPluginFormatter<AWPluginFormatterNoFo
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformattertemperature.h b/sources/awesome-widget/plugin/formatters/awpluginformattertemperature.h
index 473866c..3f9e0af 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformattertemperature.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformattertemperature.h
@@ -24,8 +24,9 @@ class AWPluginFormatterTemperature : public AWPluginFormatter<AWPluginFormatterT
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &_settings) const override;
 
 private:
-    static double convert(const double &_value, const QString &_units);
+    [[nodiscard]] static double convert(const double &_value, const QString &_units);
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformattertime.h b/sources/awesome-widget/plugin/formatters/awpluginformattertime.h
index 5b43b21..7be694b 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformattertime.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformattertime.h
@@ -24,5 +24,6 @@ class AWPluginFormatterTime : public AWPluginFormatter<AWPluginFormatterTime>
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformattertimecustom.h b/sources/awesome-widget/plugin/formatters/awpluginformattertimecustom.h
index ccd3621..bbc35f6 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformattertimecustom.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformattertimecustom.h
@@ -26,10 +26,11 @@ class AWPluginFormatterTimeCustom : public AWPluginFormatter<AWPluginFormatterTi
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &_settings) const override;
     void load() override;
 
 private:
-    QString format(const QDateTime &_value, QString _formatString, const QLocale &_locale) const;
+    [[nodiscard]] QString format(const QDateTime &_value, QString _formatString, const QLocale &_locale) const;
     QStringList m_timeKeys;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformattertimeiso.h b/sources/awesome-widget/plugin/formatters/awpluginformattertimeiso.h
index fa8e557..896396e 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformattertimeiso.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformattertimeiso.h
@@ -24,5 +24,6 @@ class AWPluginFormatterTimeISO : public AWPluginFormatter<AWPluginFormatterTimeI
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformattertimelong.h b/sources/awesome-widget/plugin/formatters/awpluginformattertimelong.h
index 3258d62..a4b873d 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformattertimelong.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformattertimelong.h
@@ -24,5 +24,6 @@ class AWPluginFormatterTimeLong : public AWPluginFormatter<AWPluginFormatterTime
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &_settings) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformattertimeshort.h b/sources/awesome-widget/plugin/formatters/awpluginformattertimeshort.h
index c99e8bd..ad5bf5a 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformattertimeshort.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformattertimeshort.h
@@ -24,5 +24,6 @@ class AWPluginFormatterTimeShort : public AWPluginFormatter<AWPluginFormatterTim
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &_settings) const override;
 };
diff --git a/sources/awesome-widget/plugin/formatters/awpluginformatteruptime.h b/sources/awesome-widget/plugin/formatters/awpluginformatteruptime.h
index 3ca0971..25d17de 100644
--- a/sources/awesome-widget/plugin/formatters/awpluginformatteruptime.h
+++ b/sources/awesome-widget/plugin/formatters/awpluginformatteruptime.h
@@ -24,8 +24,9 @@ class AWPluginFormatterUptime : public AWPluginFormatter<AWPluginFormatterUptime
 {
 
 public:
-    QString format(const QVariant &_value, const QString &, const AWPluginFormatSettings &_settings) const override;
+    [[nodiscard]] QString format(const QVariant &_value, const QString &,
+                                 const AWPluginFormatSettings &_settings) const override;
 
 private:
-    static QString format(const long &_value, QString _formatString);
+    [[nodiscard]] static QString format(const long &_value, QString _formatString);
 };
diff --git a/sources/awesome-widget/plugin/matchers/awpluginmatcher.h b/sources/awesome-widget/plugin/matchers/awpluginmatcher.h
index cf47581..34729f7 100644
--- a/sources/awesome-widget/plugin/matchers/awpluginmatcher.h
+++ b/sources/awesome-widget/plugin/matchers/awpluginmatcher.h
@@ -45,13 +45,13 @@ public:
     AWPluginMatcher(AWPluginMatcher &) = delete;
     void operator=(const AWPluginMatcher &) = delete;
 
-    static Matcher *instance()
+    [[nodiscard]] static Matcher *instance()
     {
         static auto instance = std::make_unique<Matcher>();
         return instance.get();
     };
 
-    static QString device(const QString &_source) { return _source.split('/')[1]; };
+    [[nodiscard]] static QString device(const QString &_source) { return _source.split('/')[1]; };
 
 protected:
     AWPluginMatcher() = default;