Release 3.5.0

.docker/Dockerfile-arch

@@ -1,12 +0,0 @@
-FROM archlinux
-
-RUN pacman -Sy
-
-# toolchain
-RUN echo -e 'y\ny' | pacman -S util-linux-libs
-RUN pacman -S --noconfirm base-devel cmake extra-cmake-modules python util-linux-libs
-# kf5 and qt5 libraries
-RUN pacman -S --noconfirm plasma-framework
-
-# required by tests
-RUN pacman -S --noconfirm xorg-server-xvfb

.docker/Dockerfile-ubuntu-amd64

@@ -1,14 +0,0 @@
-FROM ubuntu:focal
-
-ENV DEBIAN_FRONTEND=noninteractive
-
-RUN apt-get update
-# toolchain
-RUN apt-get install -yq cmake extra-cmake-modules g++ git gettext
-# kf5 and qt5 libraries
-RUN apt-get install -yq libkf5i18n-dev libkf5notifications-dev libkf5service-dev \
-      libkf5windowsystem-dev libkf5plasma-dev qtbase5-dev qtdeclarative5-dev \
-      plasma-framework
-
-# required by tests
-RUN apt-get install -yq xvfb

.docker/build-arch.sh

@@ -1,14 +0,0 @@
-#!/bin/bash
-
-set -e
-
-rm -rf build-arch
-mkdir build-arch
-
-# build
-cd build-arch
-cmake -DKDE_INSTALL_USE_QT_SYS_PATHS=ON -DCMAKE_BUILD_TYPE=Optimization -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_FUTURE=ON -DBUILD_TESTING=ON ../sources
-make
-
-# tests
-xvfb-run -a make test

.docker/build-ubuntu-package.sh

@@ -1,15 +0,0 @@
-#!/bin/bash
-
-set -e
-
-rm -rf build-ubuntu
-mkdir build-ubuntu
-
-# patches
-git apply patches/qt5.14-splitbehavior-and-qset.patch
-
-# build
-cd build-ubuntu
-cmake -DKDE_INSTALL_USE_QT_SYS_PATHS=ON -DCMAKE_BUILD_TYPE=Optimization -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_FUTURE=ON -DBUILD_DEB_PACKAGE=ON ../sources
-make package
-

.docker/build-ubuntu.sh

@@ -1,17 +0,0 @@
-#!/bin/bash
-
-set -e
-
-rm -rf build-ubuntu
-mkdir build-ubuntu
-
-# patches
-git apply patches/qt5.14-splitbehavior-and-qset.patch
-
-# build
-cd build-ubuntu
-cmake -DKDE_INSTALL_USE_QT_SYS_PATHS=ON -DCMAKE_BUILD_TYPE=Optimization -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_FUTURE=ON -DBUILD_TESTING=ON ../sources
-make
-
-# tests
-xvfb-run -a make test

.github/workflows/release.yml

@@ -0,0 +1,51 @@
+name: release
+
+on:
+  push:
+    tags:
+      - '*'
+
+jobs:
+  make-release:
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: create changelog
+        id: changelog
+        uses: jaywcjlove/changelog-generator@main
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          filter: 'Release \d+\.\d+\.\d+'
+
+      - name: create archive
+        run: bash create_archive.sh
+        env:
+          VERSION: ${{ steps.version.outputs.VERSION }}
+
+      - name: build debian package
+        run: |
+          sudo apt update && \
+          sudo apt install -yq cmake extra-cmake-modules g++ git gettext make && \
+          sudo apt install -yq libkf5i18n-dev libkf5notifications-dev libkf5service-dev \
+            libkf5windowsystem-dev libkf5plasma-dev qtbase5-dev qtdeclarative5-dev \
+            plasma-workspace-dev && \
+          cmake -B build-deb -DKDE_INSTALL_USE_QT_SYS_PATHS=ON -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Optimization -DBUILD_FUTURE=ON -DBUILD_DEB_PACKAGE=ON sources && \
+          cd build-deb && \
+          make package && \
+          cd ..
+
+      - name: release
+        uses: softprops/action-gh-release@v1
+        with:
+          body: |
+            ${{ steps.changelog.outputs.compareurl }}
+            ${{ steps.changelog.outputs.changelog }}
+          files: |
+            awesome-widgets-*-src.tar.xz
+            build-deb/plasma-widget-awesome-widgets-*.deb
+          fail_on_unmatched_files: true
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.travis.yml

@@ -1,14 +0,0 @@
-sudo: required
-language: generic
-
-env:
-  - DOCKER_TAG_ARCH="arcan1s/awesome-widgets-arch"
-
-services:
-  - docker
-
-before_install:
-  - docker build --tag="${DOCKER_TAG_ARCH}" -f ".docker/Dockerfile-arch" ".docker"
-
-script:
-  - docker run --rm -v "$(pwd):/opt/build" -w /opt/build "${DOCKER_TAG_ARCH}" sh -c ".docker/build-arch.sh"

CHANGELOG

@@ -1,3 +1,8 @@
+Ver.3.5.0:
++ wayland support
+* update code to latest standards
+- drop support of windows preview
+
 Ver.3.4.2:
 + Italian translation (#136, thanks to @avivace)
 + stooq quotes support (default) (#131)

README.md

@@ -1,7 +1,7 @@
 awesome-widgets (ex-pytextmonitor)
 ==================================
 
-[![Build Status](https://travis-ci.org/arcan1s/awesome-widgets.svg?branch=development)](https://travis-ci.org/arcan1s/awesome-widgets)
+[![build & tests](https://github.com/arcan1s/awesome-widgets/actions/workflows/build.yml/badge.svg)](https://github.com/arcan1s/awesome-widgets/actions/workflows/build.yml)
 [![Coverity Scan Build Status](https://scan.coverity.com/projects/8254/badge.svg)](https://scan.coverity.com/projects/awesome-widgets)
 
 Information
@@ -62,10 +62,6 @@ Installation
 
   **NOTE** on Plasma 5 it very likely requires `-DKDE_INSTALL_USE_QT_SYS_PATHS=ON` flag
 
-  **NOTE** if you are going to build from git, you need to init submodules first, e.g.:
-
-        git submodule update --init --recursive
-
 Additional information
 ======================
 

create_archive.sh

@@ -1,32 +1,20 @@
 #!/bin/bash
 
 SRCDIR="sources"
-MAJOR=$(grep -m1 PROJECT_VERSION_MAJOR sources/CMakeLists.txt | awk '{print $2}' | sed 's/^.\(.*\)..$/\1/')
-MINOR=$(grep -m1 PROJECT_VERSION_MINOR sources/CMakeLists.txt | awk '{print $2}' | sed 's/^.\(.*\)..$/\1/')
-PATCH=$(grep -m1 PROJECT_VERSION_PATCH sources/CMakeLists.txt | awk '{print $2}' | sed 's/^.\(.*\)..$/\1/')
-VERSION="${MAJOR}.${MINOR}.${PATCH}"
-
-# update submodules
-git submodule update --init --recursive
+VERSION="$(git describe --tags --abbrev=0)"
 
 # build widget
 ARCHIVE="awesome-widgets"
-FILES="AUTHORS CHANGELOG COPYING packages patches"
+FILES="AUTHORS CHANGELOG COPYING packages patches sources"
 IGNORELIST="build usr .kdev4 *.kdev4 .idea packages/*src.tar.xz"
 # create archive
 [[ -e ${ARCHIVE}-${VERSION}-src.tar.xz ]] && rm -f "${ARCHIVE}-${VERSION}-src.tar.xz"
 [[ -d ${ARCHIVE} ]] && rm -rf "${ARCHIVE}"
+
 cp -r "${SRCDIR}" "${ARCHIVE}"
 for FILE in ${FILES[*]}; do cp -r "$FILE" "${ARCHIVE}"; done
 for FILE in ${IGNORELIST[*]}; do rm -rf "${ARCHIVE}/${FILE}"; done
-tar cJf "${ARCHIVE}-${VERSION}-src.tar.xz" "${ARCHIVE}"
-ln -sf "../${ARCHIVE}-${VERSION}-src.tar.xz" packages
-rm -rf "${ARCHIVE}"
 
-# update md5sum
-MD5SUMS=$(md5sum ${ARCHIVE}-${VERSION}-src.tar.xz | awk '{print $1}')
-sed -i "/md5sums=('[0-9A-Fa-f]*/s/[^'][^)]*/md5sums=('${MD5SUMS}'/" packages/PKGBUILD
-sed -i "s/pkgver=[0-9.]*/pkgver=${VERSION}/" packages/PKGBUILD
-# clear
-find . -type f -name '*src.tar.xz' -not -name "*${VERSION}-src.tar.xz" -exec rm -rf {} \;
-find packages -type l -xtype l -exec rm -rf {} \;
+tar cJf "${ARCHIVE}-${VERSION}-src.tar.xz" "${ARCHIVE}"
+
+rm -rf "${ARCHIVE}"

packages/build-requirements.deb.txt

@@ -1,11 +0,0 @@
-cmake
-extra-cmake-modules
-g++
-git
-libkf5i18n-dev
-libkf5notifications-dev
-libkf5service-dev
-libkf5windowsystem-dev
-plasma-framework-dev
-qtbase5-dev
-qtdeclarative5-dev

patches/qt5.14-splitbehavior-and-qset.patch

@@ -1,255 +0,0 @@
-diff --git a/sources/awdebug.cpp b/sources/awdebug.cpp
-index 7135db6..a2870ec 100644
---- a/sources/awdebug.cpp
-+++ b/sources/awdebug.cpp
-@@ -67,7 +67,7 @@ QString AWDebug::getAboutText(const QString &_type)
-             translator = QString("<li>%1</li>").arg(translator);
-         text = i18n("Translators:") + "<ul>" + translatorList.join("") + "</ul>";
-     } else if (_type == "3rdparty") {
--        QStringList trdPartyList = QString(TRDPARTY_LICENSE).split(';', Qt::SkipEmptyParts);
-+        QStringList trdPartyList = QString(TRDPARTY_LICENSE).split(';', QString::SkipEmptyParts);
-         for (int i = 0; i < trdPartyList.count(); i++)
-             trdPartyList[i] = QString("<li><a href=\"%3\">%1</a> (%2 license)</li>")
-                                   .arg(trdPartyList.at(i).split(',')[0])
-@@ -75,7 +75,7 @@ QString AWDebug::getAboutText(const QString &_type)
-                                   .arg(trdPartyList.at(i).split(',')[2]);
-         text = i18n("This software uses:") + "<ul>" + trdPartyList.join("") + "</ul>";
-     } else if (_type == "thanks") {
--        QStringList thanks = QString(SPECIAL_THANKS).split(';', Qt::SkipEmptyParts);
-+        QStringList thanks = QString(SPECIAL_THANKS).split(';', QString::SkipEmptyParts);
-         for (int i = 0; i < thanks.count(); i++)
-             thanks[i] = QString("<li><a href=\"%2\">%1</a></li>")
-                             .arg(thanks.at(i).split(',')[0])
-diff --git a/sources/awesome-widget/plugin/awabstractpairhelper.cpp b/sources/awesome-widget/plugin/awabstractpairhelper.cpp
-index 55a4e91..f7c2969 100644
---- a/sources/awesome-widget/plugin/awabstractpairhelper.cpp
-+++ b/sources/awesome-widget/plugin/awabstractpairhelper.cpp
-@@ -61,7 +61,7 @@ QStringList AWAbstractPairHelper::values() const
- QSet<QString> AWAbstractPairHelper::valuesSet() const
- {
-     auto values = m_pairs.values();
--    return QSet(values.cbegin(), values.cend());
-+    return QSet<QString>::fromList(values);
- }
- 
- 
-@@ -138,4 +138,4 @@ bool AWAbstractPairHelper::removeUnusedKeys(const QStringList &_keys) const
-     settings.sync();
- 
-     return (settings.status() == QSettings::NoError);
--}
-\ No newline at end of file
-+}
-diff --git a/sources/awesome-widget/plugin/awkeycache.cpp b/sources/awesome-widget/plugin/awkeycache.cpp
-index 15aab94..54b47b3 100644
---- a/sources/awesome-widget/plugin/awkeycache.cpp
-+++ b/sources/awesome-widget/plugin/awkeycache.cpp
-@@ -83,9 +83,9 @@ QStringList AWKeyCache::getRequiredKeys(const QStringList &_keys, const QStringL
-                     << _tooltip;
- 
-     // initial copy
--    QSet<QString> used(_keys.cbegin(), _keys.cend());
--    used.unite(QSet(_bars.cbegin(), _bars.cend()));
--    used.unite(QSet(_userKeys.cbegin(), _userKeys.cend()));
-+    auto used = QSet<QString>::fromList(_keys);
-+    used.unite(QSet<QString>::fromList(_bars));
-+    used.unite(QSet<QString>::fromList(_userKeys));
-     // insert keys from tooltip
-     for (auto &key : _tooltip.keys()) {
-         if ((key.endsWith("Tooltip")) && (_tooltip[key].toBool())) {
-diff --git a/sources/awesomewidgets/awjsonformatter.cpp b/sources/awesomewidgets/awjsonformatter.cpp
-index bbdd7ce..8a1c5e0 100644
---- a/sources/awesomewidgets/awjsonformatter.cpp
-+++ b/sources/awesomewidgets/awjsonformatter.cpp
-@@ -178,7 +178,7 @@ QVariant AWJsonFormatter::getFromMap(const QVariant &_value, const QString &_key
- void AWJsonFormatter::initPath()
- {
-     m_splittedPath.clear();
--    QStringList splittedByDot = m_path.split('.', Qt::SkipEmptyParts);
-+    QStringList splittedByDot = m_path.split('.', QString::SkipEmptyParts);
- 
-     for (auto &element : splittedByDot) {
-         bool ok;
-diff --git a/sources/awesomewidgets/extscript.cpp b/sources/awesomewidgets/extscript.cpp
-index 3017dac..da009f9 100644
---- a/sources/awesomewidgets/extscript.cpp
-+++ b/sources/awesomewidgets/extscript.cpp
-@@ -218,7 +218,7 @@ void ExtScript::readConfiguration()
-     setExecutable(settings.value("Exec", executable()).toString());
-     setStrRedirect(settings.value("X-AW-Redirect", strRedirect()).toString());
-     // api == 3
--    setFilters(settings.value("X-AW-Filters", filters()).toString().split(',', Qt::SkipEmptyParts));
-+    setFilters(settings.value("X-AW-Filters", filters()).toString().split(',', QString::SkipEmptyParts));
-     settings.endGroup();
- 
-     bumpApi(AW_EXTSCRIPT_API);
-diff --git a/sources/awesomewidgets/extupgrade.cpp b/sources/awesomewidgets/extupgrade.cpp
-index 0195779..0081cc9 100644
---- a/sources/awesomewidgets/extupgrade.cpp
-+++ b/sources/awesomewidgets/extupgrade.cpp
-@@ -219,8 +219,8 @@ void ExtUpgrade::updateValue()
-         = QTextCodec::codecForMib(106)->toUnicode(m_process->readAllStandardOutput()).trimmed();
-     m_values[tag("pkgcount")] = [this](const QString &output) {
-         return filter().isEmpty()
--                   ? output.split('\n', Qt::SkipEmptyParts).count() - null()
--                   : output.split('\n', Qt::SkipEmptyParts).filter(QRegExp(filter())).count();
-+                   ? output.split('\n', QString::SkipEmptyParts).count() - null()
-+                   : output.split('\n', QString::SkipEmptyParts).filter(QRegExp(filter())).count();
-     }(qoutput);
- 
-     emit(dataReceived(m_values));
-diff --git a/sources/awesomewidgets/qcronscheduler.cpp b/sources/awesomewidgets/qcronscheduler.cpp
-index 6f67590..c72abc9 100644
---- a/sources/awesomewidgets/qcronscheduler.cpp
-+++ b/sources/awesomewidgets/qcronscheduler.cpp
-@@ -87,7 +87,7 @@ QList<int> QCronScheduler::parseField(const QString &_value, const int _min, con
-         parsedField.fromRange(field.split('/').first(), _min, _max);
-         if (field.contains('/')) {
-             bool status;
--            parsedField.div = field.split('/', Qt::SkipEmptyParts).at(1).toInt(&status);
-+            parsedField.div = field.split('/', QString::SkipEmptyParts).at(1).toInt(&status);
-             if (!status)
-                 parsedField.div = 1;
-         }
-@@ -107,7 +107,7 @@ void QCronScheduler::QCronField::fromRange(const QString &_range, const int _min
-         minValue = _min;
-         maxValue = _max;
-     } else if (_range.contains("-")) {
--        auto interval = _range.split('-', Qt::SkipEmptyParts);
-+        auto interval = _range.split('-', QString::SkipEmptyParts);
-         if (interval.count() != 2)
-             return;
-         bool status;
-diff --git a/sources/extsysmon/extsysmon.cpp b/sources/extsysmon/extsysmon.cpp
-index 88b6e39..5bdc7f3 100644
---- a/sources/extsysmon/extsysmon.cpp
-+++ b/sources/extsysmon/extsysmon.cpp
-@@ -126,7 +126,7 @@ QHash<QString, QString> ExtendedSysMon::updateConfiguration(QHash<QString, QStri
-     } else if (_rawConfig["HDDDEV"] == "disable") {
-         _rawConfig["HDDDEV"] = "";
-     } else {
--        QStringList deviceList = _rawConfig["HDDDEV"].split(',', Qt::SkipEmptyParts);
-+        QStringList deviceList = _rawConfig["HDDDEV"].split(',', QString::SkipEmptyParts);
-         QStringList devices;
-         QRegExp diskRegexp = QRegExp("^/dev/[hms]d[a-z]$");
-         for (auto &device : deviceList)
-diff --git a/sources/extsysmonsources/gpuloadsource.cpp b/sources/extsysmonsources/gpuloadsource.cpp
-index 6281637..e81be26 100644
---- a/sources/extsysmonsources/gpuloadsource.cpp
-+++ b/sources/extsysmonsources/gpuloadsource.cpp
-@@ -132,7 +132,7 @@ void GPULoadSource::updateValue()
-     qCInfo(LOG_ESS) << "Output" << qoutput;
- 
-     if (m_device == "nvidia") {
--        for (auto &str : qoutput.split('\n', Qt::SkipEmptyParts)) {
-+        for (auto &str : qoutput.split('\n', QString::SkipEmptyParts)) {
-             if (!str.contains("<gpu_util>"))
-                 continue;
-             auto load = str.remove("<gpu_util>").remove("</gpu_util>").remove('%');
-@@ -140,10 +140,10 @@ void GPULoadSource::updateValue()
-             break;
-         }
-     } else if (m_device == "ati") {
--        for (auto &str : qoutput.split('\n', Qt::SkipEmptyParts)) {
-+        for (auto &str : qoutput.split('\n', QString::SkipEmptyParts)) {
-             if (!str.contains("load"))
-                 continue;
--            QString load = str.split(' ', Qt::SkipEmptyParts)[3].remove('%');
-+            QString load = str.split(' ', QString::SkipEmptyParts)[3].remove('%');
-             m_values["gpu/load"] = load.toFloat();
-             break;
-         }
-diff --git a/sources/extsysmonsources/gputempsource.cpp b/sources/extsysmonsources/gputempsource.cpp
-index 55fbadc..dce0c6e 100644
---- a/sources/extsysmonsources/gputempsource.cpp
-+++ b/sources/extsysmonsources/gputempsource.cpp
-@@ -112,7 +112,7 @@ void GPUTemperatureSource::updateValue()
-     qCInfo(LOG_ESS) << "Output" << qoutput;
- 
-     if (m_device == "nvidia") {
--        for (auto &str : qoutput.split('\n', Qt::SkipEmptyParts)) {
-+        for (auto &str : qoutput.split('\n', QString::SkipEmptyParts)) {
-             if (!str.contains("<gpu_temp>"))
-                 continue;
-             QString temp = str.remove("<gpu_temp>").remove("C</gpu_temp>");
-@@ -120,10 +120,10 @@ void GPUTemperatureSource::updateValue()
-             break;
-         }
-     } else if (m_device == "ati") {
--        for (auto &str : qoutput.split('\n', Qt::SkipEmptyParts)) {
-+        for (auto &str : qoutput.split('\n', QString::SkipEmptyParts)) {
-             if (!str.contains("Temperature"))
-                 continue;
--            QString temp = str.split(' ', Qt::SkipEmptyParts).at(4);
-+            QString temp = str.split(' ', QString::SkipEmptyParts).at(4);
-             m_values["gpu/temperature"] = temp.toFloat();
-             break;
-         }
-diff --git a/sources/extsysmonsources/hddtempsource.cpp b/sources/extsysmonsources/hddtempsource.cpp
-index efaae08..dad47a3 100644
---- a/sources/extsysmonsources/hddtempsource.cpp
-+++ b/sources/extsysmonsources/hddtempsource.cpp
-@@ -31,7 +31,7 @@ HDDTemperatureSource::HDDTemperatureSource(QObject *_parent, const QStringList &
-     Q_ASSERT(_args.count() == 2);
-     qCDebug(LOG_ESS) << __PRETTY_FUNCTION__;
- 
--    m_devices = _args.at(0).split(',', Qt::SkipEmptyParts);
-+    m_devices = _args.at(0).split(',', QString::SkipEmptyParts);
-     m_cmd = _args.at(1).split(' '); // lets hope no one put cmd with spaces here lol
- 
-     m_smartctl = m_cmd.contains("smartctl");
-@@ -131,17 +131,17 @@ void HDDTemperatureSource::updateValue(const QString &_device)
- 
-     // parse
-     if (m_smartctl) {
--        QStringList lines = qoutput.split('\n', Qt::SkipEmptyParts);
-+        QStringList lines = qoutput.split('\n', QString::SkipEmptyParts);
-         for (auto &str : lines) {
-             if (!str.startsWith("194"))
-                 continue;
--            if (str.split(' ', Qt::SkipEmptyParts).count() < 9)
-+            if (str.split(' ', QString::SkipEmptyParts).count() < 9)
-                 continue;
--            m_values[_device] = str.split(' ', Qt::SkipEmptyParts).at(9).toFloat();
-+            m_values[_device] = str.split(' ', QString::SkipEmptyParts).at(9).toFloat();
-             break;
-         }
-     } else {
--        QStringList lines = qoutput.split(':', Qt::SkipEmptyParts);
-+        QStringList lines = qoutput.split(':', QString::SkipEmptyParts);
-         if (lines.count() >= 3) {
-             QString temp = lines.at(2);
-             temp.remove(QChar(0260)).remove('C');
-diff --git a/sources/extsysmonsources/playersource.cpp b/sources/extsysmonsources/playersource.cpp
-index aaca22f..e127a05 100644
---- a/sources/extsysmonsources/playersource.cpp
-+++ b/sources/extsysmonsources/playersource.cpp
-@@ -256,11 +256,11 @@ void PlayerSource::mpdSocketReadyRead()
-     qCInfo(LOG_ESS) << "Output" << qoutput;
- 
-     // parse
--    for (auto &str : qoutput.split('\n', Qt::SkipEmptyParts)) {
--        if (str.split(": ", Qt::SkipEmptyParts).count() == 2) {
-+    for (auto &str : qoutput.split('\n', QString::SkipEmptyParts)) {
-+        if (str.split(": ", QString::SkipEmptyParts).count() == 2) {
-             // "Metadata: data"
--            QString metadata = str.split(": ", Qt::SkipEmptyParts).first().toLower();
--            QString data = str.split(": ", Qt::SkipEmptyParts).last().trimmed();
-+            QString metadata = str.split(": ", QString::SkipEmptyParts).first().toLower();
-+            QString data = str.split(": ", QString::SkipEmptyParts).last().trimmed();
-             // there are one more time...
-             if ((metadata == "time") && (data.contains(':'))) {
-                 QStringList times = data.split(':');
-diff --git a/sources/test/testawtelemetryhandler.cpp b/sources/test/testawtelemetryhandler.cpp
-index ffb0e79..b4181e0 100644
---- a/sources/test/testawtelemetryhandler.cpp
-+++ b/sources/test/testawtelemetryhandler.cpp
-@@ -51,7 +51,7 @@ void TestAWTelemetryHandler::test_get()
-     QStringList output = plugin->get(telemetryGroup);
- 
-     QVERIFY(!output.isEmpty());
--    QCOMPARE(QSet<QString>(output.cbegin(), output.cend()).count(), output.count());
-+    QCOMPARE(QSet<QString>::fromList(output).count(), output.count());
-     QVERIFY(output.contains(telemetryData));
- }
- 

sources/.clang-format

@@ -2,11 +2,11 @@
 Language:        Cpp
 AccessModifierOffset: -4
 AlignAfterOpenBracket: Align
-AlignConsecutiveAssignments: false
+AlignConsecutiveAssignments: None
 AlignOperands:   true
 AlignTrailingComments: true
 AllowAllParametersOfDeclarationOnNextLine: true
-AllowShortBlocksOnASingleLine: false
+AllowShortBlocksOnASingleLine: Never
 AllowShortCaseLabelsOnASingleLine: false
 AllowShortFunctionsOnASingleLine: Inline
 AllowShortIfStatementsOnASingleLine: Never

sources/CMakeLists.txt

@@ -15,8 +15,8 @@ set(PROJECT_AUTHOR "Evgeniy Alekseev")
 set(PROJECT_CONTACT "esalexeev@gmail.com")
 set(PROJECT_LICENSE "GPL3")
 set(PROJECT_VERSION_MAJOR "3")
-set(PROJECT_VERSION_MINOR "4")
-set(PROJECT_VERSION_PATCH "3")
+set(PROJECT_VERSION_MINOR "5")
+set(PROJECT_VERSION_PATCH "0")
 set(PROJECT_VERSION "${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}")
 # append git version if any
 set(PROJECT_COMMIT_SHA "Commit hash" CACHE INTERNAL "")

sources/awesome-widget/package/metadata.desktop

@@ -19,7 +19,7 @@ X-Plasma-MainScript=ui/main.qml
 X-KDE-PluginInfo-Author=Evgeniy Alekseev aka arcanis
 X-KDE-PluginInfo-Email=esalexeev@gmail.com
 X-KDE-PluginInfo-Name=org.kde.plasma.awesomewidget
-X-KDE-PluginInfo-Version=3.4.3
+X-KDE-PluginInfo-Version=3.5.0
 X-KDE-PluginInfo-Website=https://arcanis.me/projects/awesome-widgets/
 X-KDE-PluginInfo-Category=System Information
 X-KDE-PluginInfo-License=GPLv3

sources/awesome-widget/plugin/awabstractpairhelper.cpp

@@ -61,7 +61,7 @@ QStringList AWAbstractPairHelper::values() const
 QSet<QString> AWAbstractPairHelper::valuesSet() const
 {
     auto values = m_pairs.values();
-    return QSet(values.cbegin(), values.cend());
+    return {values.cbegin(), values.cend()};
 }
 
 

sources/awesome-widget/plugin/awbugreporter.h

@@ -38,7 +38,7 @@ public:
     Q_INVOKABLE void sendBugReport(const QString &_title, const QString &_body);
 
 signals:
-    void replyReceived(const int _number, const QString &_url);
+    void replyReceived(int _number, const QString &_url);
 
 private slots:
     void issueReplyRecieved(QNetworkReply *_reply);

sources/awesome-widget/plugin/awcustomkeyshelper.cpp

@@ -74,5 +74,5 @@ QStringList AWCustomKeysHelper::leftKeys()
 
 QStringList AWCustomKeysHelper::rightKeys()
 {
-    return QStringList();
+    return {};
 }

sources/awesome-widget/plugin/awdataengineaggregator.cpp

@@ -20,7 +20,6 @@
 #include <Plasma/DataContainer>
 
 #include "awdebug.h"
-#include "awkeys.h"
 
 
 AWDataEngineAggregator::AWDataEngineAggregator(QObject *_parent)

sources/awesome-widget/plugin/awdbusadaptor.cpp

@@ -38,7 +38,7 @@ AWDBusAdaptor::~AWDBusAdaptor()
 }
 
 
-QStringList AWDBusAdaptor::ActiveServices() const
+QStringList AWDBusAdaptor::ActiveServices()
 {
     QDBusMessage listServices = QDBusConnection::sessionBus().interface()->call(QDBus::BlockWithGui, "ListNames");
     if (listServices.arguments().isEmpty()) {

sources/awesome-widget/plugin/awdbusadaptor.h

@@ -37,11 +37,11 @@ public:
 
 public slots:
     // get methods
-    QStringList ActiveServices() const;
-    QString Info(const QString &key) const;
-    QStringList Keys(const QString &regexp) const;
-    QString Value(const QString &key) const;
-    qlonglong WhoAmI() const;
+    [[nodiscard]] static QStringList ActiveServices();
+    [[nodiscard]] QString Info(const QString &key) const;
+    [[nodiscard]] QStringList Keys(const QString &regexp) const;
+    [[nodiscard]] QString Value(const QString &key) const;
+    [[nodiscard]] qlonglong WhoAmI() const;
     // set methods
     void SetLogLevel(const QString &what, int level);
     void SetLogLevel(const QString &what, const QString &level, bool enabled);

sources/awesome-widget/plugin/awformatterhelper.cpp

@@ -102,7 +102,7 @@ void AWFormatterHelper::editPairs()
 
 QStringList AWFormatterHelper::leftKeys()
 {
-    return QStringList();
+    return {};
 }
 
 

sources/awesome-widget/plugin/awkeyoperations.cpp

@@ -18,7 +18,6 @@
 #include "awkeyoperations.h"
 
 #include <QDir>
-#include <QJSEngine>
 #include <QRegExp>
 #include <QThread>
 

sources/awesome-widget/plugin/awkeys.h

@@ -58,7 +58,7 @@ public:
 public slots:
     void dataUpdated(const QString &_sourceName, const Plasma::DataEngine::Data &_data);
     // dummy method required by DataEngine connections
-    static void modelChanged(QString, QAbstractItemModel *){};
+    static void modelChanged(const QString &, QAbstractItemModel *){};
 
 signals:
     void dropSourceFromDataengine(const QString &_source);

sources/awesomewidgets/abstractextitem.h

@@ -79,7 +79,7 @@ public slots:
     virtual void readConfiguration();
     virtual QVariantHash run() = 0;
     virtual int showConfiguration(const QVariant &_args) = 0;
-    virtual bool tryDelete() const;
+    [[nodiscard]] virtual bool tryDelete() const;
     virtual void writeConfiguration() const;
 
 private slots:

sources/awesomewidgets/abstractextitemaggregator.h

@@ -67,7 +67,7 @@ public:
     void editItem();
     QString getName();
     virtual void initItems() = 0;
-    AbstractExtItem *itemFromWidget() const;
+    [[nodiscard]] AbstractExtItem *itemFromWidget() const;
     void repaintList() const;
     [[nodiscard]] int uniqNumber() const;
     // get methods

sources/awesomewidgets/abstractweatherprovider.h

@@ -38,7 +38,7 @@ public:
     {
         return dynamic_cast<AbstractExtItem *>(parent())->tag(_type);
     };
-    virtual QUrl url() const = 0;
+    [[nodiscard]] virtual QUrl url() const = 0;
 };
 
 

sources/awesomewidgets/awabstractformatter.h

@@ -43,7 +43,7 @@ public:
 
 public slots:
     void readConfiguration() override;
-    QVariantHash run() override { return QVariantHash(); };
+    QVariantHash run() override { return {}; };
     void writeConfiguration() const override;
 
 private:

sources/awesomewidgets/graphicalitem.cpp

@@ -100,7 +100,7 @@ QString GraphicalItem::image(const QVariant &value)
 
     m_scene->clear();
     int scale[2] = {1, 1};
-    float converted = m_helper->getPercents(value.toFloat(), minValue(), maxValue());
+    float converted = GraphicalItemHelper::getPercents(value.toFloat(), minValue(), maxValue());
 
     // paint
     switch (m_type) {
@@ -457,12 +457,12 @@ int GraphicalItem::showConfiguration(const QVariant &_args)
     ui->doubleSpinBox_max->setValue(maxValue());
     ui->doubleSpinBox_min->setValue(minValue());
     ui->spinBox_count->setValue(count());
-    if (m_helper->isColor(activeColor()))
+    if (GraphicalItemHelper::isColor(activeColor()))
         ui->comboBox_activeImageType->setCurrentIndex(0);
     else
         ui->comboBox_activeImageType->setCurrentIndex(1);
     ui->lineEdit_activeColor->setText(activeColor());
-    if (m_helper->isColor(inactiveColor()))
+    if (GraphicalItemHelper::isColor(inactiveColor()))
         ui->comboBox_inactiveImageType->setCurrentIndex(0);
     else
         ui->comboBox_inactiveImageType->setCurrentIndex(1);
@@ -539,7 +539,7 @@ void GraphicalItem::changeColor()
 
     QString outputColor;
     if (state == 0) {
-        QColor color = m_helper->stringToColor(lineEdit->text());
+        QColor color = GraphicalItemHelper::stringToColor(lineEdit->text());
         QColor newColor = QColorDialog::getColor(color, this, i18n("Select color"), QColorDialog::ShowAlphaChannel);
         if (!newColor.isValid())
             return;

sources/awesomewidgets/graphicalitem.h

@@ -91,7 +91,7 @@ public:
 
 public slots:
     void readConfiguration() override;
-    QVariantHash run() override { return QVariantHash(); };
+    QVariantHash run() override { return {}; };
     int showConfiguration(const QVariant &_args) override;
     void writeConfiguration() const override;
 

sources/awesomewidgets/qcronscheduler.cpp

@@ -135,7 +135,7 @@ QList<int> QCronScheduler::QCronField::toList()
 {
     // error checking
     if ((minValue == -1) || (maxValue == -1))
-        return QList<int>();
+        return {};
 
     QList<int> output;
     for (auto &i = minValue; i <= maxValue; ++i) {

sources/awesomewidgets/yahooweatherprovider.cpp

@@ -57,7 +57,7 @@ QVariantHash YahooWeatherProvider::parse(const QVariantMap &_json) const
     QVariantMap jsonMap = _json["query"].toMap();
     if (jsonMap["count"].toInt() != 1) {
         qCWarning(LOG_LIB) << "Found data count" << _json["count"].toInt() << "is not 1";
-        return QVariantHash();
+        return {};
     }
     QVariantMap results = jsonMap["results"].toMap()["channel"].toMap();
     QVariantMap item = results["item"].toMap();

sources/changelog.cmake

@@ -1,5 +1,6 @@
-exec_program(
-        "sed -n '1,/^Ver/ p' CHANGELOG 2> /dev/null | grep -v '^Ver' | tr '\n' '@'"
-        ${CMAKE_CURRENT_SOURCE_DIR}
+execute_process(
+        COMMAND "sed -n '1,/^Ver/ p' CHANGELOG 2> /dev/null | grep -v '^Ver' | tr '\n' '@'"
+        WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
         OUTPUT_VARIABLE PROJECT_CHANGELOG
+        OUTPUT_STRIP_TRAILING_WHITESPACE
 )

sources/checkgit.cmake

@@ -1,9 +1,9 @@
-exec_program(
-        "git"
-        ${CMAKE_CURRENT_SOURCE_DIR}
-        ARGS "log" "-1" "--format=\"%h\""
+execute_process(
+        COMMAND git log -1 --format=%h
+        WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
         OUTPUT_VARIABLE COMMIT_SHA
-        RETURN_VALUE GIT_RETURN
+        RESULT_VARIABLE GIT_RETURN
+        OUTPUT_STRIP_TRAILING_WHITESPACE
 )
 
 if (${GIT_RETURN} EQUAL "0")

sources/desktop-panel/package/metadata.desktop

@@ -19,7 +19,7 @@ X-Plasma-MainScript=ui/main.qml
 X-KDE-PluginInfo-Author=Evgeniy Alekseev aka arcanis
 X-KDE-PluginInfo-Email=esalexeev@gmail.com
 X-KDE-PluginInfo-Name=org.kde.plasma.desktoppanel
-X-KDE-PluginInfo-Version=3.4.3
+X-KDE-PluginInfo-Version=3.5.0
 X-KDE-PluginInfo-Website=https://arcanis.me/projects/awesome-widgets/
 X-KDE-PluginInfo-Category=System Information
 X-KDE-PluginInfo-License=GPLv3

sources/desktop-panel/plugin/dpadds.cpp

@@ -59,8 +59,8 @@ DPAdds::~DPAdds()
 {
     qCDebug(LOG_DP) << __PRETTY_FUNCTION__;
 
-    delete m_vdi;
-    delete m_taskModel;
+    m_vdi->deleteLater();
+    m_taskModel->deleteLater();
 }
 
 

sources/extsysmonsources/desktopsource.cpp

@@ -38,7 +38,7 @@ DesktopSource::~DesktopSource()
 {
     qCDebug(LOG_ESS) << __PRETTY_FUNCTION__;
 
-    delete m_vdi;
+    m_vdi->deleteLater();
 }
 
 
@@ -59,7 +59,7 @@ QVariant DesktopSource::data(const QString &_source)
         return m_vdi->numberOfDesktops();
     }
 
-    return QVariant();
+    return {};
 }
 
 

sources/version.h.in

@@ -67,7 +67,7 @@ const char STATIC_KEYS[] = "time,isotime,shorttime,longtime,tstime,ctime,uptime,
 // links
 const char HOMEPAGE[] = "https://arcanis.me/projects/awesome-widgets";
 const char REPOSITORY[] = "https://github.com/arcan1s/awesome-widgets";
-const char RELEASES[] = "https://github.com/arcan1s/awesome-widgets/releases/tag/V.";
+const char RELEASES[] = "https://github.com/arcan1s/awesome-widgets/releases/tag/";
 const char VERSION_API[] = "https://api.github.com/repos/arcan1s/awesome-widgets/releases";
 const char BUGTRACKER[] = "https://github.com/arcan1s/awesome-widgets/issues";
 const char BUGTRACKER_API[] = "https://arcanis.me/repos/arcan1s/awesome-widgets/issues";