ci: get rid of development branch

Closes #157

.github/workflows/build.yml

@@ -2,9 +2,11 @@ name: build & tests
 
 on:
   push:
-    branches: [ development, master ]
+    branches:
+      - master
   pull_request:
-    branches: [ development, master ]
+    branches:
+      - master
 
 env:
   BUILD_TYPE: Release
@@ -24,7 +26,7 @@ jobs:
     - uses: actions/checkout@v3
 
     - name: create build environment
-      run: pacman -Sy --noconfirm base-devel cmake extra-cmake-modules python util-linux-libs xorg-server-xvfb
+      run: pacman -Syu --noconfirm base-devel cmake extra-cmake-modules python util-linux-libs xorg-server-xvfb
     
     - name: install dependencies
       run: pacman -S --noconfirm plasma-workspace

CONTRIBUTING.md

@@ -6,27 +6,20 @@ for more details. To avoid manual labor there is automatic cmake target named
 `clangformat` (see below). Some additional detail see below.
 
 * Indent is only spaces. 4 spaces.
-* Any private variable should start with `m_` prefix (`m_foo`). The only one
+* Any private variable should start with `m_` prefix (`m_foo`). The only one exception is `Ui` object which should be named as `ui`.
-  exception is `Ui` object which should be named as `ui`.
 * Avoid to create a large methods. Exception: if method contains lambda functions.
-* If some method is called only once, it is recommended to use lambda functions.
-  Exception is `Q_INVOKABLE` methods.
 * STL containers are not recommended, use Qt ones instead.
-* In other hand Qt specific variables types (`qint`, `qfloat`, etc) are not
+* In other hand Qt specific variables types (`qint`, `qfloat`, etc) are not recommended.
-  recommended.
 * Do not repeat yourself ([DRY](https://en.wikipedia.org/wiki/Don't_repeat_yourself)).
 * Headers declaration:
-    * Include only those headers which are strictly necessary inside headers. Use
+    * Include only those headers which are strictly necessary inside headers. Use forward class declaration instead. Exception is base class header declaration.
-      forward class declaration instead. Exception is base class header declaration.
+    * In a`*.cpp` file header declaration should have the following order separated by a new line in the alphabet order:
-    * In a`*.cpp` file header declaration should have the following order separated
-      by a new line in the alphabet order:
         1. Class header.
         2. KDE specific headers.
         3. Qt specific headers.
         4. Third party headers.
         5. Project headers.
-    * Any header should have [include guard](https://en.wikipedia.org/wiki/Include_guard)
+    * Any header should have `#pragma once`.
-      named as `CLASSNAMECAPS_H`
 * If any `#if` directive is used condition should be mentioned in `#endif`:
 
   ```
@@ -36,80 +29,60 @@ for more details. To avoid manual labor there is automatic cmake target named
   ```
 
 * `Q_PROPERTY` macro is allowed and recommended for QObject based classes.
-* Qt macros (e.g. `signals`, `slots`, `Q_OBJECT`, etc) are allowed. In other hand
+* Qt macros (e.g. `signals`, `slots`, `Q_OBJECT`, etc) are allowed. In other hand `Q_FOREACH` (`foreach`) is not allowed use `for (auto &foo : bar)` instead.
-`Q_FOREACH` (`foreach`) is not allowed use `for (auto &foo : bar)` instead.
+* Current project standard is **C++23**.
-* Current project standard is **C++17**.
 * Do not use C-like code:
-    * C-like style iteration if possible. Use `for (auto &foo : bar)` and
+    * C-like style iteration if possible. Use `for (auto &foo : bar)` and `std::for_each` instead if possible. It is also recommended to use iterators.
-      `std::for_each` instead if possible. It is also recommended to use iterators.
+    * C-like casts, use `const_cast`, `static_cast`, `dymanic_Cast` instead. Using of `reinterpret_cast` is not recommended. It is highly recommended to use `dynamic_cast` with the exception catching. It is also possible to use `qvariant_cast` if required.
-    * C-like casts, use `const_cast`, `static_cast`, `dymanic_Cast` instead. Using
-      of `reinterpret_cast` is not recommended. It is highly recommended to use
-      `dynamic_cast` with the exception catching. It is also possible to use
-      `qvariant_cast` if required.
     * C-like `NULL`, use `nullptr` instead.
-    * C-like constant definition, use `const vartype foo = bar` definition instead.
+    * C-like constant definition, use `static const vartype foo = bar` definition instead.
 * Abstract classes (which have at least one pure virtual method) are allowed.
-* Templates are allowed and recommended. Templates usually should be described
+* Templates are allowed and recommended. Templates usually should be described inside header not source code file.
-  inside header not source code file.
+* Hardcode is not recommended. But it is possible to use cmake variables to configure some items during build time.
-* Hardcode is not recommended. But it is possible to use cmake variables to
-  configure some items during build time.
 * Build should not require any additional system variable declaration/changing.
 * Any line should not end with space.
 * Do not hesitate move public methods to private one if possible.
-* Do not hesitate use `const` modifier. In other hand `volatile` modifier is not
+* Do not hesitate use `const` modifier. In other hand `volatile` modifier is not recommended.
-  recommended.
 * New lines rules:
     * One line after license header.
     * One line between header group declaration (see above).
-    * Two lines after header declaration and before declaration at the end of a
+    * Two lines after header declaration and before declaration at the end of a file.
-      file.
     * One line after class and types forward declarations in headers.
     * One line before each method modifiers (`public`, `public slots`, etc).
     * Two lines between methods inside source code (`*.cpp`).
     * One line after `qCDebug()` information (see below).
     * One line inside a method to improve code reading.
 * Each destructor should be virtual.
-* Class constructor should have default arguments. Use `QObject *parent` property
+* Class constructor should have default arguments. Use `QObject *_parent` property for QObject based classes.
-  for QObject based classes.
 * QObject based classes constructors should have explicit modifier.
 * Create one file (source and header) per class.
 * `else if` construction is allowed and recommended.
 * 'true ? foo : bar' construction is allowed and recommended for one-line assignment.
-* Any global pointer should be assign to `nullptr` after deletion and before
+* Any global pointer should be assigned to `nullptr` after deletion and before initialization. Exception: if object is deleted into class destructor.
-  initialization. Exception: if object is deleted into class destructor.
 * Do not use semicolon in qml files unless it is required.
 * Any method argument including class constructors should start with `_`.
 
 Comments
 --------
 
-Please do not hesitate to use comments inside source code (especially in non-obvious
+Please do not hesitate to use comments inside source code (especially in non-obvious blocks). Comments also may use the following keywords:
-blocks). Comments also may use the following keywords:
 
-* **TODO** - indicates that some new code should be implemented here later. Please
+* **TODO** - indicates that some new code should be implemented here later. Please note that usually these methods should be implemented before the next release.
-  note that usually these methods should be implemented before the next release.
 * **FIXME** - some dirty hacks and/or methods which should be done better.
-* **HACK** - hacks inside code which requires to avoid some restrictions and/or
+* **HACK** - hacks inside code which requires to avoid some restrictions and/or which adds additional non-obvious optimizations.
-  which adds additional non-obvious optimizations.
 
 Do not use dots at the end of the comment line.
 
 Development
 -----------
 
-* Officially the latest libraries versions should be used. In addition it is
+* Officially the latest libraries versions should be used. In addition, it is possible to add workarounds for all versions (usually by using preprocessor directives); in this case patches should be placed to `packages` directory.
-  possible to add workarounds for all versions (usually by using preprocessor
-  directives); in this case patches should be placed to `packages` directory.
 * Build should not contain any warning.
-* Try to minimize message in Release build with logging disabled. It is highly
+* Try to minimize message in Release build with logging disabled. It is highly recommended to fix KDE/Qt specific warning if possible
-  recommended to fix KDE/Qt specific warning if possible
+* Do not use dependency to KDE libraries if there are no any strictly necessary. Exceptions are KNotification and KI18n libraries.
-* Do not use dependency to KDE libraries if there are no any strictly necessary.
-  Exceptions are KNotification and KI18n libraries.
 * It is highly recommended to use submodules for third party libraries if possible.
-* The main branch is **development**. Changes in this branch may be merged to the
+* The main branch is **master**.
-  master one only if it is a 'stable' build.
+* For experimental features development new branch `feature/foo` creation is allowed and recommended.
-* For experimental features development new branch `feature-foo` creation is allowed
-  and recommended.
 * Experimental features should be added inside `BUILD_FUTURE` definition:
 
   ```
@@ -118,54 +91,41 @@ Development
   #endif /* BUILD_FUTURE */
   ```
 
-* Any project specific build variable should be mentioned inside `version.h` as
+* Any project specific build variable should be mentioned inside `version.h` as well.
-  well.
 * Recommended compiler is `clang`.
 
 HIG
 ---
 
-The recommended HIG is [KDE one](https://techbase.kde.org/Projects/Usability/HIG).
+The recommended HIG is [KDE one](https://techbase.kde.org/Projects/Usability/HIG). Avoid to paint interfaces inside plugin because QML and C++ parts may have different theming.
-Avoid to paint interfaces inside plugin because QML and C++ parts may have different
-theming.
 
 Licensing
 ---------
 
-All files should be licensed under GPLv3, the owner of the license should be the
+All files should be licensed under GPLv3, the owner of the license should be the project (i.e. **awesome-widgets**). See **Tools** section for more details.
-project (i.e. **awesome-widgets**). See **Tools** section for more details.
 
 Logging
 -------
 
-For logging please use [QLoggingCategory](http://doc.qt.io/qt-5/qloggingcategory.html).
+For logging please use [QLoggingCategory](http://doc.qt.io/qt-5/qloggingcategory.html). Available categories should be declared in `awdebug.*` files. The following log levels should be used:
-Available categories should be declared in `awdebug.*` files. The following log
-levels should be used:
 
-* **debug** (`qCDebug()`) - method arguments information. Please note that it
+* **debug** (`qCDebug()`) - method arguments information. Please note that it is recommended to logging all arguments in the one line.
-  is recommended to logging all arguments in the one line.
 * **info** (`qCInfo()`) - additional information inside methods.
-* **warning** (`qCWarning()`) - not critical information, which may be caused by
+* **warning** (`qCWarning()`) - not critical information, which may be caused by mistakes in configuration for example.
-  mistakes in configuration for example.
+* **critical** (`qCCritical()`) - a critical error. After this error program may be terminated.
-* **critical** (`qCCritical()`) - a critical error. After this error program may
-  be terminated.
 
-The empty log string (e.g. `qCDebug();`) is not allowed because the method names
+The empty log string (e.g. `qCDebug();`) is not allowed because the method names will be stripped by compiler with `Release` build type. To log class constructor and destructor use `__PRETTY_FUNCTION__` macro.
-will be stripped by compiler with `Release` build type. To log class constructor
-and destructor use `__PRETTY_FUNCTION__` macro.
 
 Testing
 -------
 
-* Any changes should be tested by using `plasmawindowed` and `plasmashell` applications.
+* Any changes should be tested by using `plasmawindowed` and `plasmashell` applications. (It is also possible to use `plasmaengineexplorer` and `plasmoidviewer` in addition.)
-  (It is also possible to use `plasmaengineexplorer` and `plasmoidviewer` in addition.)
 * Any test should be performed on real (not Virtual Machine) system.
 * Test builds should be:
     1. `-DCMAKE_BUILD_TYPE=Debug`.
     2. `-DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON`.
     3. `-DCMAKE_BUILD_TYPE=Release`.
-* Additional test functions should be declated and used only inside `BUILD_TESTING`
+* Additional test functions should be declated and used only inside `BUILD_TESTING` definition.
-  definition.
 
 Tools
 -----
@@ -222,7 +182,6 @@ Tools
         // declare with default value
         bool m_prop = false;
   ```
-* Use `cppcheck` to avoid common errors in the code. To start application just
+* Use `cppcheck` to avoid common errors in the code. To start application just run `make cppcheck`.
-  run `make cppcheck`.
+* Use `clang-format` to apply valid code format. To start application just run `make clangformat`.
-* Use `clang-format` to apply valid code format. To start application just run
+* use `-DCMAKE_CXX_COMPILER=clang++` in order to enable clang-tidy checks.
-  `make clangformat`.

README.md

@@ -14,11 +14,11 @@ A collection of minimalistic widgets which looks like Awesome Window Manager wid
 Features
 ========
 
-* easy and fully configurable native Plasma widget which may be used as Conky widget or as Awesome-like information panel
+* easy and fully configurable native Plasma widget which may be used as desktop or panel widget
-* panel which shows active desktop status
+* additionnal widget which shows active desktop status
-* clear Conky-like configuration with html tags support
+* clear text configuration with html tags support
 * custom command support (it may be simple action as well as special custom tag)
-* graphical item support - tooltips, bars
+* graphical widgets support - tooltips, bars
 
 See [links](#Links) for more details.
 
@@ -30,15 +30,11 @@ Instruction
 Dependencies
 ------------
 
-* plasma-framework
+* plasma-workspace
-* ksysguard (since plasma 5.22)
 
 Optional dependencies
 ---------------------
 
-* proprietary video driver
-* hddtemp
-* smartmontools
 * music player (mpd or MPRIS supported)
 * wireless_tools
 
@@ -48,19 +44,20 @@ Make dependencies
 * cmake
 * extra-cmake-modules
 
-In addition some distros might require to install some -dev packages, e.g. the list of required packages for deb-based distros can be found [here](https://github.com/arcan1s/awesome-widgets/blob/development/.docker/Dockerfile-ubuntu-amd64#L7).
+In addition, some distros might require to install some -dev packages, e.g. the list of required packages for deb-based distros can be found [here](https://github.com/arcan1s/awesome-widgets/blob/development/.docker/Dockerfile-ubuntu-amd64#L7).
 
 Installation
 ------------
 
 * download sources
-* install
+* build package
 
-        mkdir build && cd build
+      cmake -B build -S sources -DCMAKE_BUILD_TYPE=Release
-        cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr ../sources
+      cmake --build build
-        make && sudo make install
 
-  **NOTE** on Plasma 5 it very likely requires `-DKDE_INSTALL_USE_QT_SYS_PATHS=ON` flag
+* install package 
+
+      cmake --install build
 
 Additional information
 ======================

packages/PKGBUILD

@@ -9,7 +9,8 @@ arch=('x86_64')
 url="https://arcanis.me/projects/awesome-widgets"
 license=('GPL3')
 depends=('plasma-workspace')
-optdepends=("mpd: for music player monitor")
+optdepends=("mpd: for music player monitor"
+            "wireless_tools: wifi information")
 makedepends=('cmake' 'extra-cmake-modules' 'python')
 source=(https://github.com/arcan1s/awesome-widgets/releases/download/${pkgver}/${_pkgname}-${pkgver}-src.tar.xz)
 install="$pkgname.install"

sources/3rdparty/fontdialog/fontdialog.cpp

@@ -58,7 +58,7 @@ CFontDialog::CFontDialog(QWidget *parent, bool needWeight, bool needItalic)
     setLayout(mainGrid);
 
     colorBox = new QComboBox(this);
-    connect(colorBox, SIGNAL(currentIndexChanged(QString)), this, SLOT(updateColor(QString)));
+    connect(colorBox, &QComboBox::currentTextChanged, this, &CFontDialog::updateColor);
     QStringList colorNames = QColor::colorNames();
     int index = 0;
     for (int i=0; i<colorNames.count(); i++) {
@@ -81,8 +81,8 @@ CFontDialog::CFontDialog(QWidget *parent, bool needWeight, bool needItalic)
 
     buttons = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel,
                                    Qt::Horizontal, this);
-    QObject::connect(buttons, SIGNAL(accepted()), this, SLOT(accept()));
+    QObject::connect(buttons, &QDialogButtonBox::accepted, this, &CFontDialog::accept);
-    QObject::connect(buttons, SIGNAL(rejected()), this, SLOT(reject()));
+    QObject::connect(buttons, &QDialogButtonBox::rejected, this, &CFontDialog::reject);
     mainGrid->addWidget(buttons, 1, 0, 1, 5);
 
     italicBox->setHidden(!needItalic);

sources/3rdparty/fontdialog/fontdialog.h

@@ -15,8 +15,7 @@
  *  License along with this library.                                       *
  ***************************************************************************/
 
-#ifndef FONTDIALOG_H
+#pragma once
-#define FONTDIALOG_H
 
 #include <QComboBox>
 #include <QDialog>
@@ -72,6 +71,3 @@ private:
     QSpinBox *sizeBox;
     QSpinBox *weightBox;
 };
-
-
-#endif /* FONTDIALOG_H */

sources/3rdparty/qreplytimeout/qreplytimeout.cpp

@@ -12,7 +12,7 @@ QReplyTimeout::QReplyTimeout(QNetworkReply *reply, const int timeout)
 
 void QReplyTimeout::timeout()
 {
-    auto *reply = dynamic_cast<QNetworkReply *>(parent());
+    auto reply = dynamic_cast<QNetworkReply *>(parent());
     if (reply->isRunning())
         reply->close();
 }

sources/CMakeLists.txt

@@ -9,6 +9,9 @@ endif ()
 if (POLICY CMP0071)
     cmake_policy(SET CMP0071 NEW)
 endif ()
+if (POLICY CMP0160)
+    cmake_policy(SET CMP0160 OLD)
+endif ()
 
 project(awesomewidgets)
 set(PROJECT_AUTHOR "Evgeniy Alekseev")

sources/awdebug.cpp

@@ -41,35 +41,32 @@ QString AWDebug::getAboutText(const QString &_type)
     } else if (_type == "description") {
         text = i18n("A set of minimalistic plasmoid widgets");
     } else if (_type == "links") {
-        text = i18n("Links:") + "<ul>" + QString("<li><a href=\"%1\">%2</a></li>").arg(HOMEPAGE).arg(i18n("Homepage"))
+        text = i18n("Links:") + "<ul>" + QString("<li><a href=\"%1\">%2</a></li>").arg(HOMEPAGE, i18n("Homepage"))
-               + QString("<li><a href=\"%1\">%2</a></li>").arg(REPOSITORY).arg(i18n("Repository"))
+               + QString("<li><a href=\"%1\">%2</a></li>").arg(REPOSITORY, i18n("Repository"))
-               + QString("<li><a href=\"%1\">%2</a></li>").arg(BUGTRACKER).arg(i18n("Bugtracker"))
+               + QString("<li><a href=\"%1\">%2</a></li>").arg(BUGTRACKER, i18n("Bugtracker"))
-               + QString("<li><a href=\"%1\">%2</a></li>").arg(TRANSLATION).arg(i18n("Translation issue"))
+               + QString("<li><a href=\"%1\">%2</a></li>").arg(TRANSLATION, i18n("Translation issue"))
-               + QString("<li><a href=\"%1\">%2</a></li>").arg(AUR_PACKAGES).arg(i18n("AUR packages"))
+               + QString("<li><a href=\"%1\">%2</a></li>").arg(AUR_PACKAGES, i18n("AUR packages"))
-               + QString("<li><a href=\"%1\">%2</a></li>").arg(OPENSUSE_PACKAGES).arg(i18n("openSUSE packages"))
+               + QString("<li><a href=\"%1\">%2</a></li>").arg(OPENSUSE_PACKAGES, i18n("openSUSE packages")) + "</ul>";
-               + "</ul>";
     } else if (_type == "copy") {
-        text = QString("<small>&copy; %1 <a href=\"mailto:%2\">%3</a><br>").arg(DATE).arg(EMAIL).arg(AUTHOR)
+        text = QString("<small>&copy; %1 <a href=\"mailto:%2\">%3</a><br>").arg(DATE, EMAIL, AUTHOR)
-               + i18nc("This software is licensed under %1", LICENSE) + "</small>";
+               + i18n("This software is licensed under %1", LICENSE) + "</small>";
     } else if (_type == "translators") {
-        QStringList translatorList = QString(TRANSLATORS).split(',');
+        auto translatorList = QString(TRANSLATORS).split(',');
         for (auto &translator : translatorList)
             translator = QString("<li>%1</li>").arg(translator);
         text = i18n("Translators:") + "<ul>" + translatorList.join("") + "</ul>";
     } else if (_type == "3rdparty") {
-        QStringList trdPartyList = QString(TRDPARTY_LICENSE).split(';', Qt::SkipEmptyParts);
+        auto trdPartyList = QString(TRDPARTY_LICENSE).split(';', Qt::SkipEmptyParts);
-        for (int i = 0; i < trdPartyList.count(); i++)
+        for (auto i = 0; i < trdPartyList.count(); ++i)
             trdPartyList[i] = QString("<li><a href=\"%3\">%1</a> (%2 license)</li>")
-                                  .arg(trdPartyList.at(i).split(',')[0])
+                                  .arg(trdPartyList.at(i).split(',')[0], trdPartyList.at(i).split(',')[1],
-                                  .arg(trdPartyList.at(i).split(',')[1])
+                                       trdPartyList.at(i).split(',')[2]);
-                                  .arg(trdPartyList.at(i).split(',')[2]);
         text = i18n("This software uses:") + "<ul>" + trdPartyList.join("") + "</ul>";
     } else if (_type == "thanks") {
-        QStringList thanks = QString(SPECIAL_THANKS).split(';', Qt::SkipEmptyParts);
+        auto thanks = QString(SPECIAL_THANKS).split(';', Qt::SkipEmptyParts);
-        for (int i = 0; i < thanks.count(); i++)
+        for (auto i = 0; i < thanks.count(); ++i)
-            thanks[i] = QString("<li><a href=\"%2\">%1</a></li>")
+            thanks[i]
-                            .arg(thanks.at(i).split(',')[0])
+                = QString("<li><a href=\"%2\">%1</a></li>").arg(thanks.at(i).split(',')[0], thanks.at(i).split(',')[1]);
-                            .arg(thanks.at(i).split(',')[1]);
         text = i18n("Special thanks to:") + "<ul>" + thanks.join("") + "</ul>";
     }
 

sources/awdebug.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWDEBUG_H
-#define AWDEBUG_H
 
 #include <QLoggingCategory>
 
@@ -42,6 +40,3 @@ Q_DECLARE_LOGGING_CATEGORY(LOG_DP)
 Q_DECLARE_LOGGING_CATEGORY(LOG_ESM)
 Q_DECLARE_LOGGING_CATEGORY(LOG_ESS)
 Q_DECLARE_LOGGING_CATEGORY(LOG_LIB)
-
-
-#endif /* AWDEBUG_H */

sources/awesome-widget/package/contents/config/config.qml

@@ -51,6 +51,12 @@ ConfigModel {
         source: "dataengine.qml"
     }
 
+    ConfigCategory {
+        name: i18n("Report bug")
+        icon: "tools-report-bug"
+        source: "bug.qml"
+    }
+
     ConfigCategory {
         name: i18n("About")
         icon: "help-about"

sources/awesome-widget/package/contents/config/main.xml

@@ -44,9 +44,6 @@
         <entry name="interval" type="Int">
             <default>1000</default>
         </entry>
-        <entry name="queueLimit" type="Int">
-            <default>0</default>
-        </entry>
         <entry name="tempUnits" type="String">
             <default>Celsius</default>
         </entry>
@@ -62,15 +59,9 @@
         <entry name="acOffline" type="String">
             <default>( )</default>
         </entry>
-        <entry name="telemetryCount" type="Int">
+        <entry name="historyCount" type="Int">
             <default>100</default>
         </entry>
-        <entry name="telemetryRemote" type="Bool">
-            <default>false</default>
-        </entry>
-        <entry name="telemetryId" type="String">
-            <default></default>
-        </entry>
     </group>
 
     <group name="Tooltip">

sources/awesome-widget/package/contents/ui/about.qml

@@ -18,7 +18,8 @@
 import QtQuick 2.15
 import org.kde.kcmutils as KCM
 
-import org.kde.plasma.private.awesomewidget 1.0
+import org.kde.plasma.awesomewidgets
+import org.kde.plasma.private.awesomewidget
 
 
 KCM.SimpleKCM {

sources/awesome-widget/package/contents/ui/advanced.qml

@@ -19,15 +19,16 @@ import QtQuick 2.15
 import QtQuick.Controls
 import org.kde.kcmutils as KCM
 
-import org.kde.plasma.private.awesomewidget 1.0
+import org.kde.plasma.awesomewidgets
+import org.kde.plasma.private.awesomewidget
 
 
 KCM.SimpleKCM {
     id: advancedPage
 
     // backend
-    AWActions {
+    AWConfigHelper {
-        id: awActions
+        id: awConfig
     }
 
     property alias cfg_background: background.checked
@@ -40,18 +41,14 @@ KCM.SimpleKCM {
     property alias cfg_height: widgetHeight.value
     property alias cfg_width: widgetWidth.value
     property alias cfg_interval: update.value
-    property alias cfg_queueLimit: queueLimit.value
     property string cfg_tempUnits: tempUnits.value
     property alias cfg_customTime: customTime.value
     property alias cfg_customUptime: customUptime.value
     property alias cfg_acOnline: acOnline.value
     property alias cfg_acOffline: acOffline.value
-    property alias cfg_telemetryCount: telemetryCount.value
+    property alias cfg_historyCount: historyCount.value
-    property alias cfg_telemetryRemote: telemetryRemote.checked
-    property alias cfg_telemetryId: telemetryId.value
 
     Column {
-        id: pageColumn
         anchors.fill: parent
 
         CheckBoxSelector {
@@ -116,15 +113,6 @@ KCM.SimpleKCM {
             value: plasmoid.configuration.interval
         }
 
-        IntegerSelector {
-            id: queueLimit
-            maximumValue: 99
-            minimumValue: 0
-            stepSize: 1
-            text: i18n("Messages queue limit")
-            value: plasmoid.configuration.queueLimit
-        }
-
         ComboBoxSelector {
             id: tempUnits
             model: [
@@ -197,7 +185,7 @@ KCM.SimpleKCM {
 
                 ButtonSelector {
                     value: i18n("Drop key cache")
-                    onButtonActivated: awActions.dropCache()
+                    onButtonActivated: awConfig.dropCache()
                 }
 
                 ButtonSelector {
@@ -226,30 +214,19 @@ KCM.SimpleKCM {
         GroupBox {
             height: implicitHeight
             width: parent.width
-            title: i18n("Telemetry")
+            title: i18n("History")
 
             Column {
                 height: implicitHeight
                 width: parent.width
 
-                CheckBoxSelector {
-                    id: telemetryRemote
-                    text: i18n("Enable remote telemetry")
-                }
-
                 IntegerSelector {
-                    id: telemetryCount
+                    id: historyCount
                     maximumValue: 10000
                     minimumValue: 0
                     stepSize: 50
                     text: i18n("History count")
-                    value: plasmoid.configuration.telemetryCount
+                    value: plasmoid.configuration.historyCount
-                }
-
-                LineSelector {
-                    id: telemetryId
-                    text: i18n("Telemetry ID")
-                    value: plasmoid.configuration.telemetryId
                 }
             }
         }

sources/awesome-widget/package/contents/ui/appearance.qml

@@ -18,8 +18,8 @@
 import QtQuick 2.15
 import org.kde.kcmutils as KCM
 
-import org.kde.plasma.private.awesomewidget 1.0
+import org.kde.plasma.awesomewidgets
-import "."
+import org.kde.plasma.private.awesomewidget
 
 
 KCM.SimpleKCM {
@@ -42,7 +42,6 @@ KCM.SimpleKCM {
     property string cfg_textStyle: textStyle.value
 
     Column {
-        id: pageColumn
         anchors.fill: parent
 
         FontSelector {

sources/awesome-widget/package/contents/ui/bug.qml

@@ -19,12 +19,15 @@ import QtQuick 2.15
 import QtQuick.Controls
 import QtQuick.Dialogs
 import QtQuick.Layouts
+import org.kde.kcmutils as KCM
 
-import org.kde.plasma.private.awesomewidget 1.0
+import org.kde.plasma.awesomewidgets
+import org.kde.plasma.private.awesomewidget
 
 
-Dialog {
+KCM.SimpleKCM {
-    id: reportDialog
+    id: bugPage
+
     AWActions {
         id: awActions
     }
@@ -32,12 +35,6 @@ Dialog {
         id: awBugReporter
     }
 
-    width: 640
-    height: 480
-
-    title: i18n("Report a bug")
-    standardButtons: DialogButtonBox.Ok | DialogButtonBox.Cancel | DialogButtonBox.Reset
-
     ColumnLayout {
         anchors.fill: parent
 
@@ -52,7 +49,6 @@ Dialog {
 
             GroupBox {
                 Layout.fillWidth: true
-                height: parent.height / 5
                 title: i18n("Description")
 
                 TextArea {
@@ -64,7 +60,6 @@ Dialog {
 
             GroupBox {
                 Layout.fillWidth: true
-                height: parent.height / 5
                 title: i18n("Steps to reproduce")
 
                 TextArea {
@@ -76,7 +71,6 @@ Dialog {
 
             GroupBox {
                 Layout.fillWidth: true
-                height: parent.height / 5
                 title: i18n("Expected result")
 
                 TextArea {
@@ -130,27 +124,36 @@ Dialog {
                 FileDialog {
                     id: logPath
                     title: i18n("Open log file")
-                    onAccepted:
+                    onAccepted: logBody.text = awActions.getFileContent(logPath.selectedFile.toString().replace("file://", ""))
-                    logBody.text = awActions.getFileContent(logPath.fileUrl.toString().replace("file://", ""))
                 }
             }
+
+            DialogButtonBox {
+                Layout.fillWidth: true
+
+                standardButtons: DialogButtonBox.Ok | DialogButtonBox.Reset
+                alignment: Qt.AlignRight
+                onAccepted: sendBugReport()
+                onReset: resetDialog()
+            }
         }
     }
 
-    onAccepted: {
+    function sendBugReport() {
         const text = awBugReporter.generateText(description.text, reproduce.text, expected.text, logBody.text)
         awBugReporter.sendBugReport(title.text, text)
     }
 
-    onReset: {
+    function resetDialog() {
         title.text = ""
         description.text = ""
         reproduce.text = ""
         expected.text = ""
+        logBody.text = ""
     }
 
     Component.onCompleted: {
+        resetDialog()
         awBugReporter.doConnect()
     }
 }
-

sources/awesome-widget/package/contents/ui/dataengine.qml

@@ -19,7 +19,8 @@ import QtQuick 2.15
 import QtQuick.Controls
 import org.kde.kcmutils as KCM
 
-import org.kde.plasma.private.awesomewidget 1.0
+import org.kde.plasma.awesomewidgets
+import org.kde.plasma.private.awesomewidget
 
 
 KCM.SimpleKCM {
@@ -36,7 +37,6 @@ KCM.SimpleKCM {
     property variant cfg_dataengine: awConfig.readDataEngineConfiguration()
 
     Column {
-        id: pageColumn
         anchors.fill: parent
 
         GroupBox {
@@ -190,10 +190,6 @@ KCM.SimpleKCM {
     Component.onCompleted: {
         // init submodule
         awKeys.updateCache()
-
-        // update hdd model
-        hdd.model = awKeys.getHddDevices()
-        hdd.onCompleted
     }
 
     Component.onDestruction: {

sources/awesome-widget/package/contents/ui/main.qml

@@ -16,14 +16,12 @@
  ***************************************************************************/
 
 import QtQuick 2.15
-import QtQuick.Controls
-import QtQuick.Dialogs
 import QtQuick.Layouts
 import org.kde.plasma.core as PlasmaCore
 import org.kde.plasma.plasmoid 2.0
 
-import org.kde.plasma.private.awesomewidget 1.0
+import org.kde.plasma.awesomewidgets
-import "."
+import org.kde.plasma.private.awesomewidget
 
 
 PlasmoidItem {
@@ -39,9 +37,6 @@ PlasmoidItem {
     AWTelemetryHandler {
         id: awTelemetryHandler
     }
-    BugReport {
-        id: bugReport
-    }
 
     property variant tooltipSettings: {
         "tooltipNumber": plasmoid.configuration.tooltipNumber,
@@ -92,7 +87,7 @@ PlasmoidItem {
 
         color: plasmoid.configuration.fontColor
         font.family: plasmoid.configuration.fontFamily
-        font.italic: plasmoid.configuration.fontStyle === "italic" ? true : false
+        font.italic: plasmoid.configuration.fontStyle === "italic"
         font.pointSize: plasmoid.configuration.fontSize
         font.weight: General.fontWeight[plasmoid.configuration.fontWeight]
 
@@ -111,35 +106,11 @@ PlasmoidItem {
         }
     }
 
-    Dialog {
-        id: tagSelector
-        title: i18n("Select tag")
-
-        ComboBox {
-            id: tagSelectorBox
-            width: parent.width
-            editable: true
-        }
-
-        onAccepted: {
-            const tag = tagSelectorBox.editText
-            let message = i18n("Tag: %1", tag)
-            message += "<br>"
-            message += i18n("Value: %1", awKeys.valueByKey(tag))
-            message += "<br>"
-            message += i18n("Info: %1", awKeys.infoByKey(tag))
-            awActions.sendNotification("tag", message)
-        }
-    }
-
     Plasmoid.contextualActions: [
         PlasmaCore.Action {
-            text: i18n("Request key")
+            text: i18n("Run monitor")
             icon.name: "utilities-system-monitor"
-            onTriggered: {
+            onTriggered: awActions.runCmd("plasma-systemmonitor", [])
-                tagSelectorBox.model = awKeys.dictKeys(true)
-                tagSelector.open()
-            }
         },
         PlasmaCore.Action {
             text: i18n("Show README")
@@ -150,14 +121,6 @@ PlasmoidItem {
             text: i18n("Check updates")
             icon.name: "system-software-update"
             onTriggered: awActions.checkUpdates(true)
-        },
-        PlasmaCore.Action {
-            text: i18n("Report bug")
-            icon.name: "tools-report-bug"
-            onTriggered: {
-                bugReport.reset()
-                bugReport.open()
-            }
         }
     ]
 
@@ -205,8 +168,7 @@ PlasmoidItem {
 
         // init submodule
         awKeys.initDataAggregator(tooltipSettings)
-        awKeys.initKeys(plasmoid.configuration.text, plasmoid.configuration.interval,
+        awKeys.initKeys(plasmoid.configuration.text, plasmoid.configuration.interval, plasmoid.configuration.optimize)
-                        plasmoid.configuration.queueLimit, plasmoid.configuration.optimize)
         awKeys.setWrapNewLines(plasmoid.configuration.wrapNewLines)
         // configure aggregator
         awKeys.setAggregatorProperty("acOffline", plasmoid.configuration.acOffline)
@@ -215,22 +177,8 @@ PlasmoidItem {
         awKeys.setAggregatorProperty("customUptime", plasmoid.configuration.customUptime)
         awKeys.setAggregatorProperty("tempUnits", plasmoid.configuration.tempUnits)
         awKeys.setAggregatorProperty("translate", plasmoid.configuration.translateStrings)
-        // update telemetry ID
-        if (plasmoid.configuration.telemetryId.length === 0)
-            plasmoid.configuration.telemetryId = generateUuid()
         // save telemetry
-        awTelemetryHandler.init(plasmoid.configuration.telemetryCount,
+        awTelemetryHandler.init(plasmoid.configuration.historyCount)
-                                plasmoid.configuration.telemetryRemote,
+        awTelemetryHandler.put("awwidgetconfig", plasmoid.configuration.text)
-                                plasmoid.configuration.telemetryId)
-        if (awTelemetryHandler.put("awwidgetconfig", plasmoid.configuration.text))
-            awTelemetryHandler.uploadTelemetry("awwidgetconfig", plasmoid.configuration.text)
-    }
-
-    // code from http://stackoverflow.com/questions/105034/create-guid-uuid-in-javascript
-    function generateUuid() {
-        return "xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx".replace(/[xy]/g, function(c) {
-            let r = Math.random() * 16 | 0, v = c === "x" ? r : (r & 0x3 | 0x8);
-            return v.toString(16);
-        });
     }
 }

sources/awesome-widget/package/contents/ui/qmldir

@@ -1,27 +0,0 @@
-# Do not edit qmldir directly it will be overrided during compilation,
-# edit qml/qmldir.in file instead.
-
-
-# common QML constants
-singleton General 1.0 file:///usr/share/awesomewidgets/qml/General.qml
-
-# custom QML UI classes
-AboutTab file:///usr/share/awesomewidgets/qml/AboutTab.qml
-AWExtensions file:///usr/share/awesomewidgets/qml/AWExtensions.qml
-AWInfoLabel file:///usr/share/awesomewidgets/qml/AWInfoLabel.qml
-AWTagSelector file:///usr/share/awesomewidgets/qml/AWTagSelector.qml
-AWTextEditor file:///usr/share/awesomewidgets/qml/AWTextEditor.qml
-BugReport file:///usr/share/awesomewidgets/qml/BugReport.qml
-ButtonSelector file:///usr/share/awesomewidgets/qml/ButtonSelector.qml
-CheckBoxSelector file:///usr/share/awesomewidgets/qml/CheckBoxSelector.qml
-ColorSelector file:///usr/share/awesomewidgets/qml/ColorSelector.qml
-ComboBoxSelector file:///usr/share/awesomewidgets/qml/ComboBoxSelector.qml
-ExportDialog file:///usr/share/awesomewidgets/qml/ExportDialog.qml
-FontSelector file:///usr/share/awesomewidgets/qml/FontSelector.qml
-HtmlDefaultFunctionsBar file:///usr/share/awesomewidgets/qml/HtmlDefaultFunctionsBar.qml
-HtmlEditorButton file:///usr/share/awesomewidgets/qml/HtmlEditorButton.qml
-HtmlEditorColor file:///usr/share/awesomewidgets/qml/HtmlEditorColor.qml
-HtmlEditorFont file:///usr/share/awesomewidgets/qml/HtmlEditorFont.qml
-ImportDialog file:///usr/share/awesomewidgets/qml/ImportDialog.qml
-IntegerSelector file:///usr/share/awesomewidgets/qml/IntegerSelector.qml
-LineSelector file:///usr/share/awesomewidgets/qml/LineSelector.qml

sources/awesome-widget/package/contents/ui/tooltip.qml

@@ -19,7 +19,8 @@ import QtQuick 2.15
 import QtQuick.Controls
 import org.kde.kcmutils as KCM
 
-import org.kde.plasma.private.awesomewidget 1.0
+import org.kde.plasma.awesomewidgets
+import org.kde.plasma.private.awesomewidget
 
 
 KCM.SimpleKCM {
@@ -44,7 +45,6 @@ KCM.SimpleKCM {
     property alias cfg_batInTooltipColor: batInTooltipColor.value
 
     Column {
-        id: pageColumn
         anchors.fill: parent
 
         Label {

sources/awesome-widget/package/contents/ui/widget.qml

@@ -19,8 +19,8 @@ import QtQuick 2.15
 import QtQuick.Controls
 import org.kde.kcmutils as KCM
 
-import org.kde.plasma.private.awesomewidget 1.0
+import org.kde.plasma.awesomewidgets
-import "."
+import org.kde.plasma.private.awesomewidget
 
 
 KCM.SimpleKCM {
@@ -40,7 +40,6 @@ KCM.SimpleKCM {
     signal needTextUpdate(string newText)
 
     Column {
-        id: pageColumn
         anchors.fill: parent
 
         AWInfoLabel {}

sources/awesome-widget/plugin/awabstractpairconfig.cpp

@@ -37,13 +37,13 @@ AWAbstractPairConfig::AWAbstractPairConfig(QWidget *_parent, const bool _hasEdit
 
     ui->setupUi(this);
 
-    connect(ui->buttonBox, SIGNAL(accepted()), this, SLOT(accept()));
+    connect(ui->buttonBox, &QDialogButtonBox::accepted, this, &AWAbstractPairConfig::accept);
-    connect(ui->buttonBox, SIGNAL(rejected()), this, SLOT(reject()));
+    connect(ui->buttonBox, &QDialogButtonBox::rejected, this, &AWAbstractPairConfig::reject);
 
     // edit feature
     if (m_hasEdit) {
         m_editButton = ui->buttonBox->addButton(i18n("Edit"), QDialogButtonBox::ActionRole);
-        connect(m_editButton, SIGNAL(clicked(bool)), this, SLOT(edit()));
+        connect(m_editButton, &QPushButton::clicked, [this]() { return edit(); });
     }
 }
 
@@ -58,6 +58,12 @@ AWAbstractPairConfig::~AWAbstractPairConfig()
 }
 
 
+void AWAbstractPairConfig::setHelper(std::unique_ptr<AWAbstractPairHelper> _helper)
+{
+    m_helper = std::move(_helper);
+}
+
+
 void AWAbstractPairConfig::showDialog()
 {
     // update dialog
@@ -84,14 +90,14 @@ void AWAbstractPairConfig::edit()
 
 void AWAbstractPairConfig::updateUi()
 {
-    QPair<QString, QString> current = dynamic_cast<AWAbstractSelector *>(sender())->current();
+    auto current = dynamic_cast<AWAbstractSelector *>(sender())->current();
-    int index = m_selectors.indexOf(dynamic_cast<AWAbstractSelector *>(sender()));
+    auto index = m_selectors.indexOf(dynamic_cast<AWAbstractSelector *>(sender()));
 
     if ((current.first.isEmpty()) && (current.second.isEmpty())) {
         // remove current selector if it is empty and does not last
         if (sender() == m_selectors.last())
             return;
-        AWAbstractSelector *selector = m_selectors.takeAt(index);
+        auto selector = m_selectors.takeAt(index);
         ui->verticalLayout->removeWidget(selector);
         selector->deleteLater();
     } else {
@@ -109,18 +115,18 @@ void AWAbstractPairConfig::addSelector(const QStringList &_keys, const QStringLi
 {
     qCDebug(LOG_AW) << "Add selector with keys" << _keys << "values" << _values << "and current ones" << _current;
 
-    auto *selector = new AWAbstractSelector(ui->scrollAreaWidgetContents, m_editable);
+    auto selector = new AWAbstractSelector(ui->scrollAreaWidgetContents, m_editable);
     selector->init(_keys, _values, _current);
     ui->verticalLayout->insertWidget(ui->verticalLayout->count() - 1, selector);
-    connect(selector, SIGNAL(selectionChanged()), this, SLOT(updateUi()));
+    connect(selector, &AWAbstractSelector::selectionChanged, this, &AWAbstractPairConfig::updateUi);
     m_selectors.append(selector);
 }
 
 
 void AWAbstractPairConfig::clearSelectors()
 {
-    for (auto &selector : m_selectors) {
+    for (auto selector : m_selectors) {
-        disconnect(selector, SIGNAL(selectionChanged()), this, SLOT(updateUi()));
+        disconnect(selector, &AWAbstractSelector::selectionChanged, this, &AWAbstractPairConfig::updateUi);
         ui->verticalLayout->removeWidget(selector);
         selector->deleteLater();
     }
@@ -130,10 +136,10 @@ void AWAbstractPairConfig::clearSelectors()
 
 void AWAbstractPairConfig::execDialog()
 {
-    int ret = exec();
+    auto ret = exec();
     QHash<QString, QString> data;
-    for (auto &selector : m_selectors) {
+    for (auto selector : m_selectors) {
-        QPair<QString, QString> select = selector->current();
+        auto select = selector->current();
         if (select.first.isEmpty())
             continue;
         data[select.first] = select.second;
@@ -160,11 +166,12 @@ QPair<QStringList, QStringList> AWAbstractPairConfig::initKeys() const
     QStringList left = {""};
     left.append(m_helper->leftKeys().isEmpty() ? m_keys : m_helper->leftKeys());
     left.sort();
+
     QStringList right = {""};
     right.append(m_helper->rightKeys().isEmpty() ? m_keys : m_helper->rightKeys());
     right.sort();
 
-    return QPair<QStringList, QStringList>(left, right);
+    return {left, right};
 }
 
 
@@ -175,7 +182,7 @@ void AWAbstractPairConfig::updateDialog()
     auto keys = initKeys();
 
     for (auto &key : m_helper->keys())
-        addSelector(keys.first, keys.second, QPair<QString, QString>(key, m_helper->pairs()[key]));
+        addSelector(keys.first, keys.second, {key, pairs[key]});
     // empty one
-    addSelector(keys.first, keys.second, QPair<QString, QString>());
+    addSelector(keys.first, keys.second, {});
 }

sources/awesome-widget/plugin/awabstractpairconfig.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWABSTRACTPAIRCONFIG_H
-#define AWABSTRACTPAIRCONFIG_H
 
 #include <QDialog>
 
@@ -35,14 +33,9 @@ class AWAbstractPairConfig : public QDialog
     Q_OBJECT
 
 public:
-    explicit AWAbstractPairConfig(QWidget *_parent = nullptr, bool _hasEdit = false, QStringList _keys = QStringList());
+    explicit AWAbstractPairConfig(QWidget *_parent = nullptr, bool _hasEdit = false, QStringList _keys = {});
     ~AWAbstractPairConfig() override;
-    template <class T> void initHelper()
+    void setHelper(std::unique_ptr<AWAbstractPairHelper> _helper);
-    {
-
-        delete m_helper;
-        m_helper = new T(this);
-    }
     void showDialog();
     // properties
     void setEditable(bool _first, bool _second);
@@ -54,7 +47,7 @@ private slots:
 private:
     QPushButton *m_editButton = nullptr;
     Ui::AWAbstractPairConfig *ui = nullptr;
-    AWAbstractPairHelper *m_helper = nullptr;
+    std::unique_ptr<AWAbstractPairHelper> m_helper;
     QList<AWAbstractSelector *> m_selectors;
     // properties
     QPair<bool, bool> m_editable = {false, false};
@@ -67,6 +60,3 @@ private:
     [[nodiscard]] QPair<QStringList, QStringList> initKeys() const;
     void updateDialog();
 };
-
-
-#endif /* AWABSTRACTPAIRCONFIG_H */

sources/awesome-widget/plugin/awabstractpairhelper.cpp

@@ -34,12 +34,6 @@ AWAbstractPairHelper::AWAbstractPairHelper(QString _filePath, QString _section)
 }
 
 
-AWAbstractPairHelper::~AWAbstractPairHelper()
-{
-    qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
-}
-
-
 QStringList AWAbstractPairHelper::keys() const
 {
     return m_pairs.keys();
@@ -69,16 +63,16 @@ void AWAbstractPairHelper::initItems()
 {
     m_pairs.clear();
 
-    QStringList configs = QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, m_filePath);
+    auto configs = QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, m_filePath);
 
     for (auto &fileName : configs) {
         QSettings settings(fileName, QSettings::IniFormat);
         qCInfo(LOG_AW) << "Configuration file" << settings.fileName();
 
         settings.beginGroup(m_section);
-        QStringList keys = settings.childKeys();
+        auto keys = settings.childKeys();
         for (auto &key : keys) {
-            QString value = settings.value(key).toString();
+            auto value = settings.value(key).toString();
             qCInfo(LOG_AW) << "Found key" << key << "for value" << value << "in" << settings.fileName();
             if (value.isEmpty()) {
                 qCInfo(LOG_AW) << "Skip empty value for" << key;
@@ -95,8 +89,8 @@ bool AWAbstractPairHelper::writeItems(const QHash<QString, QString> &_configurat
 {
     qCDebug(LOG_AW) << "Write configuration" << _configuration;
 
-    QString fileName
+    auto fileName
-        = QString("%1/%2").arg(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation)).arg(m_filePath);
+        = QString("%1/%2").arg(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation), m_filePath);
     QSettings settings(fileName, QSettings::IniFormat);
     qCInfo(LOG_AW) << "Configuration file" << fileName;
 
@@ -107,7 +101,7 @@ bool AWAbstractPairHelper::writeItems(const QHash<QString, QString> &_configurat
 
     settings.sync();
 
-    return (settings.status() == QSettings::NoError);
+    return settings.status() == QSettings::NoError;
 }
 
 
@@ -115,14 +109,13 @@ bool AWAbstractPairHelper::removeUnusedKeys(const QStringList &_keys) const
 {
     qCDebug(LOG_AW) << "Remove keys" << _keys;
 
-    QString fileName
+    auto fileName
-        = QString("%1/%2").arg(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation)).arg(m_filePath);
+        = QString("%1/%2").arg(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation), m_filePath);
     QSettings settings(fileName, QSettings::IniFormat);
     qCInfo(LOG_AW) << "Configuration file" << fileName;
 
     settings.beginGroup(m_section);
-    QStringList foundKeys = settings.childKeys();
+    for (auto &key : settings.childKeys()) {
-    for (auto &key : foundKeys) {
         if (_keys.contains(key))
             continue;
         settings.remove(key);
@@ -131,5 +124,5 @@ bool AWAbstractPairHelper::removeUnusedKeys(const QStringList &_keys) const
 
     settings.sync();
 
-    return (settings.status() == QSettings::NoError);
+    return settings.status() == QSettings::NoError;
 }

sources/awesome-widget/plugin/awabstractpairhelper.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWABSTRACTPAIRHELPER_H
-#define AWABSTRACTPAIRHELPER_H
 
 #include <QHash>
 
@@ -26,7 +24,7 @@ class AWAbstractPairHelper
 {
 public:
     explicit AWAbstractPairHelper(QString _filePath = "", QString _section = "");
-    virtual ~AWAbstractPairHelper();
+    virtual ~AWAbstractPairHelper() = default;
     [[nodiscard]] QStringList keys() const;
     [[nodiscard]] QHash<QString, QString> pairs() const;
     [[nodiscard]] QStringList values() const;
@@ -46,6 +44,3 @@ private:
     QString m_filePath;
     QString m_section;
 };
-
-
-#endif /* AWABSTRACTPAIRHELPER_H */

sources/awesome-widget/plugin/awabstractselector.cpp

@@ -31,8 +31,8 @@ AWAbstractSelector::AWAbstractSelector(QWidget *_parent, const QPair<bool, bool>
     ui->comboBox_key->setEditable(_editable.first);
     ui->comboBox_value->setEditable(_editable.second);
 
-    connect(ui->comboBox_key, SIGNAL(currentIndexChanged(int)), this, SIGNAL(selectionChanged()));
+    connect(ui->comboBox_key, &QComboBox::currentIndexChanged, this, &AWAbstractSelector::selectionChanged);
-    connect(ui->comboBox_value, SIGNAL(currentIndexChanged(int)), this, SIGNAL(selectionChanged()));
+    connect(ui->comboBox_value, &QComboBox::currentIndexChanged, this, &AWAbstractSelector::selectionChanged);
 }
 
 
@@ -46,10 +46,10 @@ AWAbstractSelector::~AWAbstractSelector()
 
 QPair<QString, QString> AWAbstractSelector::current() const
 {
-    QString key = ui->comboBox_key->currentText();
+    auto key = ui->comboBox_key->currentText();
-    QString value = ui->comboBox_value->currentText();
+    auto value = ui->comboBox_value->currentText();
 
-    return QPair<QString, QString>(key, value);
+    return {key, value};
 }
 
 

sources/awesome-widget/plugin/awabstractselector.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWABSTRACTSELECTOR_H
-#define AWABSTRACTSELECTOR_H
 
 #include <QWidget>
 
@@ -43,6 +41,3 @@ signals:
 private:
     Ui::AWAbstractSelector *ui = nullptr;
 };
-
-
-#endif /* AWABSTRACTSELECTOR_H */

sources/awesome-widget/plugin/awactions.cpp

@@ -40,12 +40,6 @@ AWActions::AWActions(QObject *_parent)
 }
 
 
-AWActions::~AWActions()
-{
-    qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
-}
-
-
 void AWActions::checkUpdates(const bool _showAnyway)
 {
     qCDebug(LOG_AW) << "Show anyway" << _showAnyway;
@@ -65,7 +59,7 @@ QString AWActions::getFileContent(const QString &_path)
         return "";
     }
 
-    QString output = inputFile.readAll();
+    auto output = inputFile.readAll();
     inputFile.close();
     return output;
 }
@@ -75,7 +69,7 @@ bool AWActions::runCmd(const QString &_cmd, const QStringList &_args)
 {
     qCDebug(LOG_AW) << "Cmd" << _cmd << "args" << _args;
 
-    sendNotification(QString("Info"), i18n("Run %1", _cmd));
+    sendNotification("system", i18n("Run %1", _cmd));
 
     return QProcess::startDetached(_cmd, _args);
 }
@@ -88,20 +82,6 @@ void AWActions::showReadme()
 }
 
 
-void AWActions::showLegacyInfo()
-{
-    auto *msgBox = new QMessageBox(nullptr);
-    msgBox->setAttribute(Qt::WA_DeleteOnClose);
-    msgBox->setModal(false);
-    msgBox->setWindowTitle(i18n("Not supported"));
-    msgBox->setText(i18n("You are using mammoth's Qt version, try to update it first"));
-    msgBox->setStandardButtons(QMessageBox::Ok);
-    msgBox->setIcon(QMessageBox::Information);
-
-    msgBox->open();
-}
-
-
 // HACK: this method uses variables from version.h
 QString AWActions::getAboutText(const QString &_type)
 {
@@ -116,10 +96,10 @@ QVariantMap AWActions::getFont(const QVariantMap &_defaultFont)
     qCDebug(LOG_AW) << "Default font is" << _defaultFont;
 
     QVariantMap fontMap;
-    int ret = 0;
+    auto ret = 0;
-    CFont defaultCFont = CFont(_defaultFont["family"].toString(), _defaultFont["size"].toInt(), 400, false,
+    auto defaultCFont = CFont(_defaultFont["family"].toString(), _defaultFont["size"].toInt(), 400, false,
-                               _defaultFont["color"].toString());
+                              _defaultFont["color"].toString());
-    CFont font = CFontDialog::getFont(i18n("Select font"), defaultCFont, false, false, &ret);
+    auto font = CFontDialog::getFont(i18n("Select font"), defaultCFont, false, false, &ret);
 
     fontMap["applied"] = ret;
     fontMap["color"] = font.color().name();
@@ -135,7 +115,6 @@ void AWActions::sendNotification(const QString &_eventId, const QString &_messag
 {
     qCDebug(LOG_AW) << "Event" << _eventId << "with message" << _message;
 
-    KNotification *notification
+    auto event = KNotification::event(_eventId, QString("Awesome Widget ::: %1").arg(_eventId), _message);
-        = KNotification::event(_eventId, QString("Awesome Widget ::: %1").arg(_eventId), _message);
+    event->setComponentName("plasma-applet-org.kde.plasma.awesome-widget");
-    notification->setComponentName("plasma-applet-org.kde.plasma.awesome-widget");
 }

sources/awesome-widget/plugin/awactions.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWACTIONS_H
-#define AWACTIONS_H
 
 #include <QMap>
 #include <QObject>
@@ -31,11 +29,10 @@ class AWActions : public QObject
 
 public:
     explicit AWActions(QObject *_parent = nullptr);
-    ~AWActions() override;
+    ~AWActions() override = default;
     Q_INVOKABLE void checkUpdates(bool _showAnyway = false);
     Q_INVOKABLE static QString getFileContent(const QString &_path);
     Q_INVOKABLE static bool runCmd(const QString &_cmd, const QStringList &_args);
-    Q_INVOKABLE static void showLegacyInfo();
     Q_INVOKABLE static void showReadme();
     // configuration slots
     Q_INVOKABLE static QString getAboutText(const QString &_type);
@@ -47,6 +44,3 @@ public slots:
 private:
     AWUpdateHelper *m_updateHelper = nullptr;
 };
-
-
-#endif /* AWACTIONS_H */

sources/awesome-widget/plugin/awbugreporter.cpp

@@ -18,6 +18,7 @@
 #include "awbugreporter.h"
 
 #include <KI18n/KLocalizedString>
+#include <KNotifications/KNotification>
 
 #include <QDesktopServices>
 #include <QJsonDocument>
@@ -32,19 +33,24 @@ AWBugReporter::AWBugReporter(QObject *_parent)
     : QObject(_parent)
 {
     qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
+
+    m_manager = new QNetworkAccessManager(nullptr);
+    connect(m_manager, &QNetworkAccessManager::finished, this, &AWBugReporter::issueReplyReceived);
 }
 
 
 AWBugReporter::~AWBugReporter()
 {
     qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
+
+    m_manager->deleteLater();
 }
 
 
-void AWBugReporter::doConnect()
+void AWBugReporter::doConnect() const
 {
     // additional method for testing needs
-    connect(this, SIGNAL(replyReceived(const int, const QString &)), this, SLOT(showInformation(int, const QString &)));
+    connect(this, &AWBugReporter::replyReceived, this, &AWBugReporter::showInformation);
 }
 
 
@@ -71,26 +77,24 @@ void AWBugReporter::sendBugReport(const QString &_title, const QString &_body)
 {
     qCDebug(LOG_AW) << "Send bug report with title" << _title << "and body" << _body;
 
-    auto *manager = new QNetworkAccessManager(nullptr);
-    connect(manager, SIGNAL(finished(QNetworkReply *)), this, SLOT(issueReplyRecieved(QNetworkReply *)));
 
-    QNetworkRequest request = QNetworkRequest(QUrl(BUGTRACKER_API));
+    auto request = QNetworkRequest(QUrl(BUGTRACKER_API));
     request.setHeader(QNetworkRequest::ContentTypeHeader, "application/json");
 
     // generate payload
     QVariantMap payload;
     payload["title"] = _title;
     payload["body"] = _body;
-    payload["labels"] = QStringList() << "from application";
+    payload["labels"] = QStringList({"from application"});
     // convert to QByteArray to send request
-    QByteArray data = QJsonDocument::fromVariant(payload).toJson(QJsonDocument::Compact);
+    auto data = QJsonDocument::fromVariant(payload).toJson(QJsonDocument::Compact);
     qCInfo(LOG_AW) << "Send request with _body" << data.data() << "and size" << data.size();
 
-    manager->post(request, data);
+    m_manager->post(request, data);
 }
 
 
-void AWBugReporter::issueReplyRecieved(QNetworkReply *_reply)
+void AWBugReporter::issueReplyReceived(QNetworkReply *_reply)
 {
     if (_reply->error() != QNetworkReply::NoError) {
         qCWarning(LOG_AW) << "An error occurs" << _reply->error() << "with message" << _reply->errorString();
@@ -98,7 +102,7 @@ void AWBugReporter::issueReplyRecieved(QNetworkReply *_reply)
     }
 
     QJsonParseError error{};
-    QJsonDocument jsonDoc = QJsonDocument::fromJson(_reply->readAll(), &error);
+    auto jsonDoc = QJsonDocument::fromJson(_reply->readAll(), &error);
     if (error.error != QJsonParseError::NoError) {
         qCWarning(LOG_AW) << "Parse error" << error.errorString();
         return emit(replyReceived(0, ""));
@@ -106,14 +110,20 @@ void AWBugReporter::issueReplyRecieved(QNetworkReply *_reply)
     _reply->deleteLater();
 
     // convert to map
-    QVariantMap response = jsonDoc.toVariant().toMap();
+    auto response = jsonDoc.toVariant().toMap();
-    QString url = response["html_url"].toString();
+    auto url = response["html_url"].toString();
-    int number = response["number"].toInt();
+    auto number = response["number"].toInt();
 
     return emit(replyReceived(number, url));
 }
 
 
+void AWBugReporter::openBugReport()
+{
+    QDesktopServices::openUrl(m_lastBugUrl);
+}
+
+
 void AWBugReporter::showInformation(const int _number, const QString &_url)
 {
     qCDebug(LOG_AW) << "Created issue with number" << _number << "and url" << _url;
@@ -121,29 +131,9 @@ void AWBugReporter::showInformation(const int _number, const QString &_url)
     // cache url first
     m_lastBugUrl = _url;
 
-    auto *msgBox = new QMessageBox(nullptr);
+    auto event = KNotification::event("system", i18n("Issue created"), i18n("Issue %1 has been created", _number));
-    msgBox->setAttribute(Qt::WA_DeleteOnClose);
+    event->setComponentName("plasma-applet-org.kde.plasma.awesome-widget");
-    msgBox->setModal(false);
-    msgBox->setWindowTitle(i18n("Issue created"));
-    msgBox->setText(i18n("Issue %1 has been created", _number));
-    msgBox->setStandardButtons(QMessageBox::Open | QMessageBox::Close);
-    msgBox->setIcon(QMessageBox::Information);
 
-    msgBox->open(this, SLOT(userReplyOnBugReport(QAbstractButton *)));
+    auto action = event->addAction(i18n("Details"));
-}
+    connect(action, &KNotificationAction::activated, this, &AWBugReporter::openBugReport);
-
-
-void AWBugReporter::userReplyOnBugReport(QAbstractButton *_button)
-{
-    QMessageBox::ButtonRole ret = dynamic_cast<QMessageBox *>(sender())->buttonRole(_button);
-    qCInfo(LOG_AW) << "User select" << ret;
-
-    switch (ret) {
-    case QMessageBox::AcceptRole:
-        QDesktopServices::openUrl(m_lastBugUrl);
-        break;
-    case QMessageBox::RejectRole:
-    default:
-        break;
-    }
 }

sources/awesome-widget/plugin/awbugreporter.h

@@ -15,14 +15,12 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWBUGREPORTER_H
-#define AWBUGREPORTER_H
 
 #include <QObject>
 
 
-class QAbstractButton;
+class QNetworkAccessManager;
 class QNetworkReply;
 
 class AWBugReporter : public QObject
@@ -32,7 +30,7 @@ class AWBugReporter : public QObject
 public:
     explicit AWBugReporter(QObject *_parent = nullptr);
     ~AWBugReporter() override;
-    Q_INVOKABLE void doConnect();
+    Q_INVOKABLE void doConnect() const;
     Q_INVOKABLE static QString generateText(const QString &_description, const QString &_reproduce,
                                             const QString &_expected, const QString &_logs);
     Q_INVOKABLE void sendBugReport(const QString &_title, const QString &_body);
@@ -41,13 +39,11 @@ signals:
     void replyReceived(int _number, const QString &_url);
 
 private slots:
-    void issueReplyRecieved(QNetworkReply *_reply);
+    void issueReplyReceived(QNetworkReply *_reply);
+    void openBugReport();
     void showInformation(int _number, const QString &_url);
-    void userReplyOnBugReport(QAbstractButton *_button);
 
 private:
     QString m_lastBugUrl;
+    QNetworkAccessManager *m_manager = nullptr;
 };
-
-
-#endif /* AWBUGREPORTER_H */

sources/awesome-widget/plugin/awconfighelper.cpp

@@ -34,17 +34,11 @@ AWConfigHelper::AWConfigHelper(QObject *_parent)
 }
 
 
-AWConfigHelper::~AWConfigHelper()
-{
-    qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
-}
-
-
 QString AWConfigHelper::configurationDirectory()
 {
     // get readable directory
-    QString localDir = QString("%1/awesomewidgets/configs")
+    auto localDir = QString("%1/awesomewidgets/configs")
-                           .arg(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation));
+                        .arg(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation));
 
     // create directory and copy files from default settings
     QDir localDirectory;
@@ -59,7 +53,7 @@ QString AWConfigHelper::configurationDirectory()
 
 bool AWConfigHelper::dropCache()
 {
-    QString fileName
+    auto fileName
         = QString("%1/awesomewidgets.ndx").arg(QStandardPaths::writableLocation(QStandardPaths::GenericCacheLocation));
 
     return QFile(fileName).remove();
@@ -72,10 +66,10 @@ bool AWConfigHelper::exportConfiguration(QObject *_nativeConfig, const QString &
 
     QSettings settings(_fileName, QSettings::IniFormat);
     // plasmoid configuration
-    const auto *configuration = dynamic_cast<const QQmlPropertyMap *>(_nativeConfig);
+    auto configuration = dynamic_cast<const QQmlPropertyMap *>(_nativeConfig);
     settings.beginGroup("plasmoid");
     for (auto &key : configuration->keys()) {
-        QVariant value = configuration->value(key);
+        auto value = configuration->value(key);
         if (!value.isValid())
             continue;
         settings.setValue(key, value);
@@ -84,8 +78,7 @@ bool AWConfigHelper::exportConfiguration(QObject *_nativeConfig, const QString &
 
     // extensions
     for (auto &item : m_dirs) {
-        QStringList items
+        auto items = QDir(QString("%1/%2").arg(m_baseDir, item)).entryList({"*.desktop"}, QDir::Files);
-            = QDir(QString("%1/%2").arg(m_baseDir).arg(item)).entryList(QStringList() << "*.desktop", QDir::Files);
         settings.beginGroup(item);
         for (auto &it : items)
             copyExtensions(it, item, settings, false);
@@ -163,7 +156,7 @@ QVariantMap AWConfigHelper::importConfiguration(const QString &_fileName, const
 
 QVariantMap AWConfigHelper::readDataEngineConfiguration()
 {
-    QString fileName = QStandardPaths::locate(QStandardPaths::ConfigLocation, "plasma-dataengine-extsysmon.conf");
+    auto fileName = QStandardPaths::locate(QStandardPaths::ConfigLocation, "plasma-dataengine-extsysmon.conf");
     qCInfo(LOG_AW) << "Configuration file" << fileName;
     QSettings settings(fileName, QSettings::IniFormat);
     QVariantMap configuration;
@@ -187,8 +180,8 @@ bool AWConfigHelper::writeDataEngineConfiguration(const QVariantMap &_configurat
 {
     qCDebug(LOG_AW) << "Configuration" << _configuration;
 
-    QString fileName = QString("%1/plasma-dataengine-extsysmon.conf")
+    auto fileName = QString("%1/plasma-dataengine-extsysmon.conf")
-                           .arg(QStandardPaths::writableLocation(QStandardPaths::ConfigLocation));
+                        .arg(QStandardPaths::writableLocation(QStandardPaths::ConfigLocation));
     QSettings settings(fileName, QSettings::IniFormat);
     qCInfo(LOG_AW) << "Configuration file" << settings.fileName();
 
@@ -211,15 +204,15 @@ void AWConfigHelper::copyConfigs(const QString &_localDir)
 {
     qCDebug(LOG_AW) << "Local directory" << _localDir;
 
-    QStringList dirs = QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, "awesomewidgets/configs",
+    auto dirs = QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, "awesomewidgets/configs",
-                                                 QStandardPaths::LocateDirectory);
+                                          QStandardPaths::LocateDirectory);
     for (auto &dir : dirs) {
         if (dir == _localDir)
             continue;
-        QStringList files = QDir(dir).entryList(QDir::Files);
+        auto files = QDir(dir).entryList(QDir::Files);
         for (auto &source : files) {
-            QString destination = QString("%1/%2").arg(_localDir).arg(source);
+            auto destination = QString("%1/%2").arg(_localDir, source);
-            bool status = QFile::copy(QString("%1/%2").arg(dir).arg(source), destination);
+            auto status = QFile::copy(QString("%1/%2").arg(dir, source), destination);
             qCInfo(LOG_AW) << "File" << source << "has been copied to" << destination << "with status" << status;
         }
     }
@@ -232,7 +225,7 @@ void AWConfigHelper::copyExtensions(const QString &_item, const QString &_type,
     qCDebug(LOG_AW) << "Extension" << _item << "has type" << _type << "inverse copying" << _inverse;
 
     _settings.beginGroup(_item);
-    QSettings itemSettings(QString("%1/%2/%3").arg(m_baseDir).arg(_type).arg(_item), QSettings::IniFormat);
+    QSettings itemSettings(QString("%1/%2/%3").arg(m_baseDir, _type, _item), QSettings::IniFormat);
     itemSettings.beginGroup("Desktop Entry");
     if (_inverse)
         copySettings(_settings, itemSettings);
@@ -259,7 +252,7 @@ void AWConfigHelper::readFile(QSettings &_settings, const QString &_key, const Q
 
     QFile file(_fileName);
     if (file.open(QIODevice::ReadOnly | QIODevice::Text)) {
-        QString text = QString::fromUtf8(file.readAll());
+        auto text = QString::fromUtf8(file.readAll());
         file.close();
         _settings.setValue(_key, text);
     } else {

sources/awesome-widget/plugin/awconfighelper.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWCONFIGHELPER_H
-#define AWCONFIGHELPER_H
 
 #include <QObject>
 #include <QVariant>
@@ -31,7 +29,7 @@ class AWConfigHelper : public QObject
 
 public:
     explicit AWConfigHelper(QObject *_parent = nullptr);
-    ~AWConfigHelper() override;
+    ~AWConfigHelper() override = default;
     Q_INVOKABLE [[nodiscard]] static QString configurationDirectory();
     Q_INVOKABLE static bool dropCache();
     Q_INVOKABLE bool exportConfiguration(QObject *_nativeConfig, const QString &_fileName) const;
@@ -52,6 +50,3 @@ private:
     QString m_baseDir;
     QStringList m_dirs = {"desktops", "quotes", "scripts", "upgrade", "weather", "formatters"};
 };
-
-
-#endif /* AWCONFIGHELPER_H */

sources/awesome-widget/plugin/awcustomkeysconfig.cpp

@@ -27,11 +27,5 @@ AWCustomKeysConfig::AWCustomKeysConfig(QWidget *_parent, const QStringList &_key
     qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
 
     setEditable(true, false);
-    initHelper<AWCustomKeysHelper>();
+    setHelper(std::make_unique<AWCustomKeysHelper>());
-}
-
-
-AWCustomKeysConfig::~AWCustomKeysConfig()
-{
-    qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
 }

sources/awesome-widget/plugin/awcustomkeysconfig.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWCUSTOMKEYSCONFIG_H
-#define AWCUSTOMKEYSCONFIG_H
 
 #include "awabstractpairconfig.h"
 
@@ -28,8 +26,5 @@ class AWCustomKeysConfig : public AWAbstractPairConfig
 
 public:
     explicit AWCustomKeysConfig(QWidget *_parent = nullptr, const QStringList &_keys = QStringList());
-    ~AWCustomKeysConfig() override;
+    ~AWCustomKeysConfig() override = default;
 };
-
-
-#endif /* AWCUSTOMKEYSCONFIG_H */

sources/awesome-widget/plugin/awcustomkeyshelper.cpp

@@ -30,12 +30,6 @@ AWCustomKeysHelper::AWCustomKeysHelper(QObject *_parent)
 }
 
 
-AWCustomKeysHelper::~AWCustomKeysHelper()
-{
-    qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
-}
-
-
 QString AWCustomKeysHelper::source(const QString &_key) const
 {
     qCDebug(LOG_AW) << "Get source by key" << _key;

sources/awesome-widget/plugin/awcustomkeyshelper.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWCUSTOMKEYSHELPER_H
-#define AWCUSTOMKEYSHELPER_H
 
 #include <QObject>
 
@@ -30,7 +28,7 @@ class AWCustomKeysHelper : public QObject, public AWAbstractPairHelper
 
 public:
     explicit AWCustomKeysHelper(QObject *_parent = nullptr);
-    ~AWCustomKeysHelper() override;
+    ~AWCustomKeysHelper() override = default;
     // get
     [[nodiscard]] QString source(const QString &_key) const;
     [[nodiscard]] QStringList sources() const;
@@ -39,9 +37,4 @@ public:
     void editPairs() override{};
     QStringList leftKeys() override;
     QStringList rightKeys() override;
-
-private:
 };
-
-
-#endif /* AWCUSTOMKEYSHELPER_H */

sources/awesome-widget/plugin/awdataaggregator.cpp

@@ -50,7 +50,8 @@ AWDataAggregator::~AWDataAggregator()
 {
     qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
 
-    delete m_toolTipScene;
+    m_toolTipView->deleteLater();
+    m_toolTipScene->deleteLater();
 }
 
 
@@ -84,26 +85,26 @@ void AWDataAggregator::setParameters(const QVariantMap &_settings)
     // resize tooltip image
     m_toolTipView->resize(100 * m_counts, 105);
 
-    requiredKeys.clear();
+    m_requiredKeys.clear();
     if (m_configuration["cpuTooltip"].toBool())
-        requiredKeys.append("cpuTooltip");
+        m_requiredKeys.append("cpuTooltip");
     if (m_configuration["cpuclTooltip"].toBool())
-        requiredKeys.append("cpuclTooltip");
+        m_requiredKeys.append("cpuclTooltip");
     if (m_configuration["memTooltip"].toBool())
-        requiredKeys.append("memTooltip");
+        m_requiredKeys.append("memTooltip");
     if (m_configuration["swapTooltip"].toBool())
-        requiredKeys.append("swapTooltip");
+        m_requiredKeys.append("swapTooltip");
     if (m_configuration["downkbTooltip"].toBool())
-        requiredKeys.append("downkbTooltip");
+        m_requiredKeys.append("downkbTooltip");
     if (m_configuration["upkbTooltip"].toBool())
-        requiredKeys.append("upkbTooltip");
+        m_requiredKeys.append("upkbTooltip");
     if (m_configuration["batTooltip"].toBool())
-        requiredKeys.append("batTooltip");
+        m_requiredKeys.append("batTooltip");
 
     // background
     m_toolTipScene->setBackgroundBrush(m_configuration["useTooltipBackground"].toBool()
-                                           ? QBrush(QColor(m_configuration["tooltipBackground"].toString()))
+                                           ? QColor(m_configuration["tooltipBackground"].toString())
-                                           : QBrush(Qt::NoBrush));
+                                           : Qt::NoBrush);
 }
 
 
@@ -112,34 +113,42 @@ QPixmap AWDataAggregator::tooltipImage()
     // create image
     m_toolTipScene->clear();
     QPen pen;
-    bool down = false;
+    auto shift = 0.0;
-    for (auto &key : requiredKeys) {
+
+    for (auto i = 0; i < m_requiredKeys.count(); ++i) {
+        auto key = m_requiredKeys[i];
+
         // create frame
-        float normX = 100.0f / static_cast<float>(m_values[key].count());
+        auto normX = 100.0 / static_cast<float>(m_values[key].count());
-        float normY = 100.0f / (1.5f * m_boundaries[key]);
+        auto normY = 100.0 / (1.5 * m_boundaries[key]);
-        float shift = static_cast<float>(requiredKeys.indexOf(key)) * 100.0f;
+
-        if (down)
-            shift -= 100.0;
         // apply pen color
         if (key != "batTooltip")
-            pen.setColor(QColor(m_configuration[QString("%1Color").arg(key)].toString()));
+            pen.setColor(m_configuration[QString("%1Color").arg(key)].toString());
+
         // paint data inside frame
         for (int j = 0; j < m_values[key].count() - 1; j++) {
             // some magic here
-            float x1 = j * normX + shift;
+            auto x1 = j * normX + shift;
-            float y1 = -std::fabs(m_values[key].at(j)) * normY + 5.0f;
+            auto y1 = -std::fabs(m_values[key].at(j)) * normY + 5.0;
-            float x2 = (j + 1) * normX + shift;
+            auto x2 = (j + 1) * normX + shift;
-            float y2 = -std::fabs(m_values[key].at(j + 1)) * normY + 5.0f;
+            auto y2 = -std::fabs(m_values[key].at(j + 1)) * normY + 5.0;
+            // apply color for the battery tooltip based on charge/discharge
             if (key == "batTooltip") {
                 if (m_values[key].at(j + 1) > 0)
                     pen.setColor(QColor(m_configuration["batTooltipColor"].toString()));
                 else
                     pen.setColor(QColor(m_configuration["batInTooltipColor"].toString()));
             }
+
             m_toolTipScene->addLine(x1, y1, x2, y2, pen);
         }
-        if (key == "downkbTooltip")
+
-            down = true;
+        // increase frame shift if not downkbtooltip
+        // Additional workaround is required because there is frame (uokb and downkb) which contains two charts
+        // with the same shift
+        if (key != "downkbTooltip")
+            shift += 100.0;
     }
 
     return m_toolTipView->grab();
@@ -154,7 +163,7 @@ void AWDataAggregator::dataUpdate(const QVariantHash &_values)
 }
 
 
-void AWDataAggregator::checkValue(const QString &_source, const float _value, const float _extremum) const
+void AWDataAggregator::checkValue(const QString &_source, const double _value, const double _extremum) const
 {
     qCDebug(LOG_AW) << "Notification source" << _source << "with value" << _value << "called with extremum"
                     << _extremum;
@@ -227,25 +236,27 @@ void AWDataAggregator::setData(const QVariantHash &_values)
 {
     // do not log these arguments
     // battery update requires info is AC online or not
-    setData(_values["ac"].toString() == m_configuration["acOnline"], "batTooltip", _values["bat"].toFloat());
+    setData(_values["ac"].toString() == m_configuration["acOnline"], "batTooltip", _values["bat"].toDouble());
+
     // usual case
-    setData("cpuTooltip", _values["cpu"].toFloat(), 90.0);
+    setData("cpuTooltip", _values["cpu"].toDouble(), 90.0);
-    setData("cpuclTooltip", _values["cpucl"].toFloat());
+    setData("cpuclTooltip", _values["cpucl"].toDouble());
-    setData("memTooltip", _values["mem"].toFloat(), 80.0);
+    setData("memTooltip", _values["mem"].toDouble(), 80.0);
-    setData("swapTooltip", _values["swap"].toFloat(), 0.0);
+    setData("swapTooltip", _values["swap"].toDouble(), 0.0);
-    setData("downkbTooltip", _values["downkb"].toFloat());
+    setData("downkbTooltip", _values["downkb"].toDouble());
-    setData("upkbTooltip", _values["upkb"].toFloat());
+    setData("upkbTooltip", _values["upkb"].toDouble());
+
     // additional check for network device
-    [this](const QString &value) {
+    auto currentNetworkDevice = _values["netdev"].toString();
-        checkValue("netdev", m_currentNetworkDevice, value);
+    checkValue("netdev", m_currentNetworkDevice, currentNetworkDevice);
-        m_currentNetworkDevice = value;
+    m_currentNetworkDevice = currentNetworkDevice;
-    }(_values["netdev"].toString());
+
     // additional check for GPU load
-    [this](const float value) { checkValue("gpu", value, 90.0); }(_values["gpu"].toFloat());
+    checkValue("gpu", _values["gpu"].toDouble(), 90.0);
 }
 
 
-void AWDataAggregator::setData(const QString &_source, float _value, const float _extremum)
+void AWDataAggregator::setData(const QString &_source, double _value, const double _extremum)
 {
     qCDebug(LOG_AW) << "Source" << _source << "to value" << _value << "with extremum" << _extremum;
 
@@ -261,16 +272,20 @@ void AWDataAggregator::setData(const QString &_source, float _value, const float
 
     m_values[_source].append(_value);
     if (_source == "downkbTooltip") {
-        QList<float> netValues = m_values["downkbTooltip"] + m_values["upkbTooltip"];
+        // to avoid copying of objects to another list we find max elements in each sequence and compare them
-        // to avoid inf value of normY
+        auto downMax = m_values["downkbTooltip"].empty()
-        netValues << 1.0;
+                           ? 1.0
-        m_boundaries["downkbTooltip"] = 1.2f * *std::max_element(netValues.cbegin(), netValues.cend());
+                           : *std::max_element(m_values["downkbTooltip"].cbegin(), m_values["downkbTooltip"].cend());
-        m_boundaries["upkbTooltip"] = m_boundaries["downkbTooltip"];
+        auto upMax = m_values["upkbTooltip"].empty()
+                         ? 1.0
+                         : *std::max_element(m_values["upkbTooltip"].cbegin(), m_values["upkbTooltip"].cend());
+        // assign both
+        m_boundaries["upkbTooltip"] = m_boundaries["downkbTooltip"] = 1.2 * std::max(downMax, upMax);
     }
 }
 
 
-void AWDataAggregator::setData(const bool _dontInvert, const QString &_source, float _value)
+void AWDataAggregator::setData(const bool _dontInvert, const QString &_source, double _value)
 {
     qCDebug(LOG_AW) << "Do not invert" << _dontInvert << "value" << _value << "for source" << _source;
 

sources/awesome-widget/plugin/awdataaggregator.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWTOOLTIP_H
-#define AWTOOLTIP_H
 
 #include <QObject>
 #include <QVariant>
@@ -26,7 +24,6 @@
 class QGraphicsScene;
 class QGraphicsView;
 class QPixmap;
-class QThreadPool;
 
 class AWDataAggregator : public QObject
 {
@@ -49,25 +46,22 @@ private:
     // ui
     QGraphicsScene *m_toolTipScene = nullptr;
     QGraphicsView *m_toolTipView = nullptr;
-    void checkValue(const QString &_source, float _value, float _extremum) const;
+    void checkValue(const QString &_source, double _value, double _extremum) const;
     void checkValue(const QString &_source, const QString &_current, const QString &_received) const;
     void initScene();
     static QString notificationText(const QString &_source, float _value);
     static QString notificationText(const QString &_source, const QString &_value);
     // main method
     void setData(const QVariantHash &_values);
-    void setData(const QString &_source, float _value, float _extremum = -1.0f);
+    void setData(const QString &_source, double _value, double _extremum = -1.0);
     // different signature for battery device
-    void setData(bool _dontInvert, const QString &_source, float _value);
+    void setData(bool _dontInvert, const QString &_source, double _value);
     // variables
     int m_counts = 0;
     QVariantHash m_configuration;
     QString m_currentNetworkDevice = "lo";
-    QHash<QString, float> m_boundaries;
+    QHash<QString, double> m_boundaries;
-    QHash<QString, QList<float>> m_values;
+    QHash<QString, QList<double>> m_values;
     bool m_enablePopup = false;
-    QStringList requiredKeys;
+    QStringList m_requiredKeys;
 };
-
-
-#endif /* AWTOOLTIP_H */

sources/awesome-widget/plugin/awdataengineaggregator.cpp

@@ -139,7 +139,7 @@ void AWDataEngineAggregator::sensorRemoved(const QString &_sensor)
 }
 
 
-void AWDataEngineAggregator::updateData(KSysGuard::SensorDataList _data)
+void AWDataEngineAggregator::updateData(const KSysGuard::SensorDataList &_data)
 {
     emit(dataUpdated(m_sensors, _data));
 }
@@ -147,9 +147,9 @@ void AWDataEngineAggregator::updateData(KSysGuard::SensorDataList _data)
 
 void AWDataEngineAggregator::updateSensors(const QHash<QString, KSysGuard::SensorInfo> &_sensors)
 {
-    for (auto sensor = _sensors.cbegin(); sensor != _sensors.cend(); ++sensor) {
+    for (auto [source, sensor] : _sensors.asKeyValueRange()) {
-        if (!isValidSensor(sensor.value()))
+        if (!isValidSensor(sensor))
             continue;
-        m_sensors.insert(sensor.key(), sensor.value());
+        m_sensors.insert(source, sensor);
     }
 }

sources/awesome-widget/plugin/awdataengineaggregator.h

@@ -49,7 +49,7 @@ public slots:
     void dropSource(const QString &_source);
     void sensorAdded(const QString &_sensor);
     void sensorRemoved(const QString &_sensor);
-    void updateData(KSysGuard::SensorDataList _data);
+    void updateData(const KSysGuard::SensorDataList &_data);
     void updateSensors(const QHash<QString, KSysGuard::SensorInfo> &_sensors);
 
 private:

sources/awesome-widget/plugin/awdataenginemapper.cpp

@@ -52,12 +52,6 @@ AWDataEngineMapper::AWDataEngineMapper(QObject *_parent, AWFormatterHelper *_cus
 }
 
 
-AWDataEngineMapper::~AWDataEngineMapper()
-{
-    qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
-}
-
-
 AWKeysAggregator::FormatterType AWDataEngineMapper::formatter(const QString &_key) const
 {
     qCDebug(LOG_AW) << "Get formatter for key" << _key;
@@ -82,18 +76,18 @@ QStringList AWDataEngineMapper::registerSource(const QString &_source, const KSy
     qCDebug(LOG_AW) << "Source" << _source << "with units" << _units;
 
     // regular expressions
-    auto cpuRegExp = QRegularExpression("^cpu/cpu.*/usage$");
+    static auto cpuRegExp = QRegularExpression("^cpu/cpu.*/usage$");
-    auto cpuclRegExp = QRegularExpression("^cpu/cpu.*/frequency$");
+    static auto cpuclRegExp = QRegularExpression("^cpu/cpu.*/frequency$");
-    auto cpuTempRegExp = QRegularExpression("^cpu/cpu.*/temperature$");
+    static auto cpuTempRegExp = QRegularExpression("^cpu/cpu.*/temperature$");
-    auto gpuRegExp = QRegularExpression("^gpu/gpu.*/usage$");
+    static auto gpuRegExp = QRegularExpression("^gpu/gpu.*/usage$");
-    auto gpuTempRegExp = QRegularExpression("^gpu/gpu.*/temperature$");
+    static auto gpuTempRegExp = QRegularExpression("^gpu/gpu.*/temperature$");
-    auto hddrRegExp = QRegularExpression("^disk/.*/read$");
+    static auto hddrRegExp = QRegularExpression("^disk/.*/read$");
-    auto hddwRegExp = QRegularExpression("^disk/.*/write$");
+    static auto hddwRegExp = QRegularExpression("^disk/.*/write$");
-    auto mountFillRegExp = QRegularExpression("^disk/.*/usedPercent$");
+    static auto mountFillRegExp = QRegularExpression("^disk/.*/usedPercent$");
-    auto mountFreeRegExp = QRegularExpression("^disk/.*/free$");
+    static auto mountFreeRegExp = QRegularExpression("^disk/.*/free$");
-    auto mountUsedRegExp = QRegularExpression("^disk/.*/used$");
+    static auto mountUsedRegExp = QRegularExpression("^disk/.*/used$");
-    auto netRegExp = QRegularExpression("^network/.*/(download|upload)$");
+    static auto netRegExp = QRegularExpression("^network/.*/(download|upload)$");
-    auto netTotalRegExp = QRegularExpression("^network/.*/(totalDownload|totalUpload)$");
+    static auto netTotalRegExp = QRegularExpression("^network/.*/(totalDownload|totalUpload)$");
 
     if (_source == "extsysmon/battery/ac") {
         // AC
@@ -153,7 +147,7 @@ QStringList AWDataEngineMapper::registerSource(const QString &_source, const KSy
         if (index > -1) {
             QString key = QString("hddr%1").arg(index);
             m_map.insert(_source, key);
-            m_formatter[key] = AWKeysAggregator::FormatterType::Integer;
+            m_formatter[key] = AWKeysAggregator::FormatterType::MemKBFormat;
         }
     } else if (_source.contains(hddwRegExp)) {
         // write speed
@@ -163,7 +157,7 @@ QStringList AWDataEngineMapper::registerSource(const QString &_source, const KSy
         if (index > -1) {
             QString key = QString("hddw%1").arg(index);
             m_map.insert(_source, key);
-            m_formatter[key] = AWKeysAggregator::FormatterType::Integer;
+            m_formatter[key] = AWKeysAggregator::FormatterType::MemKBFormat;
         }
     } else if (_source == "gpu/all/usage") {
         // gpu load
@@ -209,7 +203,7 @@ QStringList AWDataEngineMapper::registerSource(const QString &_source, const KSy
         auto index = m_devices["mount"].indexOf(device);
         if (index > -1) {
             // mb
-            QString key = QString("hddfreemb%1").arg(index);
+            auto key = QString("hddfreemb%1").arg(index);
             m_map.insert(_source, key);
             m_formatter[key] = AWKeysAggregator::FormatterType::MemMBFormat;
             // gb
@@ -224,7 +218,7 @@ QStringList AWDataEngineMapper::registerSource(const QString &_source, const KSy
         auto index = m_devices["mount"].indexOf(device);
         if (index > -1) {
             // mb
-            QString key = QString("hddmb%1").arg(index);
+            auto key = QString("hddmb%1").arg(index);
             m_map.insert(_source, key);
             m_formatter[key] = AWKeysAggregator::FormatterType::MemMBFormat;
             // gb
@@ -285,7 +279,7 @@ QStringList AWDataEngineMapper::registerSource(const QString &_source, const KSy
             // kb
             auto key = QString("%1kb%2").arg(type).arg(index);
             m_map.insert(_source, key);
-            m_formatter[key] = AWKeysAggregator::FormatterType::Integer;
+            m_formatter[key] = AWKeysAggregator::FormatterType::MemKBFormat;
             // smart
             key = QString("%1%2").arg(type).arg(index);
             m_map.insert(_source, key);
@@ -303,7 +297,7 @@ QStringList AWDataEngineMapper::registerSource(const QString &_source, const KSy
             // kb
             auto key = QString("%1totkb%2").arg(type).arg(index);
             m_map.insert(_source, key);
-            m_formatter[key] = AWKeysAggregator::FormatterType::Integer;
+            m_formatter[key] = AWKeysAggregator::FormatterType::MemKBFormat;
             // mb
             key = QString("%1tot%2").arg(type).arg(index);
             m_map.insert(_source, key);
@@ -435,7 +429,7 @@ QStringList AWDataEngineMapper::registerSource(const QString &_source, const KSy
 
     // drop key from dictionary if no one user requested key required it
     qCInfo(LOG_AW) << "Looking for keys" << foundKeys << "in" << _keys;
-    auto required = _keys.isEmpty() || std::any_of(foundKeys.cbegin(), foundKeys.cend(), [&_keys](const QString &key) {
+    auto required = _keys.isEmpty() || std::any_of(foundKeys.cbegin(), foundKeys.cend(), [&_keys](auto &key) {
                         return _keys.contains(key);
                     });
     if (!required) {

sources/awesome-widget/plugin/awdataenginemapper.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWDATAENGINEMAPPER_H
-#define AWDATAENGINEMAPPER_H
 
 #include <ksysguard/formatter/Unit.h>
 
@@ -35,12 +33,12 @@ class AWDataEngineMapper : public QObject
 
 public:
     explicit AWDataEngineMapper(QObject *_parent = nullptr, AWFormatterHelper *_custom = nullptr);
-    ~AWDataEngineMapper() override;
+    ~AWDataEngineMapper() override = default;
     // get methods
     [[nodiscard]] AWKeysAggregator::FormatterType formatter(const QString &_key) const;
     [[nodiscard]] QStringList keysFromSource(const QString &_source) const;
     // set methods
-    QStringList registerSource(const QString &_source, const KSysGuard::Unit _units, const QStringList &_keys);
+    QStringList registerSource(const QString &_source, KSysGuard::Unit _units, const QStringList &_keys);
     void setDevices(const QHash<QString, QStringList> &_devices);
 
 private:
@@ -50,6 +48,3 @@ private:
     QHash<QString, AWKeysAggregator::FormatterType> m_formatter;
     QMultiHash<QString, QString> m_map;
 };
-
-
-#endif /* AWDATAENGINEMAPPER_H */

sources/awesome-widget/plugin/awdbusadaptor.cpp

@@ -32,27 +32,20 @@ AWDBusAdaptor::AWDBusAdaptor(AWKeys *_parent)
 }
 
 
-AWDBusAdaptor::~AWDBusAdaptor()
-{
-    qCDebug(LOG_DBUS) << __PRETTY_FUNCTION__;
-}
-
-
 QStringList AWDBusAdaptor::ActiveServices()
 {
-    QDBusMessage listServices = QDBusConnection::sessionBus().interface()->call(QDBus::BlockWithGui, "ListNames");
+    auto listServices = QDBusConnection::sessionBus().interface()->call(QDBus::BlockWithGui, "ListNames");
     if (listServices.arguments().isEmpty()) {
         qCWarning(LOG_DBUS) << "Could not find any DBus service";
         return {};
     }
-    QStringList arguments = listServices.arguments().first().toStringList();
+    auto arguments = listServices.arguments().first().toStringList();
 
-    return std::accumulate(arguments.cbegin(), arguments.cend(), QStringList(),
+    return std::accumulate(arguments.cbegin(), arguments.cend(), QStringList(), [](auto source, auto &service) {
-                           [](QStringList source, const QString &service) {
+        if (service.startsWith(AWDBUS_SERVICE))
-                               if (service.startsWith(AWDBUS_SERVICE))
+            source.append(service);
-                                   source.append(service);
+        return source;
-                               return source;
+    });
-                           });
 }
 
 
@@ -103,6 +96,6 @@ void AWDBusAdaptor::SetLogLevel(const QString &what, const QString &level, const
         return;
     }
 
-    QString state = enabled ? "true" : "false";
+    auto state = enabled ? "true" : "false";
-    QLoggingCategory::setFilterRules(QString("%1.%2=%3").arg(what).arg(level).arg(state));
+    QLoggingCategory::setFilterRules(QString("%1.%2=%3").arg(what, level, state));
 }

sources/awesome-widget/plugin/awdbusadaptor.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWDBUSADAPTOR_H
-#define AWDBUSADAPTOR_H
 
 #include <QDBusAbstractAdaptor>
 
@@ -33,7 +31,7 @@ class AWDBusAdaptor : public QDBusAbstractAdaptor
 
 public:
     explicit AWDBusAdaptor(AWKeys *_parent = nullptr);
-    ~AWDBusAdaptor() override;
+    ~AWDBusAdaptor() override = default;
 
 public slots:
     // get methods
@@ -50,6 +48,3 @@ private:
     AWKeys *m_plugin = nullptr;
     QStringList m_logLevels = {"debug", "info", "warning", "critical"};
 };
-
-
-#endif /* AWDBUSADAPTOR_H */

sources/awesome-widget/plugin/awesomewidget.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWPLUGIN_H
-#define AWPLUGIN_H
 
 #include <QQmlExtensionPlugin>
 
@@ -30,6 +28,3 @@ class AWPlugin : public QQmlExtensionPlugin
 public:
     void registerTypes(const char *uri) override;
 };
-
-
-#endif /* AWPLUGIN_H */

sources/awesome-widget/plugin/awformatterconfig.cpp

@@ -27,11 +27,5 @@ AWFormatterConfig::AWFormatterConfig(QWidget *_parent, const QStringList &_keys)
     qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
 
     setEditable(false, false);
-    initHelper<AWFormatterHelper>();
+    setHelper(std::make_unique<AWFormatterHelper>());
-}
-
-
-AWFormatterConfig::~AWFormatterConfig()
-{
-    qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
 }

sources/awesome-widget/plugin/awformatterconfig.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWFORMATTERCONFIG_H
-#define AWFORMATTERCONFIG_H
 
 #include "awabstractpairconfig.h"
 
@@ -28,8 +26,5 @@ class AWFormatterConfig : public AWAbstractPairConfig
 
 public:
     explicit AWFormatterConfig(QWidget *_parent = nullptr, const QStringList &_keys = QStringList());
-    ~AWFormatterConfig() override;
+    ~AWFormatterConfig() override = default;
 };
-
-
-#endif /* AWFORMATTERCONFIG_H */

sources/awesome-widget/plugin/awformatterhelper.cpp

@@ -33,7 +33,7 @@
 #include "awstringformatter.h"
 
 
-AWFormatterHelper::AWFormatterHelper(QWidget *_parent)
+AWFormatterHelper::AWFormatterHelper(QObject *_parent)
     : AbstractExtItemAggregator(_parent, "formatters")
     , AWAbstractPairHelper("awesomewidgets/formatters/formatters.ini", "Formatters")
 {
@@ -58,8 +58,7 @@ void AWFormatterHelper::initItems()
 
     // assign internal storage
     m_formatters.clear();
-    for (auto &key : pairs().keys()) {
+    for (auto [key, name] : pairs().asKeyValueRange()) {
-        auto name = pairs()[key];
         if (!m_formattersClasses.contains(name)) {
             qCWarning(LOG_AW) << "Invalid formatter" << name << "found in" << key;
             continue;
@@ -87,7 +86,7 @@ QStringList AWFormatterHelper::definedFormatters() const
 QList<AbstractExtItem *> AWFormatterHelper::items() const
 {
     QList<AbstractExtItem *> converted;
-    for (auto &item : m_formattersClasses.values())
+    for (auto item : m_formattersClasses.values())
         converted.append(item);
 
     return converted;
@@ -123,7 +122,7 @@ AWAbstractFormatter::FormatterClass AWFormatterHelper::defineFormatterClass(cons
 {
     qCDebug(LOG_AW) << "Define formatter class for" << _stringType;
 
-    AWAbstractFormatter::FormatterClass formatter = AWAbstractFormatter::FormatterClass::NoFormat;
+    auto formatter = AWAbstractFormatter::FormatterClass::NoFormat;
     if (_stringType == "DateTime")
         formatter = AWAbstractFormatter::FormatterClass::DateTime;
     else if (_stringType == "Float")
@@ -151,17 +150,17 @@ void AWFormatterHelper::initFormatters()
 
     auto dirs = directories();
     for (auto &dir : dirs) {
-        QStringList files = QDir(dir).entryList(QDir::Files, QDir::Name);
+        auto files = QDir(dir).entryList(QDir::Files, QDir::Name);
         for (auto &file : files) {
             // check filename
             if (!file.endsWith(".desktop"))
                 continue;
             qCInfo(LOG_AW) << "Found file" << file << "in" << dir;
-            QString filePath = QString("%1/%2").arg(dir).arg(file);
+            auto filePath = QString("%1/%2").arg(dir, file);
             // check if already exists
             auto values = m_formattersClasses.values();
             if (std::any_of(values.cbegin(), values.cend(),
-                            [&filePath](const AWAbstractFormatter *item) { return (item->fileName() == filePath); }))
+                            [&filePath](auto item) { return (item->filePath() == filePath); }))
                 continue;
 
             auto metadata = readMetadata(filePath);
@@ -198,13 +197,14 @@ QPair<QString, AWAbstractFormatter::FormatterClass> AWFormatterHelper::readMetad
     qCDebug(LOG_AW) << "Read initial parameters from" << _filePath;
 
     QSettings settings(_filePath, QSettings::IniFormat);
+
     settings.beginGroup("Desktop Entry");
     auto name = settings.value("Name", _filePath).toString();
     auto type = settings.value("X-AW-Type", "NoFormat").toString();
     auto formatter = defineFormatterClass(type);
     settings.endGroup();
 
-    return QPair<QString, AWAbstractFormatter::FormatterClass>(name, formatter);
+    return {name, formatter};
 }
 
 
@@ -219,7 +219,7 @@ void AWFormatterHelper::doCreateItem(QListWidget *_widget)
     }
 
     qCInfo(LOG_AW) << "Selected type" << select;
-    AWAbstractFormatter::FormatterClass formatter = defineFormatterClass(select);
+    auto formatter = defineFormatterClass(select);
     switch (formatter) {
     case AWAbstractFormatter::FormatterClass::DateTime:
         return createItem<AWDateTimeFormatter>(_widget);

sources/awesome-widget/plugin/awformatterhelper.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWFORMATTERHELPER_H
-#define AWFORMATTERHELPER_H
 
 #include "abstractextitemaggregator.h"
 #include "awabstractformatter.h"
@@ -29,7 +27,7 @@ class AWFormatterHelper : public AbstractExtItemAggregator, public AWAbstractPai
     Q_OBJECT
 
 public:
-    explicit AWFormatterHelper(QWidget *_parent = nullptr);
+    explicit AWFormatterHelper(QObject *_parent = nullptr);
     ~AWFormatterHelper() override;
     // read-write methods
     void initItems() override;
@@ -56,6 +54,3 @@ private:
     QHash<QString, AWAbstractFormatter *> m_formatters;
     QHash<QString, AWAbstractFormatter *> m_formattersClasses;
 };
-
-
-#endif /* AWFORMATTERHELPER_H */

sources/awesome-widget/plugin/awkeycache.cpp

@@ -44,7 +44,7 @@ bool AWKeyCache::addKeyToCache(const QString &_type, const QString &_key)
     if (_type == "net") {
         auto rawInterfaceList = QNetworkInterface::allInterfaces();
         for (auto &interface : rawInterfaceList) {
-            QString device = interface.name();
+            auto device = interface.name();
             if (cachedValues.contains(device))
                 continue;
             qCInfo(LOG_AW) << "Found new key" << device << "for type" << _type;
@@ -74,10 +74,11 @@ QStringList AWKeyCache::getRequiredKeys(const QStringList &_keys, const QStringL
     used.unite(QSet(_bars.cbegin(), _bars.cend()));
     used.unite(QSet(_userKeys.cbegin(), _userKeys.cend()));
     // insert keys from tooltip
-    for (auto &key : _tooltip.keys()) {
+    for (auto [key, value] : _tooltip.asKeyValueRange()) {
-        if ((key.endsWith("Tooltip")) && (_tooltip[key].toBool())) {
+        if ((key.endsWith("Tooltip")) && value.toBool()) {
-            key.remove("Tooltip");
+            auto local = key;
-            used << key;
+            local.remove("Tooltip");
+            used << local;
         }
     }
 
@@ -133,7 +134,7 @@ QStringList AWKeyCache::getRequiredKeys(const QStringList &_keys, const QStringL
             used << filtered;
     }
     // netdev key
-    if (std::any_of(netKeys.cbegin(), netKeys.cend(), [&used](const QString &key) { return used.contains(key); }))
+    if (std::any_of(netKeys.cbegin(), netKeys.cend(), [&used](auto &key) { return used.contains(key); }))
         used << "netdev";
 
     // HACK append dummy if there are no other keys. This hack is required

sources/awesome-widget/plugin/awkeycache.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWKEYCACHE_H
-#define AWKEYCACHE_H
 
 #include <QHash>
 #include <QString>
@@ -31,6 +29,3 @@ QStringList getRequiredKeys(const QStringList &_keys, const QStringList &_bars,
                             const QStringList &_userKeys, const QStringList &_allKeys);
 QHash<QString, QStringList> loadKeysFromCache();
 } // namespace AWKeyCache
-
-
-#endif /* AWKEYCACHE_H */

sources/awesome-widget/plugin/awkeyoperations.cpp

@@ -40,18 +40,12 @@ AWKeyOperations::AWKeyOperations(QObject *_parent)
     qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
 
     m_customKeys = new AWCustomKeysHelper(this);
-    m_graphicalItems = new ExtItemAggregator<GraphicalItem>(nullptr, "desktops");
+    m_graphicalItems = new ExtItemAggregator<GraphicalItem>(this, "desktops");
-    m_extNetRequest = new ExtItemAggregator<ExtNetworkRequest>(nullptr, "requests");
+    m_extNetRequest = new ExtItemAggregator<ExtNetworkRequest>(this, "requests");
-    m_extQuotes = new ExtItemAggregator<ExtQuotes>(nullptr, "quotes");
+    m_extQuotes = new ExtItemAggregator<ExtQuotes>(this, "quotes");
-    m_extScripts = new ExtItemAggregator<ExtScript>(nullptr, "scripts");
+    m_extScripts = new ExtItemAggregator<ExtScript>(this, "scripts");
-    m_extUpgrade = new ExtItemAggregator<ExtUpgrade>(nullptr, "upgrade");
+    m_extUpgrade = new ExtItemAggregator<ExtUpgrade>(this, "upgrade");
-    m_extWeather = new ExtItemAggregator<ExtWeather>(nullptr, "weather");
+    m_extWeather = new ExtItemAggregator<ExtWeather>(this, "weather");
-}
-
-
-AWKeyOperations::~AWKeyOperations()
-{
-    qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
 }
 
 
@@ -80,7 +74,7 @@ QStringList AWKeyOperations::dictKeys() const
 {
     QStringList allKeys;
     // weather
-    for (auto &item : m_extWeather->activeItems()) {
+    for (auto item : m_extWeather->activeItems()) {
         allKeys.append(item->tag("weatherId"));
         allKeys.append(item->tag("weather"));
         allKeys.append(item->tag("humidity"));
@@ -89,20 +83,20 @@ QStringList AWKeyOperations::dictKeys() const
         allKeys.append(item->tag("timestamp"));
     }
     // cpuclock & cpu
-    for (auto i = 0; i < QThread::idealThreadCount(); i++) {
+    for (auto i = 0; i < QThread::idealThreadCount(); ++i) {
         allKeys.append(QString("cpucl%1").arg(i));
         allKeys.append(QString("cpu%1").arg(i));
     }
     // temperature
-    for (auto i = 0; i < m_devices["temp"].count(); i++)
+    for (auto i = 0; i < m_devices["temp"].count(); ++i)
         allKeys.append(QString("temp%1").arg(i));
     // gpu
-    for (auto i = 0; i < m_devices["gpu"].count(); i++) {
+    for (auto i = 0; i < m_devices["gpu"].count(); ++i) {
         allKeys.append(QString("gpu%1").arg(i));
         allKeys.append(QString("gputemp%1").arg(i));
     }
     // hdd
-    for (auto i = 0; i < m_devices["mount"].count(); i++) {
+    for (auto i = 0; i < m_devices["mount"].count(); ++i) {
         allKeys.append(QString("hddmb%1").arg(i));
         allKeys.append(QString("hddgb%1").arg(i));
         allKeys.append(QString("hddfreemb%1").arg(i));
@@ -112,12 +106,12 @@ QStringList AWKeyOperations::dictKeys() const
         allKeys.append(QString("hdd%1").arg(i));
     }
     // hdd speed
-    for (auto i = 0; i < m_devices["disk"].count(); i++) {
+    for (auto i = 0; i < m_devices["disk"].count(); ++i) {
         allKeys.append(QString("hddr%1").arg(i));
         allKeys.append(QString("hddw%1").arg(i));
     }
     // network
-    for (auto i = 0; i < m_devices["net"].count(); i++) {
+    for (auto i = 0; i < m_devices["net"].count(); ++i) {
         allKeys.append(QString("downunits%1").arg(i));
         allKeys.append(QString("upunits%1").arg(i));
         allKeys.append(QString("downtotkb%1").arg(i));
@@ -132,7 +126,7 @@ QStringList AWKeyOperations::dictKeys() const
     // battery
     auto allBatteryDevices = QDir("/sys/class/power_supply")
                                  .entryList(QStringList({"BAT*"}), QDir::Dirs | QDir::NoDotAndDotDot, QDir::Name);
-    for (int i = 0; i < allBatteryDevices.count(); i++) {
+    for (int i = 0; i < allBatteryDevices.count(); ++i) {
         allKeys.append(QString("bat%1").arg(i));
         allKeys.append(QString("batleft%1").arg(i));
         allKeys.append(QString("batnow%1").arg(i));
@@ -140,10 +134,10 @@ QStringList AWKeyOperations::dictKeys() const
         allKeys.append(QString("battotal%1").arg(i));
     }
     // package manager
-    for (auto &item : m_extUpgrade->activeItems())
+    for (auto item : m_extUpgrade->activeItems())
         allKeys.append(item->tag("pkgcount"));
     // quotes
-    for (auto &item : m_extQuotes->activeItems()) {
+    for (auto item : m_extQuotes->activeItems()) {
         allKeys.append(item->tag("price"));
         allKeys.append(item->tag("pricechg"));
         allKeys.append(item->tag("percpricechg"));
@@ -152,13 +146,13 @@ QStringList AWKeyOperations::dictKeys() const
         allKeys.append(item->tag("percvolumechg"));
     }
     // custom
-    for (auto &item : m_extScripts->activeItems())
+    for (auto item : m_extScripts->activeItems())
         allKeys.append(item->tag("custom"));
     // network requests
-    for (auto &item : m_extNetRequest->activeItems())
+    for (auto item : m_extNetRequest->activeItems())
         allKeys.append(item->tag("response"));
     // bars
-    for (auto &item : m_graphicalItems->activeItems())
+    for (auto item : m_graphicalItems->activeItems())
         allKeys.append(item->tag("bar"));
     // user defined keys
     allKeys.append(m_customKeys->keys());
@@ -205,40 +199,50 @@ QString AWKeyOperations::infoByKey(const QString &_key) const
 {
     qCDebug(LOG_AW) << "Requested key" << _key;
 
+    static auto numberRegExp = QRegularExpression("\\d+");
+
     auto stripped = _key;
-    stripped.remove(QRegularExpression("\\d+"));
+    stripped.remove(numberRegExp);
     QString output;
 
+    static auto hddRegExp = QRegularExpression("^hdd(|mb|gb|freemb|freegb|totmb|totgb)");
+    static auto hddrwRegExp = QRegularExpression("^hdd[rw]");
+    static auto hddMatchRegExp = QRegularExpression("^hdd([0-9]|mb|gb|freemb|freegb|totmb|totgb)");
+    static auto netRegExp = QRegularExpression("^(down|up)");
+    static auto netMatchRegExp = QRegularExpression("^(down|up)[0-9]");
+    static auto quotesRegExp = QRegularExpression("^(|perc)(ask|bid|price)(chg|)");
+    static auto weatherRegExp = QRegularExpression("^(weather|weatherId|humidity|pressure|temperature)");
+
     if (_key.startsWith("bar")) {
-        auto *item = m_graphicalItems->itemByTag(_key, stripped);
+        auto item = m_graphicalItems->itemByTag(_key, stripped);
         if (item)
             output = item->uniq();
     } else if (_key.startsWith("custom")) {
-        auto *item = m_extScripts->itemByTag(_key, stripped);
+        auto item = m_extScripts->itemByTag(_key, stripped);
         if (item)
             output = item->uniq();
-    } else if (_key.contains(QRegularExpression("^hdd[rw]"))) {
+    } else if (_key.contains(hddrwRegExp)) {
         auto index = _key;
-        index.remove(QRegularExpression("hdd[rw]"));
+        index.remove(hddrwRegExp);
         output = m_devices["disk"][index.toInt()];
-    } else if (_key.contains(QRegularExpression("^hdd([0-9]|mb|gb|freemb|freegb|totmb|totgb)"))) {
+    } else if (_key.contains(hddMatchRegExp)) {
         auto index = _key;
-        index.remove(QRegularExpression("^hdd(|mb|gb|freemb|freegb|totmb|totgb)"));
+        index.remove(hddRegExp);
         output = m_devices["mount"][index.toInt()];
-    } else if (_key.contains(QRegularExpression("^(down|up)[0-9]"))) {
+    } else if (_key.contains(netMatchRegExp)) {
         auto index = _key;
-        index.remove(QRegularExpression("^(down|up)"));
+        index.remove(netRegExp);
         output = m_devices["net"][index.toInt()];
     } else if (_key.startsWith("pkgcount")) {
-        auto *item = m_extUpgrade->itemByTag(_key, stripped);
+        auto item = m_extUpgrade->itemByTag(_key, stripped);
         if (item)
             output = item->uniq();
-    } else if (_key.contains(QRegularExpression("(^|perc)(ask|bid|price)(chg|)"))) {
+    } else if (_key.contains(quotesRegExp)) {
-        auto *item = m_extQuotes->itemByTag(_key, stripped);
+        auto item = m_extQuotes->itemByTag(_key, stripped);
         if (item)
             output = item->uniq();
-    } else if (_key.contains(QRegularExpression("(weather|weatherId|humidity|pressure|temperature)"))) {
+    } else if (_key.contains(weatherRegExp)) {
-        auto *item = m_extWeather->itemByTag(_key, stripped);
+        auto item = m_extWeather->itemByTag(_key, stripped);
         if (item)
             output = item->uniq();
     } else if (_key.startsWith("temp")) {
@@ -246,7 +250,7 @@ QString AWKeyOperations::infoByKey(const QString &_key) const
         index.remove("temp");
         output = m_devices["temp"][index.toInt()];
     } else if (_key.startsWith("response")) {
-        auto *item = m_extNetRequest->itemByTag(_key, stripped);
+        auto item = m_extNetRequest->itemByTag(_key, stripped);
         if (item)
             output = item->uniq();
     } else {
@@ -275,8 +279,10 @@ void AWKeyOperations::editItem(const QString &_type)
 {
     qCDebug(LOG_AW) << "Item type" << _type;
 
+    static auto supportsGraphicalRegExp = QRegularExpression("^(cpu(?!cl).*|gpu$|mem$|swap$|hdd[0-9].*|bat.*)");
+
     if (_type == "graphicalitem") {
-        QStringList keys = dictKeys().filter(QRegularExpression("^(cpu(?!cl).*|gpu$|mem$|swap$|hdd[0-9].*|bat.*)"));
+        auto keys = dictKeys().filter(supportsGraphicalRegExp);
         keys.sort();
         m_graphicalItems->setConfigArgs(keys);
         return m_graphicalItems->editItems();
@@ -298,10 +304,10 @@ void AWKeyOperations::addDevice(const QString &_source)
 {
     qCDebug(LOG_AW) << "Source" << _source;
 
-    auto diskRegexp = QRegularExpression("^disk/.*/read$");
+    static auto diskRegexp = QRegularExpression("^disk/.*/read$");
-    auto mountRegexp = QRegularExpression("^disk/.*/usedPercent$");
+    static auto mountRegexp = QRegularExpression("^disk/.*/usedPercent$");
-    auto cpuTempRegExp = QRegularExpression("^cpu/cpu.*/temperature$");
+    static auto cpuTempRegExp = QRegularExpression("^cpu/cpu.*/temperature$");
-    auto gpuRegExp = QRegularExpression("^gpu/gpu.*/usage$");
+    static auto gpuRegExp = QRegularExpression("^gpu/gpu.*/usage$");
 
     if (_source.contains(diskRegexp)) {
         auto device = _source;
@@ -344,7 +350,7 @@ void AWKeyOperations::reinitKeys()
     m_extWeather->initItems();
 
     // init
-    QStringList allKeys = dictKeys();
+    auto allKeys = dictKeys();
 
     // apply aw_* functions
     m_pattern = AWPatternFunctions::insertAllKeys(m_pattern, allKeys);

sources/awesome-widget/plugin/awkeyoperations.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWKEYOPERATIONS_H
-#define AWKEYOPERATIONS_H
 
 #include <QObject>
 
@@ -39,7 +37,7 @@ class AWKeyOperations : public QObject
 
 public:
     explicit AWKeyOperations(QObject *_parent = nullptr);
-    ~AWKeyOperations() override;
+    ~AWKeyOperations() override = default;
     [[nodiscard]] QStringList devices(const QString &_type) const;
     [[nodiscard]] QHash<QString, QStringList> devices() const;
     void updateCache();
@@ -78,6 +76,3 @@ private:
     QHash<QString, QStringList> m_devices;
     QString m_pattern;
 };
-
-
-#endif /* AWKEYOPERATIONS_H */

sources/awesome-widget/plugin/awkeys.cpp

@@ -19,9 +19,8 @@
 
 #include <QDBusConnection>
 #include <QDBusError>
-#include <QThread>
+#include <QRegularExpression>
 #include <QTimer>
-#include <QtConcurrent/QtConcurrent>
 
 #include "awdataaggregator.h"
 #include "awdataengineaggregator.h"
@@ -42,9 +41,6 @@ AWKeys::AWKeys(QObject *_parent)
     for (auto &metadata : AWDebug::getBuildData())
         qCDebug(LOG_AW) << metadata;
 
-    // thread pool
-    m_threadPool = new QThreadPool(this);
-
     m_aggregator = new AWKeysAggregator(this);
     m_dataAggregator = new AWDataAggregator(this);
     m_dataEngineAggregator = new AWDataEngineAggregator(this);
@@ -91,14 +87,12 @@ void AWKeys::initDataAggregator(const QVariantMap &_tooltipParams)
 }
 
 
-void AWKeys::initKeys(const QString &_currentPattern, const int _interval, const int _limit, const bool _optimize)
+void AWKeys::initKeys(const QString &_currentPattern, const int _interval, const bool _optimize)
 {
-    qCDebug(LOG_AW) << "Pattern" << _currentPattern << "with interval" << _interval << "and queue limit" << _limit
+    qCDebug(LOG_AW) << "Pattern" << _currentPattern << "with interval" << _interval << "with optimization" << _optimize;
-                    << "with optimization" << _optimize;
 
     // init
     m_optimize = _optimize;
-    m_threadPool->setMaxThreadCount(_limit == 0 ? QThread::idealThreadCount() : _limit);
     // child objects
     m_aggregator->initFormatters();
     m_keyOperator->setPattern(_currentPattern);
@@ -153,26 +147,6 @@ QStringList AWKeys::dictKeys(const bool _sorted, const QString &_regexp) const
 }
 
 
-QVariantList AWKeys::getHddDevices() const
-{
-    QStringList hddDevices = m_keyOperator->devices("hdd");
-    // required by selector in the UI
-    hddDevices.insert(0, "disable");
-    hddDevices.insert(0, "auto");
-
-    // build model
-    QVariantList devices;
-    for (auto &device : hddDevices) {
-        QVariantMap model;
-        model["label"] = device;
-        model["name"] = device;
-        devices.append(model);
-    }
-
-    return devices;
-}
-
-
 QString AWKeys::infoByKey(const QString &_key) const
 {
     qCDebug(LOG_AW) << "Requested info for key" << _key;
@@ -202,12 +176,13 @@ void AWKeys::editItem(const QString &_type)
 
 void AWKeys::dataUpdated(const QHash<QString, KSysGuard::SensorInfo> &_sensors, const KSysGuard::SensorDataList &_data)
 {
-    for (auto &single : _data) {
+    qCDebug(LOG_AW) << "Update data for" << _data.count() << "items";
-        if (_sensors.contains(single.sensorProperty)) {
+
-            setDataBySource(single.sensorProperty, _sensors.value(single.sensorProperty), single);
+    for (auto &data : _data) {
-        }
+        if (!_sensors.contains(data.sensorProperty))
-        // TODO use QtConcurrent::map or something like that
+            continue;
-        //        QtConcurrent::run(m_threadPool, this, &AWKeys::setDataBySource, "ss", sensor);
+        auto sensor = _sensors[data.sensorProperty];
+        setDataBySource(data.sensorProperty, sensor, data.payload);
     }
 }
 
@@ -223,7 +198,7 @@ void AWKeys::reinitKeys(const QStringList &_currentKeys)
     // generate list of required keys for bars
     QStringList barKeys;
     for (auto &bar : m_foundBars) {
-        GraphicalItem *item = m_keyOperator->giByKey(bar);
+        auto item = m_keyOperator->giByKey(bar);
         if (item->isCustom())
             item->setUsedKeys(AWPatternFunctions::findKeys(item->bar(), _currentKeys, false));
         else
@@ -243,12 +218,10 @@ void AWKeys::reinitKeys(const QStringList &_currentKeys)
 void AWKeys::updateTextData()
 {
     // do not do it in parallel to avoid race condition
-    m_mutex.lock();
     calculateValues();
     auto text = parsePattern(m_keyOperator->pattern());
     // update tooltip values under lock
     m_dataAggregator->dataUpdate(m_values);
-    m_mutex.unlock();
 
     emit(needTextToBeUpdated(text));
 }
@@ -259,9 +232,9 @@ void AWKeys::updateTextData()
 void AWKeys::calculateValues()
 {
     // hddtot*
-    QStringList mountDevices = m_keyOperator->devices("mount");
+    auto mountDevices = m_keyOperator->devices("mount");
     for (auto &device : mountDevices) {
-        int index = mountDevices.indexOf(device);
+        auto index = mountDevices.indexOf(device);
         m_values[QString("hddtotmb%1").arg(index)] = m_values[QString("hddfreemb%1").arg(index)].toDouble()
                                                      + m_values[QString("hddmb%1").arg(index)].toDouble();
         m_values[QString("hddtotgb%1").arg(index)] = m_values[QString("hddfreegb%1").arg(index)].toDouble()
@@ -272,10 +245,10 @@ void AWKeys::calculateValues()
     m_values["memtotmb"] = m_values["memusedmb"].toLongLong() + m_values["memfreemb"].toLongLong();
     m_values["memtotgb"] = m_values["memusedgb"].toDouble() + m_values["memfreegb"].toDouble();
     // mem
-    m_values["mem"] = 100.0f * m_values["memmb"].toDouble() / m_values["memtotmb"].toDouble();
+    m_values["mem"] = 100.0 * m_values["memmb"].toDouble() / m_values["memtotmb"].toDouble();
 
     // up, down, upkb, downkb, upunits, downunits
-    int netIndex = m_keyOperator->devices("net").indexOf(m_values["netdev"].toString());
+    auto netIndex = m_keyOperator->devices("net").indexOf(m_values["netdev"].toString());
     m_values["down"] = m_values[QString("down%1").arg(netIndex)];
     m_values["downkb"] = m_values[QString("downkb%1").arg(netIndex)];
     m_values["downtot"] = m_values[QString("downtot%1").arg(netIndex)];
@@ -291,7 +264,7 @@ void AWKeys::calculateValues()
     m_values["swaptotmb"] = m_values["swapmb"].toLongLong() + m_values["swapfreemb"].toLongLong();
     m_values["swaptotgb"] = m_values["swapgb"].toDouble() + m_values["swapfreegb"].toDouble();
     // swap
-    m_values["swap"] = 100.0f * m_values["swapmb"].toDouble() / m_values["swaptotmb"].toDouble();
+    m_values["swap"] = 100.0 * m_values["swapmb"].toDouble() / m_values["swaptotmb"].toDouble();
 
     // user defined keys
     for (auto &key : m_keyOperator->userKeys())
@@ -309,7 +282,7 @@ void AWKeys::createDBusInterface()
     auto id = reinterpret_cast<qlonglong>(this);
 
     // create session
-    QDBusConnection instanceBus = QDBusConnection::sessionBus();
+    auto instanceBus = QDBusConnection::sessionBus();
     // HACK we are going to use different services because it binds to
     // application
     if (instanceBus.registerService(QString("%1.i%2").arg(AWDBUS_SERVICE).arg(id))) {
@@ -320,7 +293,7 @@ void AWKeys::createDBusInterface()
     }
 
     // and same instance but for id independent service
-    QDBusConnection commonBus = QDBusConnection::sessionBus();
+    auto commonBus = QDBusConnection::sessionBus();
     if (commonBus.registerService(AWDBUS_SERVICE))
         commonBus.registerObject(AWDBUS_PATH, new AWDBusAdaptor(this), QDBusConnection::ExportAllContents);
 }
@@ -341,10 +314,10 @@ QString AWKeys::parsePattern(QString _pattern) const
 
     // bars
     for (auto &bar : m_foundBars) {
-        GraphicalItem *item = m_keyOperator->giByKey(bar);
+        auto item = m_keyOperator->giByKey(bar);
-        QString image = item->isCustom() ? item->image(
+        auto image = item->isCustom() ? item->image(
-                            AWPatternFunctions::expandLambdas(item->bar(), m_aggregator, m_values, item->usedKeys()))
+                         AWPatternFunctions::expandLambdas(item->bar(), m_aggregator, m_values, item->usedKeys()))
-                                         : item->image(m_values[item->bar()]);
+                                      : item->image(m_values[item->bar()]);
         _pattern.replace(QString("$%1").arg(bar), image);
     }
 
@@ -357,10 +330,9 @@ QString AWKeys::parsePattern(QString _pattern) const
 }
 
 
-void AWKeys::setDataBySource(const QString &_source, const KSysGuard::SensorInfo &_sensor,
+void AWKeys::setDataBySource(const QString &_source, const KSysGuard::SensorInfo &_sensor, const QVariant &_value)
-                             const KSysGuard::SensorData &_data)
 {
-    qCDebug(LOG_AW) << "Source" << _source << _sensor.name << "with data" << _data.payload;
+    qCDebug(LOG_AW) << "Source" << _source << _sensor.name << "with data" << _value;
 
     // first list init
     auto tags = m_aggregator->keysFromSource(_source);
@@ -373,7 +345,5 @@ void AWKeys::setDataBySource(const QString &_source, const KSysGuard::SensorInfo
         return emit(dropSourceFromDataengine(_source));
     }
 
-    m_mutex.lock();
+    std::for_each(tags.cbegin(), tags.cend(), [this, _value](const QString &tag) { m_values[tag] = _value; });
-    std::for_each(tags.cbegin(), tags.cend(), [this, &_data](const QString &tag) { m_values[tag] = _data.payload; });
-    m_mutex.unlock();
 }

sources/awesome-widget/plugin/awkeys.h

@@ -15,11 +15,8 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
+#pragma once
 
-#ifndef AWKEYS_H
-#define AWKEYS_H
-
-#include <QMutex>
 #include <QObject>
 
 #include <ksysguard/systemstats/SensorInfo.h>
@@ -29,7 +26,6 @@ class AWDataAggregator;
 class AWDataEngineAggregator;
 class AWKeyOperations;
 class AWKeysAggregator;
-class QThreadPool;
 class QTimer;
 
 class AWKeys : public QObject
@@ -40,7 +36,7 @@ public:
     explicit AWKeys(QObject *_parent = nullptr);
     ~AWKeys() override;
     Q_INVOKABLE void initDataAggregator(const QVariantMap &_tooltipParams);
-    Q_INVOKABLE void initKeys(const QString &_currentPattern, int _interval, int _limit, bool _optimize);
+    Q_INVOKABLE void initKeys(const QString &_currentPattern, int _interval, bool _optimize);
     Q_INVOKABLE void setAggregatorProperty(const QString &_key, const QVariant &_value);
     Q_INVOKABLE void setWrapNewLines(bool _wrap);
     // additional method to force load keys from Qml UI. Used in some
@@ -48,22 +44,19 @@ public:
     Q_INVOKABLE void updateCache();
     // keys
     Q_INVOKABLE [[nodiscard]] QStringList dictKeys(bool _sorted = false, const QString &_regexp = "") const;
-    Q_INVOKABLE [[nodiscard]] QVariantList getHddDevices() const;
     // values
     Q_INVOKABLE [[nodiscard]] QString infoByKey(const QString &_key) const;
     Q_INVOKABLE [[nodiscard]] QString valueByKey(const QString &_key) const;
     // configuration
     Q_INVOKABLE void editItem(const QString &_type);
 
-public slots:
-    void dataUpdated(const QHash<QString, KSysGuard::SensorInfo> &_sensors, const KSysGuard::SensorDataList &_data);
-
 signals:
     void dropSourceFromDataengine(const QString &_source);
     void needTextToBeUpdated(const QString &_newText) const;
     void needToolTipToBeUpdated(const QString &_newText) const;
 
 private slots:
+    void dataUpdated(const QHash<QString, KSysGuard::SensorInfo> &_sensors, const KSysGuard::SensorDataList &_data);
     void reinitKeys(const QStringList &_currentKeys);
     void updateTextData();
 
@@ -72,8 +65,7 @@ private:
     void calculateValues();
     void createDBusInterface();
     [[nodiscard]] QString parsePattern(QString _pattern) const;
-    void setDataBySource(const QString &_source, const KSysGuard::SensorInfo &_sensor,
+    void setDataBySource(const QString &_source, const KSysGuard::SensorInfo &_sensor, const QVariant &_value);
-                         const KSysGuard::SensorData &_data);
     // objects
     AWDataAggregator *m_dataAggregator = nullptr;
     AWDataEngineAggregator *m_dataEngineAggregator = nullptr;
@@ -86,10 +78,4 @@ private:
     QVariantHash m_values;
     bool m_optimize = false;
     bool m_wrapNewLines = false;
-    // multithread features
-    QThreadPool *m_threadPool = nullptr;
-    QMutex m_mutex;
 };
-
-
-#endif /* AWKEYS_H */

sources/awesome-widget/plugin/awkeysaggregator.cpp

@@ -33,7 +33,7 @@ AWKeysAggregator::AWKeysAggregator(QObject *_parent)
 {
     qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
 
-    m_customFormatters = new AWFormatterHelper(nullptr);
+    m_customFormatters = new AWFormatterHelper(this);
     m_mapper = new AWDataEngineMapper(this, m_customFormatters);
 
     // sort time keys
@@ -43,12 +43,6 @@ AWKeysAggregator::AWKeysAggregator(QObject *_parent)
 }
 
 
-AWKeysAggregator::~AWKeysAggregator()
-{
-    qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
-}
-
-
 void AWKeysAggregator::initFormatters()
 {
     m_customFormatters->initItems();
@@ -85,21 +79,24 @@ QString AWKeysAggregator::formatter(const QVariant &_data, const QString &_key,
         output = _data.toBool() ? m_acOnline : m_acOffline;
         break;
     case FormatterType::MemGBFormat:
-        output = QString("%1").arg(_data.toDouble() / (1024.0 * 1024.0), 5, 'f', 1);
+        output = QString("%1").arg(_data.toDouble() / GBinBytes, 5, 'f', 1);
         break;
     case FormatterType::MemMBFormat:
-        output = QString("%1").arg(_data.toDouble() / 1024.0, 5, 'f', 0);
+        output = QString("%1").arg(_data.toDouble() / MBinBytes, 5, 'f', 0);
+        break;
+    case FormatterType::MemKBFormat:
+        output = QString("%1").arg(_data.toDouble() / KBinBytes, 5, 'f', 0);
         break;
     case FormatterType::NetSmartFormat:
-        output = [](const float value) {
+        output = [](const double value) {
-            if (value > 1024.0)
+            if (value > MBinBytes)
-                return QString("%1").arg(value / 1024.0, 4, 'f', 1);
+                return QString("%1").arg(value / MBinBytes, 4, 'f', 1);
             else
-                return QString("%1").arg(value, 4, 'f', 0);
+                return QString("%1").arg(value / KBinBytes, 4, 'f', 0);
         }(_data.toDouble());
         break;
     case FormatterType::NetSmartUnits:
-        if (_data.toDouble() > 1024.0)
+        if (_data.toDouble() > MBinBytes)
             output = m_translate ? i18n("MB/s") : "MB/s";
         else
             output = m_translate ? i18n("KB/s") : "KB/s";
@@ -137,17 +134,19 @@ QString AWKeysAggregator::formatter(const QVariant &_data, const QString &_key,
     case FormatterType::Uptime:
     case FormatterType::UptimeCustom:
         output =
-            [](QString source, const int uptime) {
+            [](auto source, auto uptime) {
-                int seconds = uptime - uptime % 60;
+                auto seconds = uptime - uptime % 60;
-                int minutes = seconds / 60 % 60;
+                auto minutes = seconds / 60 % 60;
-                int hours = ((seconds / 60) - minutes) / 60 % 24;
+                auto hours = ((seconds / 60) - minutes) / 60 % 24;
-                int days = (((seconds / 60) - minutes) / 60 - hours) / 24;
+                auto days = (((seconds / 60) - minutes) / 60 - hours) / 24;
+
                 source.replace("$dd", QString("%1").arg(days, 3, 10, QChar('0')));
                 source.replace("$d", QString("%1").arg(days));
                 source.replace("$hh", QString("%1").arg(hours, 2, 10, QChar('0')));
                 source.replace("$h", QString("%1").arg(hours));
                 source.replace("$mm", QString("%1").arg(minutes, 2, 10, QChar('0')));
                 source.replace("$m", QString("%1").arg(minutes));
+
                 return source;
             }(m_mapper->formatter(_key) == FormatterType::Uptime ? "$ddd$hhh$mmm" : m_customUptime,
               static_cast<int>(_data.toDouble()));
@@ -234,7 +233,7 @@ void AWKeysAggregator::setTranslate(const bool _translate)
 }
 
 
-QStringList AWKeysAggregator::registerSource(const QString &_source, const KSysGuard::Unit &_units,
+QStringList AWKeysAggregator::registerSource(const QString &_source, const KSysGuard::Unit _units,
                                              const QStringList &_keys)
 {
     qCDebug(LOG_AW) << "Source" << _source << "with units" << _units;
@@ -243,24 +242,24 @@ QStringList AWKeysAggregator::registerSource(const QString &_source, const KSysG
 }
 
 
-float AWKeysAggregator::temperature(const float temp) const
+double AWKeysAggregator::temperature(const double temp) const
 {
     qCDebug(LOG_AW) << "Temperature value" << temp;
 
-    float converted = temp;
+    auto converted = temp;
     if (m_tempUnits == "Celsius") {
     } else if (m_tempUnits == "Fahrenheit") {
-        converted = temp * 9.0f / 5.0f + 32.0f;
+        converted = temp * 9.0f / 5.0 + 32.0;
     } else if (m_tempUnits == "Kelvin") {
-        converted = temp + 273.15f;
+        converted = temp + 273.15;
     } else if (m_tempUnits == "Reaumur") {
-        converted = temp * 0.8f;
+        converted = temp * 0.8;
     } else if (m_tempUnits == "cm^-1") {
-        converted = (temp + 273.15f) * 0.695f;
+        converted = (temp + 273.15) * 0.695;
     } else if (m_tempUnits == "kJ/mol") {
-        converted = (temp + 273.15f) * 8.31f;
+        converted = (temp + 273.15) * 8.31;
     } else if (m_tempUnits == "kcal/mol") {
-        converted = (temp + 273.15f) * 1.98f;
+        converted = (temp + 273.15) * 1.98;
     } else {
         qCWarning(LOG_AW) << "Invalid units" << m_tempUnits;
     }

sources/awesome-widget/plugin/awkeysaggregator.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWKEYSAGGREGATOR_H
-#define AWKEYSAGGREGATOR_H
 
 #include <ksysguard/formatter/Unit.h>
 
@@ -53,6 +51,7 @@ public:
         ACFormat,
         MemGBFormat,
         MemMBFormat,
+        MemKBFormat,
         NetSmartFormat,
         NetSmartUnits,
         Quotes,
@@ -67,8 +66,12 @@ public:
         UptimeCustom
     };
 
+    static constexpr double KBinBytes = 1024.0;
+    static constexpr double MBinBytes = 1024.0 * KBinBytes;
+    static constexpr double GBinBytes = 1024.0 * MBinBytes;
+
     explicit AWKeysAggregator(QObject *_parent = nullptr);
-    ~AWKeysAggregator() override;
+    ~AWKeysAggregator() override = default;
     void initFormatters();
     // get methods
     [[nodiscard]] QString formatter(const QVariant &_data, const QString &_key, bool replaceSpace) const;
@@ -83,10 +86,10 @@ public:
     void setTranslate(bool _translate);
 
 public slots:
-    QStringList registerSource(const QString &_source, const KSysGuard::Unit &_units, const QStringList &_keys);
+    QStringList registerSource(const QString &_source, KSysGuard::Unit _units, const QStringList &_keys);
 
 private:
-    [[nodiscard]] float temperature(float temp) const;
+    [[nodiscard]] double temperature(double temp) const;
     AWFormatterHelper *m_customFormatters = nullptr;
     AWDataEngineMapper *m_mapper = nullptr;
     QStringList m_timeKeys;
@@ -98,6 +101,3 @@ private:
     QString m_tempUnits;
     bool m_translate = false;
 };
-
-
-#endif /* AWKEYSAGGREGATOR_H */

sources/awesome-widget/plugin/awpairconfigfactory.cpp

@@ -29,15 +29,9 @@ AWPairConfigFactory::AWPairConfigFactory(QObject *_parent)
 }
 
 
-AWPairConfigFactory::~AWPairConfigFactory()
-{
-    qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
-}
-
-
 void AWPairConfigFactory::showFormatterDialog(const QStringList &_keys)
 {
-    auto *config = new AWFormatterConfig(nullptr, _keys);
+    auto config = new AWFormatterConfig(nullptr, _keys);
     config->showDialog();
     config->deleteLater();
 }
@@ -45,7 +39,7 @@ void AWPairConfigFactory::showFormatterDialog(const QStringList &_keys)
 
 void AWPairConfigFactory::showKeysDialog(const QStringList &_keys)
 {
-    auto *config = new AWCustomKeysConfig(nullptr, _keys);
+    auto config = new AWCustomKeysConfig(nullptr, _keys);
     config->showDialog();
     config->deleteLater();
 }

sources/awesome-widget/plugin/awpairconfigfactory.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWPAIRCONFIGFACTORY_H
-#define AWPAIRCONFIGFACTORY_H
 
 #include <QObject>
 
@@ -28,12 +26,9 @@ class AWPairConfigFactory : public QObject
 
 public:
     explicit AWPairConfigFactory(QObject *_parent = nullptr);
-    ~AWPairConfigFactory() override;
+    ~AWPairConfigFactory() override = default;
     Q_INVOKABLE static void showFormatterDialog(const QStringList &_keys);
     Q_INVOKABLE static void showKeysDialog(const QStringList &_keys);
 
 private:
 };
-
-
-#endif /* AWPAIRCONFIGFACTORY_H */

sources/awesome-widget/plugin/awpatternfunctions.cpp

@@ -36,7 +36,7 @@ QString AWPatternFunctions::expandLambdas(QString _code, AWKeysAggregator *_aggr
     for (auto &lambdaKey : _usedKeys)
         _code.replace(QString("$%1").arg(lambdaKey), _aggregator->formatter(_metadata[lambdaKey], lambdaKey, false));
     qCInfo(LOG_AW) << "Expression" << _code;
-    QJSValue result = engine.evaluate(_code);
+    auto result = engine.evaluate(_code);
     if (result.isError()) {
         qCWarning(LOG_AW) << "Uncaught exception at line" << result.property("lineNumber").toInt() << ":"
                           << result.toString();
@@ -52,17 +52,17 @@ QString AWPatternFunctions::expandTemplates(QString _code)
     qCDebug(LOG_AW) << "Expand templates in" << _code;
 
     // match the following construction $template{{some code here}}
-    QRegularExpression templatesRegexp(R"(\$template\{\{(?<body>.*?)\}\})");
+    static QRegularExpression templatesRegexp(R"(\$template\{\{(?<body>.*?)\}\})");
     templatesRegexp.setPatternOptions(QRegularExpression::DotMatchesEverythingOption);
 
-    QRegularExpressionMatchIterator it = templatesRegexp.globalMatch(_code);
+    auto it = templatesRegexp.globalMatch(_code);
     while (it.hasNext()) {
-        QRegularExpressionMatch match = it.next();
+        auto match = it.next();
-        QString body = match.captured("body");
+        auto body = match.captured("body");
 
         QJSEngine engine;
         qCInfo(LOG_AW) << "Expression" << body;
-        QJSValue result = engine.evaluate(body);
+        auto result = engine.evaluate(body);
         QString templateResult = "";
         if (result.isError()) {
             qCWarning(LOG_AW) << "Uncaught exception at line" << result.property("lineNumber").toInt() << ":"
@@ -94,20 +94,20 @@ QList<AWPatternFunctions::AWFunction> AWPatternFunctions::findFunctionCalls(cons
     regex.setPatternOptions(QRegularExpression::DotMatchesEverythingOption);
 
     QList<AWPatternFunctions::AWFunction> foundFunctions;
-    QRegularExpressionMatchIterator it = regex.globalMatch(_code);
+    auto it = regex.globalMatch(_code);
     while (it.hasNext()) {
-        QRegularExpressionMatch match = it.next();
+        auto match = it.next();
 
         AWPatternFunctions::AWFunction metadata;
         // work with args
-        QString argsString = match.captured("args");
+        auto argsString = match.captured("args");
         if (argsString.isEmpty()) {
             metadata.args = QStringList();
         } else {
             // replace '$,' to 0x1d
             argsString.replace("$,", QChar(0x1d));
-            QStringList args = argsString.split(',');
+            auto args = argsString.split(',');
-            std::for_each(args.begin(), args.end(), [](QString &arg) { arg.replace(QChar(0x1d), ","); });
+            std::for_each(args.begin(), args.end(), [](auto &arg) { arg.replace(QChar(0x1d), ","); });
             metadata.args = args;
         }
         // other variables
@@ -127,11 +127,11 @@ QString AWPatternFunctions::insertAllKeys(QString _code, const QStringList &_key
 {
     qCDebug(LOG_AW) << "Looking for keys in code" << _code << "using list" << _keys;
 
-    QList<AWPatternFunctions::AWFunction> found = AWPatternFunctions::findFunctionCalls("aw_all", _code);
+    auto found = AWPatternFunctions::findFunctionCalls("aw_all", _code);
     for (auto &function : found) {
-        QString separator = function.args.isEmpty() ? "," : function.args.at(0);
+        auto separator = function.args.isEmpty() ? "," : function.args.at(0);
-        QStringList required = _keys.filter(QRegularExpression(function.body));
+        auto required = _keys.filter(QRegularExpression(function.body));
-        std::for_each(required.begin(), required.end(), [](QString &value) { value = QString("%1: $%1").arg(value); });
+        std::for_each(required.begin(), required.end(), [](auto &value) { value = QString("%1: $%1").arg(value); });
 
         _code.replace(function.what, required.join(separator));
     }
@@ -144,9 +144,9 @@ QString AWPatternFunctions::insertKeyCount(QString _code, const QStringList &_ke
 {
     qCDebug(LOG_AW) << "Looking for count in code" << _code << "using list" << _keys;
 
-    QList<AWPatternFunctions::AWFunction> found = AWPatternFunctions::findFunctionCalls("aw_count", _code);
+    auto found = AWPatternFunctions::findFunctionCalls("aw_count", _code);
     for (auto &function : found) {
-        int count = _keys.filter(QRegularExpression(function.body)).count();
+        auto count = _keys.filter(QRegularExpression(function.body)).count();
 
         _code.replace(function.what, QString::number(count));
     }
@@ -159,10 +159,10 @@ QString AWPatternFunctions::insertKeyNames(QString _code, const QStringList &_ke
 {
     qCDebug(LOG_AW) << "Looking for key names in code" << _code << "using list" << _keys;
 
-    QList<AWPatternFunctions::AWFunction> found = AWPatternFunctions::findFunctionCalls("aw_names", _code);
+    auto found = AWPatternFunctions::findFunctionCalls("aw_names", _code);
     for (auto &function : found) {
-        QString separator = function.args.isEmpty() ? "," : function.args.at(0);
+        auto separator = function.args.isEmpty() ? "," : function.args.at(0);
-        QStringList required = _keys.filter(QRegularExpression(function.body));
+        auto required = _keys.filter(QRegularExpression(function.body));
 
         _code.replace(function.what, required.join(separator));
     }
@@ -175,11 +175,11 @@ QString AWPatternFunctions::insertKeys(QString _code, const QStringList &_keys)
 {
     qCDebug(LOG_AW) << "Looking for keys in code" << _code << "using list" << _keys;
 
-    QList<AWPatternFunctions::AWFunction> found = AWPatternFunctions::findFunctionCalls("aw_keys", _code);
+    auto found = AWPatternFunctions::findFunctionCalls("aw_keys", _code);
     for (auto &function : found) {
-        QString separator = function.args.isEmpty() ? "," : function.args.at(0);
+        auto separator = function.args.isEmpty() ? "," : function.args.at(0);
-        QStringList required = _keys.filter(QRegularExpression(function.body));
+        auto required = _keys.filter(QRegularExpression(function.body));
-        std::for_each(required.begin(), required.end(), [](QString &value) { value = QString("$%1").arg(value); });
+        std::for_each(required.begin(), required.end(), [](auto &value) { value = QString("$%1").arg(value); });
 
         _code.replace(function.what, required.join(separator));
     }
@@ -192,26 +192,25 @@ QString AWPatternFunctions::insertMacros(QString _code)
 {
     qCDebug(LOG_AW) << "Looking for macros in code" << _code;
 
-    QList<AWPatternFunctions::AWFunction> found = AWPatternFunctions::findFunctionCalls("aw_macro", _code);
+    auto found = AWPatternFunctions::findFunctionCalls("aw_macro", _code);
     for (auto &macro : found) {
         // get macro params
         if (macro.args.isEmpty()) {
             qCWarning(LOG_AW) << "No macro name found for" << macro.what;
             continue;
         }
-        QString name = macro.args.takeFirst();
+        auto name = macro.args.takeFirst();
         // find macro usage
-        QList<AWPatternFunctions::AWFunction> macroUsage
+        auto macroUsage = AWPatternFunctions::findFunctionCalls(QString("aw_macro_%1").arg(name), _code);
-            = AWPatternFunctions::findFunctionCalls(QString("aw_macro_%1").arg(name), _code);
         for (auto &function : macroUsage) {
             if (function.args.count() != macro.args.count()) {
                 qCWarning(LOG_AW) << "Invalid args count found for call" << function.what << "with macro" << macro.what;
                 continue;
             }
             // generate body to replace
-            QString result = macro.body;
+            auto result = macro.body;
-            std::for_each(macro.args.cbegin(), macro.args.cend(), [&result, macro, function](const QString &arg) {
+            std::for_each(macro.args.cbegin(), macro.args.cend(), [&result, macro, function](auto &arg) {
-                int index = macro.args.indexOf(arg);
+                auto index = macro.args.indexOf(arg);
                 result.replace(QString("$%1").arg(arg), function.args.at(index));
             });
             // do replace
@@ -231,7 +230,7 @@ QStringList AWPatternFunctions::findKeys(const QString &_code, const QStringList
     qCDebug(LOG_AW) << "Looking for keys in code" << _code << "using list" << _keys;
 
     QStringList selectedKeys;
-    QString replacedCode = _code;
+    auto replacedCode = _code;
     for (auto &key : _keys)
         if ((key.startsWith("bar") == _isBars) && (replacedCode.contains(QString("$%1").arg(key)))) {
             qCInfo(LOG_AW) << "Found key" << key << "with bar enabled" << _isBars;
@@ -251,13 +250,13 @@ QStringList AWPatternFunctions::findLambdas(const QString &_code)
 
     QStringList selectedKeys;
     // match the following construction ${{some code here}}
-    QRegularExpression lambdaRegexp(R"(\$\{\{(?<body>.*?)\}\})");
+    static QRegularExpression lambdaRegexp(R"(\$\{\{(?<body>.*?)\}\})");
     lambdaRegexp.setPatternOptions(QRegularExpression::DotMatchesEverythingOption);
 
-    QRegularExpressionMatchIterator it = lambdaRegexp.globalMatch(_code);
+    auto it = lambdaRegexp.globalMatch(_code);
     while (it.hasNext()) {
-        QRegularExpressionMatch match = it.next();
+        auto match = it.next();
-        QString lambda = match.captured("body");
+        auto lambda = match.captured("body");
 
         // append
         qCInfo(LOG_AW) << "Found lambda" << lambda;

sources/awesome-widget/plugin/awpatternfunctions.h

@@ -15,9 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWPATTERNFUNCTIONS_H
-#define AWPATTERNFUNCTIONS_H
 
 #include <QString>
 #include <QVariant>
@@ -47,6 +45,3 @@ QString insertMacros(QString _code);
 QStringList findKeys(const QString &_code, const QStringList &_keys, bool _isBars);
 QStringList findLambdas(const QString &_code);
 } // namespace AWPatternFunctions
-
-
-#endif /* AWPATTERNFUNCTIONS_H */

sources/awesome-widget/plugin/awtelemetryhandler.cpp

@@ -18,8 +18,6 @@
 #include "awtelemetryhandler.h"
 
 #include <QJsonDocument>
-#include <QNetworkAccessManager>
-#include <QNetworkReply>
 #include <QSettings>
 #include <QStandardPaths>
 #include <QUuid>
@@ -27,23 +25,13 @@
 #include "awdebug.h"
 
 
-AWTelemetryHandler::AWTelemetryHandler(QObject *_parent, const QString &_clientId)
+AWTelemetryHandler::AWTelemetryHandler(QObject *_parent)
     : QObject(_parent)
 {
     qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
 
     m_localFile = QString("%1/awesomewidgets/telemetry.ini")
                       .arg(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation));
-
-    // override client id if any
-    if (!_clientId.isEmpty())
-        m_clientId = _clientId;
-}
-
-
-AWTelemetryHandler::~AWTelemetryHandler()
-{
-    qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
 }
 
 
@@ -71,14 +59,11 @@ QString AWTelemetryHandler::getLast(const QString &_group) const
 }
 
 
-void AWTelemetryHandler::init(const int _count, const bool _enableRemote, const QString &_clientId)
+void AWTelemetryHandler::init(const int _count)
 {
-    qCDebug(LOG_AW) << "Init telemetry with count" << _count << "enable remote" << _enableRemote << "client ID"
+    qCDebug(LOG_AW) << "Init telemetry with count" << _count;
-                    << _clientId;
 
     m_storeCount = _count;
-    m_uploadEnabled = _enableRemote;
-    m_clientId = _clientId;
 }
 
 
@@ -106,7 +91,7 @@ bool AWTelemetryHandler::put(const QString &_group, const QString &_value) const
     settings.remove("");
     // and save now
     for (auto &val : saved) {
-        QString key = getKey(settings.childKeys().count());
+        auto key = getKey(settings.childKeys().count());
         settings.setValue(key, val);
     }
 
@@ -118,59 +103,6 @@ bool AWTelemetryHandler::put(const QString &_group, const QString &_value) const
 }
 
 
-void AWTelemetryHandler::uploadTelemetry(const QString &_group, const QString &_value)
-{
-    qCDebug(LOG_AW) << "Upload data with group" << _group << "and value" << _value;
-    if (!m_uploadEnabled) {
-        qCInfo(LOG_AW) << "Upload disabled by configuration";
-        return;
-    }
-
-    auto *manager = new QNetworkAccessManager(nullptr);
-    connect(manager, SIGNAL(finished(QNetworkReply *)), this, SLOT(telemetryReplyRecieved(QNetworkReply *)));
-
-    QUrl url(REMOTE_TELEMETRY_URL);
-    QNetworkRequest request(url);
-    request.setHeader(QNetworkRequest::ContentTypeHeader, "application/json");
-
-    // generate payload
-    QVariantMap payload;
-    payload["api"] = AW_TELEMETRY_API;
-    payload["client_id"] = m_clientId;
-    payload["metadata"] = _value;
-    payload["type"] = _group;
-    // convert to QByteArray to send request
-    QByteArray data = QJsonDocument::fromVariant(payload).toJson(QJsonDocument::Compact);
-    qCInfo(LOG_AW) << "Send request with body" << data.data() << "and size" << data.size();
-
-    manager->post(request, data);
-}
-
-
-void AWTelemetryHandler::telemetryReplyRecieved(QNetworkReply *_reply)
-{
-    if (_reply->error() != QNetworkReply::NoError) {
-        qCWarning(LOG_AW) << "An error occurs" << _reply->error() << "with message" << _reply->errorString();
-        return;
-    }
-
-    QJsonParseError error{};
-    QJsonDocument jsonDoc = QJsonDocument::fromJson(_reply->readAll(), &error);
-    if (error.error != QJsonParseError::NoError) {
-        qCWarning(LOG_AW) << "Parse error" << error.errorString();
-        return;
-    }
-    _reply->deleteLater();
-
-    // convert to map
-    QVariantMap response = jsonDoc.toVariant().toMap();
-    QString message = response["message"].toString();
-    qCInfo(LOG_AW) << "Server reply on telemetry" << message;
-
-    return emit(replyReceived(message));
-}
-
-
 QString AWTelemetryHandler::getKey(const int _count)
 {
     qCDebug(LOG_AW) << "Get key for keys count" << _count;

sources/awesome-widget/plugin/awtelemetryhandler.h

@@ -15,43 +15,25 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-
+#pragma once
-#ifndef AWTELEMETRYHANDLER_H
-#define AWTELEMETRYHANDLER_H
 
 #include <QObject>
 
 
-class QNetworkReply;
-
 class AWTelemetryHandler : public QObject
 {
     Q_OBJECT
 
 public:
-    const char *REMOTE_TELEMETRY_URL = "https://arcanis.me/telemetry";
+    explicit AWTelemetryHandler(QObject *_parent = nullptr);
-
+    ~AWTelemetryHandler() override = default;
-    explicit AWTelemetryHandler(QObject *_parent = nullptr, const QString &_clientId = "");
-    ~AWTelemetryHandler() override;
     Q_INVOKABLE [[nodiscard]] QStringList get(const QString &_group) const;
     Q_INVOKABLE [[nodiscard]] QString getLast(const QString &_group) const;
-    Q_INVOKABLE void init(int _count, bool _enableRemote, const QString &_clientId);
+    Q_INVOKABLE void init(int _count);
     Q_INVOKABLE [[nodiscard]] bool put(const QString &_group, const QString &_value) const;
-    Q_INVOKABLE void uploadTelemetry(const QString &_group, const QString &_value);
-
-signals:
-    void replyReceived(const QString &_message);
-
-private slots:
-    void telemetryReplyRecieved(QNetworkReply *_reply);
 
 private:
     static QString getKey(int _count);
-    QString m_clientId;
     QString m_localFile;
     int m_storeCount = 0;
-    bool m_uploadEnabled = false;
 };
-
-
-#endif /* AWTELEMETRYHANDLER_H */

sources/awesome-widget/plugin/awupdatehelper.cpp

@@ -18,6 +18,7 @@
 #include "awupdatehelper.h"
 
 #include <KI18n/KLocalizedString>
+#include <KNotifications/KNotification>
 
 #include <QDesktopServices>
 #include <QJsonDocument>
@@ -40,21 +41,15 @@ AWUpdateHelper::AWUpdateHelper(QObject *_parent)
 }
 
 
-AWUpdateHelper::~AWUpdateHelper()
-{
-    qCDebug(LOG_AW) << __PRETTY_FUNCTION__;
-}
-
-
 void AWUpdateHelper::checkUpdates(const bool _showAnyway)
 {
     qCDebug(LOG_AW) << "Show anyway" << _showAnyway;
 
-    // showAnyway options requires to show message if no updates found on direct
+    // showAnyway options required to show message if no updates found on direct
     // request. In case of automatic check no message will be shown
-    auto *manager = new QNetworkAccessManager(nullptr);
+    auto manager = new QNetworkAccessManager(nullptr);
     connect(manager, &QNetworkAccessManager::finished,
-            [_showAnyway, this](QNetworkReply *reply) { return versionReplyRecieved(reply, _showAnyway); });
+            [_showAnyway, this](QNetworkReply *reply) { return versionReplyReceived(reply, _showAnyway); });
 
     manager->get(QNetworkRequest(QUrl(VERSION_API)));
 }
@@ -63,15 +58,14 @@ void AWUpdateHelper::checkUpdates(const bool _showAnyway)
 bool AWUpdateHelper::checkVersion()
 {
     QSettings settings(m_genericConfig, QSettings::IniFormat);
-    QVersionNumber version = QVersionNumber::fromString(settings.value("Version", QString(VERSION)).toString());
+    auto version = QVersionNumber::fromString(settings.value("Version", QString(VERSION)).toString());
     // update version
     settings.setValue("Version", QString(VERSION));
     settings.sync();
     qCInfo(LOG_AW) << "Found version" << version << "actual one is" << m_foundVersion;
 
     if ((version != m_foundVersion) && (!QString(CHANGELOG).isEmpty())) {
-        genMessageBox(i18nc("Changelog of %1", VERSION), QString(CHANGELOG).replace('@', '\n'), QMessageBox::Ok)
+        sendNotification(i18n("Changelog of %1", VERSION), QString(CHANGELOG).replace('@', '\n'));
-            ->open();
         return true;
     } else if (version != m_foundVersion) {
         qCWarning(LOG_AW) << "No changelog information provided";
@@ -84,49 +78,40 @@ bool AWUpdateHelper::checkVersion()
 }
 
 
+void AWUpdateHelper::openReleasesPage()
+{
+    QDesktopServices::openUrl(QString(RELEASES) + m_foundVersion.toString());
+}
+
+
 void AWUpdateHelper::showInfo(const QVersionNumber &_version)
 {
     qCDebug(LOG_AW) << "Version" << _version;
 
-    QString text = i18n("You are using the actual version %1", _version.toString());
+    auto text = i18n("You are using the actual version %1", _version.toString());
     if (!QString(COMMIT_SHA).isEmpty())
         text += QString(" (%1)").arg(QString(COMMIT_SHA));
-    return genMessageBox(i18n("No new version found"), text, QMessageBox::Ok)->open();
+    sendNotification(i18n("No new version found"), text);
 }
 
 
-void AWUpdateHelper::showUpdates(const QVersionNumber &_version)
+void AWUpdateHelper::showUpdates(const QVersionNumber &_version) const
 {
     qCDebug(LOG_AW) << "Version" << _version;
 
     QString text;
-    text += i18nc("Current version : %1", VERSION);
+    text += i18n("Current version : %1", VERSION);
     text += QString(COMMIT_SHA).isEmpty() ? "\n" : QString(" (%1)\n").arg(QString(COMMIT_SHA));
     text += i18n("New version : %1", _version.toString()) + "\n\n";
     text += i18n("Click \"Ok\" to download");
 
-    genMessageBox(i18n("There are updates"), text, QMessageBox::Ok | QMessageBox::Cancel)
+    auto event = sendNotification(i18n("There are updates"), text);
-        ->open(this, SLOT(userReplyOnUpdates(QAbstractButton *)));
+    auto action = event->addAction(i18n("Details"));
+    connect(action, &KNotificationAction::activated, this, &AWUpdateHelper::openReleasesPage);
 }
 
 
-void AWUpdateHelper::userReplyOnUpdates(QAbstractButton *_button)
+void AWUpdateHelper::versionReplyReceived(QNetworkReply *_reply, const bool _showAnyway)
-{
-    QMessageBox::ButtonRole ret = dynamic_cast<QMessageBox *>(sender())->buttonRole(_button);
-    qCInfo(LOG_AW) << "User select" << ret;
-
-    switch (ret) {
-    case QMessageBox::AcceptRole:
-        QDesktopServices::openUrl(QString(RELEASES) + m_foundVersion.toString());
-        break;
-    case QMessageBox::RejectRole:
-    default:
-        break;
-    }
-}
-
-
-void AWUpdateHelper::versionReplyRecieved(QNetworkReply *_reply, const bool _showAnyway)
 {
     qCDebug(LOG_AW) << "Show message anyway" << _showAnyway;
     if (_reply->error() != QNetworkReply::NoError) {
@@ -134,22 +119,23 @@ void AWUpdateHelper::versionReplyRecieved(QNetworkReply *_reply, const bool _sho
         return;
     }
 
-    QJsonParseError error = QJsonParseError();
+    auto error = QJsonParseError();
-    QJsonDocument jsonDoc = QJsonDocument::fromJson(_reply->readAll(), &error);
+    auto jsonDoc = QJsonDocument::fromJson(_reply->readAll(), &error);
     if (error.error != QJsonParseError::NoError) {
         qCWarning(LOG_AW) << "Parse error" << error.errorString();
         return;
     }
     _reply->deleteLater();
+    _reply->manager()->deleteLater(); // remember to delete manager too
 
     // convert to map
-    QVariantMap firstRelease = jsonDoc.toVariant().toList().first().toMap();
+    auto firstRelease = jsonDoc.toVariant().toList().first().toMap();
-    QString version = firstRelease["tag_name"].toString();
+    auto version = firstRelease["tag_name"].toString();
     version.remove("V.");
     m_foundVersion = QVersionNumber::fromString(version);
     qCInfo(LOG_AW) << "Update found version to" << m_foundVersion;
 
-    QVersionNumber oldVersion = QVersionNumber::fromString(VERSION);
+    auto oldVersion = QVersionNumber::fromString(VERSION);
     if (oldVersion < m_foundVersion)
         return showUpdates(m_foundVersion);
     else if (_showAnyway)
@@ -158,18 +144,12 @@ void AWUpdateHelper::versionReplyRecieved(QNetworkReply *_reply, const bool _sho
 
 
 // additional method which is used to show message box which does not block UI
-QMessageBox *AWUpdateHelper::genMessageBox(const QString &_title, const QString &_body,
+KNotification *AWUpdateHelper::sendNotification(const QString &_title, const QString &_body)
-                                           const QMessageBox::StandardButtons _buttons)
 {
     qCDebug(LOG_AW) << "Construct message box with title" << _title << "and body" << _body;
 
-    auto *msgBox = new QMessageBox(nullptr);
+    auto event = KNotification::event("system", _title, _body);
-    msgBox->setAttribute(Qt::WA_DeleteOnClose);
+    event->setComponentName("plasma-applet-org.kde.plasma.awesome-widget");
-    msgBox->setModal(false);
-    msgBox->setWindowTitle(_title);
-    msgBox->setText(_body);
-    msgBox->setStandardButtons(_buttons);
-    msgBox->setIcon(QMessageBox::Information);
 
-    return msgBox;
+    return event;
 }

sources/awesome-widget/plugin/awupdatehelper.h

@@ -15,15 +15,13 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
+#pragma once
 
-#ifndef AWUPDATEHELPER_H
-#define AWUPDATEHELPER_H
-
-#include <QMessageBox>
 #include <QObject>
 #include <QVersionNumber>
 
 
+class KNotification;
 class QNetworkReply;
 
 class AWUpdateHelper : public QObject
@@ -32,22 +30,18 @@ class AWUpdateHelper : public QObject
 
 public:
     explicit AWUpdateHelper(QObject *_parent = nullptr);
-    ~AWUpdateHelper() override;
+    ~AWUpdateHelper() override = default;
     void checkUpdates(bool _showAnyway = false);
     bool checkVersion();
 
 private slots:
+    void openReleasesPage();
     static void showInfo(const QVersionNumber &_version);
-    void showUpdates(const QVersionNumber &_version);
+    void showUpdates(const QVersionNumber &_version) const;
-    void userReplyOnUpdates(QAbstractButton *_button);
+    void versionReplyReceived(QNetworkReply *_reply, bool _showAnyway);
-    void versionReplyRecieved(QNetworkReply *_reply, bool _showAnyway);
 
 private:
-    static QMessageBox *genMessageBox(const QString &_title, const QString &_body,
+    static KNotification *sendNotification(const QString &_title, const QString &_body);
-                                      QMessageBox::StandardButtons _buttons);
     QVersionNumber m_foundVersion;
     QString m_genericConfig;
 };
-
-
-#endif /* AWUPDATEHELPER_H */

sources/awesomewidgets/abstractextitem.cpp

@@ -29,13 +29,19 @@
 
 AbstractExtItem::AbstractExtItem(QObject *_parent, const QString &_filePath)
     : QObject(_parent)
-    , m_fileName(_filePath)
+    , m_filePath(_filePath)
 {
     qCDebug(LOG_LIB) << __PRETTY_FUNCTION__;
 
     qCDebug(LOG_LIB) << "Desktop name" << _filePath;
 
-    m_name = m_fileName;
+    m_name = m_filePath;
+
+    m_scheduler = new QCronScheduler(this);
+    connect(m_scheduler, &QCronScheduler::activated, this, &AbstractExtItem::requestDataUpdate);
+
+    m_socket = new QLocalServer(this);
+    connect(m_socket, &QLocalServer::newConnection, this, &AbstractExtItem::requestDataUpdate);
 }
 
 
@@ -43,11 +49,11 @@ AbstractExtItem::~AbstractExtItem()
 {
     qCDebug(LOG_LIB) << __PRETTY_FUNCTION__;
 
-    if (m_socket) {
+    m_scheduler->stop();
-        m_socket->close();
+    m_scheduler->deleteLater();
-        QLocalServer::removeServer(socket());
+
-        m_socket->deleteLater();
+    m_socket->close();
-    }
+    m_socket->deleteLater();
 }
 
 
@@ -95,10 +101,11 @@ void AbstractExtItem::startTimer()
 }
 
 
-QString AbstractExtItem::writtableConfig() const
+QString AbstractExtItem::writableConfig() const
 {
-    auto path = m_fileName;
+    auto path = m_filePath;
-    auto name = QFileInfo(path).fileName();
+    auto name = fileName();
+    // extract subdirectory
     path.remove(path.length() - name.length() - 1, name.length() + 1);
     auto dir = QFileInfo(path).fileName();
 
@@ -127,7 +134,13 @@ QString AbstractExtItem::cron() const
 
 QString AbstractExtItem::fileName() const
 {
-    return m_fileName;
+    return QFileInfo(filePath()).fileName();
+}
+
+
+QString AbstractExtItem::filePath() const
+{
+    return m_filePath;
 }
 
 
@@ -196,20 +209,14 @@ void AbstractExtItem::setComment(const QString &_comment)
 void AbstractExtItem::setCron(const QString &_cron)
 {
     qCDebug(LOG_LIB) << "Cron string" << _cron;
-    // deinit module first
-    if (m_scheduler) {
-        disconnect(m_scheduler, SIGNAL(activated()), this, SIGNAL(requestDataUpdate()));
-        delete m_scheduler;
-    }
 
     m_cron = _cron;
-    if (cron().isEmpty())
+    if (m_cron.isEmpty()) { // disable cron timer
-        return;
+        m_scheduler->stop();
-
+    } else {
-    // init scheduler
+        m_scheduler->parse(m_cron);
-    m_scheduler = new QCronScheduler(this);
+        m_scheduler->start();
-    m_scheduler->parse(cron());
+    }
-    connect(m_scheduler, SIGNAL(activated()), this, SIGNAL(requestDataUpdate()));
 }
 
 
@@ -234,11 +241,11 @@ void AbstractExtItem::setName(const QString &_name)
 void AbstractExtItem::setNumber(int _number)
 {
     qCDebug(LOG_LIB) << "Number" << _number;
-    bool generateNumber = (_number == -1);
+    auto generateNumber = (_number == -1);
     if (generateNumber) {
         _number = []() {
             qCWarning(LOG_LIB) << "Number is empty, generate new one";
-            auto n = QRandomGenerator::global()->generate() % 1000;
+            auto n = QRandomGenerator::global()->bounded(1000);
             qCInfo(LOG_LIB) << "Generated number is" << n;
             return n;
         }();
@@ -253,40 +260,24 @@ void AbstractExtItem::setNumber(int _number)
 void AbstractExtItem::setSocket(const QString &_socket)
 {
     qCDebug(LOG_LIB) << "Socket" << _socket;
-    // remove old socket first
-    deinitSocket();
 
     m_socketFile = _socket;
 }
 
 
-void AbstractExtItem::deinitSocket()
-{
-    if (!m_socket)
-        return;
-
-    m_socket->close();
-    QLocalServer::removeServer(socket());
-    disconnect(m_socket, SIGNAL(newConnection()), this, SLOT(newConnectionReceived()));
-    delete m_socket;
-}
-
-
 void AbstractExtItem::initSocket()
 {
-    // remove old socket first
+    // reload local socket
-    deinitSocket();
+    m_socket->close();
 
-    m_socket = new QLocalServer(this);
+    auto listening = m_socket->listen(m_socketFile);
-    bool listening = m_socket->listen(socket());
+    qCInfo(LOG_LIB) << "Server listening on" << m_socketFile << listening;
-    qCInfo(LOG_LIB) << "Server listening on" << socket() << listening;
-    connect(m_socket, SIGNAL(newConnection()), this, SLOT(newConnectionReceived()));
 }
 
 
 void AbstractExtItem::readConfiguration()
 {
-    QSettings settings(m_fileName, QSettings::IniFormat);
+    QSettings settings(m_filePath, QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
     setName(settings.value("Name", name()).toString());
@@ -303,8 +294,8 @@ void AbstractExtItem::readConfiguration()
 
 bool AbstractExtItem::tryDelete() const
 {
-    bool status = QFile::remove(m_fileName);
+    auto status = QFile::remove(m_filePath);
-    qCInfo(LOG_LIB) << "Remove file" << m_fileName << status;
+    qCInfo(LOG_LIB) << "Remove file" << m_filePath << status;
 
     return status;
 }
@@ -312,7 +303,7 @@ bool AbstractExtItem::tryDelete() const
 
 void AbstractExtItem::writeConfiguration() const
 {
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");
@@ -329,9 +320,3 @@ void AbstractExtItem::writeConfiguration() const
 
     settings.sync();
 }
-
-
-void AbstractExtItem::newConnectionReceived()
-{
-    emit(requestDataUpdate());
-}

sources/awesomewidgets/abstractextitem.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef ABSTRACTEXTITEM_H
+#pragma once
-#define ABSTRACTEXTITEM_H
 
 #include <QVariant>
 
@@ -33,6 +32,7 @@ class AbstractExtItem : public QObject
     Q_PROPERTY(QString comment READ comment WRITE setComment)
     Q_PROPERTY(QString cron READ cron WRITE setCron)
     Q_PROPERTY(QString fileName READ fileName)
+    Q_PROPERTY(QString filePath READ filePath)
     Q_PROPERTY(int interval READ interval WRITE setInterval)
     Q_PROPERTY(QString name READ name WRITE setName)
     Q_PROPERTY(int number READ number WRITE setNumber)
@@ -46,12 +46,13 @@ public:
     virtual AbstractExtItem *copy(const QString &_fileName, int _number) = 0;
     virtual void copyDefaults(AbstractExtItem *_other) const;
     virtual void startTimer();
-    [[nodiscard]] QString writtableConfig() const;
+    [[nodiscard]] QString writableConfig() const;
     // get methods
     [[nodiscard]] int apiVersion() const;
     [[nodiscard]] QString comment() const;
     [[nodiscard]] QString cron() const;
     [[nodiscard]] QString fileName() const;
+    [[nodiscard]] QString filePath() const;
     [[nodiscard]] int interval() const;
     [[nodiscard]] bool isActive() const;
     [[nodiscard]] QString name() const;
@@ -74,7 +75,6 @@ signals:
     void requestDataUpdate();
 
 public slots:
-    virtual void deinitSocket();
     virtual void initSocket();
     virtual void readConfiguration();
     virtual QVariantHash run() = 0;
@@ -82,12 +82,9 @@ public slots:
     [[nodiscard]] virtual bool tryDelete() const;
     virtual void writeConfiguration() const;
 
-private slots:
-    void newConnectionReceived();
-
 private:
     QCronScheduler *m_scheduler = nullptr;
-    QString m_fileName = "/dev/null";
+    QString m_filePath = "";
     int m_times = 0;
     // FIXME find a better way to do it
     virtual void translate(void *_ui) = 0;
@@ -102,6 +99,3 @@ private:
     QLocalServer *m_socket = nullptr;
     QString m_socketFile = "";
 };
-
-
-#endif /* ABSTRACTEXTITEM_H */

sources/awesomewidgets/abstractextitemaggregator.cpp

@@ -35,8 +35,7 @@ AbstractExtItemAggregator::AbstractExtItemAggregator(QObject *_parent, QString _
     // create directory at $HOME
     auto localDir = QString("%1/awesomewidgets/%2")
                         .arg(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation), type());
-    QDir localDirectory;
+    if (QDir().mkpath(localDir))
-    if (localDirectory.mkpath(localDir))
         qCInfo(LOG_LIB) << "Created directory" << localDir;
 }
 
@@ -102,18 +101,13 @@ int AbstractExtItemAggregator::exec()
     auto createButton = ui->buttonBox->addButton(i18n("Create"), QDialogButtonBox::ActionRole);
     auto deleteButton = ui->buttonBox->addButton(i18n("Remove"), QDialogButtonBox::ActionRole);
 
-    connect(ui->buttonBox, &QDialogButtonBox::clicked, [&](QAbstractButton *_button) {
+    connect(copyButton, &QPushButton::clicked, [this, ui]() { copyItem(ui->listWidget); });
-        if (dynamic_cast<QPushButton *>(_button) == copyButton)
+    connect(createButton, &QPushButton::clicked, [this, ui]() { doCreateItem(ui->listWidget); });
-            copyItem(ui->listWidget);
+    connect(deleteButton, &QPushButton::clicked, [this, ui]() { deleteItem(ui->listWidget); });
-        else if (dynamic_cast<QPushButton *>(_button) == createButton)
+    connect(ui->buttonBox, &QDialogButtonBox::accepted, [this, ui]() { editItem(ui->listWidget); });
-            doCreateItem(ui->listWidget);
+
-        else if (dynamic_cast<QPushButton *>(_button) == deleteButton)
-            deleteItem(ui->listWidget);
-        else if (ui->buttonBox->buttonRole(_button) == QDialogButtonBox::AcceptRole)
-            editItem(ui->listWidget);
-    });
     connect(ui->buttonBox, &QDialogButtonBox::rejected, [dialog]() { dialog->reject(); });
-    connect(ui->listWidget, &QListWidget::itemActivated, [&](QListWidgetItem *) { editItem(ui->listWidget); });
+    connect(ui->listWidget, &QListWidget::itemActivated, [this, ui](QListWidgetItem *) { editItem(ui->listWidget); });
 
     repaintList(ui->listWidget);
     auto ret = dialog->exec();
@@ -145,8 +139,8 @@ AbstractExtItem *AbstractExtItemAggregator::itemFromWidget(QListWidget *_widget)
         return nullptr;
 
     AbstractExtItem *found = nullptr;
-    for (auto &item : items()) {
+    for (auto item : items()) {
-        auto fileName = QFileInfo(item->fileName()).fileName();
+        auto fileName = item->fileName();
         if (fileName != widgetItem->text())
             continue;
         found = item;
@@ -162,8 +156,8 @@ AbstractExtItem *AbstractExtItemAggregator::itemFromWidget(QListWidget *_widget)
 void AbstractExtItemAggregator::repaintList(QListWidget *_widget) const
 {
     _widget->clear();
-    for (auto &_item : items()) {
+    for (auto _item : items()) {
-        QString fileName = QFileInfo(_item->fileName()).fileName();
+        QString fileName = _item->fileName();
         auto item = new QListWidgetItem(fileName, _widget);
         QStringList tooltip;
         tooltip.append(i18n("Name: %1", _item->name()));
@@ -178,9 +172,10 @@ void AbstractExtItemAggregator::repaintList(QListWidget *_widget) const
 int AbstractExtItemAggregator::uniqNumber() const
 {
     QList<int> tagList;
-    for (auto &item : items())
+    for (auto item : items())
         tagList.append(item->number());
-    int number = 0;
+
+    auto number = 0;
     while (tagList.contains(number))
         number++;
 
@@ -196,10 +191,8 @@ QVariant AbstractExtItemAggregator::configArgs() const
 
 QStringList AbstractExtItemAggregator::directories() const
 {
-    auto dirs = QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, QString("awesomewidgets/%1").arg(type()),
+    return QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, QString("awesomewidgets/%1").arg(type()),
-                                          QStandardPaths::LocateDirectory);
+                                     QStandardPaths::LocateDirectory);
-
-    return dirs;
 }
 
 

sources/awesomewidgets/abstractextitemaggregator.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef ABSTRACTEXTITEMAGGREGATOR_H
+#pragma once
-#define ABSTRACTEXTITEMAGGREGATOR_H
 
 #include <QStandardPaths>
 
@@ -24,7 +23,6 @@
 #include "awdebug.h"
 
 
-class QAbstractButton;
 class QListWidget;
 class QListWidgetItem;
 
@@ -60,7 +58,7 @@ public:
     void deleteItem(QListWidget *_widget);
     void editItem(QListWidget *_widget);
     [[nodiscard]] int exec();
-    QString getName();
+    [[nodiscard]] static QString getName();
     virtual void initItems() = 0;
     [[nodiscard]] AbstractExtItem *itemFromWidget(QListWidget *_widget) const;
     void repaintList(QListWidget *_widget) const;
@@ -80,6 +78,3 @@ private:
     // ui methods
     virtual void doCreateItem(QListWidget *_widget) = 0;
 };
-
-
-#endif /* ABSTRACTEXTITEMAGGREGATOR_H */

sources/awesomewidgets/abstractquotesprovider.h

@@ -15,31 +15,17 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef ABSTRACTQUOTESPROVIDER_H
+#pragma once
-#define ABSTRACTQUOTESPROVIDER_H
 
-#include <QObject>
 #include <QUrl>
-
+#include <QVariant>
-#include "abstractextitem.h"
 
 
-class AbstractQuotesProvider : public QObject
+class AbstractQuotesProvider
 {
-    Q_OBJECT
-
 public:
-    explicit AbstractQuotesProvider(QObject *_parent)
+    virtual ~AbstractQuotesProvider() = default;
-        : QObject(_parent){};
-    ~AbstractQuotesProvider() override = default;
     virtual void initUrl(const QString &_asset) = 0;
-    [[nodiscard]] virtual QVariantHash parse(const QByteArray &_source, const QVariantHash &_oldValues) const = 0;
+    [[nodiscard]] virtual QVariantHash parse(const QByteArray &_source) = 0;
-    [[nodiscard]] QString tag(const QString &_type) const
-    {
-        return dynamic_cast<AbstractExtItem *>(parent())->tag(_type);
-    };
     [[nodiscard]] virtual QUrl url() const = 0;
 };
-
-
-#endif /* ABSTRACTQUOTESPROVIDER_H */

sources/awesomewidgets/abstractweatherprovider.h

@@ -15,31 +15,17 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef ABSTRACTWEATHERPROVIDER_H
+#pragma once
-#define ABSTRACTWEATHERPROVIDER_H
 
-#include <QObject>
 #include <QUrl>
-
+#include <QVariant>
-#include "abstractextitem.h"
 
 
-class AbstractWeatherProvider : public QObject
+class AbstractWeatherProvider
 {
-    Q_OBJECT
-
 public:
-    explicit AbstractWeatherProvider(QObject *_parent)
+    virtual ~AbstractWeatherProvider() = default;
-        : QObject(_parent){};
-    ~AbstractWeatherProvider() override = default;
     virtual void initUrl(const QString &_city, const QString &_country, int _ts) = 0;
     [[nodiscard]] virtual QVariantHash parse(const QVariantMap &_json) const = 0;
-    [[nodiscard]] QString tag(const QString &_type) const
-    {
-        return dynamic_cast<AbstractExtItem *>(parent())->tag(_type);
-    };
     [[nodiscard]] virtual QUrl url() const = 0;
 };
-
-
-#endif /* ABSTRACTWEATHERPROVIDER_H */

sources/awesomewidgets/awabstractformatter.cpp

@@ -113,7 +113,7 @@ void AWAbstractFormatter::readConfiguration()
 {
     AbstractExtItem::readConfiguration();
 
-    QSettings settings(fileName(), QSettings::IniFormat);
+    QSettings settings(filePath(), QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
     setStrType(settings.value("X-AW-Type", strType()).toString());
@@ -125,7 +125,7 @@ void AWAbstractFormatter::writeConfiguration() const
 {
     AbstractExtItem::writeConfiguration();
 
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");

sources/awesomewidgets/awabstractformatter.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef AWABSTRACTFORMATTER_H
+#pragma once
-#define AWABSTRACTFORMATTER_H
 
 #include <QRegularExpression>
 
@@ -52,6 +51,3 @@ private:
     // properties
     FormatterClass m_type = FormatterClass::NoFormat;
 };
-
-
-#endif /* AWABSTRACTFORMATTER_H */

sources/awesomewidgets/awdatetimeformatter.cpp

@@ -50,6 +50,7 @@ AWDateTimeFormatter *AWDateTimeFormatter::copy(const QString &_fileName, const i
 
     auto item = new AWDateTimeFormatter(parent(), _fileName);
     AWAbstractFormatter::copyDefaults(item);
+
     item->setFormat(format());
     item->setTranslateString(translateString());
     item->setNumber(_number);
@@ -91,7 +92,7 @@ void AWDateTimeFormatter::readConfiguration()
 {
     AWAbstractFormatter::readConfiguration();
 
-    QSettings settings(fileName(), QSettings::IniFormat);
+    QSettings settings(filePath(), QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
     setFormat(settings.value("X-AW-Format", format()).toString());
@@ -140,7 +141,7 @@ void AWDateTimeFormatter::writeConfiguration() const
 {
     AWAbstractFormatter::writeConfiguration();
 
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");

sources/awesomewidgets/awdatetimeformatter.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef AWDATETIMEFORMATTER_H
+#pragma once
-#define AWDATETIMEFORMATTER_H
 
 #include <QLocale>
 
@@ -52,6 +51,3 @@ private:
     QString m_format = "";
     bool m_translate = true;
 };
-
-
-#endif /* AWDATETIMEFORMATTER_H */

sources/awesomewidgets/awfloatformatter.cpp

@@ -54,6 +54,7 @@ AWFloatFormatter *AWFloatFormatter::copy(const QString &_fileName, const int _nu
 
     auto item = new AWFloatFormatter(parent(), _fileName);
     AWAbstractFormatter::copyDefaults(item);
+
     item->setCount(count());
     item->setFormat(format());
     item->setFillChar(fillChar());
@@ -174,7 +175,7 @@ void AWFloatFormatter::readConfiguration()
 {
     AWAbstractFormatter::readConfiguration();
 
-    QSettings settings(fileName(), QSettings::IniFormat);
+    QSettings settings(filePath(), QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
     setCount(settings.value("X-AW-Width", count()).toInt());
@@ -238,7 +239,7 @@ void AWFloatFormatter::writeConfiguration() const
 {
     AWAbstractFormatter::writeConfiguration();
 
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");

sources/awesomewidgets/awfloatformatter.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef AWFLOATFORMATTER_H
+#pragma once
-#define AWFLOATFORMATTER_H
 
 #include "awabstractformatter.h"
 
@@ -68,6 +67,3 @@ private:
     int m_precision = -1;
     double m_summand = 0.0;
 };
-
-
-#endif /* AWFLOATFORMATTER_H */

sources/awesomewidgets/awjsonformatter.cpp

@@ -41,10 +41,10 @@ QString AWJsonFormatter::convert(const QVariant &_value) const
     qCDebug(LOG_LIB) << "Convert value" << _value;
 
     // check if _value is string and parse first if required
-    QJsonDocument json = _value.userType() == QMetaType::QString ? QJsonDocument::fromJson(_value.toString().toUtf8())
+    auto json = _value.userType() == QMetaType::QString ? QJsonDocument::fromJson(_value.toString().toUtf8())
-                                                                 : QJsonDocument::fromVariant(_value);
+                                                        : QJsonDocument::fromVariant(_value);
-    QVariant converted = json.toVariant();
+    auto converted = json.toVariant();
-    for (auto &element : m_splittedPath)
+    for (auto &element : m_path)
         converted = getFromJson(converted, element);
 
     return converted.toString();
@@ -57,6 +57,7 @@ AWJsonFormatter *AWJsonFormatter::copy(const QString &_fileName, const int _numb
 
     auto item = new AWJsonFormatter(parent(), _fileName);
     AWAbstractFormatter::copyDefaults(item);
+
     item->setNumber(_number);
     item->setPath(path());
 
@@ -66,7 +67,8 @@ AWJsonFormatter *AWJsonFormatter::copy(const QString &_fileName, const int _numb
 
 QString AWJsonFormatter::path() const
 {
-    return m_path;
+    return std::accumulate(m_path.cbegin(), m_path.cend(), QString(""),
+                           [](auto acc, auto &value) { return QString("%1.%2").arg(acc, value.toString()); });
 }
 
 
@@ -74,8 +76,14 @@ void AWJsonFormatter::setPath(const QString &_path)
 {
     qCDebug(LOG_LIB) << "Path" << _path;
 
-    m_path = _path;
+    m_path.clear();
-    initPath();
+    auto elements = _path.split('.', Qt::SkipEmptyParts);
+
+    for (auto &element : elements) {
+        bool ok;
+        auto number = element.toInt(&ok);
+        m_path.append(ok ? QVariant(number) : QVariant(element));
+    }
 }
 
 
@@ -83,7 +91,7 @@ void AWJsonFormatter::readConfiguration()
 {
     AWAbstractFormatter::readConfiguration();
 
-    QSettings settings(fileName(), QSettings::IniFormat);
+    QSettings settings(filePath(), QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
     setPath(settings.value("X-AW-Path", path()).toString());
@@ -129,7 +137,7 @@ void AWJsonFormatter::writeConfiguration() const
 {
     AWAbstractFormatter::writeConfiguration();
 
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");
@@ -171,19 +179,6 @@ QVariant AWJsonFormatter::getFromMap(const QVariant &_value, const QString &_key
 }
 
 
-void AWJsonFormatter::initPath()
-{
-    m_splittedPath.clear();
-    QStringList splittedByDot = m_path.split('.', Qt::SkipEmptyParts);
-
-    for (auto &element : splittedByDot) {
-        bool ok;
-        int number = element.toInt(&ok);
-        m_splittedPath.append(ok ? QVariant(number) : QVariant(element));
-    }
-}
-
-
 void AWJsonFormatter::translate(void *_ui)
 {
     auto ui = reinterpret_cast<Ui::AWJsonFormatter *>(_ui);

sources/awesomewidgets/awjsonformatter.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef AWJSONFORMATTER_H
+#pragma once
-#define AWJSONFORMATTER_H
 
 #include "awabstractformatter.h"
 
@@ -43,12 +42,7 @@ private:
     static QVariant getFromJson(const QVariant &_value, const QVariant &_element);
     static QVariant getFromList(const QVariant &_value, int _index);
     static QVariant getFromMap(const QVariant &_value, const QString &_key);
-    void initPath();
     void translate(void *_ui) override;
     // properties
-    QString m_path;
+    QVariantList m_path;
-    QVariantList m_splittedPath;
 };
-
-
-#endif /* AWJSONFORMATTER_H */

sources/awesomewidgets/awlistformatter.cpp

@@ -53,6 +53,7 @@ AWListFormatter *AWListFormatter::copy(const QString &_fileName, const int _numb
 
     auto item = new AWListFormatter(parent(), _fileName);
     AWAbstractFormatter::copyDefaults(item);
+
     item->setFilter(filter());
     item->setSeparator(separator());
     item->setSorted(isSorted());
@@ -91,7 +92,7 @@ void AWListFormatter::setFilter(const QString &_filter)
 
 void AWListFormatter::setSeparator(const QString &_separator)
 {
-    qCDebug(LOG_LIB) << "Separtor" << _separator;
+    qCDebug(LOG_LIB) << "Separator" << _separator;
 
     m_separator = _separator;
 }
@@ -109,7 +110,7 @@ void AWListFormatter::readConfiguration()
 {
     AWAbstractFormatter::readConfiguration();
 
-    QSettings settings(fileName(), QSettings::IniFormat);
+    QSettings settings(filePath(), QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
     setFilter(settings.value("X-AW-Filter", filter()).toString());
@@ -161,7 +162,7 @@ void AWListFormatter::writeConfiguration() const
 {
     AWAbstractFormatter::writeConfiguration();
 
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");

sources/awesomewidgets/awlistformatter.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef AWLISTFORMATTER_H
+#pragma once
-#define AWLISTFORMATTER_H
 
 #include "awabstractformatter.h"
 
@@ -53,6 +52,3 @@ private:
     bool m_sorted = false;
     QRegularExpression m_regex;
 };
-
-
-#endif /* AWLISTFORMATTER_H */

sources/awesomewidgets/awnoformatter.cpp

@@ -47,6 +47,7 @@ AWNoFormatter *AWNoFormatter::copy(const QString &_fileName, const int _number)
 
     auto item = new AWNoFormatter(parent(), _fileName);
     AWAbstractFormatter::copyDefaults(item);
+
     item->setNumber(_number);
 
     return item;

sources/awesomewidgets/awnoformatter.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef AWNOFORMATTER_H
+#pragma once
-#define AWNOFORMATTER_H
 
 #include "awabstractformatter.h"
 
@@ -35,8 +34,4 @@ public slots:
 
 private:
     void translate(void *_ui) override;
-    // properties
 };
-
-
-#endif /* AWNOFORMATTER_H */

sources/awesomewidgets/awscriptformatter.cpp

@@ -61,6 +61,7 @@ AWScriptFormatter *AWScriptFormatter::copy(const QString &_fileName, const int _
 
     auto item = new AWScriptFormatter(parent(), _fileName);
     AWAbstractFormatter::copyDefaults(item);
+
     item->setAppendCode(appendCode());
     item->setCode(code());
     item->setHasReturn(hasReturn());
@@ -125,7 +126,7 @@ void AWScriptFormatter::readConfiguration()
 {
     AWAbstractFormatter::readConfiguration();
 
-    QSettings settings(fileName(), QSettings::IniFormat);
+    QSettings settings(filePath(), QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
     setAppendCode(settings.value("X-AW-AppendCode", appendCode()).toBool());
@@ -178,7 +179,7 @@ void AWScriptFormatter::writeConfiguration() const
 {
     AWAbstractFormatter::writeConfiguration();
 
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");

sources/awesomewidgets/awscriptformatter.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef AWSCRIPTFORMATTER_H
+#pragma once
-#define AWSCRIPTFORMATTER_H
 
 #include "awabstractformatter.h"
 
@@ -56,6 +55,3 @@ private:
     bool m_hasReturn = false;
     QString m_program;
 };
-
-
-#endif /* AWSCRIPTFORMATTER_H */

sources/awesomewidgets/awstringformatter.cpp

@@ -53,6 +53,7 @@ AWStringFormatter *AWStringFormatter::copy(const QString &_fileName, const int _
 
     auto item = new AWStringFormatter(parent(), _fileName);
     AWAbstractFormatter::copyDefaults(item);
+
     item->setCount(count());
     item->setFillChar(fillChar());
     item->setForceWidth(forceWidth());
@@ -108,7 +109,7 @@ void AWStringFormatter::readConfiguration()
 {
     AWAbstractFormatter::readConfiguration();
 
-    QSettings settings(fileName(), QSettings::IniFormat);
+    QSettings settings(filePath(), QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
     setCount(settings.value("X-AW-Width", count()).toInt());
@@ -160,7 +161,7 @@ void AWStringFormatter::writeConfiguration() const
 {
     AWAbstractFormatter::writeConfiguration();
 
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");

sources/awesomewidgets/awstringformatter.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef AWSTRINGFORMATTER_H
+#pragma once
-#define AWSTRINGFORMATTER_H
 
 #include "awabstractformatter.h"
 
@@ -52,6 +51,3 @@ private:
     QChar m_fillChar = QChar();
     bool m_forceWidth = false;
 };
-
-
-#endif /* AWSTRINGFORMATTER_H */

sources/awesomewidgets/extitemaggregator.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef EXTITEMAGGREGATOR_H
+#pragma once
-#define EXTITEMAGGREGATOR_H
 
 #include <KI18n/KLocalizedString>
 
@@ -24,6 +23,8 @@
 #include <QSettings>
 #include <QStandardPaths>
 
+#include <ranges>
+
 #include "abstractextitemaggregator.h"
 #include "awdebug.h"
 
@@ -49,10 +50,12 @@ public:
         qCDebug(LOG_LIB) << __PRETTY_FUNCTION__;
 
         m_items.clear();
-        m_activeItems.clear();
     };
 
-    QList<T *> activeItems() { return m_activeItems; };
+    auto activeItems()
+    {
+        return m_items | std::ranges::views::filter([](auto item) { return item->isActive(); });
+    };
 
     void editItems()
     {
@@ -63,14 +66,7 @@ public:
     void initItems() override
     {
         m_items.clear();
-        m_activeItems.clear();
-
         m_items = getItems();
-        for (auto &item : m_items) {
-            if (!item->isActive())
-                continue;
-            m_activeItems.append(static_cast<T *>(item));
-        }
     };
 
     void initSockets()
@@ -78,7 +74,7 @@ public:
         // HACK as soon as per one widget instance we have two objects each of
         // them will try to control socket, whereas actually only one of them
         // should be owner of the socket
-        for (auto &item : m_items)
+        for (auto item : m_items)
             item->initSocket();
     }
 
@@ -86,41 +82,34 @@ public:
     {
         qCDebug(LOG_LIB) << "Tag" << _tag << "with used type" << _type;
 
-        T *found = nullptr;
+        auto found = std::find_if(m_items.cbegin(), m_items.cend(),
-        for (auto &item : m_items) {
+                                  [&_tag, &_type](auto item) { return item->tag(_type) == _tag; });
-            if (item->tag(_type) != _tag)
-                continue;
-            found = static_cast<T *>(item);
-            break;
-        }
-        if (found == nullptr)
-            qCWarning(LOG_LIB) << "Could not find item by tag" << _tag;
 
-        return found;
+        if (found == std::end(m_items)) {
+            qCWarning(LOG_LIB) << "Could not find item by tag" << _tag;
+            return nullptr;
+        }
+        return static_cast<T *>(*found);
     };
 
     T *itemByTagNumber(const int _number) const
     {
         qCDebug(LOG_LIB) << "Number" << _number;
 
-        T *found = nullptr;
+        auto found = std::find_if(m_items.cbegin(), m_items.cend(),
-        for (auto &item : m_items) {
+                                  [_number](auto item) { return item->number() == _number; });
-            if (item->number() != _number)
-                continue;
-            found = static_cast<T *>(item);
-            break;
-        }
-        if (found == nullptr)
-            qCWarning(LOG_LIB) << "Could not find item by number" << _number;
 
-        return found;
+        if (found == std::end(m_items)) {
+            qCWarning(LOG_LIB) << "Could not find item by number" << _number;
+            return nullptr;
+        }
+        return static_cast<T *>(*found);
     };
 
     [[nodiscard]] QList<AbstractExtItem *> items() const override { return m_items; };
 
 private:
     QList<AbstractExtItem *> m_items;
-    QList<T *> m_activeItems;
 
     void doCreateItem(QListWidget *_widget) override { return createItem<T>(_widget); }
 
@@ -128,9 +117,8 @@ private:
     {
         QList<AbstractExtItem *> items;
 
-        auto dirs = directories();
+        for (auto &dir : directories()) {
-        for (auto &dir : dirs) {
+            auto files = QDir(dir).entryList(QDir::Files, QDir::Name);
-            QStringList files = QDir(dir).entryList(QDir::Files, QDir::Name);
             for (auto &file : files) {
                 // check filename
                 if (!file.endsWith(".desktop"))
@@ -138,18 +126,14 @@ private:
                 qCInfo(LOG_LIB) << "Found file" << file << "in" << dir;
                 auto filePath = QString("%1/%2").arg(dir, file);
                 // check if already exists
-                if (std::any_of(items.cbegin(), items.cend(),
+                if (std::any_of(items.cbegin(), items.cend(), [&file](auto item) { return item->fileName() == file; }))
-                                [&filePath](AbstractExtItem *item) { return (item->fileName() == filePath); }))
                     continue;
                 items.append(new T(this, filePath));
             }
         }
 
         // sort items
-        std::sort(items.begin(), items.end(), [](auto *lhs, auto *rhs) { return lhs->number() < rhs->number(); });
+        std::sort(items.begin(), items.end(), [](auto lhs, auto rhs) { return lhs->number() < rhs->number(); });
         return items;
     };
 };
-
-
-#endif /* EXTITEMAGGREGATOR_H */

sources/awesomewidgets/extnetworkrequest.cpp

@@ -40,9 +40,8 @@ ExtNetworkRequest::ExtNetworkRequest(QObject *_parent, const QString &_filePath)
     // HACK declare as child of nullptr to avoid crash with plasmawindowed
     // in the destructor
     m_manager = new QNetworkAccessManager(nullptr);
-    connect(m_manager, SIGNAL(finished(QNetworkReply *)), this, SLOT(networkReplyReceived(QNetworkReply *)));
+    connect(m_manager, &QNetworkAccessManager::finished, this, &ExtNetworkRequest::networkReplyReceived);
-
+    connect(this, &ExtNetworkRequest::requestDataUpdate, this, &ExtNetworkRequest::sendRequest);
-    connect(this, SIGNAL(requestDataUpdate()), this, SLOT(sendRequest()));
 }
 
 
@@ -50,9 +49,6 @@ ExtNetworkRequest::~ExtNetworkRequest()
 {
     qCDebug(LOG_LIB) << __PRETTY_FUNCTION__;
 
-    disconnect(m_manager, SIGNAL(finished(QNetworkReply *)), this, SLOT(networkReplyReceived(QNetworkReply *)));
-    disconnect(this, SIGNAL(requestDataUpdate()), this, SLOT(sendRequest()));
-
     m_manager->deleteLater();
 }
 
@@ -63,31 +59,31 @@ ExtNetworkRequest *ExtNetworkRequest::copy(const QString &_fileName, const int _
 
     auto item = new ExtNetworkRequest(parent(), _fileName);
     copyDefaults(item);
+
     item->setNumber(_number);
-    item->setStringUrl(stringUrl());
+    item->setUrl(url());
 
     return item;
 }
 
 
-QString ExtNetworkRequest::stringUrl() const
+QString ExtNetworkRequest::url() const
-{
-    return m_stringUrl;
-}
-
-
-QString ExtNetworkRequest::uniq() const
 {
     return m_url.toString();
 }
 
 
-void ExtNetworkRequest::setStringUrl(const QString &_url)
+QString ExtNetworkRequest::uniq() const
+{
+    return url();
+}
+
+
+void ExtNetworkRequest::setUrl(const QString &_url)
 {
     qCDebug(LOG_LIB) << "Url" << _url;
 
-    m_stringUrl = _url;
+    m_url = QUrl(_url);
-    initUrl();
 }
 
 
@@ -95,10 +91,10 @@ void ExtNetworkRequest::readConfiguration()
 {
     AbstractExtItem::readConfiguration();
 
-    QSettings settings(fileName(), QSettings::IniFormat);
+    QSettings settings(filePath(), QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
-    setStringUrl(settings.value("X-AW-Url", stringUrl()).toString());
+    setUrl(settings.value("X-AW-Url", url()).toString());
     settings.endGroup();
 
     bumpApi(AW_EXTNETREQUEST_API);
@@ -127,7 +123,7 @@ int ExtNetworkRequest::showConfiguration(QWidget *_parent, const QVariant &_args
     ui->lineEdit_name->setText(name());
     ui->lineEdit_comment->setText(comment());
     ui->label_numberValue->setText(QString("%1").arg(number()));
-    ui->lineEdit_url->setText(stringUrl());
+    ui->lineEdit_url->setText(url());
     ui->checkBox_active->setCheckState(isActive() ? Qt::Checked : Qt::Unchecked);
     ui->lineEdit_schedule->setText(cron());
     ui->lineEdit_socket->setText(socket());
@@ -139,7 +135,7 @@ int ExtNetworkRequest::showConfiguration(QWidget *_parent, const QVariant &_args
         setComment(ui->lineEdit_comment->text());
         setNumber(ui->label_numberValue->text().toInt());
         setApiVersion(AW_EXTNETREQUEST_API);
-        setStringUrl(ui->lineEdit_url->text());
+        setUrl(ui->lineEdit_url->text());
         setActive(ui->checkBox_active->checkState() == Qt::Checked);
         setCron(ui->lineEdit_schedule->text());
         setSocket(ui->lineEdit_socket->text());
@@ -159,11 +155,11 @@ void ExtNetworkRequest::writeConfiguration() const
 {
     AbstractExtItem::writeConfiguration();
 
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");
-    settings.setValue("X-AW-Url", stringUrl());
+    settings.setValue("X-AW-Url", url());
     settings.endGroup();
 
     settings.sync();
@@ -191,12 +187,6 @@ void ExtNetworkRequest::sendRequest()
 }
 
 
-void ExtNetworkRequest::initUrl()
-{
-    m_url = QUrl(m_stringUrl);
-}
-
-
 void ExtNetworkRequest::translate(void *_ui)
 {
     auto ui = reinterpret_cast<Ui::ExtNetworkRequest *>(_ui);

sources/awesomewidgets/extnetworkrequest.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef EXTNETWORKREQUEST_H
+#pragma once
-#define EXTNETWORKREQUEST_H
 
 #include <QNetworkReply>
 
@@ -26,17 +25,17 @@
 class ExtNetworkRequest : public AbstractExtItem
 {
     Q_OBJECT
-    Q_PROPERTY(QString stringUrl READ stringUrl WRITE setStringUrl)
+    Q_PROPERTY(QString url READ url WRITE setUrl)
 
 public:
     explicit ExtNetworkRequest(QObject *_parent = nullptr, const QString &_filePath = "");
     ~ExtNetworkRequest() override;
     ExtNetworkRequest *copy(const QString &_fileName, int _number) override;
     // get methods
-    [[nodiscard]] QString stringUrl() const;
+    [[nodiscard]] QString url() const;
     [[nodiscard]] QString uniq() const override;
     // set methods
-    void setStringUrl(const QString &_url);
+    void setUrl(const QString &_url);
 
 public slots:
     void readConfiguration() override;
@@ -52,13 +51,9 @@ private:
     QNetworkAccessManager *m_manager = nullptr;
     QUrl m_url;
     bool m_isRunning = false;
-    void initUrl();
     void translate(void *_ui) override;
     // properties
     QString m_stringUrl = "https://httpbin.org/get";
     // values
     QVariantHash m_values;
 };
-
-
-#endif /* EXTNETWORKREQUEST_H */

sources/awesomewidgets/extquotes.cpp

@@ -55,9 +55,6 @@ ExtQuotes::~ExtQuotes()
 {
     qCDebug(LOG_LIB) << __PRETTY_FUNCTION__;
 
-    disconnect(m_manager, &QNetworkAccessManager::finished, this, &ExtQuotes::quotesReplyReceived);
-    disconnect(this, &ExtQuotes::requestDataUpdate, this, &ExtQuotes::sendRequest);
-
     m_manager->deleteLater();
 }
 
@@ -68,6 +65,7 @@ ExtQuotes *ExtQuotes::copy(const QString &_fileName, const int _number)
 
     auto item = new ExtQuotes(parent(), _fileName);
     copyDefaults(item);
+
     item->setNumber(_number);
     item->setTicker(ticker());
 
@@ -100,7 +98,7 @@ void ExtQuotes::readConfiguration()
 {
     AbstractExtItem::readConfiguration();
 
-    QSettings settings(fileName(), QSettings::IniFormat);
+    QSettings settings(filePath(), QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
     setTicker(settings.value("X-AW-Ticker", ticker()).toString());
@@ -164,7 +162,7 @@ void ExtQuotes::writeConfiguration() const
 {
     AbstractExtItem::writeConfiguration();
 
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");
@@ -185,10 +183,10 @@ void ExtQuotes::quotesReplyReceived(QNetworkReply *_reply)
     auto text = _reply->readAll();
     _reply->deleteLater();
 
-    auto data = m_providerObject->parse(text, m_values);
+    auto data = m_providerObject->parse(text);
-    if (data.isEmpty())
+    for (auto [key, value] : data.asKeyValueRange()) {
-        return;
+        m_values[tag(key)] = value;
-    m_values = data;
+    }
 
     emit(dataReceived(m_values));
 }
@@ -204,10 +202,8 @@ void ExtQuotes::sendRequest()
 
 void ExtQuotes::initProvider()
 {
-    delete m_providerObject;
-
     // in the future release it is possible to change provider here
-    m_providerObject = new StooqQuotesProvider(this);
+    m_providerObject = std::make_unique<StooqQuotesProvider>();
 
     return m_providerObject->initUrl(ticker());
 }

sources/awesomewidgets/extquotes.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef EXTQUOTES_H
+#pragma once
-#define EXTQUOTES_H
 
 #include <QNetworkReply>
 
@@ -51,7 +50,7 @@ private slots:
     void sendRequest();
 
 private:
-    AbstractQuotesProvider *m_providerObject = nullptr;
+    std::unique_ptr<AbstractQuotesProvider> m_providerObject;
     QNetworkAccessManager *m_manager = nullptr;
     bool m_isRunning = false;
     void initProvider();
@@ -61,6 +60,3 @@ private:
     // values
     QVariantHash m_values;
 };
-
-
-#endif /* EXTQUOTES_H */

sources/awesomewidgets/extscript.cpp

@@ -40,10 +40,10 @@ ExtScript::ExtScript(QObject *_parent, const QString &_filePath)
     m_values[tag("custom")] = "";
 
     m_process = new QProcess(nullptr);
-    connect(m_process, SIGNAL(finished(int, QProcess::ExitStatus)), this, SLOT(updateValue()));
+    connect(m_process, &QProcess::finished, [this]() { return updateValue(); });
     m_process->waitForFinished(0);
 
-    connect(this, SIGNAL(requestDataUpdate()), this, SLOT(startProcess()));
+    connect(this, &ExtScript::requestDataUpdate, this, &ExtScript::startProcess);
 }
 
 
@@ -51,10 +51,8 @@ ExtScript::~ExtScript()
 {
     qCDebug(LOG_LIB) << __PRETTY_FUNCTION__;
 
-    disconnect(m_process, SIGNAL(finished(int, QProcess::ExitStatus)), this, SLOT(updateValue()));
     m_process->kill();
     m_process->deleteLater();
-    disconnect(this, SIGNAL(requestDataUpdate()), this, SLOT(startProcess()));
 }
 
 
@@ -64,6 +62,7 @@ ExtScript *ExtScript::copy(const QString &_fileName, const int _number)
 
     auto item = new ExtScript(parent(), _fileName);
     copyDefaults(item);
+
     item->setExecutable(executable());
     item->setNumber(_number);
     item->setRedirect(redirect());
@@ -180,8 +179,8 @@ QString ExtScript::applyFilters(QString _value) const
             qCWarning(LOG_LIB) << "Could not find filter" << _value << "in the json";
             continue;
         }
-        for (auto &f : filter.keys())
+        for (auto [key, value] : filter.asKeyValueRange())
-            _value.replace(f, filter[f].toString());
+            _value.replace(key, value.toString());
     }
 
     return _value;
@@ -206,7 +205,7 @@ void ExtScript::readConfiguration()
 {
     AbstractExtItem::readConfiguration();
 
-    QSettings settings(fileName(), QSettings::IniFormat);
+    QSettings settings(filePath(), QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
     setExecutable(settings.value("Exec", executable()).toString());
@@ -227,11 +226,11 @@ void ExtScript::readJsonFilters()
         qCWarning(LOG_LIB) << "Could not open" << fileName;
         return;
     }
-    QString jsonText = jsonFile.readAll();
+    auto jsonText = jsonFile.readAll();
     jsonFile.close();
 
     QJsonParseError error{};
-    auto jsonDoc = QJsonDocument::fromJson(jsonText.toUtf8(), &error);
+    auto jsonDoc = QJsonDocument::fromJson(jsonText, &error);
     if (error.error != QJsonParseError::NoError) {
         qCWarning(LOG_LIB) << "Parse error" << error.errorString();
         return;
@@ -306,7 +305,7 @@ void ExtScript::writeConfiguration() const
 {
     AbstractExtItem::writeConfiguration();
 
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");
@@ -333,24 +332,24 @@ void ExtScript::updateValue()
     qCInfo(LOG_LIB) << "Error" << qdebug;
     auto qoutput = QString::fromUtf8(m_process->readAllStandardOutput()).trimmed();
     qCInfo(LOG_LIB) << "Output" << qoutput;
-    QString strValue;
 
+    QString result;
     switch (redirect()) {
     case Redirect::stdout2stderr:
         break;
     case Redirect::stderr2stdout:
-        strValue = QString("%1\n%2").arg(qdebug).arg(qoutput);
+        result = QString("%1\n%2").arg(qdebug, qoutput);
         break;
     case Redirect::swap:
-        strValue = qdebug;
+        result = qdebug;
         break;
     case Redirect::nothing:
-        strValue = qoutput;
+        result = qoutput;
         break;
     }
 
     // filters
-    m_values[tag("custom")] = applyFilters(strValue);
+    m_values[tag("custom")] = applyFilters(result);
     emit(dataReceived(m_values));
 }
 

sources/awesomewidgets/extscript.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef EXTSCRIPT_H
+#pragma once
-#define EXTSCRIPT_H
 
 #include <QProcess>
 
@@ -76,6 +75,3 @@ private:
     QVariantMap m_jsonFilters;
     QVariantHash m_values;
 };
-
-
-#endif /* EXTSCRIPT_H */

sources/awesomewidgets/extupgrade.cpp

@@ -36,10 +36,10 @@ ExtUpgrade::ExtUpgrade(QObject *_parent, const QString &_filePath)
     m_values[tag("pkgcount")] = 0;
 
     m_process = new QProcess(nullptr);
-    connect(m_process, SIGNAL(finished(int)), this, SLOT(updateValue()));
+    connect(m_process, &QProcess::finished, this, &ExtUpgrade::updateValue);
     m_process->waitForFinished(0);
 
-    connect(this, SIGNAL(requestDataUpdate()), this, SLOT(startProcess()));
+    connect(this, &ExtUpgrade::requestDataUpdate, this, &ExtUpgrade::startProcess);
 }
 
 
@@ -49,7 +49,6 @@ ExtUpgrade::~ExtUpgrade()
 
     m_process->kill();
     m_process->deleteLater();
-    disconnect(this, SIGNAL(requestDataUpdate()), this, SLOT(startProcess()));
 }
 
 
@@ -59,6 +58,7 @@ ExtUpgrade *ExtUpgrade::copy(const QString &_fileName, const int _number)
 
     auto item = new ExtUpgrade(parent(), _fileName);
     copyDefaults(item);
+
     item->setExecutable(executable());
     item->setFilter(filter());
     item->setNumber(_number);
@@ -122,7 +122,7 @@ void ExtUpgrade::readConfiguration()
 {
     AbstractExtItem::readConfiguration();
 
-    QSettings settings(fileName(), QSettings::IniFormat);
+    QSettings settings(filePath(), QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
     setExecutable(settings.value("Exec", executable()).toString());
@@ -193,7 +193,7 @@ void ExtUpgrade::writeConfiguration() const
 {
     AbstractExtItem::writeConfiguration();
 
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");

sources/awesomewidgets/extupgrade.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef EXTUPGRADE_H
+#pragma once
-#define EXTUPGRADE_H
 
 #include <QProcess>
 
@@ -64,6 +63,3 @@ private:
     // internal properties
     QVariantHash m_values;
 };
-
-
-#endif /* EXTUPGRADE_H */

sources/awesomewidgets/extweather.cpp

@@ -49,9 +49,8 @@ ExtWeather::ExtWeather(QObject *_parent, const QString &_filePath)
     // HACK declare as child of nullptr to avoid crash with plasmawindowed
     // in the destructor
     m_manager = new QNetworkAccessManager(nullptr);
-    connect(m_manager, SIGNAL(finished(QNetworkReply *)), this, SLOT(weatherReplyReceived(QNetworkReply *)));
+    connect(m_manager, &QNetworkAccessManager::finished, this, &ExtWeather::weatherReplyReceived);
-
+    connect(this, &ExtWeather::requestDataUpdate, this, &ExtWeather::sendRequest);
-    connect(this, SIGNAL(requestDataUpdate()), this, SLOT(sendRequest()));
 }
 
 
@@ -59,9 +58,6 @@ ExtWeather::~ExtWeather()
 {
     qCDebug(LOG_LIB) << __PRETTY_FUNCTION__;
 
-    disconnect(m_manager, SIGNAL(finished(QNetworkReply *)), this, SLOT(weatherReplyReceived(QNetworkReply *)));
-    disconnect(this, SIGNAL(requestDataUpdate()), this, SLOT(sendRequest()));
-
     m_manager->deleteLater();
 }
 
@@ -72,6 +68,7 @@ ExtWeather *ExtWeather::copy(const QString &_fileName, const int _number)
 
     auto item = new ExtWeather(parent(), _fileName);
     copyDefaults(item);
+
     item->setCity(city());
     item->setCountry(country());
     item->setImage(image());
@@ -150,7 +147,7 @@ int ExtWeather::ts() const
 
 QString ExtWeather::uniq() const
 {
-    return QString("%1 (%2) at %3").arg(city()).arg(country()).arg(ts());
+    return QString("%1 (%2) at %3").arg(city(), country()).arg(ts());
 }
 
 
@@ -213,7 +210,7 @@ void ExtWeather::readConfiguration()
 {
     AbstractExtItem::readConfiguration();
 
-    QSettings settings(fileName(), QSettings::IniFormat);
+    QSettings settings(filePath(), QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
     setCity(settings.value("X-AW-City", city()).toString());
@@ -237,11 +234,11 @@ void ExtWeather::readJsonMap()
         qCWarning(LOG_LIB) << "Could not open" << fileName;
         return;
     }
-    QString jsonText = jsonFile.readAll();
+    auto jsonText = jsonFile.readAll();
     jsonFile.close();
 
     QJsonParseError error{};
-    auto jsonDoc = QJsonDocument::fromJson(jsonText.toUtf8(), &error);
+    auto jsonDoc = QJsonDocument::fromJson(jsonText, &error);
     if (error.error != QJsonParseError::NoError) {
         qCWarning(LOG_LIB) << "Parse error" << error.errorString();
         return;
@@ -314,7 +311,7 @@ void ExtWeather::writeConfiguration() const
 {
     AbstractExtItem::writeConfiguration();
 
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");
@@ -354,9 +351,8 @@ void ExtWeather::weatherReplyReceived(QNetworkReply *_reply)
     }
 
     auto data = m_providerObject->parse(jsonDoc.toVariant().toMap());
-    if (data.isEmpty())
+    for (auto [key, value] : data.asKeyValueRange())
-        return;
+        m_values[tag(key)] = value;
-    m_values = data;
     m_values[tag("weather")] = weatherFromInt(m_values[tag("weatherId")].toInt());
 
     emit(dataReceived(m_values));
@@ -365,10 +361,8 @@ void ExtWeather::weatherReplyReceived(QNetworkReply *_reply)
 
 void ExtWeather::initProvider()
 {
-    delete m_providerObject;
-
     // in the future release it is possible to change provider here
-    m_providerObject = new OWMWeatherProvider(this);
+    m_providerObject = std::make_unique<OWMWeatherProvider>();
 
     return m_providerObject->initUrl(city(), country(), ts());
 }

sources/awesomewidgets/extweather.h

@@ -15,8 +15,7 @@
  *   along with awesome-widgets. If not, see http://www.gnu.org/licenses/  *
  ***************************************************************************/
 
-#ifndef EXTWEATHER_H
+#pragma once
-#define EXTWEATHER_H
 
 #include <QNetworkReply>
 
@@ -75,7 +74,7 @@ private slots:
     void weatherReplyReceived(QNetworkReply *_reply);
 
 private:
-    AbstractWeatherProvider *m_providerObject = nullptr;
+    std::unique_ptr<AbstractWeatherProvider> m_providerObject;
     QNetworkAccessManager *m_manager = nullptr;
     bool m_isRunning = false;
     void initProvider();
@@ -90,6 +89,3 @@ private:
     // values
     QVariantHash m_values;
 };
-
-
-#endif /* EXTWEATHER_H */

sources/awesomewidgets/graphicalitem.cpp

@@ -39,7 +39,7 @@ GraphicalItem::GraphicalItem(QObject *_parent, const QString &_filePath)
 
     // init scene
     m_scene = new QGraphicsScene();
-    m_scene->setBackgroundBrush(QBrush(Qt::NoBrush));
+    m_scene->setBackgroundBrush({Qt::NoBrush});
     // init view
     m_view = new QGraphicsView(m_scene);
     m_view->setStyleSheet("background: transparent");
@@ -55,12 +55,22 @@ GraphicalItem::GraphicalItem(QObject *_parent, const QString &_filePath)
 }
 
 
+GraphicalItem::~GraphicalItem()
+{
+    qCDebug(LOG_LIB) << __PRETTY_FUNCTION__;
+
+    m_view->deleteLater();
+    m_scene->deleteLater();
+}
+
+
 GraphicalItem *GraphicalItem::copy(const QString &_fileName, const int _number)
 {
     qCDebug(LOG_LIB) << "File" << _fileName << "with number" << _number;
 
     auto item = new GraphicalItem(parent(), _fileName);
     copyDefaults(item);
+
     item->setActiveColor(activeColor());
     item->setBar(bar());
     item->setCount(count());
@@ -83,44 +93,41 @@ QString GraphicalItem::image(const QVariant &value)
     qCDebug(LOG_LIB) << "Value" << value;
 
     m_scene->clear();
-    int scale[2] = {1, 1};
+    auto scaleX = 1, scaleY = 1;
-    auto converted = GraphicalItemHelper::getPercents(value.toFloat(), minValue(), maxValue());
+    auto converted = GraphicalItemHelper::getPercents(value.toDouble(), minValue(), maxValue());
 
     // paint
     switch (m_type) {
     case Type::Vertical:
         m_helper->paintVertical(converted);
-        // scale
+        scaleY = -2 * static_cast<int>(direction()) + 1;
-        scale[1] = -2 * static_cast<int>(direction()) + 1;
         break;
     case Type::Circle:
         m_helper->paintCircle(converted);
-        // scale
+        scaleX = -2 * static_cast<int>(direction()) + 1;
-        scale[0] = -2 * static_cast<int>(direction()) + 1;
         break;
     case Type::Graph:
         m_helper->paintGraph(converted);
-        scale[0] = -2 * static_cast<int>(direction()) + 1;
+        scaleX = -2 * static_cast<int>(direction()) + 1;
-        scale[1] = -1;
+        scaleY = -1;
         break;
     case Type::Bars:
         m_helper->paintBars(converted);
-        scale[0] = -2 * static_cast<int>(direction()) + 1;
+        scaleX = -2 * static_cast<int>(direction()) + 1;
-        scale[1] = -1;
+        scaleY = -1;
         break;
     case Type::Horizontal:
         m_helper->paintHorizontal(converted);
-        // scale
+        scaleX = -2 * static_cast<int>(direction()) + 1;
-        scale[0] = -2 * static_cast<int>(direction()) + 1;
         break;
     }
 
     // convert
-    auto pixmap = m_view->grab().transformed(QTransform().scale(scale[0], scale[1]));
+    auto pixmap = m_view->grab().transformed(QTransform().scale(scaleX, scaleY));
     QByteArray byteArray;
     QBuffer buffer(&byteArray);
     pixmap.save(&buffer, "PNG");
-    auto url = QString("<img src=\"data:image/png;base64,%1\"/>").arg(QString(byteArray.toBase64()));
+    auto url = QString("<img src=\"data:image/png;base64,%1\"/>").arg(byteArray.toBase64());
 
     return url;
 }
@@ -175,13 +182,13 @@ int GraphicalItem::itemWidth() const
 }
 
 
-float GraphicalItem::maxValue() const
+double GraphicalItem::maxValue() const
 {
     return m_maxValue;
 }
 
 
-float GraphicalItem::minValue() const
+double GraphicalItem::minValue() const
 {
     return m_minValue;
 }
@@ -314,7 +321,7 @@ void GraphicalItem::setItemWidth(const int _width)
 }
 
 
-void GraphicalItem::setMaxValue(const float _value)
+void GraphicalItem::setMaxValue(const double _value)
 {
     qCDebug(LOG_LIB) << "Max value" << _value;
 
@@ -322,7 +329,7 @@ void GraphicalItem::setMaxValue(const float _value)
 }
 
 
-void GraphicalItem::setMinValue(const float _value)
+void GraphicalItem::setMinValue(const double _value)
 {
     qCDebug(LOG_LIB) << "Min value" << _value;
 
@@ -393,14 +400,14 @@ void GraphicalItem::readConfiguration()
 {
     AbstractExtItem::readConfiguration();
 
-    QSettings settings(fileName(), QSettings::IniFormat);
+    QSettings settings(filePath(), QSettings::IniFormat);
 
     settings.beginGroup("Desktop Entry");
     setCount(settings.value("X-AW-Count", count()).toInt());
     setCustom(settings.value("X-AW-Custom", isCustom()).toBool());
     setBar(settings.value("X-AW-Value", bar()).toString());
-    setMaxValue(settings.value("X-AW-Max", maxValue()).toFloat());
+    setMaxValue(settings.value("X-AW-Max", maxValue()).toDouble());
-    setMinValue(settings.value("X-AW-Min", minValue()).toFloat());
+    setMinValue(settings.value("X-AW-Min", minValue()).toDouble());
     setActiveColor(settings.value("X-AW-ActiveColor", activeColor()).toString());
     setInactiveColor(settings.value("X-AW-InactiveColor", inactiveColor()).toString());
     setStrType(settings.value("X-AW-Type", strType()).toString());
@@ -432,9 +439,8 @@ int GraphicalItem::showConfiguration(QWidget *_parent, const QVariant &_args)
     ui->setupUi(dialog);
     translate(ui);
 
-    connect(ui->checkBox_custom, &QCheckBox::stateChanged, [this, ui](const int state) { changeValue(ui, state); });
+    connect(ui->checkBox_custom, &QCheckBox::stateChanged, [ui](const int state) { changeValue(ui, state); });
-    connect(ui->comboBox_type, &QComboBox::currentIndexChanged,
+    connect(ui->comboBox_type, &QComboBox::currentIndexChanged, [ui](const int state) { changeCountState(ui, state); });
-            [this, ui](const int state) { changeCountState(ui, state); });
     connect(ui->toolButton_activeColor, &QToolButton::clicked, [this, ui]() { changeColor(ui); });
     connect(ui->toolButton_inactiveColor, &QToolButton::clicked, [this, ui]() { changeColor(ui); });
 
@@ -502,7 +508,7 @@ void GraphicalItem::writeConfiguration() const
 {
     AbstractExtItem::writeConfiguration();
 
-    QSettings settings(writtableConfig(), QSettings::IniFormat);
+    QSettings settings(writableConfig(), QSettings::IniFormat);
     qCInfo(LOG_LIB) << "Configuration file" << settings.fileName();
 
     settings.beginGroup("Desktop Entry");