refactor: fix some minor clang-tidy warnings

sources/test/testabstractextitem.cpp

@@ -34,7 +34,7 @@ void TestAbstractExtItem::initTestCase()
     comment = AWTestLibrary::randomString();
     socket = AWTestLibrary::randomString();
 
-    extItem = new ExtUpgrade(nullptr, filePath);
+    extItem = new ExtUpgrade(this, filePath);
     extItem->setActive(false);
     extItem->setApiVersion(1);
     extItem->setComment(comment);
@@ -48,7 +48,6 @@ void TestAbstractExtItem::initTestCase()
 void TestAbstractExtItem::cleanupTestCase()
 {
     QFile::remove(filePath);
-    delete extItem;
 }
 
 
@@ -83,7 +82,7 @@ void TestAbstractExtItem::test_configuration()
     QCOMPARE(newExtItem->socket(), extItem->socket());
     QCOMPARE(newExtItem->cron(), extItem->cron());
 
-    delete newExtItem;
+    newExtItem->deleteLater();
 }
 
 
@@ -102,7 +101,7 @@ void TestAbstractExtItem::test_delete()
     QVERIFY(newExtItem->tryDelete());
     QVERIFY(!QFile::exists(writeFilePath));
 
-    delete newExtItem;
+    newExtItem->deleteLater();
 }
 
 
@@ -117,7 +116,7 @@ void TestAbstractExtItem::test_copy()
     QCOMPARE(newExtItem->socket(), extItem->socket());
     QCOMPARE(newExtItem->cron(), extItem->cron());
 
-    delete newExtItem;
+    newExtItem->deleteLater();
 }
 
 

sources/test/testabstractformatter.cpp

@@ -26,14 +26,11 @@
 void TestAbstractFormatter::initTestCase()
 {
     AWTestLibrary::init();
-    formatter = new AWNoFormatter(nullptr);
+    formatter = new AWNoFormatter(this);
 }
 
 
-void TestAbstractFormatter::cleanupTestCase()
-{
-    delete formatter;
-}
+void TestAbstractFormatter::cleanupTestCase() {}
 
 
 void TestAbstractFormatter::test_values() {}
@@ -58,7 +55,7 @@ void TestAbstractFormatter::test_copy()
     QCOMPARE(newFormatter->type(), formatter->type());
     QCOMPARE(newFormatter->name(), formatter->name());
 
-    delete newFormatter;
+    newFormatter->deleteLater();
 }
 
 

sources/test/testawbugreporter.cpp

@@ -31,10 +31,7 @@ void TestAWBugReporter::initTestCase()
 }
 
 
-void TestAWBugReporter::cleanupTestCase()
-{
-    delete plugin;
-}
+void TestAWBugReporter::cleanupTestCase() {}
 
 
 void TestAWBugReporter::test_generateText()
@@ -54,7 +51,7 @@ void TestAWBugReporter::test_sendBugReport()
                           plugin->generateText(data.at(0), data.at(1), data.at(2), data.at(3)));
 
     QVERIFY(spy.wait(5000));
-    QVariantList arguments = spy.takeFirst();
+    auto arguments = spy.takeFirst();
 
     QVERIFY(arguments.at(0).toInt() > 0);
     QVERIFY(!arguments.at(1).toString().isEmpty());

sources/test/testawconfighelper.cpp

@@ -30,10 +30,7 @@ void TestAWConfigHelper::initTestCase()
 }
 
 
-void TestAWConfigHelper::cleanupTestCase()
-{
-    delete plugin;
-}
+void TestAWConfigHelper::cleanupTestCase() {}
 
 
 void TestAWConfigHelper::test_configurationDirectory()

sources/test/testawkeys.cpp

@@ -67,10 +67,7 @@ void TestAWKeys::initTestCase()
 }
 
 
-void TestAWKeys::cleanupTestCase()
-{
-    delete plugin;
-}
+void TestAWKeys::cleanupTestCase() {}
 
 
 void TestAWKeys::test_dictKeys()

sources/test/testawpatternfunctions.cpp

@@ -42,7 +42,7 @@ void TestAWPatternFunctions::test_findFunctionCalls()
 
     auto pattern = AWTestLibrary::randomString() + function + AWTestLibrary::randomString();
 
-    QList<AWPatternFunctions::AWFunction> found = AWPatternFunctions::findFunctionCalls(name, pattern);
+    auto found = AWPatternFunctions::findFunctionCalls(name, pattern);
     QCOMPARE(found.count(), 1);
 
     QCOMPARE(found.at(0).args, args);

sources/test/testawtelemetryhandler.cpp

@@ -33,10 +33,7 @@ void TestAWTelemetryHandler::initTestCase()
 }
 
 
-void TestAWTelemetryHandler::cleanupTestCase()
-{
-    delete plugin;
-}
+void TestAWTelemetryHandler::cleanupTestCase() {}
 
 
 void TestAWTelemetryHandler::test_put()

sources/test/testawupdatehelper.cpp

@@ -30,10 +30,7 @@ void TestAWUpdateHelper::initTestCase()
 }
 
 
-void TestAWUpdateHelper::cleanupTestCase()
-{
-    delete plugin;
-}
+void TestAWUpdateHelper::cleanupTestCase() {}
 
 
 void TestAWUpdateHelper::test_checkVersion()

sources/test/testbatterysource.cpp

@@ -32,10 +32,7 @@ void TestBatterySource::initTestCase()
 }
 
 
-void TestBatterySource::cleanupTestCase()
-{
-    delete source;
-}
+void TestBatterySource::cleanupTestCase() {}
 
 
 void TestBatterySource::test_sources()
@@ -53,11 +50,11 @@ void TestBatterySource::test_battery()
     std::for_each(batteries.cbegin(), batteries.cend(), [this](auto bat) {
         auto value = source->data(bat);
         if (bat == "ac")
-            QCOMPARE(value.type(), QVariant::Bool);
+            QCOMPARE(value.typeId(), QMetaType::Bool);
         else if (bat.startsWith("batrate") || bat.startsWith("batleft"))
             ;
         else
-            QVERIFY((value.toFloat() >= battery.first) || (std::isnan(value.toFloat())));
+            QVERIFY((value.toDouble() >= battery.first) || (std::isnan(value.toDouble())));
     });
 }
 

sources/test/testdatetimeformatter.cpp

@@ -29,15 +29,12 @@ void TestAWDateTimeFormatter::initTestCase()
     AWTestLibrary::init();
     format = AWTestLibrary::randomSelect(QString(TIME_KEYS).split(',')).join(' ');
 
-    formatter = new AWDateTimeFormatter(nullptr);
+    formatter = new AWDateTimeFormatter(this);
     formatter->setFormat(format);
 }
 
 
-void TestAWDateTimeFormatter::cleanupTestCase()
-{
-    delete formatter;
-}
+void TestAWDateTimeFormatter::cleanupTestCase() {}
 
 
 void TestAWDateTimeFormatter::test_values()
@@ -62,7 +59,7 @@ void TestAWDateTimeFormatter::test_copy()
     QCOMPARE(newFormatter->translateString(), formatter->translateString());
     QCOMPARE(newFormatter->number(), 1);
 
-    delete newFormatter;
+    newFormatter->deleteLater();
 }
 
 

sources/test/testdesktopsource.cpp

@@ -31,10 +31,7 @@ void TestDesktopSource::initTestCase()
 }
 
 
-void TestDesktopSource::cleanupTestCase()
-{
-    delete source;
-}
+void TestDesktopSource::cleanupTestCase() {}
 
 
 void TestDesktopSource::test_sources()

sources/test/testdpplugin.cpp

@@ -32,10 +32,7 @@ void TestDPPlugin::initTestCase()
 }
 
 
-void TestDPPlugin::cleanupTestCase()
-{
-    delete plugin;
-}
+void TestDPPlugin::cleanupTestCase() {}
 
 
 void TestDPPlugin::test_desktops()

sources/test/testextitemaggregator.cpp

@@ -27,14 +27,11 @@
 void TestExtItemAggregator::initTestCase()
 {
     AWTestLibrary::init();
-    aggregator = new ExtItemAggregator<AWNoFormatter>(nullptr, type);
+    aggregator = new ExtItemAggregator<AWNoFormatter>(this, type);
 }
 
 
-void TestExtItemAggregator::cleanupTestCase()
-{
-    delete aggregator;
-}
+void TestExtItemAggregator::cleanupTestCase() {}
 
 
 void TestExtItemAggregator::test_values()

sources/test/testextquotes.cpp

@@ -26,7 +26,7 @@
 void TestExtQuotes::initTestCase()
 {
     AWTestLibrary::init();
-    extQuotes = new ExtQuotes(nullptr);
+    extQuotes = new ExtQuotes(this);
     extQuotes->setInterval(1);
     extQuotes->setTicker(ticker);
     extQuotes->setNumber(0);
@@ -35,10 +35,7 @@ void TestExtQuotes::initTestCase()
 }
 
 
-void TestExtQuotes::cleanupTestCase()
-{
-    delete extQuotes;
-}
+void TestExtQuotes::cleanupTestCase() {}
 
 
 void TestExtQuotes::test_values()
@@ -96,7 +93,7 @@ void TestExtQuotes::test_copy()
     QCOMPARE(newExtQuotes->ticker(), extQuotes->ticker());
     QCOMPARE(newExtQuotes->number(), 1);
 
-    delete newExtQuotes;
+    newExtQuotes->deleteLater();
 }
 
 

sources/test/testextscript.cpp

@@ -28,7 +28,7 @@ void TestExtScript::initTestCase()
     AWTestLibrary::init();
     randomString = AWTestLibrary::randomString();
 
-    extScript = new ExtScript(nullptr);
+    extScript = new ExtScript(this);
     extScript->setInterval(1);
     extScript->setExecutable(QString("echo %1").arg(randomString));
     extScript->setNumber(0);
@@ -38,10 +38,7 @@ void TestExtScript::initTestCase()
 }
 
 
-void TestExtScript::cleanupTestCase()
-{
-    delete extScript;
-}
+void TestExtScript::cleanupTestCase() {}
 
 
 void TestExtScript::test_values()
@@ -95,7 +92,7 @@ void TestExtScript::test_copy()
     QCOMPARE(newExtScript->filters(), extScript->filters());
     QCOMPARE(newExtScript->number(), 1);
 
-    delete newExtScript;
+    newExtScript->deleteLater();
 }
 
 

sources/test/testextupgrade.cpp

@@ -29,7 +29,7 @@ void TestExtUpgrade::initTestCase()
     randomStrings = AWTestLibrary::randomStringList();
     cmd = QString("echo -e '%1'").arg(randomStrings.join("\n"));
 
-    extUpgrade = new ExtUpgrade(nullptr);
+    extUpgrade = new ExtUpgrade(this);
     extUpgrade->setInterval(1);
     extUpgrade->setExecutable(cmd);
     extUpgrade->setNumber(0);
@@ -38,10 +38,7 @@ void TestExtUpgrade::initTestCase()
 }
 
 
-void TestExtUpgrade::cleanupTestCase()
-{
-    delete extUpgrade;
-}
+void TestExtUpgrade::cleanupTestCase() {}
 
 
 void TestExtUpgrade::test_values()
@@ -106,7 +103,7 @@ void TestExtUpgrade::test_copy()
     QCOMPARE(newExtUpgrade->null(), extUpgrade->null());
     QCOMPARE(newExtUpgrade->number(), 1);
 
-    delete newExtUpgrade;
+    newExtUpgrade->deleteLater();
 }
 
 

sources/test/testextweather.cpp

@@ -26,7 +26,7 @@
 void TestExtWeather::initTestCase()
 {
     AWTestLibrary::init();
-    extWeather = new ExtWeather(nullptr);
+    extWeather = new ExtWeather(this);
     extWeather->setInterval(1);
     extWeather->setCity(city);
     extWeather->setCountry(country);
@@ -37,10 +37,7 @@ void TestExtWeather::initTestCase()
 }
 
 
-void TestExtWeather::cleanupTestCase()
-{
-    delete extWeather;
-}
+void TestExtWeather::cleanupTestCase() {}
 
 
 void TestExtWeather::test_values()
@@ -95,7 +92,7 @@ void TestExtWeather::test_copy()
     QCOMPARE(newExtWeather->provider(), extWeather->provider());
     QCOMPARE(newExtWeather->number(), 1);
 
-    delete newExtWeather;
+    newExtWeather->deleteLater();
 }
 
 
@@ -114,8 +111,8 @@ void TestExtWeather::run()
             && (arguments[extWeather->tag("humidity")].toInt() <= humidity.second));
     QVERIFY((arguments[extWeather->tag("pressure")].toInt() > pressure.first)
             && (arguments[extWeather->tag("pressure")].toInt() < pressure.second));
-    QVERIFY((arguments[extWeather->tag("temperature")].toFloat() > temp.first)
-            && (arguments[extWeather->tag("temperature")].toFloat() < temp.second));
+    QVERIFY((arguments[extWeather->tag("temperature")].toDouble() > temp.first)
+            && (arguments[extWeather->tag("temperature")].toDouble() < temp.second));
     // image should be only one symbol here
     if (extWeather->jsonMapFile().isEmpty())
         QSKIP("No json map found for weather, skip image test");

sources/test/testfloatformatter.cpp

@@ -27,14 +27,11 @@
 void TestAWFloatFormatter::initTestCase()
 {
     AWTestLibrary::init();
-    formatter = new AWFloatFormatter(nullptr);
+    formatter = new AWFloatFormatter(this);
 }
 
 
-void TestAWFloatFormatter::cleanupTestCase()
-{
-    delete formatter;
-}
+void TestAWFloatFormatter::cleanupTestCase() {}
 
 
 void TestAWFloatFormatter::test_values() {}
@@ -95,7 +92,7 @@ void TestAWFloatFormatter::test_forceWidth()
 void TestAWFloatFormatter::test_format()
 {
     // assign
-    QWARN("Lets assing 'z' formatter, it should cause a warning");
+    qWarning("Lets assign 'z' formatter, it should cause a warning");
     formatter->setFormat('z');
     QCOMPARE(formatter->format(), 'f');
     formatter->setFormat('e');
@@ -175,7 +172,7 @@ void TestAWFloatFormatter::test_copy()
     QCOMPARE(newFormatter->summand(), formatter->summand());
     QCOMPARE(newFormatter->number(), 1);
 
-    delete newFormatter;
+    newFormatter->deleteLater();
 }
 
 

sources/test/testjsonformatter.cpp

@@ -26,17 +26,14 @@
 void TestAWJsonFormatter::initTestCase()
 {
     AWTestLibrary::init();
-    formatter = new AWJsonFormatter(nullptr);
+    formatter = new AWJsonFormatter(this);
 
     generate();
     formatter->setPath(path);
 }
 
 
-void TestAWJsonFormatter::cleanupTestCase()
-{
-    delete formatter;
-}
+void TestAWJsonFormatter::cleanupTestCase() {}
 
 
 void TestAWJsonFormatter::test_values()
@@ -58,7 +55,7 @@ void TestAWJsonFormatter::test_copy()
     QCOMPARE(newFormatter->path(), formatter->path());
     QCOMPARE(newFormatter->number(), 1);
 
-    delete newFormatter;
+    newFormatter->deleteLater();
 }
 
 
@@ -79,8 +76,7 @@ void TestAWJsonFormatter::generate()
         } else {
             auto key = AWTestLibrary::randomString();
             auto val = AWTestLibrary::randomString();
-            QVariantMap dict;
-            dict[key] = val;
+            QVariantMap dict{{key, val}};
             second.append(dict);
         }
     }

sources/test/testlistformatter.cpp

@@ -28,15 +28,12 @@ void TestAWListFormatter::initTestCase()
     AWTestLibrary::init();
     separator = AWTestLibrary::randomString(9, 10);
 
-    formatter = new AWListFormatter(nullptr);
+    formatter = new AWListFormatter(this);
     formatter->setSeparator(separator);
 }
 
 
-void TestAWListFormatter::cleanupTestCase()
-{
-    delete formatter;
-}
+void TestAWListFormatter::cleanupTestCase() {}
 
 
 void TestAWListFormatter::test_values()
@@ -85,7 +82,7 @@ void TestAWListFormatter::test_copy()
     QCOMPARE(newFormatter->separator(), formatter->separator());
     QCOMPARE(newFormatter->isSorted(), formatter->isSorted());
 
-    delete newFormatter;
+    newFormatter->deleteLater();
 }
 
 

sources/test/testnetworksource.cpp

@@ -30,10 +30,7 @@ void TestNetworkSource::initTestCase()
 }
 
 
-void TestNetworkSource::cleanupTestCase()
-{
-    delete source;
-}
+void TestNetworkSource::cleanupTestCase() {}
 
 
 void TestNetworkSource::test_sources()

sources/test/testnoformatter.cpp

@@ -26,14 +26,11 @@
 void TestAWNoFormatter::initTestCase()
 {
     AWTestLibrary::init();
-    formatter = new AWNoFormatter(nullptr);
+    formatter = new AWNoFormatter(this);
 }
 
 
-void TestAWNoFormatter::cleanupTestCase()
-{
-    delete formatter;
-}
+void TestAWNoFormatter::cleanupTestCase() {}
 
 
 void TestAWNoFormatter::test_values() {}
@@ -45,7 +42,7 @@ void TestAWNoFormatter::test_conversion()
     auto randomInt = AWTestLibrary::randomInt();
     QCOMPARE(formatter->convert(randomInt), QString::number(randomInt));
     // float
-    QWARN("Float conversion isn't tested here due to possible rounding errors");
+    qWarning("Float conversion isn't tested here due to possible rounding errors");
     // string
     auto randomString = AWTestLibrary::randomString();
     QCOMPARE(formatter->convert(randomString), randomString);
@@ -58,7 +55,7 @@ void TestAWNoFormatter::test_copy()
 
     QCOMPARE(newFormatter->number(), 1);
 
-    delete newFormatter;
+    newFormatter->deleteLater();
 }
 
 

sources/test/testplayersource.cpp

@@ -67,8 +67,10 @@ void TestPlayerSource::test_autoMpris()
     auto source = new PlayerSource(this, "mpris", mpdAddress, mpdPort, "auto", 10);
 
     auto empty = source->getAutoMpris().isEmpty();
+    source->deleteLater();
+
     if (empty)
-        QWARN("No MPRIS found, manual check required");
+        qWarning("No MPRIS found, manual check required");
     else
         QVERIFY(!empty);
 }
@@ -95,6 +97,8 @@ void TestPlayerSource::test_mpd()
         QSKIP("No mpd found");
 
     QVERIFY(secondValue["progress"].toInt() < secondValue["duration"].toInt());
+
+    source->deleteLater();
 }
 
 
@@ -112,6 +116,8 @@ void TestPlayerSource::test_mpris()
         QSKIP("No mpris found");
 
     QVERIFY(progress < duration);
+
+    source->deleteLater();
 }
 
 

sources/test/testprocessessource.cpp

@@ -30,10 +30,7 @@ void TestProcessesSource::initTestCase()
 }
 
 
-void TestProcessesSource::cleanupTestCase()
-{
-    delete source;
-}
+void TestProcessesSource::cleanupTestCase() {}
 
 
 void TestProcessesSource::test_sources()

sources/test/testscriptformatter.cpp

@@ -33,10 +33,7 @@ void TestAWScriptFormatter::initTestCase()
 }
 
 
-void TestAWScriptFormatter::cleanupTestCase()
-{
-    delete formatter;
-}
+void TestAWScriptFormatter::cleanupTestCase() {}
 
 
 void TestAWScriptFormatter::test_values()
@@ -100,7 +97,7 @@ void TestAWScriptFormatter::test_copy()
     QCOMPARE(newFormatter->program(), formatter->program());
     QCOMPARE(newFormatter->number(), 1);
 
-    delete newFormatter;
+    newFormatter->deleteLater();
 }
 
 

sources/test/teststringformatter.cpp

@@ -26,14 +26,11 @@
 void TestAWStringFormatter::initTestCase()
 {
     AWTestLibrary::init();
-    formatter = new AWStringFormatter(nullptr);
+    formatter = new AWStringFormatter(this);
 }
 
 
-void TestAWStringFormatter::cleanupTestCase()
-{
-    delete formatter;
-}
+void TestAWStringFormatter::cleanupTestCase() {}
 
 
 void TestAWStringFormatter::test_values() {}
@@ -104,7 +101,7 @@ void TestAWStringFormatter::test_copy()
     QCOMPARE(newFormatter->forceWidth(), formatter->forceWidth());
     QCOMPARE(newFormatter->number(), 1);
 
-    delete newFormatter;
+    newFormatter->deleteLater();
 }