arcanis/awesome-widgets
1
0 Fork 0
mirror of https://github.com/arcan1s/awesome-widgets.git synced 2026-10-21 21:35:34 +00:00
Code Issues Projects Releases Wiki Activity

add fix for possible race condition (#96)

Browse Source
This commit is contained in:
arcanis committed 2016-06-16 15:17:58 +03:00
1 parent 75d101cc8b
commit b20a96d32f
2 files changed
+17
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

patches/fix-race-condition.patch
+15
View File
@@ -0,0 +1,15 @@
diff --git a/sources/awesome-widget/plugin/awkeys.cpp b/sources/awesome-widget/plugin/awkeys.cpp
index 1744fb7..f483209 100644
--- a/sources/awesome-widget/plugin/awkeys.cpp
+++ b/sources/awesome-widget/plugin/awkeys.cpp
@@ -234,8 +234,10 @@ void AWKeys::reinitKeys(const QStringList currentKeys)
void AWKeys::updateTextData()
{
// do not do it in parallel to avoid race condition
+ m_mutex.lock();
calculateValues();
QString text = parsePattern(keyOperator->pattern());
+ m_mutex.unlock();
emit(needTextToBeUpdated(text));
emit(dataAggregator->updateData(values));
sources/awesome-widget/plugin/awkeys.cpp
+2
View File
@@ -234,8 +234,10 @@ void AWKeys::reinitKeys(const QStringList currentKeys)
void AWKeys::updateTextData() void AWKeys::updateTextData()
{ {
// do not do it in parallel to avoid race condition // do not do it in parallel to avoid race condition
m_mutex.lock();
calculateValues(); calculateValues();
QString text = parsePattern(keyOperator->pattern()); QString text = parsePattern(keyOperator->pattern());
m_mutex.unlock();
emit(needTextToBeUpdated(text)); emit(needTextToBeUpdated(text));
emit(dataAggregator->updateData(values)); emit(dataAggregator->updateData(values));