clang-tidy warning fixes

This commit is contained in:
2020-11-03 04:23:01 +03:00
parent e81d765098
commit 91abbdcd96
99 changed files with 392 additions and 436 deletions

View File

@ -20,15 +20,13 @@
#include <KWindowSystem>
#include <QEventLoop>
#include <QRandomGenerator>
#include <QSet>
#include <QStandardPaths>
#include <QRandomGenerator>
#include <QtTest>
void AWTestLibrary::init()
{
}
void AWTestLibrary::init() {}
bool AWTestLibrary::isKWinActive()

View File

@ -52,10 +52,12 @@ void TestBatterySource::test_battery()
QSKIP("No battery found, test will be skipped");
QStringList batteries = source->sources();
std::for_each(batteries.begin(), batteries.end(), [this](const QString bat) {
std::for_each(batteries.begin(), batteries.end(), [this](const QString &bat) {
QVariant value = source->data(bat);
if (bat == "battery/ac")
QCOMPARE(value.type(), QVariant::Bool);
else if (bat.startsWith("battery/batrate") || bat.startsWith("battery/batleft"))
;
else
QVERIFY((value.toFloat() >= battery.first) || (std::isnan(value.toFloat())));
});

View File

@ -31,10 +31,9 @@ void TestExtScript::initTestCase()
extScript = new ExtScript(nullptr);
extScript->setInterval(1);
extScript->setExecutable(randomString);
extScript->setExecutable(QString("echo %1").arg(randomString));
extScript->setNumber(0);
extScript->setRedirect(ExtScript::Redirect::stderr2stdout);
extScript->setPrefix("echo");
extScript->run();
}
@ -50,9 +49,8 @@ void TestExtScript::test_values()
{
QCOMPARE(extScript->interval(), 1);
QCOMPARE(extScript->number(), 0);
QCOMPARE(extScript->executable(), randomString);
QCOMPARE(extScript->executable(), QString("echo %1").arg(randomString));
QCOMPARE(extScript->strRedirect(), QString("stderr2stdout"));
QCOMPARE(extScript->prefix(), QString("echo"));
}
@ -97,7 +95,6 @@ void TestExtScript::test_copy()
QCOMPARE(newExtScript->interval(), extScript->interval());
QCOMPARE(newExtScript->executable(), extScript->executable());
QCOMPARE(newExtScript->strRedirect(), extScript->strRedirect());
QCOMPARE(newExtScript->prefix(), extScript->prefix());
QCOMPARE(newExtScript->filters(), extScript->filters());
QCOMPARE(newExtScript->number(), 1);

View File

@ -18,8 +18,8 @@
#include "testfloatformatter.h"
#include <QtTest>
#include <QRandomGenerator>
#include <QtTest>
#include "awfloatformatter.h"
#include "awtestlibrary.h"