clang-tidy warning fixes

This commit is contained in:
2020-11-03 04:23:01 +03:00
parent e81d765098
commit 91abbdcd96
99 changed files with 392 additions and 436 deletions

View File

@ -36,10 +36,10 @@ ExtScript::ExtScript(QWidget *_parent, const QString &_filePath)
qCDebug(LOG_LIB) << __PRETTY_FUNCTION__;
if (!_filePath.isEmpty())
readConfiguration();
ExtScript::readConfiguration();
readJsonFilters();
ui->setupUi(this);
translate();
ExtScript::translate();
m_values[tag("custom")] = "";
@ -71,7 +71,6 @@ ExtScript *ExtScript::copy(const QString &_fileName, const int _number)
copyDefaults(item);
item->setExecutable(executable());
item->setNumber(_number);
item->setPrefix(prefix());
item->setRedirect(redirect());
item->setFilters(filters());
@ -102,12 +101,6 @@ QStringList ExtScript::filters() const
}
QString ExtScript::prefix() const
{
return m_prefix;
}
ExtScript::Redirect ExtScript::redirect() const
{
return m_redirect;
@ -159,14 +152,6 @@ void ExtScript::setFilters(const QStringList &_filters)
}
void ExtScript::setPrefix(const QString &_prefix)
{
qCDebug(LOG_LIB) << "Prefix" << _prefix;
m_prefix = _prefix;
}
void ExtScript::setRedirect(const Redirect _redirect)
{
qCDebug(LOG_LIB) << "Redirect" << static_cast<int>(_redirect);
@ -231,11 +216,9 @@ void ExtScript::readConfiguration()
settings.beginGroup("Desktop Entry");
setExecutable(settings.value("Exec", executable()).toString());
setPrefix(settings.value("X-AW-Prefix", prefix()).toString());
setStrRedirect(settings.value("X-AW-Redirect", strRedirect()).toString());
// api == 3
setFilters(
settings.value("X-AW-Filters", filters()).toString().split(',', Qt::SkipEmptyParts));
setFilters(settings.value("X-AW-Filters", filters()).toString().split(',', Qt::SkipEmptyParts));
settings.endGroup();
bumpApi(AW_EXTSCRIPT_API);
@ -283,7 +266,6 @@ int ExtScript::showConfiguration(const QVariant &_args)
ui->lineEdit_comment->setText(comment());
ui->label_numberValue->setText(QString("%1").arg(number()));
ui->lineEdit_command->setText(executable());
ui->lineEdit_prefix->setText(prefix());
ui->checkBox_active->setCheckState(isActive() ? Qt::Checked : Qt::Unchecked);
ui->comboBox_redirect->setCurrentIndex(static_cast<int>(redirect()));
ui->lineEdit_schedule->setText(cron());
@ -305,7 +287,6 @@ int ExtScript::showConfiguration(const QVariant &_args)
setNumber(ui->label_numberValue->text().toInt());
setApiVersion(AW_EXTSCRIPT_API);
setExecutable(ui->lineEdit_command->text());
setPrefix(ui->lineEdit_prefix->text());
setActive(ui->checkBox_active->checkState() == Qt::Checked);
setRedirect(static_cast<Redirect>(ui->comboBox_redirect->currentIndex()));
setCron(ui->lineEdit_schedule->text());
@ -330,7 +311,6 @@ void ExtScript::writeConfiguration() const
settings.beginGroup("Desktop Entry");
settings.setValue("Exec", executable());
settings.setValue("X-AW-Prefix", prefix());
settings.setValue("X-AW-Redirect", strRedirect());
settings.setValue("X-AW-Filters", filters().join(','));
settings.endGroup();
@ -341,12 +321,8 @@ void ExtScript::writeConfiguration() const
void ExtScript::startProcess()
{
QStringList cmdList;
if (!prefix().isEmpty())
cmdList.append(prefix());
cmdList.append(executable());
qCInfo(LOG_LIB) << "Run cmd" << cmdList.join(' ');
m_process->start("sh", QStringList() << "-c" << cmdList);
qCInfo(LOG_LIB) << "Run cmd" << executable();
m_process->start("sh", QStringList() << "-c" << executable());
}
@ -387,7 +363,6 @@ void ExtScript::translate()
ui->label_comment->setText(i18n("Comment"));
ui->label_number->setText(i18n("Tag"));
ui->label_command->setText(i18n("Command"));
ui->label_prefix->setText(i18n("Prefix"));
ui->checkBox_active->setText(i18n("Active"));
ui->label_redirect->setText(i18n("Redirect"));
ui->label_schedule->setText(i18n("Schedule"));