fix codefactor warnings

This commit is contained in:
2024-04-30 19:59:42 +03:00
parent 54a29e8cb3
commit 793346ddf4
86 changed files with 31 additions and 103 deletions

View File

@ -32,11 +32,11 @@ public:
explicit AbstractExtSysMonSource(QObject *_parent);
~AbstractExtSysMonSource() override = default;
virtual QVariant data(const QString &_source) = 0;
[[nodiscard]] virtual QVariant data(const QString &_source) = 0;
[[nodiscard]] virtual QHash<QString, KSysGuard::SensorInfo *> sources() const = 0;
static int index(const QString &_source);
[[nodiscard]] static int index(const QString &_source);
// safe value extractor
template <class T> static QVariantHash dataByItem(T *_extension, const QString &_source)
template <class T> [[nodiscard]] static QVariantHash dataByItem(T *_extension, const QString &_source)
{
auto idx = index(_source);
if (idx == -1)
@ -45,9 +45,9 @@ public:
auto item = _extension->itemByTagNumber(idx);
return item ? item->run() : QVariantHash();
}
static KSysGuard::SensorInfo *makeSensorInfo(const QString &_name, QMetaType::Type _type,
KSysGuard::Unit _unit = KSysGuard::UnitNone, double _min = 0,
double _max = 0);
[[nodiscard]] static KSysGuard::SensorInfo *makeSensorInfo(const QString &_name, QMetaType::Type _type,
KSysGuard::Unit _unit = KSysGuard::UnitNone,
double _min = 0, double _max = 0);
signals:
void dataReceived(const QVariantHash &);

View File

@ -32,7 +32,7 @@ public:
explicit BatterySource(QObject *_parent, QString _acpiPath);
~BatterySource() override = default;
QVariant data(const QString &_source) override;
[[nodiscard]] QVariant data(const QString &_source) override;
void run();
[[nodiscard]] QHash<QString, KSysGuard::SensorInfo *> sources() const override;

View File

@ -32,7 +32,7 @@ class CustomSource : public AbstractExtSysMonSource
public:
explicit CustomSource(QObject *_parent);
~CustomSource() override = default;
QVariant data(const QString &_source) override;
[[nodiscard]] QVariant data(const QString &_source) override;
[[nodiscard]] QHash<QString, KSysGuard::SensorInfo *> sources() const override;
private:

View File

@ -35,7 +35,7 @@ public:
explicit DesktopSource(QObject *_parent);
~DesktopSource() override = default;
QVariant data(const QString &_source) override;
[[nodiscard]] QVariant data(const QString &_source) override;
[[nodiscard]] QHash<QString, KSysGuard::SensorInfo *> sources() const override;
private:

View File

@ -29,6 +29,6 @@ class LoadSource : public AbstractExtSysMonSource
public:
explicit LoadSource(QObject *_parent);
~LoadSource() override = default;
QVariant data(const QString &_source) override;
[[nodiscard]] QVariant data(const QString &_source) override;
[[nodiscard]] QHash<QString, KSysGuard::SensorInfo *> sources() const override;
};

View File

@ -31,7 +31,7 @@ class NetworkSource : public AbstractExtSysMonSource
public:
explicit NetworkSource(QObject *_parent);
~NetworkSource() override;
QVariant data(const QString &_source) override;
[[nodiscard]] QVariant data(const QString &_source) override;
[[nodiscard]] QHash<QString, KSysGuard::SensorInfo *> sources() const override;
private slots:

View File

@ -36,13 +36,13 @@ public:
explicit PlayerSource(QObject *_parent, QString _player, QString _mpdAddress, int _mpdPort, QString _mpris,
int _symbols);
~PlayerSource() override;
QVariant data(const QString &_source) override;
static QString getAutoMpris();
[[nodiscard]] QVariant data(const QString &_source) override;
[[nodiscard]] static QString getAutoMpris();
void run();
[[nodiscard]] QHash<QString, KSysGuard::SensorInfo *> sources() const override;
// additional method to build dynamic tags
static QString buildString(const QString &_current, const QString &_value, int _s);
static QString stripString(const QString &_value, int _s);
[[nodiscard]] static QString buildString(const QString &_current, const QString &_value, int _s);
[[nodiscard]] static QString stripString(const QString &_value, int _s);
// additional test method
[[nodiscard]] bool isMpdSocketConnected() const;
@ -52,8 +52,8 @@ private slots:
void mpdSocketWritten(qint64 _bytes);
private:
static inline QVariantHash defaultInfo();
QVariantHash getPlayerMpdInfo();
[[nodiscard]] static inline QVariantHash defaultInfo();
[[nodiscard]] QVariantHash getPlayerMpdInfo();
[[nodiscard]] static QVariantHash getPlayerMprisInfo(const QString &_mpris);
QTcpSocket m_mpdSocket;
// configuration and values
@ -64,6 +64,6 @@ private:
QMutex m_dbusMutex;
QString m_player;
int m_symbols;
QStringList m_metadata = QStringList({"album", "artist", "title"});
QStringList m_metadata = {"album", "artist", "title"};
QVariantHash m_values;
};

View File

@ -29,7 +29,7 @@ class ProcessesSource : public AbstractExtSysMonSource
public:
explicit ProcessesSource(QObject *_parent);
~ProcessesSource() override = default;
QVariant data(const QString &_source) override;
[[nodiscard]] QVariant data(const QString &_source) override;
void run();
[[nodiscard]] QHash<QString, KSysGuard::SensorInfo *> sources() const override;

View File

@ -32,7 +32,7 @@ class QuotesSource : public AbstractExtSysMonSource
public:
explicit QuotesSource(QObject *_parent);
~QuotesSource() override = default;
QVariant data(const QString &_source) override;
[[nodiscard]] QVariant data(const QString &_source) override;
[[nodiscard]] QHash<QString, KSysGuard::SensorInfo *> sources() const override;
private:

View File

@ -32,7 +32,7 @@ class RequestSource : public AbstractExtSysMonSource
public:
explicit RequestSource(QObject *_parent);
~RequestSource() override = default;
QVariant data(const QString &_source) override;
[[nodiscard]] QVariant data(const QString &_source) override;
[[nodiscard]] QHash<QString, KSysGuard::SensorInfo *> sources() const override;
private:

View File

@ -29,14 +29,15 @@ class SystemInfoSource : public AbstractExtSysMonSource
public:
explicit SystemInfoSource(QObject *_parent);
~SystemInfoSource() override = default;
QVariant data(const QString &_source) override;
[[nodiscard]] QVariant data(const QString &_source) override;
[[nodiscard]] QHash<QString, KSysGuard::SensorInfo *> sources() const override;
private:
// configuration and values
static QVariant fromDBusVariant(const QVariant &_value);
static double getCurrentBrightness();
static double getCurrentVolume();
static QVariant sendDBusRequest(const QString &_destination, const QString &_path, const QString &_interface,
const QString &_method, const QVariantList &_args = {});
[[nodiscard]] static QVariant fromDBusVariant(const QVariant &_value);
[[nodiscard]] static double getCurrentBrightness();
[[nodiscard]] static double getCurrentVolume();
[[nodiscard]] static QVariant sendDBusRequest(const QString &_destination, const QString &_path,
const QString &_interface, const QString &_method,
const QVariantList &_args = {});
};

View File

@ -29,6 +29,6 @@ class TimeSource : public AbstractExtSysMonSource
public:
explicit TimeSource(QObject *_parent);
~TimeSource() override = default;
QVariant data(const QString &_source) override;
[[nodiscard]] QVariant data(const QString &_source) override;
[[nodiscard]] QHash<QString, KSysGuard::SensorInfo *> sources() const override;
};

View File

@ -32,7 +32,7 @@ class UpgradeSource : public AbstractExtSysMonSource
public:
explicit UpgradeSource(QObject *_parent);
~UpgradeSource() override = default;
QVariant data(const QString &_source) override;
[[nodiscard]] QVariant data(const QString &_source) override;
[[nodiscard]] QHash<QString, KSysGuard::SensorInfo *> sources() const override;
private:

View File

@ -32,7 +32,7 @@ class WeatherSource : public AbstractExtSysMonSource
public:
explicit WeatherSource(QObject *_parent);
~WeatherSource() override = default;
QVariant data(const QString &_source) override;
[[nodiscard]] QVariant data(const QString &_source) override;
[[nodiscard]] QHash<QString, KSysGuard::SensorInfo *> sources() const override;
private: