arcanis/awesome-widgets
1
0
Fork 0
mirror of https://github.com/arcan1s/awesome-widgets.git synced 2025-07-13 05:45:49 +00:00
Code Issues Projects Releases Wiki Activity

massive changes inside

Browse Source 
* use pass by ref instead of by value if possible
* use reference in interation over collections
* fix no tag inserting
This commit is contained in:
Evgenii Alekseev
2017-05-04 15:00:50 +03:00
parent 6e99e262d4
commit 6e62ceaac7
119 changed files with 645 additions and 634 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
sources/extsysmonsources/weathersource.cpp
View File

@ -22,7 +22,7 @@
#include "extweather.h"
WeatherSource::WeatherSource(QObject *parent, const QStringList args)
WeatherSource::WeatherSource(QObject *parent, const QStringList &args)
: AbstractExtSysMonSource(parent, args)
{
Q_ASSERT(args.count() == 0);
@ -43,23 +43,24 @@ WeatherSource::~WeatherSource()
}
QVariant WeatherSource::data(QString source)
QVariant WeatherSource::data(const QString &source)
{
qCDebug(LOG_ESS) << "Source" << source;
int ind = index(source);
source.remove(QString("weather/"));
if (!m_values.contains(source)) {
auto service = source;
service.remove("weather/");
if (!m_values.contains(service)) {
QVariantHash data = m_extWeather->itemByTagNumber(ind)->run();
for (auto key : data.keys())
for (auto &key : data.keys())
m_values[key] = data[key];
}
QVariant value = m_values.take(source);
QVariant value = m_values.take(service);
return value;
}
QVariantMap WeatherSource::initialData(QString source) const
QVariantMap WeatherSource::initialData(const QString &source) const
{
qCDebug(LOG_ESS) << "Source" << source;
@ -128,7 +129,7 @@ QStringList WeatherSource::sources() const
QStringList WeatherSource::getSources()
{
QStringList sources;
for (auto item : m_extWeather->activeItems()) {
for (auto &item : m_extWeather->activeItems()) {
sources.append(
QString("weather/%1").arg(item->tag(QString("weatherId"))));
sources.append(