arcanis/awesome-widgets
1
0
Fork 0
mirror of https://github.com/arcan1s/awesome-widgets.git synced 2025-07-13 05:45:49 +00:00
Code Issues Projects Releases Wiki Activity

massive changes inside

Browse Source 
* use pass by ref instead of by value if possible
* use reference in interation over collections
* fix no tag inserting
This commit is contained in:
Evgenii Alekseev
2017-05-04 15:00:50 +03:00
parent 6e99e262d4
commit 6e62ceaac7
119 changed files with 645 additions and 634 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
sources/awesomewidgets/graphicalitem.cpp
View File

@ -32,7 +32,7 @@
#include "graphicalitemhelper.h"
GraphicalItem::GraphicalItem(QWidget *parent, const QString filePath)
GraphicalItem::GraphicalItem(QWidget *parent, const QString &filePath)
: AbstractExtItem(parent, filePath)
, ui(new Ui::GraphicalItem)
{
@ -64,7 +64,7 @@ GraphicalItem::~GraphicalItem()
}
GraphicalItem *GraphicalItem::copy(const QString _fileName, const int _number)
GraphicalItem *GraphicalItem::copy(const QString &_fileName, const int _number)
{
qCDebug(LOG_LIB) << "File" << _fileName << "with number" << _number;
@ -283,7 +283,7 @@ QString GraphicalItem::uniq() const
}
void GraphicalItem::setBar(const QString _bar)
void GraphicalItem::setBar(const QString &_bar)
{
qCDebug(LOG_LIB) << "Bar" << _bar;
@ -291,7 +291,7 @@ void GraphicalItem::setBar(const QString _bar)
}
void GraphicalItem::setActiveColor(const QString _color)
void GraphicalItem::setActiveColor(const QString &_color)
{
qCDebug(LOG_LIB) << "Color" << _color;
@ -317,7 +317,7 @@ void GraphicalItem::setCustom(const bool _custom)
}
void GraphicalItem::setInactiveColor(const QString _color)
void GraphicalItem::setInactiveColor(const QString &_color)
{
qCDebug(LOG_LIB) << "Color" << _color;
@ -369,7 +369,7 @@ void GraphicalItem::setType(const Type _type)
}
void GraphicalItem::setStrType(const QString _type)
void GraphicalItem::setStrType(const QString &_type)
{
qCDebug(LOG_LIB) << "Type" << _type;
@ -394,7 +394,7 @@ void GraphicalItem::setDirection(const Direction _direction)
}
void GraphicalItem::setStrDirection(const QString _direction)
void GraphicalItem::setStrDirection(const QString &_direction)
{
qCDebug(LOG_LIB) << "Direction" << _direction;
@ -405,14 +405,14 @@ void GraphicalItem::setStrDirection(const QString _direction)
}
void GraphicalItem::setUsedKeys(const QStringList _usedKeys)
void GraphicalItem::setUsedKeys(const QStringList &_usedKeys)
{
qCDebug(LOG_LIB) << "Used keys" << _usedKeys;
// remove dubs
// HACK converting to set may break order
usedKeys().clear();
for (auto key : _usedKeys) {
for (auto &key : _usedKeys) {
if (usedKeys().contains(key))
continue;
usedKeys().append(key);
@ -460,7 +460,7 @@ void GraphicalItem::readConfiguration()
}
int GraphicalItem::showConfiguration(const QVariant args)
int GraphicalItem::showConfiguration(const QVariant &args)
{
qCDebug(LOG_LIB) << "Combobox arguments" << args;
QStringList tags = args.toStringList();