arcanis/awesome-widgets
1
0
Fork 0
mirror of https://github.com/arcan1s/awesome-widgets.git synced 2025-07-19 00:29:57 +00:00
Code Issues Projects Releases Wiki Activity

massive changes inside

Browse Source 
* use pass by ref instead of by value if possible
* use reference in interation over collections
* fix no tag inserting
This commit is contained in:
Evgenii Alekseev
2017-05-04 15:00:50 +03:00
parent 6e99e262d4
commit 6e62ceaac7
119 changed files with 645 additions and 634 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
sources/awesome-widget/plugin/awdataaggregator.cpp
View File

@ -57,7 +57,7 @@ AWDataAggregator::~AWDataAggregator()
}
QList<float> AWDataAggregator::getData(const QString key) const
QList<float> AWDataAggregator::getData(const QString &key) const
{
qCDebug(LOG_AW) << "Key" << key;
@ -78,7 +78,7 @@ QString AWDataAggregator::htmlImage(const QPixmap &source) const
}
void AWDataAggregator::setParameters(QVariantMap settings)
void AWDataAggregator::setParameters(const QVariantMap &settings)
{
qCDebug(LOG_AW) << "Settings" << settings;
@ -128,7 +128,7 @@ QPixmap AWDataAggregator::tooltipImage()
m_toolTipScene->clear();
QPen pen;
bool down = false;
for (auto key : requiredKeys) {
for (auto &key : requiredKeys) {
// create frame
float normX = 100.0f / static_cast<float>(m_values[key].count());
float normY = 100.0f / (1.5f * m_boundaries[key]);
@ -174,7 +174,7 @@ void AWDataAggregator::dataUpdate(const QVariantHash &values)
}
void AWDataAggregator::checkValue(const QString source, const float value,
void AWDataAggregator::checkValue(const QString &source, const float value,
const float extremum) const
{
qCDebug(LOG_AW) << "Notification source" << source << "with value" << value
@ -194,8 +194,8 @@ void AWDataAggregator::checkValue(const QString source, const float value,
}
void AWDataAggregator::checkValue(const QString source, const QString current,
const QString received) const
void AWDataAggregator::checkValue(const QString &source, const QString &current,
const QString &received) const
{
qCDebug(LOG_AW) << "Notification source" << source << "with current value"
<< current << "and received one" << received;
@ -218,7 +218,7 @@ void AWDataAggregator::initScene()
}
QString AWDataAggregator::notificationText(const QString source,
QString AWDataAggregator::notificationText(const QString &source,
const float value) const
{
qCDebug(LOG_AW) << "Notification source" << source << "with value" << value;
@ -239,8 +239,8 @@ QString AWDataAggregator::notificationText(const QString source,
}
QString AWDataAggregator::notificationText(const QString source,
const QString value) const
QString AWDataAggregator::notificationText(const QString &source,
const QString &value) const
{
qCDebug(LOG_AW) << "Notification source" << source << "with value" << value;