diff --git a/sources/awesomewidgets/abstractextitem.cpp b/sources/awesomewidgets/abstractextitem.cpp index 71e9633..07e2cc9 100644 --- a/sources/awesomewidgets/abstractextitem.cpp +++ b/sources/awesomewidgets/abstractextitem.cpp @@ -196,8 +196,8 @@ void AbstractExtItem::readConfiguration() if (debug) qDebug() << PDEBUG; for (int i=m_dirs.count()-1; i>=0; i--) { - if (!QDir(m_dirs[i]).entryList(QDir::Files).contains(m_fileName)) continue; - QSettings settings(QString("%1/%2").arg(m_dirs[i]).arg(m_fileName), QSettings::IniFormat); + if (!QDir(m_dirs.at(i)).entryList(QDir::Files).contains(m_fileName)) continue; + QSettings settings(QString("%1/%2").arg(m_dirs.at(i)).arg(m_fileName), QSettings::IniFormat); settings.beginGroup(QString("Desktop Entry")); setName(settings.value(QString("Name"), m_name).toString()); @@ -215,15 +215,14 @@ bool AbstractExtItem::tryDelete() const { if (debug) qDebug() << PDEBUG; - for (int i=0; ifileName() != item->text()) continue; + if (m_items.at(i)->fileName() != item->text()) continue; originalItem = i; break; } @@ -96,11 +96,9 @@ public: if (debug) qDebug() << PDEBUG; QList tagList; - for (int i=0; inumber()); + foreach(T *item, m_items) tagList.append(item->number()); int number = 0; - while (tagList.contains(number)) - number++; + while (tagList.contains(number)) number++; return number; }; @@ -128,14 +126,14 @@ private: QStandardPaths::LocateDirectory); QStringList names; QList items; - for (int i=0; iclear(); - for (int i=0; ifileName(), widgetDialog); + foreach(T *_item, m_items) { + QListWidgetItem *item = new QListWidgetItem(_item->fileName(), widgetDialog); QStringList tooltip; - tooltip.append(i18n("Name: %1", m_items[i]->name())); - tooltip.append(i18n("Comment: %1", m_items[i]->comment())); - tooltip.append(i18n("Identity: %1", m_items[i]->uniq())); + tooltip.append(i18n("Name: %1", _item->name())); + tooltip.append(i18n("Comment: %1", _item->comment())); + tooltip.append(i18n("Identity: %1", _item->uniq())); item->setToolTip(tooltip.join(QChar('\n'))); widgetDialog->addItem(item); } diff --git a/sources/awesomewidgets/extquotes.cpp b/sources/awesomewidgets/extquotes.cpp index 50f941f..5210604 100644 --- a/sources/awesomewidgets/extquotes.cpp +++ b/sources/awesomewidgets/extquotes.cpp @@ -120,8 +120,8 @@ void ExtQuotes::readConfiguration() AbstractExtItem::readConfiguration(); for (int i=directories().count()-1; i>=0; i--) { - if (!QDir(directories()[i]).entryList(QDir::Files).contains(fileName())) continue; - QSettings settings(QString("%1/%2").arg(directories()[i]).arg(fileName()), QSettings::IniFormat); + if (!QDir(directories().at(i)).entryList(QDir::Files).contains(fileName())) continue; + QSettings settings(QString("%1/%2").arg(directories().at(i)).arg(fileName()), QSettings::IniFormat); settings.beginGroup(QString("Desktop Entry")); setTicker(settings.value(QString("X-AW-Ticker"), m_ticker).toString()); @@ -188,7 +188,7 @@ void ExtQuotes::writeConfiguration() const if (debug) qDebug() << PDEBUG; AbstractExtItem::writeConfiguration(); - QSettings settings(QString("%1/%2").arg(directories()[0]).arg(fileName()), QSettings::IniFormat); + QSettings settings(QString("%1/%2").arg(directories().first()).arg(fileName()), QSettings::IniFormat); if (debug) qDebug() << PDEBUG << ":" << "Configuration file" << settings.fileName(); settings.beginGroup(QString("Desktop Entry")); diff --git a/sources/awesomewidgets/extscript.cpp b/sources/awesomewidgets/extscript.cpp index 70d178e..0a676a1 100644 --- a/sources/awesomewidgets/extscript.cpp +++ b/sources/awesomewidgets/extscript.cpp @@ -167,8 +167,8 @@ void ExtScript::setFilters(const QStringList _filters) if (debug) qDebug() << PDEBUG; if (debug) qDebug() << PDEBUG << ":" << "Filters" << _filters; - for (int i=0; i<_filters.count(); i++) - updateFilter(_filters[i]); + foreach(QString filter, _filters) + updateFilter(filter); } @@ -218,15 +218,15 @@ QString ExtScript::applyFilters(QString _value) const if (debug) qDebug() << PDEBUG; if (debug) qDebug() << PDEBUG << ":" << "Value" << _value; - for (int i=0; i=0; i--) { - if (!QDir(directories()[i]).entryList(QDir::Files).contains(fileName())) continue; - QSettings settings(QString("%1/%2").arg(directories()[i]).arg(fileName()), QSettings::IniFormat); + if (!QDir(directories().at(i)).entryList(QDir::Files).contains(fileName())) continue; + QSettings settings(QString("%1/%2").arg(directories().at(i)).arg(fileName()), QSettings::IniFormat); settings.beginGroup(QString("Desktop Entry")); setExecutable(settings.value(QString("Exec"), m_executable).toString()); @@ -367,7 +367,7 @@ void ExtScript::writeConfiguration() const if (debug) qDebug() << PDEBUG; AbstractExtItem::writeConfiguration(); - QSettings settings(QString("%1/%2").arg(directories()[0]).arg(fileName()), QSettings::IniFormat); + QSettings settings(QString("%1/%2").arg(directories().first()).arg(fileName()), QSettings::IniFormat); if (debug) qDebug() << PDEBUG << ":" << "Configuration file" << settings.fileName(); settings.beginGroup(QString("Desktop Entry")); diff --git a/sources/awesomewidgets/extupgrade.cpp b/sources/awesomewidgets/extupgrade.cpp index b53bb10..52e7738 100644 --- a/sources/awesomewidgets/extupgrade.cpp +++ b/sources/awesomewidgets/extupgrade.cpp @@ -126,8 +126,8 @@ void ExtUpgrade::readConfiguration() AbstractExtItem::readConfiguration(); for (int i=directories().count()-1; i>=0; i--) { - if (!QDir(directories()[i]).entryList(QDir::Files).contains(fileName())) continue; - QSettings settings(QString("%1/%2").arg(directories()[i]).arg(fileName()), QSettings::IniFormat); + if (!QDir(directories().at(i)).entryList(QDir::Files).contains(fileName())) continue; + QSettings settings(QString("%1/%2").arg(directories().at(i)).arg(fileName()), QSettings::IniFormat); settings.beginGroup(QString("Desktop Entry")); setExecutable(settings.value(QString("Exec"), m_executable).toString()); @@ -192,7 +192,7 @@ void ExtUpgrade::writeConfiguration() const if (debug) qDebug() << PDEBUG; AbstractExtItem::writeConfiguration(); - QSettings settings(QString("%1/%2").arg(directories()[0]).arg(fileName()), QSettings::IniFormat); + QSettings settings(QString("%1/%2").arg(directories().first()).arg(fileName()), QSettings::IniFormat); if (debug) qDebug() << PDEBUG << ":" << "Configuration file" << settings.fileName(); settings.beginGroup(QString("Desktop Entry")); diff --git a/sources/awesomewidgets/extweather.cpp b/sources/awesomewidgets/extweather.cpp index d37089c..603e1b2 100644 --- a/sources/awesomewidgets/extweather.cpp +++ b/sources/awesomewidgets/extweather.cpp @@ -253,8 +253,8 @@ void ExtWeather::readConfiguration() AbstractExtItem::readConfiguration(); for (int i=directories().count()-1; i>=0; i--) { - if (!QDir(directories()[i]).entryList(QDir::Files).contains(fileName())) continue; - QSettings settings(QString("%1/%2").arg(directories()[i]).arg(fileName()), QSettings::IniFormat); + if (!QDir(directories().at(i)).entryList(QDir::Files).contains(fileName())) continue; + QSettings settings(QString("%1/%2").arg(directories().at(i)).arg(fileName()), QSettings::IniFormat); settings.beginGroup(QString("Desktop Entry")); setCity(settings.value(QString("X-AW-City"), m_city).toString()); @@ -327,7 +327,7 @@ void ExtWeather::writeConfiguration() const if (debug) qDebug() << PDEBUG; AbstractExtItem::writeConfiguration(); - QSettings settings(QString("%1/%2").arg(directories()[0]).arg(fileName()), QSettings::IniFormat); + QSettings settings(QString("%1/%2").arg(directories().first()).arg(fileName()), QSettings::IniFormat); if (debug) qDebug() << PDEBUG << ":" << "Configuration file" << settings.fileName(); settings.beginGroup(QString("Desktop Entry")); @@ -368,10 +368,9 @@ void ExtWeather::weatherReplyReceived(QNetworkReply *reply) data = parseSingleJson(json); else { QVariantList list = json[QString("list")].toList(); - data = parseSingleJson(list.count() <= m_ts ? list[m_ts-1].toMap() : list.last().toMap()); + data = parseSingleJson(list.count() <= m_ts ? list.at(m_ts-1).toMap() : list.last().toMap()); } - for (int i=0; i 0) { - int _id = weather[0].toMap()[QString("id")].toInt(); + if (!weather.isEmpty()) { + int _id = weather.first().toMap()[QString("id")].toInt(); output[QString("weatherId")] = _id; output[QString("weather")] = weatherFromInt(_id); } // main data QVariantMap mainWeather = json[QString("main")].toMap(); - if (weather.count() > 0) { + if (!weather.isEmpty()) { output[QString("humidity")] = mainWeather[QString("humidity")].toFloat(); output[QString("pressure")] = mainWeather[QString("pressure")].toFloat(); output[QString("temperature")] = mainWeather[QString("temp")].toFloat(); diff --git a/sources/awesomewidgets/graphicalitem.cpp b/sources/awesomewidgets/graphicalitem.cpp index 3eaa1c0..1d13190 100644 --- a/sources/awesomewidgets/graphicalitem.cpp +++ b/sources/awesomewidgets/graphicalitem.cpp @@ -369,8 +369,8 @@ void GraphicalItem::readConfiguration() AbstractExtItem::readConfiguration(); for (int i=directories().count()-1; i>=0; i--) { - if (!QDir(directories()[i]).entryList(QDir::Files).contains(fileName())) continue; - QSettings settings(QString("%1/%2").arg(directories()[i]).arg(fileName()), QSettings::IniFormat); + if (!QDir(directories().at(i)).entryList(QDir::Files).contains(fileName())) continue; + QSettings settings(QString("%1/%2").arg(directories().at(i)).arg(fileName()), QSettings::IniFormat); settings.beginGroup(QString("Desktop Entry")); setBar(settings.value(QString("X-AW-Value"), m_bar).toString()); @@ -443,7 +443,7 @@ void GraphicalItem::writeConfiguration() const if (debug) qDebug() << PDEBUG; AbstractExtItem::writeConfiguration(); - QSettings settings(QString("%1/%2").arg(directories()[0]).arg(fileName()), QSettings::IniFormat); + QSettings settings(QString("%1/%2").arg(directories().first()).arg(fileName()), QSettings::IniFormat); if (debug) qDebug() << PDEBUG << ":" << "Configuration file" << settings.fileName(); settings.beginGroup(QString("Desktop Entry")); @@ -487,10 +487,10 @@ QColor GraphicalItem::stringToColor(const QString _color) const QStringList listColor = _color.split(QChar(',')); while (listColor.count() < 4) listColor.append(QString("0")); - qcolor.setRed(listColor[0].toInt()); - qcolor.setGreen(listColor[1].toInt()); - qcolor.setBlue(listColor[2].toInt()); - qcolor.setAlpha(listColor[3].toInt()); + qcolor.setRed(listColor.at(0).toInt()); + qcolor.setGreen(listColor.at(1).toInt()); + qcolor.setBlue(listColor.at(2).toInt()); + qcolor.setAlpha(listColor.at(3).toInt()); return qcolor; } diff --git a/sources/extsysmon/extsysmon.cpp b/sources/extsysmon/extsysmon.cpp index 2ee774a..1984480 100644 --- a/sources/extsysmon/extsysmon.cpp +++ b/sources/extsysmon/extsysmon.cpp @@ -116,12 +116,12 @@ QString ExtendedSysMon::getAutoMpris() const QDBusMessage listServices = QDBusConnection::sessionBus().interface()->call(QDBus::BlockWithGui, QString("ListNames")); if (listServices.arguments().isEmpty()) return QString(); - QStringList arguments = listServices.arguments().at(0).toStringList(); + QStringList arguments = listServices.arguments().first().toStringList(); - for (int i=0; i ExtendedSysMon::updateConfiguration(QHash -1)) - devices.append(deviceList.at(i)); + foreach(QString device, deviceList) + if ((QFile::exists(device)) && (diskRegexp.indexIn(device) > -1)) + devices.append(device); if (devices.isEmpty()) rawConfig[QString("HDDDEV")] = allHddDevices.join(QChar(',')); else @@ -216,9 +215,8 @@ QHash ExtendedSysMon::updateConfiguration(QHash"))) { - QString load = qoutput.split(QChar('\n'), QString::SkipEmptyParts)[i] - .remove(QString("")) - .remove(QString("")) - .remove(QChar('%')); - value = load.toFloat(); - } + foreach(QString str, qoutput.split(QChar('\n'), QString::SkipEmptyParts)) { + if (!str.contains(QString(""))) continue; + QString load = str.remove(QString("")).remove(QString("")) + .remove(QChar('%')); + value = load.toFloat(); + break; } else if (configuration[QString("GPUDEV")] == QString("ati")) - for (int i=0; itoUnicode(process.output); if (configuration[QString("GPUDEV")] == QString("nvidia")) - for (int i=0; i"))) { - QString temp = qoutput.split(QChar('\n'), QString::SkipEmptyParts)[i] - .remove(QString("")) - .remove(QString("C")); - value = temp.toFloat(); - } + foreach(QString str, qoutput.split(QChar('\n'), QString::SkipEmptyParts)) { + if (!str.contains(QString(""))) continue; + QString temp = str.remove(QString("")).remove(QString("C")); + value = temp.toFloat(); + break; } else if (configuration[QString("GPUDEV")] == QString("ati")) - for (int i=0; itoUnicode(process.output).trimmed(); if (smartctl) { - for (int i=0; i rawInterfaceList = QNetworkInterface::allInterfaces(); - for (int i=0; itoUnicode(process.output).trimmed(); - QString qstr = QString(""); - for (int i=0; i 1) { - if (qstr.split(QString(": "), QString::SkipEmptyParts).at(0) == QString("Album")) - info[QString("album")] = qstr.split(QString(": "), QString::SkipEmptyParts)[1].trimmed(); - else if (qstr.split(QString(": "), QString::SkipEmptyParts).at(0) == QString("Artist")) - info[QString("artist")] = qstr.split(QString(": "), QString::SkipEmptyParts)[1].trimmed(); - else if (qstr.split(QString(": "), QString::SkipEmptyParts).at(0) == QString("time")) { - info[QString("duration")] = qstr.split(QString(": "), QString::SkipEmptyParts)[1].trimmed().split(QString(":"))[0]; - info[QString("progress")] = qstr.split(QString(": "), QString::SkipEmptyParts)[1].trimmed().split(QString(":"))[1]; - } else if (qstr.split(QString(": "), QString::SkipEmptyParts).at(0) == QString("Title")) - info[QString("title")] = qstr.split(QString(": "), QString::SkipEmptyParts)[1].trimmed(); + foreach(QString str, qoutput.split(QChar('\n'), QString::SkipEmptyParts)) { + if (str.split(QString(": "), QString::SkipEmptyParts).count() > 1) { + if (str.split(QString(": "), QString::SkipEmptyParts).first() == QString("Album")) + info[QString("album")] = str.split(QString(": "), QString::SkipEmptyParts)[1].trimmed(); + else if (str.split(QString(": "), QString::SkipEmptyParts).first() == QString("Artist")) + info[QString("artist")] = str.split(QString(": "), QString::SkipEmptyParts)[1].trimmed(); + else if (str.split(QString(": "), QString::SkipEmptyParts).first() == QString("time")) { + info[QString("duration")] = str.split(QString(": "), QString::SkipEmptyParts)[1].trimmed().split(QString(":"))[0]; + info[QString("progress")] = str.split(QString(": "), QString::SkipEmptyParts)[1].trimmed().split(QString(":"))[1]; + } else if (str.split(QString(": "), QString::SkipEmptyParts).first() == QString("Title")) + info[QString("title")] = str.split(QString(": "), QString::SkipEmptyParts)[1].trimmed(); } } @@ -518,7 +508,7 @@ QVariantHash ExtendedSysMon::getPlayerMprisInfo(const QString mpris) const if (debug) qDebug() << PDEBUG << ":" << "Error message" << response.errorMessage(); } else { // another portion of dirty magic - QVariantHash map = qdbus_cast(response.arguments().at(0) + QVariantHash map = qdbus_cast(response.arguments().first() .value().variant() .value()); info[QString("album")] = map.value(QString("xesam:album"), QString("unknown")); @@ -536,7 +526,7 @@ QVariantHash ExtendedSysMon::getPlayerMprisInfo(const QString mpris) const if (debug) qDebug() << PDEBUG << ":" << "Error message" << response.errorMessage(); } else // this cast is simpler than the previous one ;) - info[QString("progress")] = response.arguments().at(0).value() + info[QString("progress")] = response.arguments().first().value() .variant().toLongLong() / (1000 * 1000); return info; @@ -552,10 +542,10 @@ QVariantHash ExtendedSysMon::getPsStats() const QStringList directories = allDirectories.filter(QRegExp(QString("(\\d+)"))); QStringList running; - for (int i=0; iitems().count(); i++) { - QVariantHash data = externalScripts->items().at(i)->run(); - for (int j=0; jitems()) { + QVariantHash data = script->run(); + foreach(QString key, data.keys()) setData(source, key, data[key]); } } else if (source == QString("desktop")) { QVariantHash desktop = getCurrentDesktop(); - for (int i=0; iitems().count(); i++) { - QVariantHash data = externalUpgrade->items().at(i)->run(); - for (int j=0; jitems()) { + QVariantHash data = upgrade->run(); + foreach(QString key, data.keys()) setData(source, key, data[key]); } } else if (source == QString("player")) { QVariantHash player = getPlayerInfo(configuration[QString("PLAYER")], configuration[QString("MPDADDRESS")], configuration[QString("MPDPORT")], configuration[QString("MPRIS")]); - for (int i=0; iitems().count(); i++) { - QVariantHash data = externalQuotes->items().at(i)->run(); - for (int j=0; jitems()) { + QVariantHash data = quote->run(); + foreach(QString key, data.keys()) setData(source, key, data[key]); } } else if (source == QString("update")) { setData(source, QString("value"), true); } else if (source == QString("weather")) { - for (int i=0; iitems().count(); i++) { - QVariantHash data = externalWeather->items().at(i)->run(); - for (int j=0; jitems()) { + QVariantHash data = weather->run(); + foreach(QString key, data.keys()) setData(source, key, data[key]); } }