From 0ee8d40ade3ea6ecf7502888db31413ce4db0281 Mon Sep 17 00:00:00 2001
From: Evgenii Alekseev <i@arcanis.me>
Date: Thu, 21 Mar 2024 18:08:19 +0200
Subject: [PATCH] do not derive from qwidget in aggregates

---
 sources/awesomewidgets/abstractextitemaggregator.cpp |  4 ++--
 sources/awesomewidgets/abstractextitemaggregator.h   | 10 ++--------
 sources/awesomewidgets/extitemaggregator.h           |  4 ++--
 3 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/sources/awesomewidgets/abstractextitemaggregator.cpp b/sources/awesomewidgets/abstractextitemaggregator.cpp
index eb90bf4..eab3e7a 100644
--- a/sources/awesomewidgets/abstractextitemaggregator.cpp
+++ b/sources/awesomewidgets/abstractextitemaggregator.cpp
@@ -26,8 +26,8 @@
 #include <utility>
 
 
-AbstractExtItemAggregator::AbstractExtItemAggregator(QWidget *_parent, QString _type)
-    : QDialog(_parent)
+AbstractExtItemAggregator::AbstractExtItemAggregator(QObject *_parent, QString _type)
+    : QObject(_parent)
     , ui(new Ui::AbstractExtItemAggregator)
     , m_type(std::move(_type))
 {
diff --git a/sources/awesomewidgets/abstractextitemaggregator.h b/sources/awesomewidgets/abstractextitemaggregator.h
index 781a657..c5f270a 100644
--- a/sources/awesomewidgets/abstractextitemaggregator.h
+++ b/sources/awesomewidgets/abstractextitemaggregator.h
@@ -18,7 +18,6 @@
 #ifndef ABSTRACTEXTITEMAGGREGATOR_H
 #define ABSTRACTEXTITEMAGGREGATOR_H
 
-#include <QDialog>
 #include <QStandardPaths>
 
 #include "abstractextitem.h"
@@ -27,20 +26,15 @@
 
 class QAbstractButton;
 class QListWidgetItem;
-namespace Ui
-{
-class AbstractExtItemAggregator;
-}
 
-class AbstractExtItemAggregator : public QDialog
+class AbstractExtItemAggregator : public QObject
 {
     Q_OBJECT
     Q_PROPERTY(QVariant configArgs READ configArgs WRITE setConfigArgs)
     Q_PROPERTY(QVariant type READ type)
 
 public:
-    explicit AbstractExtItemAggregator(QWidget *_parent, QString _type);
-    ~AbstractExtItemAggregator() override;
+    explicit AbstractExtItemAggregator(QObject *_parent, QString _type);
     // methods
     void copyItem();
     template <class T> void createItem()
diff --git a/sources/awesomewidgets/extitemaggregator.h b/sources/awesomewidgets/extitemaggregator.h
index 3925b16..e8a6524 100644
--- a/sources/awesomewidgets/extitemaggregator.h
+++ b/sources/awesomewidgets/extitemaggregator.h
@@ -31,7 +31,7 @@
 template <class T> class ExtItemAggregator : public AbstractExtItemAggregator
 {
 public:
-    explicit ExtItemAggregator(QWidget *_parent, const QString &_type)
+    explicit ExtItemAggregator(QObject *_parent, const QString &_type)
         : AbstractExtItemAggregator(_parent, _type)
     {
         qSetMessagePattern(AWDebug::LOG_FORMAT);
@@ -57,7 +57,7 @@ public:
     void editItems()
     {
         repaintList();
-        int ret = exec();
+        auto ret = exec();
         qCInfo(LOG_LIB) << "Dialog returns" << ret;
     };