arcanis/ahriman
1
0
Fork 0
mirror of https://github.com/arcan1s/ahriman.git synced 2025-04-24 23:37:18 +00:00
Code Issues Projects Releases Wiki Activity

do not terminate child process explicitly

Browse Source 
This feature sometimes causes the main process termination. Since the
child process has been already terminated (or going to) there is no need
to terminate it manually
This commit is contained in:
Evgenii Alekseev 2023-05-29 17:27:04 +03:00
parent 5627c9cca0
commit d064e46af6
2 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/ahriman/core/spawn.py
View File

@ -172,7 +172,6 @@ class Spawn(Thread, LazyLogging):
process = self.active.pop(process_id, None) process = self.active.pop(process_id, None)
if process is not None: if process is not None:
process.terminate() # make sure lol
process.join() process.join()
def stop(self) -> None: def stop(self) -> None:

2
tests/ahriman/core/test_spawn.py
View File

@ -140,9 +140,7 @@ def test_run_pop(spawner: Spawn) -> None:
spawner.run() spawner.run()
first.terminate.assert_called_once_with()
first.join.assert_called_once_with() first.join.assert_called_once_with()
second.terminate.assert_called_once_with()
second.join.assert_called_once_with() second.join.assert_called_once_with()
assert not spawner.active assert not spawner.active