chore: add metthod definition order plugin to pylint

Also reorder some methods to fix errors

tests/ahriman/application/test_ahriman.py

@@ -104,36 +104,6 @@ def test_subparsers_aur_search_option_repository(parser: argparse.ArgumentParser
     assert args.repository == ""
 
 
-def test_subparsers_help(parser: argparse.ArgumentParser) -> None:
-    """
-    help command must imply architecture list, lock, quiet, report, repository, unsafe and parser
-    """
-    args = parser.parse_args(["help"])
-    assert args.architecture == ""
-    assert args.lock is None
-    assert args.quiet
-    assert not args.report
-    assert args.repository == ""
-    assert args.unsafe
-    assert args.parser is not None and args.parser()
-
-
-def test_subparsers_help_option_architecture(parser: argparse.ArgumentParser) -> None:
-    """
-    help command must correctly parse architecture list
-    """
-    args = parser.parse_args(["-a", "x86_64", "help"])
-    assert args.architecture == ""
-
-
-def test_subparsers_help_option_repository(parser: argparse.ArgumentParser) -> None:
-    """
-    help command must correctly parse repository list
-    """
-    args = parser.parse_args(["-r", "repo", "help"])
-    assert args.repository == ""
-
-
 def test_subparsers_help_commands_unsafe(parser: argparse.ArgumentParser) -> None:
     """
     help-commands-unsafe command must imply architecture list, lock, quiet, report, repository, unsafe and parser
@@ -164,6 +134,36 @@ def test_subparsers_help_commands_unsafe_option_repository(parser: argparse.Argu
     assert args.repository == ""
 
 
+def test_subparsers_help(parser: argparse.ArgumentParser) -> None:
+    """
+    help command must imply architecture list, lock, quiet, report, repository, unsafe and parser
+    """
+    args = parser.parse_args(["help"])
+    assert args.architecture == ""
+    assert args.lock is None
+    assert args.quiet
+    assert not args.report
+    assert args.repository == ""
+    assert args.unsafe
+    assert args.parser is not None and args.parser()
+
+
+def test_subparsers_help_option_architecture(parser: argparse.ArgumentParser) -> None:
+    """
+    help command must correctly parse architecture list
+    """
+    args = parser.parse_args(["-a", "x86_64", "help"])
+    assert args.architecture == ""
+
+
+def test_subparsers_help_option_repository(parser: argparse.ArgumentParser) -> None:
+    """
+    help command must correctly parse repository list
+    """
+    args = parser.parse_args(["-r", "repo", "help"])
+    assert args.repository == ""
+
+
 def test_subparsers_help_updates(parser: argparse.ArgumentParser) -> None:
     """
     help-updates command must imply architecture list, lock, quiet, report, repository, and unsafe

tests/ahriman/application/test_lock.py

@@ -30,30 +30,6 @@ def test_path(args: argparse.Namespace, configuration: Configuration) -> None:
         Lock(args, repository_id, configuration).path  # special case
 
 
-def test_check_version(lock: Lock, mocker: MockerFixture) -> None:
-    """
-    must check version correctly
-    """
-    mocker.patch("ahriman.core.status.client.Client.status_get",
-                 return_value=InternalStatus(status=BuildStatus(), version=__version__))
-    logging_mock = mocker.patch("logging.Logger.warning")
-
-    lock.check_version()
-    logging_mock.assert_not_called()
-
-
-def test_check_version_mismatch(lock: Lock, mocker: MockerFixture) -> None:
-    """
-    must check mismatched version correctly
-    """
-    mocker.patch("ahriman.core.status.client.Client.status_get",
-                 return_value=InternalStatus(status=BuildStatus(), version="version"))
-    logging_mock = mocker.patch("logging.Logger.warning")
-
-    lock.check_version()
-    logging_mock.assert_called_once()  # we do not check logging arguments
-
-
 def test_check_user(lock: Lock, mocker: MockerFixture) -> None:
     """
     must check user correctly
@@ -84,6 +60,30 @@ def test_check_user_unsafe(lock: Lock, mocker: MockerFixture) -> None:
     lock.check_user()
 
 
+def test_check_version(lock: Lock, mocker: MockerFixture) -> None:
+    """
+    must check version correctly
+    """
+    mocker.patch("ahriman.core.status.client.Client.status_get",
+                 return_value=InternalStatus(status=BuildStatus(), version=__version__))
+    logging_mock = mocker.patch("logging.Logger.warning")
+
+    lock.check_version()
+    logging_mock.assert_not_called()
+
+
+def test_check_version_mismatch(lock: Lock, mocker: MockerFixture) -> None:
+    """
+    must check mismatched version correctly
+    """
+    mocker.patch("ahriman.core.status.client.Client.status_get",
+                 return_value=InternalStatus(status=BuildStatus(), version="version"))
+    logging_mock = mocker.patch("logging.Logger.warning")
+
+    lock.check_version()
+    logging_mock.assert_called_once()  # we do not check logging arguments
+
+
 def test_clear(lock: Lock) -> None:
     """
     must remove lock file

tests/ahriman/core/upload/test_github.py

@@ -89,15 +89,6 @@ def test_asset_upload_empty_mimetype(github: GitHub, github_release: dict[str, A
                                          headers={"Content-Type": "application/octet-stream"})
 
 
-def test_get_local_files(github: GitHub, resource_path_root: Path, mocker: MockerFixture) -> None:
-    """
-    must get all local files recursively
-    """
-    walk_mock = mocker.patch("ahriman.core.util.walk")
-    github.get_local_files(resource_path_root)
-    walk_mock.assert_called()
-
-
 def test_files_remove(github: GitHub, github_release: dict[str, Any], mocker: MockerFixture) -> None:
     """
     must remove files from the remote
@@ -137,6 +128,15 @@ def test_files_upload_empty(github: GitHub, github_release: dict[str, Any], mock
     upload_mock.assert_not_called()
 
 
+def test_get_local_files(github: GitHub, resource_path_root: Path, mocker: MockerFixture) -> None:
+    """
+    must get all local files recursively
+    """
+    walk_mock = mocker.patch("ahriman.core.util.walk")
+    github.get_local_files(resource_path_root)
+    walk_mock.assert_called()
+
+
 def test_release_create(github: GitHub, mocker: MockerFixture) -> None:
     """
     must create release

tests/ahriman/models/test_repository_id.py

@@ -3,6 +3,14 @@ import pytest
 from ahriman.models.repository_id import RepositoryId
 
 
+def test_id() -> None:
+    """
+    must correctly generate id
+    """
+    assert RepositoryId("", "").id == ""
+    assert RepositoryId("arch", "repo").id == "arch-repo"
+
+
 def test_is_empty() -> None:
     """
     must check if repository id is empty or not
@@ -13,14 +21,6 @@ def test_is_empty() -> None:
     assert not RepositoryId("arch", "repo").is_empty
 
 
-def test_id() -> None:
-    """
-    must correctly generate id
-    """
-    assert RepositoryId("", "").id == ""
-    assert RepositoryId("arch", "repo").id == "arch-repo"
-
-
 def test_query() -> None:
     """
     must generate query request parameters