do not bump timestamp on empty updates

This commit is contained in:
Evgenii Alekseev 2022-05-21 04:19:04 +03:00
parent b1dfafe275
commit ad84895e18
2 changed files with 0 additions and 34 deletions

View File

@ -72,8 +72,6 @@ class UpdateHandler(Cleaner):
if local.is_outdated(remote, self.paths):
self.reporter.set_pending(local.base)
result.append(remote)
else:
self.reporter.set_success(local)
except Exception:
self.reporter.set_failed(local.base)
self.logger.exception("could not load remote package %s", local.base)
@ -103,8 +101,6 @@ class UpdateHandler(Cleaner):
elif local.is_outdated(remote, self.paths):
self.reporter.set_pending(local.base)
result.append(remote)
else:
self.reporter.set_success(local)
except Exception:
self.logger.exception("could not process package at %s", dirname)

View File

@ -45,20 +45,6 @@ def test_updates_aur_official(update_handler: UpdateHandler, package_ahriman: Pa
status_client_mock.assert_called_once_with(package_ahriman.base)
def test_updates_aur_success(update_handler: UpdateHandler, package_ahriman: Package,
mocker: MockerFixture) -> None:
"""
must provide updates with status updates with success
"""
mocker.patch("ahriman.core.repository.update_handler.UpdateHandler.packages", return_value=[package_ahriman])
mocker.patch("ahriman.models.package.Package.is_outdated", return_value=False)
mocker.patch("ahriman.models.package.Package.from_aur", return_value=package_ahriman)
status_client_mock = mocker.patch("ahriman.core.status.client.Client.set_success")
assert not update_handler.updates_aur([], False)
status_client_mock.assert_called_once_with(package_ahriman)
def test_updates_aur_failed(update_handler: UpdateHandler, package_ahriman: Package,
mocker: MockerFixture) -> None:
"""
@ -156,22 +142,6 @@ def test_updates_local_with_failures(update_handler: UpdateHandler, package_ahri
assert not update_handler.updates_local()
def test_updates_local_success(update_handler: UpdateHandler, package_ahriman: Package,
mocker: MockerFixture) -> None:
"""
must set success status for up-to-date packages
"""
mocker.patch("ahriman.core.repository.update_handler.UpdateHandler.packages", return_value=[package_ahriman])
mocker.patch("pathlib.Path.iterdir", return_value=[package_ahriman.base])
mocker.patch("ahriman.models.package.Package.is_outdated", return_value=False)
mocker.patch("ahriman.core.build_tools.sources.Sources.fetch")
mocker.patch("ahriman.models.package.Package.from_build", return_value=package_ahriman)
status_client_mock = mocker.patch("ahriman.core.status.client.Client.set_success")
assert not update_handler.updates_local()
status_client_mock.assert_called_once_with(package_ahriman)
def test_updates_manual_clear(update_handler: UpdateHandler, mocker: MockerFixture) -> None:
"""
requesting manual updates must clear packages directory