Add ability to trigger updates from the web (#31)

* add external process spawner and update test cases

* pass no_report to handlers

* provide service api endpoints

* do not spawn process for single architecture run

* pass no report to handlers

* make _call method of handlers public and also simplify process spawn

* move update under add

* implement actions from web page

* clear logging & improve l&f

tests/ahriman/core/auth/test_auth.py

@@ -46,8 +46,8 @@ def test_is_safe_request(auth: Auth) -> None:
     must validate safe request
     """
     # login and logout are always safe
-    assert auth.is_safe_request("/login", UserAccess.Write)
-    assert auth.is_safe_request("/logout", UserAccess.Write)
+    assert auth.is_safe_request("/user-api/v1/login", UserAccess.Write)
+    assert auth.is_safe_request("/user-api/v1/logout", UserAccess.Write)
 
     auth.allowed_paths.add("/safe")
     auth.allowed_paths_groups.add("/unsafe/safe")

tests/ahriman/core/repository/conftest.py

@@ -19,7 +19,7 @@ def cleaner(configuration: Configuration, mocker: MockerFixture) -> Cleaner:
     :return: cleaner test instance
     """
     mocker.patch("pathlib.Path.mkdir")
-    return Cleaner("x86_64", configuration)
+    return Cleaner("x86_64", configuration, no_report=True)
 
 
 @pytest.fixture
@@ -36,7 +36,7 @@ def executor(configuration: Configuration, mocker: MockerFixture) -> Executor:
     mocker.patch("ahriman.core.repository.cleaner.Cleaner.clear_chroot")
     mocker.patch("ahriman.core.repository.cleaner.Cleaner.clear_manual")
     mocker.patch("ahriman.core.repository.cleaner.Cleaner.clear_packages")
-    return Executor("x86_64", configuration)
+    return Executor("x86_64", configuration, no_report=True)
 
 
 @pytest.fixture
@@ -48,7 +48,7 @@ def repository(configuration: Configuration, mocker: MockerFixture) -> Repositor
     :return: repository test instance
     """
     mocker.patch("pathlib.Path.mkdir")
-    return Repository("x86_64", configuration)
+    return Repository("x86_64", configuration, no_report=True)
 
 
 @pytest.fixture
@@ -58,7 +58,7 @@ def properties(configuration: Configuration) -> Properties:
     :param configuration: configuration fixture
     :return: properties test instance
     """
-    return Properties("x86_64", configuration)
+    return Properties("x86_64", configuration, no_report=True)
 
 
 @pytest.fixture
@@ -75,4 +75,4 @@ def update_handler(configuration: Configuration, mocker: MockerFixture) -> Updat
     mocker.patch("ahriman.core.repository.cleaner.Cleaner.clear_chroot")
     mocker.patch("ahriman.core.repository.cleaner.Cleaner.clear_manual")
     mocker.patch("ahriman.core.repository.cleaner.Cleaner.clear_packages")
-    return UpdateHandler("x86_64", configuration)
+    return UpdateHandler("x86_64", configuration, no_report=True)

tests/ahriman/core/repository/test_properties.py

@@ -2,6 +2,7 @@ from pytest_mock import MockerFixture
 
 from ahriman.core.configuration import Configuration
 from ahriman.core.repository.properties import Properties
+from ahriman.core.status.web_client import WebClient
 
 
 def test_create_tree_on_load(configuration: Configuration, mocker: MockerFixture) -> None:
@@ -9,6 +10,29 @@ def test_create_tree_on_load(configuration: Configuration, mocker: MockerFixture
     must create tree on load
     """
     create_tree_mock = mocker.patch("ahriman.models.repository_paths.RepositoryPaths.create_tree")
-    Properties("x86_64", configuration)
+    Properties("x86_64", configuration, True)
 
     create_tree_mock.assert_called_once()
+
+
+def test_create_dummy_report_client(configuration: Configuration, mocker: MockerFixture) -> None:
+    """
+    must create dummy report client if report is disabled
+    """
+    mocker.patch("ahriman.models.repository_paths.RepositoryPaths.create_tree")
+    load_mock = mocker.patch("ahriman.core.status.client.Client.load")
+    properties = Properties("x86_64", configuration, True)
+
+    load_mock.assert_not_called()
+    assert not isinstance(properties.reporter, WebClient)
+
+
+def test_create_full_report_client(configuration: Configuration, mocker: MockerFixture) -> None:
+    """
+    must create load report client if report is enabled
+    """
+    mocker.patch("ahriman.models.repository_paths.RepositoryPaths.create_tree")
+    load_mock = mocker.patch("ahriman.core.status.client.Client.load")
+    Properties("x86_64", configuration, False)
+
+    load_mock.assert_called_once()

tests/ahriman/core/status/test_watcher.py

@@ -5,12 +5,28 @@ from pathlib import Path
 from pytest_mock import MockerFixture
 from unittest.mock import PropertyMock
 
+from ahriman.core.configuration import Configuration
 from ahriman.core.exceptions import UnknownPackage
 from ahriman.core.status.watcher import Watcher
+from ahriman.core.status.web_client import WebClient
 from ahriman.models.build_status import BuildStatus, BuildStatusEnum
 from ahriman.models.package import Package
 
 
+def test_force_no_report(configuration: Configuration, mocker: MockerFixture) -> None:
+    """
+    must force dummy report client
+    """
+    configuration.set_option("web", "port", "8080")
+    mocker.patch("pathlib.Path.mkdir")
+
+    load_mock = mocker.patch("ahriman.core.status.client.Client.load")
+    watcher = Watcher("x86_64", configuration)
+
+    load_mock.assert_not_called()
+    assert not isinstance(watcher.repository.reporter, WebClient)
+
+
 def test_cache_load(watcher: Watcher, package_ahriman: Package, mocker: MockerFixture) -> None:
     """
     must load state from cache

tests/ahriman/core/test_spawn.py

@@ -0,0 +1,111 @@
+from pytest_mock import MockerFixture
+from unittest.mock import MagicMock
+
+from ahriman.core.spawn import Spawn
+
+
+def test_process(spawner: Spawn) -> None:
+    """
+    must process external process run correctly
+    """
+    args = MagicMock()
+    callback = MagicMock()
+    callback.return_value = True
+
+    spawner.process(callback, args, spawner.architecture, "id", spawner.queue)
+
+    callback.assert_called_with(args, spawner.architecture)
+    (uuid, status) = spawner.queue.get()
+    assert uuid == "id"
+    assert status
+    assert spawner.queue.empty()
+
+
+def test_process_error(spawner: Spawn) -> None:
+    """
+    must process external run with error correctly
+    """
+    callback = MagicMock()
+    callback.return_value = False
+
+    spawner.process(callback, MagicMock(), spawner.architecture, "id", spawner.queue)
+
+    (uuid, status) = spawner.queue.get()
+    assert uuid == "id"
+    assert not status
+    assert spawner.queue.empty()
+
+
+def test_packages_add(spawner: Spawn, mocker: MockerFixture) -> None:
+    """
+    must call package addition
+    """
+    spawn_mock = mocker.patch("ahriman.core.spawn.Spawn.spawn_process")
+    spawner.packages_add(["ahriman", "linux"], now=False)
+    spawn_mock.assert_called_with("add", "ahriman", "linux")
+
+
+def test_packages_add_with_build(spawner: Spawn, mocker: MockerFixture) -> None:
+    """
+    must call package addition with update
+    """
+    spawn_mock = mocker.patch("ahriman.core.spawn.Spawn.spawn_process")
+    spawner.packages_add(["ahriman", "linux"], now=True)
+    spawn_mock.assert_called_with("add", "ahriman", "linux", now="")
+
+
+def test_packages_remove(spawner: Spawn, mocker: MockerFixture) -> None:
+    """
+    must call package removal
+    """
+    spawn_mock = mocker.patch("ahriman.core.spawn.Spawn.spawn_process")
+    spawner.packages_remove(["ahriman", "linux"])
+    spawn_mock.assert_called_with("remove", "ahriman", "linux")
+
+
+def test_spawn_process(spawner: Spawn, mocker: MockerFixture) -> None:
+    """
+    must correctly spawn child process
+    """
+    start_mock = mocker.patch("multiprocessing.Process.start")
+
+    spawner.spawn_process("add", "ahriman", now="", maybe="?")
+    start_mock.assert_called_once()
+    spawner.args_parser.parse_args.assert_called_with([
+        "--architecture", spawner.architecture, "--configuration", str(spawner.configuration.path),
+        "add", "ahriman", "--now", "--maybe", "?"
+    ])
+
+
+def test_run(spawner: Spawn, mocker: MockerFixture) -> None:
+    """
+    must implement run method
+    """
+    logging_mock = mocker.patch("logging.Logger.info")
+
+    spawner.queue.put(("1", False))
+    spawner.queue.put(("2", True))
+    spawner.queue.put(None)  # terminate
+
+    spawner.run()
+    logging_mock.assert_called()
+
+
+def test_run_pop(spawner: Spawn) -> None:
+    """
+    must pop and terminate child process
+    """
+    first = spawner.active["1"] = MagicMock()
+    second = spawner.active["2"] = MagicMock()
+
+    spawner.queue.put(("1", False))
+    spawner.queue.put(("2", True))
+    spawner.queue.put(None)  # terminate
+
+    spawner.run()
+
+    first.terminate.assert_called_once()
+    first.join.assert_called_once()
+    second.terminate.assert_called_once()
+    second.join.assert_called_once()
+    assert not spawner.active

tests/ahriman/core/upload/test_s3.py

@@ -59,10 +59,14 @@ def test_get_local_files(s3: S3, resource_path_root: Path) -> None:
         Path("models/package_ahriman_srcinfo"),
         Path("models/package_tpacpi-bat-git_srcinfo"),
         Path("models/package_yay_srcinfo"),
+        Path("web/templates/build-status/login-modal.jinja2"),
+        Path("web/templates/build-status/package-actions-modals.jinja2"),
+        Path("web/templates/build-status/package-actions-script.jinja2"),
+        Path("web/templates/utils/bootstrap-scripts.jinja2"),
+        Path("web/templates/utils/style.jinja2"),
         Path("web/templates/build-status.jinja2"),
         Path("web/templates/email-index.jinja2"),
         Path("web/templates/repo-index.jinja2"),
-        Path("web/templates/style.jinja2"),
     ])
 
     local_files = list(sorted(s3.get_local_files(resource_path_root).keys()))