arcanis/ahriman
1
0
Fork 0
mirror of https://github.com/arcan1s/ahriman.git synced 2025-06-28 14:51:43 +00:00
Code Issues Projects Releases Wiki Activity

add retry on authorization errros

Browse Source
This commit is contained in:
Evgenii Alekseev
2023-11-15 18:01:22 +02:00
parent 82d1be52a8
commit 6bc7353514
7 changed files with 120 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
tests/ahriman/core/http/test_sync_ahriman_client.py
View File

@ -1,8 +1,10 @@
import pytest
import requests
import requests_unixsocket
import tenacity
from pytest_mock import MockerFixture
from unittest.mock import call as MockCall
from ahriman.core.http import SyncAhrimanClient
from ahriman.models.user import User
@ -30,6 +32,37 @@ def test_session_unix_socket(ahriman_client: SyncAhrimanClient, mocker: MockerFi
login_mock.assert_not_called()
def test_is_retry_allowed() -> None:
"""
must allow retries on 401 errors
"""
assert not SyncAhrimanClient.is_retry_allowed(Exception())
response = requests.Response()
response.status_code = 400
assert not SyncAhrimanClient.is_retry_allowed(requests.HTTPError(response=response))
response.status_code = 401
assert SyncAhrimanClient.is_retry_allowed(requests.HTTPError(response=response))
response.status_code = 403
assert not SyncAhrimanClient.is_retry_allowed(requests.HTTPError(response=response))
def test_on_retry(ahriman_client: SyncAhrimanClient) -> None:
"""
must remove session on retry
"""
SyncAhrimanClient.on_retry(
tenacity.RetryCallState(
retry_object=tenacity.Retrying(),
fn=SyncAhrimanClient.make_request,
args=(ahriman_client,),
kwargs={},
)
)
def test_login(ahriman_client: SyncAhrimanClient, user: User, mocker: MockerFixture) -> None:
"""
must login user
@ -79,3 +112,35 @@ def test_login_url(ahriman_client: SyncAhrimanClient) -> None:
"""
assert ahriman_client._login_url().startswith(ahriman_client.address)
assert ahriman_client._login_url().endswith("/api/v1/login")
def test_make_request_retry(ahriman_client: SyncAhrimanClient, mocker: MockerFixture) -> None:
"""
must retry HTTP request
"""
response_ok = requests.Response()
response_ok.status_code = 200
response_error = requests.Response()
response_error.status_code = 401
# login on init -> request with error -> login on error -> request without error
request_mock = mocker.patch("requests.Session.request", side_effect=[
response_ok,
response_error,
response_ok,
response_ok,
])
ahriman_client.auth = ("username", "password")
assert ahriman_client.make_request("GET", "url") is not None
request_mock.assert_has_calls([
MockCall("POST", "http://127.0.0.1:8080/api/v1/login", params=None, data=None, headers=None, files=None,
json={"username": "username", "password": "password"},
auth=ahriman_client.auth, timeout=ahriman_client.timeout),
MockCall("GET", "url", params=None, data=None, headers=None, files=None, json=None,
auth=ahriman_client.auth, timeout=ahriman_client.timeout),
MockCall("POST", "http://127.0.0.1:8080/api/v1/login", params=None, data=None, headers=None, files=None,
json={"username": "username", "password": "password"},
auth=ahriman_client.auth, timeout=ahriman_client.timeout),
MockCall("GET", "url", params=None, data=None, headers=None, files=None, json=None,
auth=ahriman_client.auth, timeout=ahriman_client.timeout),
])