calculate dependencies based on package information (#89)

tests/ahriman/models/conftest.py

@@ -139,6 +139,8 @@ def pyalpm_package_description_ahriman(package_description_ahriman: PackageDescr
     type(mock).arch = PropertyMock(return_value=package_description_ahriman.architecture)
     type(mock).builddate = PropertyMock(return_value=package_description_ahriman.build_date)
     type(mock).depends = PropertyMock(return_value=package_description_ahriman.depends)
+    type(mock).makedepends = PropertyMock(return_value=package_description_ahriman.make_depends)
+    type(mock).optdepends = PropertyMock(return_value=package_description_ahriman.opt_depends)
     type(mock).desc = PropertyMock(return_value=package_description_ahriman.description)
     type(mock).groups = PropertyMock(return_value=package_description_ahriman.groups)
     type(mock).isize = PropertyMock(return_value=package_description_ahriman.installed_size)

tests/ahriman/models/test_aur_package.py

@@ -66,6 +66,7 @@ def test_from_pacman(pyalpm_package_ahriman: pyalpm.Package, aur_package_ahriman
     object.__setattr__(model, "first_submitted", aur_package_ahriman.first_submitted)
     object.__setattr__(model, "url_path", aur_package_ahriman.url_path)
     object.__setattr__(model, "maintainer", aur_package_ahriman.maintainer)
+    object.__setattr__(model, "submitter", aur_package_ahriman.submitter)
 
     assert model == aur_package_ahriman
 

tests/ahriman/models/test_package.py

@@ -9,6 +9,7 @@ from ahriman.core.exceptions import PackageInfoError
 from ahriman.core.util import utcnow
 from ahriman.models.aur_package import AURPackage
 from ahriman.models.package import Package
+from ahriman.models.package_description import PackageDescription
 from ahriman.models.repository_paths import RepositoryPaths
 
 
@@ -22,6 +23,58 @@ def test_depends(package_python_schedule: Package) -> None:
     )
 
 
+def test_depends_build(package_ahriman: Package, package_python_schedule: Package) -> None:
+    """
+    must return full list of packages required for build
+    """
+    assert all(
+        set(package_ahriman.depends_build).intersection(package.depends)
+        for package in package_ahriman.packages.values()
+    )
+    assert all(
+        set(package_ahriman.depends_build).intersection(package.make_depends)
+        for package in package_ahriman.packages.values()
+    )
+
+    assert all(
+        set(package_python_schedule.depends_build).intersection(package.depends)
+        for package in package_python_schedule.packages.values()
+    )
+    # there is no make dependencies for python-schedule
+
+
+def test_depends_build_with_version_and_overlap(mocker: MockerFixture, resource_path_root: Path) -> None:
+    """
+    must load correct list of dependencies with version
+    """
+
+    srcinfo = (resource_path_root / "models" / "package_gcc10_srcinfo").read_text()
+    mocker.patch("ahriman.models.package.Package._check_output", return_value=srcinfo)
+
+    package_gcc10 = Package.from_build(Path("local"))
+    assert package_gcc10.depends_build == {"glibc", "doxygen", "binutils", "git", "libmpc", "python", "zstd"}
+
+
+def test_depends_make(package_ahriman: Package) -> None:
+    """
+    must return list of make dependencies
+    """
+    assert all(
+        set(package_ahriman.depends_make).intersection(package.make_depends)
+        for package in package_ahriman.packages.values()
+    )
+
+
+def test_depends_opt(package_ahriman: Package) -> None:
+    """
+    must return list of optional dependencies
+    """
+    assert all(
+        set(package_ahriman.depends_opt).intersection(package.opt_depends)
+        for package in package_ahriman.packages.values()
+    )
+
+
 def test_groups(package_ahriman: Package) -> None:
     """
     must return list of groups for each package
@@ -108,6 +161,33 @@ def test_from_build(package_ahriman: Package, mocker: MockerFixture, resource_pa
     assert package_ahriman == package
 
 
+def test_from_build_multiple_packages(mocker: MockerFixture, resource_path_root: Path) -> None:
+    """
+    must construct package from srcinfo with dependencies per-package overrides
+    """
+    srcinfo = (resource_path_root / "models" / "package_gcc10_srcinfo").read_text()
+    mocker.patch("ahriman.models.package.Package._check_output", return_value=srcinfo)
+
+    package = Package.from_build(Path("path"))
+    assert package.packages == {
+        "gcc10": PackageDescription(
+            depends=["gcc10-libs=10.3.0-2", "binutils>=2.28", "libmpc", "zstd"],
+            make_depends=["binutils", "doxygen", "git", "libmpc", "python"],
+            opt_depends=[],
+        ),
+        "gcc10-libs": PackageDescription(
+            depends=["glibc>=2.27"],
+            make_depends=["binutils", "doxygen", "git", "libmpc", "python"],
+            opt_depends=[],
+        ),
+        "gcc10-fortran": PackageDescription(
+            depends=["gcc10=10.3.0-2"],
+            make_depends=["binutils", "doxygen", "git", "libmpc", "python"],
+            opt_depends=[],
+        ),
+    }
+
+
 def test_from_build_failed(package_ahriman: Package, mocker: MockerFixture) -> None:
     """
     must raise exception if there are errors during srcinfo load
@@ -153,37 +233,6 @@ def test_from_official(package_ahriman: Package, aur_package_ahriman: AURPackage
     assert package_ahriman.packages.keys() == package.packages.keys()
 
 
-def test_dependencies_failed(mocker: MockerFixture) -> None:
-    """
-    must raise exception if there are errors during srcinfo load for dependencies
-    """
-    mocker.patch("ahriman.models.package.Package._check_output", return_value="")
-    mocker.patch("ahriman.models.package.parse_srcinfo", return_value=({"packages": {}}, ["an error"]))
-
-    with pytest.raises(PackageInfoError):
-        Package.dependencies(Path("path"))
-
-
-def test_dependencies_with_version(mocker: MockerFixture, resource_path_root: Path) -> None:
-    """
-    must load correct list of dependencies with version
-    """
-    srcinfo = (resource_path_root / "models" / "package_yay_srcinfo").read_text()
-    mocker.patch("ahriman.models.package.Package._check_output", return_value=srcinfo)
-
-    assert Package.dependencies(Path("path")) == {"git", "go", "pacman"}
-
-
-def test_dependencies_with_version_and_overlap(mocker: MockerFixture, resource_path_root: Path) -> None:
-    """
-    must load correct list of dependencies with version
-    """
-    srcinfo = (resource_path_root / "models" / "package_gcc10_srcinfo").read_text()
-    mocker.patch("ahriman.models.package.Package._check_output", return_value=srcinfo)
-
-    assert Package.dependencies(Path("path")) == {"glibc", "doxygen", "binutils", "git", "libmpc", "python", "zstd"}
-
-
 def test_supported_architectures(mocker: MockerFixture, resource_path_root: Path) -> None:
     """
     must generate list of available architectures

tests/ahriman/models/test_package_description.py

@@ -1,8 +1,17 @@
 from unittest.mock import MagicMock
 
+from ahriman.models.aur_package import AURPackage
 from ahriman.models.package_description import PackageDescription
 
 
+def test_post_init() -> None:
+    """
+    must trim versions and descriptions from dependencies list
+    """
+    assert PackageDescription(depends=["a=1"], make_depends=["b>=3"], opt_depends=["c: a description"]) == \
+        PackageDescription(depends=["a"], make_depends=["b"], opt_depends=["c"])
+
+
 def test_filepath(package_description_ahriman: PackageDescription) -> None:
     """
     must generate correct filepath if set
@@ -19,6 +28,19 @@ def test_filepath_empty(package_description_ahriman: PackageDescription) -> None
     assert package_description_ahriman.filepath is None
 
 
+def test_from_aur(package_description_ahriman: PackageDescription, aur_package_ahriman: AURPackage) -> None:
+    """
+    must construct package description from AUR descriptor
+    """
+    actual = PackageDescription.from_aur(aur_package_ahriman)
+    # missing attributes
+    actual.architecture = package_description_ahriman.architecture
+    actual.archive_size = package_description_ahriman.archive_size
+    actual.build_date = package_description_ahriman.build_date
+    actual.filename = package_description_ahriman.filename
+    actual.installed_size = package_description_ahriman.installed_size
+
+
 def test_from_json(package_description_ahriman: PackageDescription) -> None:
     """
     must construct description from json object