arcanis/ahriman
1
0
Fork 0
mirror of https://github.com/arcan1s/ahriman.git synced 2025-06-28 06:41:43 +00:00
Code Issues Projects Releases Wiki Activity

render httpunauthorized as html in plain http requests

Browse Source
This commit is contained in:
Evgenii Alekseev
2022-11-22 23:40:27 +02:00
parent f2c23bad17
commit 4462eba860
5 changed files with 118 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/ahriman/core/test_util.py
View File

@ -335,6 +335,7 @@ def test_walk(resource_path_root: Path) -> None:
resource_path_root / "web" / "templates" / "utils" / "style.jinja2",
resource_path_root / "web" / "templates" / "build-status.jinja2",
resource_path_root / "web" / "templates" / "email-index.jinja2",
resource_path_root / "web" / "templates" / "error.jinja2",
resource_path_root / "web" / "templates" / "repo-index.jinja2",
resource_path_root / "web" / "templates" / "shell",
resource_path_root / "web" / "templates" / "telegram-index.jinja2",

67
tests/ahriman/web/middlewares/test_exception_handler.py
View File

@ -2,12 +2,12 @@ import json
import logging
import pytest
from aiohttp.web_exceptions import HTTPBadRequest, HTTPInternalServerError, HTTPNoContent
from aiohttp.web_exceptions import HTTPBadRequest, HTTPInternalServerError, HTTPNoContent, HTTPUnauthorized
from pytest_mock import MockerFixture
from typing import Any
from unittest.mock import AsyncMock
from unittest.mock import AsyncMock, MagicMock
from ahriman.web.middlewares.exception_handler import exception_handler
from ahriman.web.middlewares.exception_handler import exception_handler, is_templated_unauthorized
def _extract_body(response: Any) -> Any:
@ -23,6 +23,37 @@ def _extract_body(response: Any) -> Any:
return json.loads(getattr(response, "body"))
def test_is_templated_unauthorized() -> None:
"""
must correct check if response should be rendered as template
"""
response_mock = MagicMock()
response_mock.path = "/api/v1/login"
response_mock.headers.getall.return_value = ["*/*"]
assert is_templated_unauthorized(response_mock)
response_mock.path = "/api/v1/login"
response_mock.headers.getall.return_value = ["application/json"]
assert not is_templated_unauthorized(response_mock)
response_mock.path = "/api/v1/logout"
response_mock.headers.getall.return_value = ["*/*"]
assert is_templated_unauthorized(response_mock)
response_mock.path = "/api/v1/logout"
response_mock.headers.getall.return_value = ["application/json"]
assert not is_templated_unauthorized(response_mock)
response_mock.path = "/api/v1/status"
response_mock.headers.getall.return_value = ["*/*"]
assert not is_templated_unauthorized(response_mock)
response_mock.path = "/api/v1/status"
response_mock.headers.getall.return_value = ["application/json"]
assert not is_templated_unauthorized(response_mock)
async def test_exception_handler(mocker: MockerFixture) -> None:
"""
must pass success response
@ -50,6 +81,36 @@ async def test_exception_handler_success(mocker: MockerFixture) -> None:
logging_mock.assert_not_called()
async def test_exception_handler_unauthorized(mocker: MockerFixture) -> None:
"""
must handle unauthorized exception as json response
"""
request = pytest.helpers.request("", "", "")
request_handler = AsyncMock(side_effect=HTTPUnauthorized())
mocker.patch("ahriman.web.middlewares.exception_handler.is_templated_unauthorized", return_value=False)
render_mock = mocker.patch("aiohttp_jinja2.render_template")
handler = exception_handler(logging.getLogger())
response = await handler(request, request_handler)
assert _extract_body(response) == {"error": HTTPUnauthorized().reason}
render_mock.assert_not_called()
async def test_exception_handler_unauthorized_templated(mocker: MockerFixture) -> None:
"""
must handle unauthorized exception as json response
"""
request = pytest.helpers.request("", "", "")
request_handler = AsyncMock(side_effect=HTTPUnauthorized())
mocker.patch("ahriman.web.middlewares.exception_handler.is_templated_unauthorized", return_value=True)
render_mock = mocker.patch("aiohttp_jinja2.render_template")
handler = exception_handler(logging.getLogger())
await handler(request, request_handler)
context = {"code": 401, "reason": "Unauthorized"}
render_mock.assert_called_once_with("error.jinja2", request, context, status=HTTPUnauthorized.status_code)
async def test_exception_handler_client_error(mocker: MockerFixture) -> None:
"""
must handle client exception