refactor: separate package_archives method from trigger

tests/ahriman/core/housekeeping/test_archive_rotation_trigger.py

@@ -3,12 +3,11 @@ import pytest
 from dataclasses import replace
 from pathlib import Path
 from pytest_mock import MockerFixture
-from typing import Any
 from unittest.mock import call as MockCall
 
-from ahriman.core.alpm.pacman import Pacman
 from ahriman.core.configuration import Configuration
 from ahriman.core.housekeeping import ArchiveRotationTrigger
+from ahriman.core.repository import Repository
 from ahriman.models.package import Package
 from ahriman.models.result import Result
 
@@ -21,26 +20,24 @@ def test_configuration_sections(configuration: Configuration) -> None:
 
 
 def test_archives_remove(archive_rotation_trigger: ArchiveRotationTrigger, package_ahriman: Package,
-                         pacman: Pacman, mocker: MockerFixture) -> None:
+                         repository: Repository, mocker: MockerFixture) -> None:
     """
     must remove older packages
     """
-    def package(version: Any, *args: Any, **kwargs: Any) -> Package:
-        generated = replace(package_ahriman, version=str(version))
+    packages = []
+    for i in range(5):
+        generated = replace(package_ahriman, version=str(i))
         generated.packages = {
-            key: replace(value, filename=str(version))
+            key: replace(value, filename=str(i))
             for key, value in generated.packages.items()
         }
-        return generated
+        packages.append(generated)
 
-    mocker.patch("pathlib.Path.is_dir", return_value=True)
-    mocker.patch("ahriman.core.housekeeping.archive_rotation_trigger.package_like", return_value=True)
+    mocker.patch("ahriman.core.repository.package_info.PackageInfo.package_archives", return_value=packages)
     mocker.patch("pathlib.Path.glob", return_value=[Path(str(i)) for i in range(5)])
-    mocker.patch("pathlib.Path.iterdir", return_value=[Path(str(i)) for i in range(5)])
-    mocker.patch("ahriman.models.package.Package.from_archive", side_effect=package)
     unlink_mock = mocker.patch("pathlib.Path.unlink", autospec=True)
 
-    archive_rotation_trigger.archives_remove(package_ahriman, pacman)
+    archive_rotation_trigger.archives_remove(package_ahriman, repository)
     unlink_mock.assert_has_calls([
         MockCall(Path("0")),
         MockCall(Path("1")),
@@ -48,28 +45,15 @@ def test_archives_remove(archive_rotation_trigger: ArchiveRotationTrigger, packa
 
 
 def test_archives_remove_keep(archive_rotation_trigger: ArchiveRotationTrigger, package_ahriman: Package,
-                              pacman: Pacman, mocker: MockerFixture) -> None:
+                              repository: Repository, mocker: MockerFixture) -> None:
     """
     must keep all packages if set to
     """
-    def package(version: Any, *args: Any, **kwargs: Any) -> Package:
-        generated = replace(package_ahriman, version=str(version))
-        generated.packages = {
-            key: replace(value, filename=str(version))
-            for key, value in generated.packages.items()
-        }
-        return generated
-
-    mocker.patch("pathlib.Path.is_dir", return_value=True)
-    mocker.patch("ahriman.core.housekeeping.archive_rotation_trigger.package_like", return_value=True)
-    mocker.patch("pathlib.Path.glob", return_value=[Path(str(i)) for i in range(5)])
-    mocker.patch("pathlib.Path.iterdir", return_value=[Path(str(i)) for i in range(5)])
-    mocker.patch("ahriman.models.package.Package.from_archive", side_effect=package)
-    unlink_mock = mocker.patch("pathlib.Path.unlink", autospec=True)
+    archives_mock = mocker.patch("ahriman.core.repository.package_info.PackageInfo.package_archives")
 
     archive_rotation_trigger.keep_built_packages = 0
-    archive_rotation_trigger.archives_remove(package_ahriman, pacman)
-    unlink_mock.assert_not_called()
+    archive_rotation_trigger.archives_remove(package_ahriman, repository)
+    archives_mock.assert_not_called()
 
 
 def test_on_result(archive_rotation_trigger: ArchiveRotationTrigger, package_ahriman: Package,

tests/ahriman/core/repository/test_package_info.py

@@ -91,6 +91,30 @@ def test_load_archives_different_version(package_info: PackageInfo, package_pyth
     assert packages[0].version == package_python_schedule.version
 
 
+def test_package_archives(package_info: PackageInfo, package_ahriman: Package, mocker: MockerFixture) -> None:
+    """
+    must load package archives sorted by version
+    """
+    from dataclasses import replace
+    from typing import Any
+
+    def package(version: Any, *args: Any, **kwargs: Any) -> Package:
+        generated = replace(package_ahriman, version=str(version))
+        generated.packages = {
+            key: replace(value, filename=str(version))
+            for key, value in generated.packages.items()
+        }
+        return generated
+
+    mocker.patch("ahriman.core.repository.package_info.package_like", return_value=True)
+    mocker.patch("pathlib.Path.iterdir", return_value=[Path(str(i)) for i in range(5)])
+    mocker.patch("ahriman.models.package.Package.from_archive", side_effect=package)
+
+    result = package_info.package_archives(package_ahriman.base)
+    assert len(result) == 5
+    assert [p.version for p in result] == [str(i) for i in range(5)]
+
+
 def test_package_changes(package_info: PackageInfo, package_ahriman: Package, mocker: MockerFixture) -> None:
     """
     must load package changes